AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,186 Commits 3 Branches 0 Tags
71d2fb20c8dc4117e54757d9d117d686ff1deef0
Commit Graph

2186 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Evgeny Mankov 71d2fb20c8 [HIPIFY] Disable cudaBuiltin matcher. 
As HIP has started to support vanilla CUDA syntax for threadIdx, blockIdx, blockDim and gridDim.
Other CUDA builtins are not tracked for now.
 2017-12-05 20:28:51 +03:00
Evgeny Mankov f24dfc6f36 [HIPIFY] remove duplicates from CUDA_IDENTIFIER_MAP 2017-12-05 19:46:53 +03:00
Evgeny Mankov 841dd69c90 Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP 2017-12-05 18:19:15 +03:00
Maneesh Gupta df4faf3b26 Merge pull request #278 from bensander/update_docs_and_square 
Update docs and square
 2017-12-05 15:57:36 +05:30
Maneesh Gupta b3fb8ea92f Simplify square sample's Makefile 
Change-Id: I44349a880a3c57ca0e833d67d9c380b706655b1e
 2017-12-05 11:54:50 +05:30
Ben Sander d62074e3fc Merge pull request #279 from AlexVlx/feature_use_module_based_dispatch_instead_of_pfe 
Clean up kernel retrieval code / module management
 2017-12-03 18:41:27 -06:00
Ben Sander 2ae6882d4f Merge pull request #276 from bensander/temp_disable_tests 
Temporarily disable a couple tests pending some HCC work
 2017-12-03 18:33:47 -06:00
Alex Voicu 5ca3176a91 Re-sync with upstream. 2017-12-03 23:14:58 +00:00
Alex Voicu 5127ce67e8 This is primarily intended as an additional cleanup of the module functionality, in the aftermath of adopting module based dispatch. The main effort was associated with refactoring the questionable ihipModuleGetSymbol. It was quaintly written and misleading, in that it had little to do with getting symbols, and was exactly retrieving a kernel object. Error handling is modified so as to reduce branching depth. Functions which serve as interfaces to the HSA RT are moved in a separate helper header. Code object readers are properly deleted. Some leftover dead functionality pertaining to associating namespace scope variables with their allocated memory is removed. Executable loading is changed to use a string which holds the ELF image of the code object being loaded, thus avoiding some corner cases where using a istream would fail. 2017-12-03 23:09:06 +00:00
Ben Sander 6f3ed5e3cf Merge pull request #271 from bensander/cppcheck 
Cppcheck
 2017-12-02 08:36:17 -06:00
Ben Sander 657e65733f Remove coordinate conversions (threadIdx.x -> hipThreadIdx_x) 
Since these are now supported directly.
 2017-12-02 07:44:54 -06:00
Ben Sander b9fa704521 Update square sample for recent HIP ease-of-use improvements 2017-12-02 07:44:27 -06:00
Ben Sander 5a642c1717 Merge pull request #277 from AlexVlx/feature_use_module_based_dispatch_instead_of_pfe 
Fix hang by purging archaisms
 2017-12-02 07:11:55 -06:00
Alex Voicu 02fc25de4c Remove stray leftover comment. 2017-12-02 00:03:10 +00:00
Alex Voicu 6027d3f332 Replace archaic use of homebrew functionality with calls to the HC maths library. This fixes a hang observed when building hipTestDeviceDouble. 2017-12-02 00:01:47 +00:00
Ben Sander 03d1263a51 Update RELEASE.md and bugs to reflect HIP infra improvements. 2017-12-01 16:09:24 -06:00
Ben Sander 7d2675520a Merge pull request #267 from AlexVlx/feature_sanitise_conversions 
Fix curious bitwise conversions.
 2017-12-01 15:51:08 -06:00
Ben Sander 62cbe22d50 Temporarily disable a couple tests pending some HCC work 2017-12-01 21:46:28 +00:00
Ben Sander 9bba97fdcc Fix some cppcheck style issues. 2017-12-01 20:45:34 +00:00
Ben Sander 4313686d6e Fix warning from default cppchek. 2017-12-01 20:45:33 +00:00
Ben Sander dac57ba854 Merge pull request #246 from AlexVlx/feature_use_module_based_dispatch_instead_of_pfe 
Use natural dispatch syntax
 2017-12-01 14:21:25 -06:00
Alex Voicu 7c0b9a005b Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter. 2017-11-30 03:29:04 +00:00
Alex Voicu 20fc68c9a1 Add missing space (the final frontier). 2017-11-29 21:50:43 +00:00
Alex Voicu 32e11e7dc6 Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions." 
This reverts commit d2fd1f5
 2017-11-29 21:49:10 +00:00
Alex Voicu 7acb1e6ff6 Use a much simpler guard for version 1.6, which allows for direct CUDA indexing to be used. 2017-11-29 21:47:04 +00:00
Alex Voicu 61453e15cc Merge branch 'feature_use_module_based_dispatch_instead_of_pfe' of https://github.com/AlexVlx/HIP into feature_use_module_based_dispatch_instead_of_pfe 2017-11-29 21:45:56 +00:00
Alex Voicu fbaf729f88 Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions." 
This reverts commit d2fd1f5
 2017-11-29 21:36:29 +00:00
Ben Sander a0cec19d6e Merge pull request #275 from mangupta/bump_version_1.5 
Bumped HIP version to 1.5 and updated summary in HIP release notes
 2017-11-29 15:06:02 -06:00
Alex Voicu d2fd1f5544 Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions. 2017-11-29 21:01:28 +00:00
Maneesh Gupta f4187b0f16 Bumped HIP version to 1.5 and updated summary in HIP release notes 
Change-Id: I4b612da88236674fac2c585ab6891bdd495511b0
 2017-11-29 13:56:17 +05:30
Alex Voicu b881cf713c Fix compiler version check. 2017-11-29 03:05:53 +00:00
Alex Voicu 3ed8897a5a Add missing file. 2017-11-29 02:16:44 +00:00
Alex Voicu faa546d194 Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component. 2017-11-29 01:37:52 +00:00
Alex Voicu 89e9399427 Choose whether or not to use functional grid_launch based on the version of HCC used to compile. 2017-11-29 00:17:44 +00:00
Alex Voicu 5aeb5dcd6f Remove leftover agent allocated globals. 2017-11-28 19:56:04 +00:00
Alex Voicu 6e4ca3fbb4 Change memset kernel to use memcpy instead of placement new. Simplify indexers. 2017-11-28 19:45:47 +00:00
Alex Voicu 02c2bfc7ef Re-sync with upstream and re-factor platform global management for texture references. 2017-11-28 19:15:29 +00:00
Alex Voicu dc67ca3feb Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe 
# Conflicts:
#	src/hip_module.cpp
 2017-11-28 17:29:11 +00:00
Maneesh Gupta 265c3b224e Fix float2int rounding functions 
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
 2017-11-28 17:23:43 +00:00
Alex Voicu a6ccaf3d57 This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands. 2017-11-28 17:23:06 +00:00
Alex Voicu a401ce6e5d This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution. 2017-11-28 17:23:06 +00:00
Chris Kitching 9d47a4d980 Add hipify mappings for all CUDA headers that have HIP equivalents 
I'm particularly running into issues with `device_types.h` in real
CUDA code...
 2017-11-28 17:23:06 +00:00
Ben Sander 0da0426f94 Merge pull request #256 from gargrahul/texture_driver_api_support 
Texture driver APIs support
 2017-11-27 13:52:39 -06:00
Rahul Garg a139b533bb Added note in Release notes for texture driver APIs 2017-11-27 22:06:50 +05:30
Evgeny Mankov 1a847a5d2b Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP 2017-11-27 17:33:48 +03:00
Evgeny Mankov aa05b3d84e Merge pull request #262 from ChrisKitching/frontendaction 
[HIPIFY] Mostly fix preprocessor-or-template induced issues
 2017-11-27 17:30:11 +03:00
Alex Voicu 907d41df77 Re-sync with upstream. 2017-11-24 13:04:12 +00:00
Rahul Garg 04bc5a1d1f Porting guides update for texture APIs usage 2017-11-24 12:00:55 +05:30
Ben Sander 814548407d Merge pull request #273 from mangupta/swdev-129574 
Fix float2int rounding functions
 2017-11-23 12:04:36 -06:00
Maneesh Gupta 4c96882366 Fix float2int rounding functions 
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
 2017-11-23 09:57:24 +05:30