Commit Graph

12547 Commits

Author SHA1 Message Date
Jaydeep Patel 76e3ffeb81 SWDEV-428198 - Revert "SWDEV-426270 - Remove duplicated operators"
This reverts commit 0ca61130a2.

Change-Id: I4973424b5f8d6f2b0d8496dda346b9d6dbba13ae
2023-10-27 01:51:03 -04:00
Anusha GodavarthySurya 5fb7536586 SWDEV-422207 - Remove L2 flush when kernelArgs are in device memory
Change-Id: I7b5625cb6d55e83689bff7bbb45be9c517ec4a8d
2023-10-26 19:14:58 +00:00
Saleel Kudchadker 182f6e2e6d SWDEV-422207 - Fix profiling check
Change-Id: Ia6ca28f0b593ea1680732684dd10f40c0043c973
2023-10-25 05:37:55 +00:00
Anusha GodavarthySurya 38d2c56784 SWDEV-422207 - Handle nonkernel nodes for graph opt
- Support graph with different types of nodes with single
branch when DEBUG_CLR_GRAPH_PACKET_CAPTURE flag is enabled

Change-Id: I149a8629769cd0d5849ffefb04f1352668a685b6
2023-10-24 18:36:06 +00:00
Ajay 6926183974 SWDEV-418100 - HIPNV_DIR error for nvidia build
Change-Id: Id1fb67311fb6a0af98de7c2dcef5cfcf29102d14
2023-10-23 18:04:05 -04:00
Saleel Kudchadker 5662d4037c SWDEV-408180 - Address possible cornercases
- Address corner cases that can arise with the new
hipMemcpyDeviceToDeviceNoCU enum
- Better log

Change-Id: I6035b901f8d616741054b7a5ff4f67956329ac57
2023-10-23 16:54:08 -04:00
Saleel Kudchadker de2b06a7a7 SWDEV-301667 - Reset addSystemScope_
If we submit a systemScope Barrier, we should reset this flag as there
is no need for dispatch AQL again to flush caches/HDP

Change-Id: I55710feb4ba6650852e785b5cadfa64c6b9ce14e
2023-10-23 16:53:47 -04:00
Julia Jiang 0371401d13 SWDEV-422771 - Update change-log adding HIP_LAUNCHING_BLOCKING and fixed issue for complex operations
Change-Id: Ief712d9c1c400513f39c06a67b83d6ee2ffdd3fd
2023-10-23 11:20:58 -04:00
kjayapra-amd e226ae109b SWDEV-413997 - Fixing multiple access desc cases for hipMemSetAccess.
Change-Id: Iec7d1207ec0a7136e4e74ef2e390f3347e753d40
2023-10-23 09:44:04 -04:00
Ioannis Assiouras 7868876db7 SWDEV-428244 - Set PARAMETERS_MIN_ALIGNMENT to the native alignment
Change-Id: I14d8a0db4e575d6fa816754c52df405de88d9200
2023-10-21 17:26:46 -04:00
Jaydeep Patel ee00ebc42f SWDEV-425568 - Do cpu wait for device sync.
Change-Id: Ia05e09bd10ab623b36c74037e9988e132120dd9f
2023-10-21 01:16:06 -04:00
Saleel Kudchadker f316a30e5d SWDEV-408180 - Add a new hipMemcpyKind
Add hipMemcpyDeviceToDeviceNoCU to force a non blit copy path. This
helps in cases where an app may determine that CU may be busy and copies
with SDMA may be quicker.

Change-Id: I59b415dd8f6022c244e8d75f265464d5c635df1e
2023-10-20 13:18:10 -04:00
taosang2 5a0085e516 SWDEV-364236 - Fix layered Image issue
Fix wrong logic to get layer index;
Make layered image's layout match cuda spec;
Fix wrong comparision of element size.
Remove amd::BufferRect from ihipMemcpyAtoHCommand()
and ihipMemcpyHtoACommand().
Change-Id: Icc6a4233fbce2e9b2dc6feb79e6bfbd761684c7d
2023-10-19 16:06:20 -04:00
German 694fe4bedb SWDEV-427689 - Report LUID in Windows
Pass LUID infromation from PAL to HIP device properties.
NodeMask is calculated based on the order of devices in PAL

Change-Id: Ic53707b68b16f392e5284a0105bf1f3941b46653
2023-10-18 15:07:39 -04:00
taosang2 0ca61130a2 SWDEV-426270 - Remove duplicated operators
Remove duplicated operators of hipComplexFloat and
hipComplexDouble.
If users need complex number multiplication and division,
they should call
hipCmulf() and hipCdivf() for hipComplexFloat,
hipCmul() and hipCdiv() for hipComplexComplex

Change-Id: Ie58d1642d578e7118997db40a9fd6a6641b666fd
2023-10-18 14:56:32 -04:00
Julia Jiang 583ec06a7b SWDEV-422771 - Updating change-log for ROCM 6.0
Change-Id: I8a3b016b8a9cedff5b730645fda009c78c5afbb7
2023-10-18 11:20:06 -04:00
German 00b58e2536 SWDEV-425441 - Create a fake WGL context
If a WGL context wasn't attachhed to OGL, then OGL fails to return
the entry points for AMD extension.

Change-Id: I2bfa5f4f4d038785282e1c9af455e4593e75d3ff
2023-10-18 09:44:09 -04:00
Ioannis Assiouras 2d8c65eedf SWDEV-427493 - Fixed segfault after accessing deleted timestamp
Change-Id: I478008f03e2bb4d9ac1f0865605edbf9f8254fea
2023-10-17 15:24:07 -04:00
Jatin Chaudhary 56f3b2563c SWDEV-306642 - Move the deprecated function/struct to hip_device_deprecated.cpp
Change-Id: Id1f8db09271c537a200bc090ba1feaacfb023b88
2023-10-16 21:42:18 +01:00
Satyanvesh Dittakavi 353dbe6e3b SWDEV-419480 - HIPRTC implementation of standard headers shouldn't be in std namespace
HIPRTC implementation of few type traits are defined in std
namespace which causes conflicts with the std C++ headers when
apps try to include those std headers. Instead, use the
specific implementation of these headers from __hip_internal
namespace to avoid this.

Change-Id: Ia358df159af8783d1eba9a19cd458e192bf7e9e6
2023-10-16 13:10:55 -04:00
kjayapra-amd 3ef829939a SWDEV-413997 - Initial VMM changes for ROCm path.
Change-Id: I4405fd7b53182eb4c4622835c811c0dc08461537
2023-10-16 11:29:16 -04:00
Rahul Garg 8fe1d9dda1 SWDEV-415029 - [ABI Break] Remove hcc symbols
This reverts commit 2535fac296.

Reason for revert: Bring back original change

Change-Id: Ie20e80f6e9b7d67a28e3a255abaf82018eb61e7a
2023-10-16 07:34:43 -04:00
sdashmiz 2d83abaca6 SWDEV-389530 - [ABI Break]Match error with cuda
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id9de54b4fd1be7b6b887a4ebfcc6a3d9a70c7bc9
2023-10-16 07:31:34 -04:00
sdashmiz d78aef7f66 SWDEV-371332 - [ABI Break] Return success for unregistered ptr
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie58d16420578e7118997eb40a9fd6a6641b666f3
2023-10-15 14:32:24 -04:00
Maneesh Gupta 67dda1ffd6 SWDEV-418100 - Move nv headers to hipother repo
Change-Id: Ib54546e366b61bdb83789d8264f30f1bfb875605
2023-10-14 06:56:13 +00:00
Jaydeep Patel 7150b2eaad SWDEV-425490 - Move ptrdiff_t & clock_t to hiprtc.cmake.
Change-Id: I7c8ce3c1b8cb11e0253b0f51ae10fca7f0a32017
2023-10-13 00:58:56 -04:00
sdashmiz c089ef4a2b SWDEV-332969 - [ABI Break]Substitute hipArray* with hipArray_t
- hipArray will be an internal struct from rocm6.0

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Icf97fe96b87be8532098cd7f9ceaad099f99c9b9
2023-10-12 12:09:19 -04:00
Jatin Chaudhary 2989840511 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries
- alias hipGetDeviceProperties to hipGetDevicePropertiesR0600
- alias hipDeviceProp_t to hipDeviceProp_tR0600
- remove gcnArch from new device property struct
- add new requested struct members

Change-Id: If3f5dbef3d608487d9f6f419285f4bf577ea9bf0
2023-10-12 11:16:18 -04:00
jiabaxie 813907c29d SWDEV-418999 - python script to support profiler with hip versioning
Change-Id: I8f5ad81162581bf3792c2606ba8c6c3a8e0b4bf2
2023-10-11 13:46:45 -04:00
Rakesh Roy 52001adf43 SWDEV-421667 - Print shared library name which doesn't contain CO for current device
- ML Frameworks link many ROCm component libraries
- It becomes a tedious task to figure out which library HIP is complaining about
- To improve debuggability print out the shared library name

Change-Id: I53c4d66393670356b8cafd3e48075e430f0a45ce
2023-10-11 10:43:03 -04:00
jiabaxie 28f0daa34f SWDEV-405983 - adding in HIP_LAUNCH_BLOCKING
Change-Id: I3f9c8a745099aab05155ebe910e727693961a02f
2023-10-10 21:11:13 -04:00
Saleel Kudchadker bf8baeecb3 SWDEV-301667 - Track last used SDMA engine per queue
- Track last SDMA engine per queue, this results in better scheduling
- Reset last SDMA engine upon batch completion. That ensures we dont get
blocked if the same engine is used by another concurrent copy

Change-Id: Id53111980da7ee41d5c932fb44e4aab5b1e065a3
2023-10-10 12:13:11 -04:00
Anusha GodavarthySurya c7e4e9c2f4 SWDEV-408701 - Avoid adding duplicates when no node is captured in cross stream
Change-Id: Iccbddaf9db73238aa938f8b3e8ec410f4a86d524
2023-10-09 13:15:47 -04:00
Rakesh Roy 2535fac296 SWDEV-425967, SWDEV-425968 - Revert "SWDEV-415029 - [ABI Break] Remove hcc symbols"
This reverts commit 051e1005f4.

Reason for revert: This causes build failure in hipBLASLt & hipSPARSELt

Change-Id: I59f6aeb8b82261b77eb978e53407bc56be1d0cf1
2023-10-09 06:30:19 -04:00
Sourabh Betigeri 01aa3557f4 SWDEV-369792 - Fix to use the roclr context already created when creating hip::Device rather than creating a new context in hip
Change-Id: I6dbccb1a17dee0e9a72ec52cb1a5bb096315fa0f
2023-10-07 14:32:32 -04:00
German Andryeyev fe7b36f3cb SWDEV-424603 - Use OR for CPU wait request
Make sure rocclr doesn't overwrite the client's request
for a wait.

Change-Id: I0addf18ea408b7f4ecaa1e04b2877cc0bbbfcc0d
2023-10-06 16:51:44 -04:00
Jaydeep Patel 46de4256e0 SWDEV-425490 - ptrdiff_t differs on windows and linux.
Change-Id: I5b943e869a6552870aa268be898182e806161b3c
2023-10-06 16:04:52 -04:00
Alex Xie 124de0c519 SWDEV-423579 - Move header file to ROCclr
This header file is used by ROCclr and might be used by HIP too.
ROCclr folder is a right place for this header file.

Change-Id: Ie2307331f9bd445f3c295d2ccbfc4924b0fa9510
2023-10-06 14:54:50 -04:00
German Andryeyev 5438b6362e SWDEV-424603 - Force CPU wait if profiling
Some pytorch tests use a tracer plugin and rely on profiling information
to be reported right after hipDeviceSynchronize()

Change-Id: Ib021a1e7b1a30b3c24de72627c471810f7f7878d
2023-10-06 11:33:06 -04:00
Ioannis Assiouras 43126bc19b SWDEV-420989 - Initialize tiled_info meta_group_rank and meta_group_size
Change-Id: I6792e928702d0fef81f18e74eaead3ad3a8fbb7b
2023-10-06 05:43:04 -04:00
Satyanvesh Dittakavi f64ead62be SWDEV-424273 - Address MIGraphX tests staging failure
Change-Id: I5f51b62a0046f567603008974fda029d40d7656b
2023-10-05 15:55:54 -04:00
kjayapra-amd 6a8bc3c718 SWDEV-419688 - Do not run GWS init kernel for targets > gfx12 and MI300.
Change-Id: I8e7441268978be71ab8a5a33e7f8bcf69660e500
(cherry picked from commit 36d37ef614909c0f215512aac0c133408d787080)
2023-10-05 14:57:56 -04:00
taosang2 6398f604b0 SWDEV-299127 - Support External Mipmap
Support hipExternalMemoryGetMappedMipmappedArray().
Add ImageExternalBuffer to differiate ImageBuffer.
Currently we only support tiling_optimal mode as
vulkan driver doesn't provide tiling information.

Change-Id: I7e3524cdde53e4df9f728894bcebf4bd3f58d4d9
2023-10-05 09:58:17 -04:00
Anusha GodavarthySurya e63c280d4d SWDEV-422207 - Capture AQL Packets for graph Kernel nodes during graph Inst. And enqueue AQL packet during launch
Change-Id: I1e5f7f9e2a70bd500d190193cb6ba0867f5a63e7
2023-10-05 00:34:29 -04:00
Julia Jiang 3eb46ae588 SWDEV-425362 - Fix GL section on HIP API module
Change-Id: I6824758a4744739a596a96e04053eec8e16516cc
2023-10-04 14:26:45 -04:00
Rahul Garg f08f5988c3 SWDEV-422771 - Sync up CHANGELOGS
Change-Id: Ide70179e0c72f7e6c8d1534ae5992a0a075db971
2023-10-04 14:09:06 -04:00
Jatin Chaudhary ab6d34ae77 SWDEV-420894 - Remove directed test link from CMakeLists.txt
Change-Id: Iece57a1624b921d556a300c8f442ee12fd8a4948
2023-10-04 05:01:49 -04:00
Ioannis Assiouras bf31109241 SWDEV-425129 - Revert "SWDEV-420822 - [ABI Break] Merge hipFunction_attribute into hipFuncAttribute"
This reverts commit c469f18e91.

Change-Id: I02d6e77f0874fc37f22de267435917edd4fdede3
2023-10-03 11:32:19 +01:00
German Andryeyev 596b496c16 SWDEV-424249 - Check if HwEvent is available
Allocate marker only if HW event doesn't exist for the last command.

Change-Id: I3e7284202365a9c75313fb5403f0c1908ab51d1e
2023-10-02 11:27:16 -04:00
Ioannis Assiouras c469f18e91 SWDEV-420822 - [ABI Break] Merge hipFunction_attribute into hipFuncAttribute
Change-Id: I9b9f7979e9b8dd422d9064c17c79a25bf7248d30
2023-10-01 06:52:12 -04:00