Commit Graph

5516 Commits

Author SHA1 Message Date
Jatin Chaudhary 78fcbab8c2 Removing redundant .hipInfo Install
Change-Id: Id8f7a4668d8b6965a47a464c94c19bc1036f3537
2020-07-28 02:01:53 -04:00
Rahul Garg c919a88795 Remove libhip_hcc symlinks to libamdhip64
Change-Id: I7b5b47fc7ca9760316c2424c16b454d7919c665c
2020-07-27 23:58:29 +00:00
jujiang c1d65e57a1 SWDEV-242344-hipMemcpyAll failed on MGPU
Change-Id: I01671e322c84213964d3d48bd6b5dc704dba731a
2020-07-27 13:30:30 -04:00
Tao Sang e9cc570be8 Remove __gnu_h2f_ieee and __gnu_f2h_ieee
Change-Id: Ide24d245d851e20961020323e52f33322a33fff9
2020-07-23 14:50:24 -04:00
Vlad Sytchenko fe6b645f3b 2D/3D copy optimizations
SWDEV-244798

If {src/dst} ptr is marked as hipMemoryTypeHost, check if the memory was
prepinned. If it was, upgrade the copy type to hipMemoryTypeDevice to
avoid extra pinning.

Change-Id: Id287ef5b14ae67dfbcf80c4caa1b08a311191948
2020-07-23 11:24:16 -04:00
Tao Sang f7cc49c0b2 Apply constexpr on global constant varaibles
When HIP_ENABLE_DEFERRED_LOADING=0, many global variables will be
referenced but they are not initialized in that early time. The patch
will use constexpr to initialze global constant varables in compile
time.

Change-Id: I9837c42e6bab38a894ece4e0f34b64f81b38fef0
2020-07-22 22:15:03 -04:00
kjayapra-amd fd783c1e88 SWDEV-236178 - Remove use of old routines functions()/modules().
Change-Id: I3a1ed967227c91b0d8cdf39e1360ade685e0bc73
2020-07-22 14:55:02 -04:00
kjayapra-amd 311fc8c513 SWDEV-240800 - Adding initial support for hipDeviceGetP2PAttribute. Some attr support still pending.
Change-Id: I0611aed136270db497dfa374144f6f5e35352a8f
2020-07-22 14:54:34 -04:00
Payam 274fded47d modify cmake to strip debug symbols from rel blds
Change-Id: Ia67261fc3c4a20f3f1bbe439a70384a3f6aefa91
2020-07-22 11:53:54 -04:00
Tao Sang eba78710dc Support numa if libnume-dev is installed
Let rocclr decide numa dependence

Change-Id: I65bdfba7ec0d06b550f86632318bcfd1f765cfa9
2020-07-22 08:55:28 -04:00
Satyanvesh Dittakavi 6f5e63ebac SWDEV-244772 - Fix dtest hipMemcpyWithStreamMultiThread.cpp.
hipSetDevice is not used correctly to allocate on multiple devices in mGPU setup.
Due to which hipMalloc was called on the same device on multiple threads leading to out of memory issues on some devices with lesser memory.

Change-Id: I0e5b1bc028b9ecb11bd40c3a5edf715f8bd721ff
2020-07-22 00:52:14 -04:00
Saleel Kudchadker 603546cd45 Print devPtr and size for hip*Symbol* api
Change-Id: I07be6949cca005700ee1d1708d86220c793c9728
2020-07-21 13:49:10 -04:00
Rahul Garg 19ede4fd23 Handle size 0 symbols
Change-Id: Ie282b37cf6bbccae4611dfc17c5c7f31977feea7
2020-07-21 10:09:26 -04:00
Aryan Salmanpour e27d53043c Add missing stream null check for some hipStreamCreate APIs
Change-Id: I716d71e4ec59b0bd7922869bfa0ed908c22c289e
2020-07-20 18:07:03 -04:00
jujiang 797d2761d4 SWDEV-242337-Fix hipHostRegister test failure for MGPU
Change-Id: I748dac0c5a47fa00184f065d9ef716573aa70b12
2020-07-20 11:40:49 -04:00
Sudheer Kumar 94c4462848 [dtest] Compare hipDeviceGetPCIBusId output with lscpi output
SWDEV-238517 for enhancing hip unit tests

Change-Id: I5507dd19fc22e7f8806655eefaa69fbd61c98f56
2020-07-20 04:31:48 -04:00
German Andryeyev 5ef00cf6e9 Grab the event lock before fetching the last command
Hip applications assume that hipEventRecord called from multiple
threads will contain exactly the last queued command to the stream.

Change-Id: I1da3259f143d7670d0870d9a47c08e32336b2222
2020-07-20 02:01:16 -04:00
Ashutosh Mishra 7d3d8c8e6d Adapting to static libaray changes for hipcc
Since the introduction of BUILD_SHARED_LIBS there is only one target created : libamdhip64
Which is static ( libamdhip64.a ) or Dynamic ( libamdhip64.so ) depending on whichever it is
being compiled for. After this change we do not have any target libamdhip64_static which is
mentioned in the hipcc for linking. Hence cleaning the same.

Change-Id: Ia45c145e17b111b3f6a32299a11962b10f1cc539
2020-07-17 14:42:07 -04:00
jujiang 50b299da66 SWDEV-243933-update HIP README document
Change-Id: Ie303698ae92c7fa1b1202c1ee06beda1005ba065
2020-07-17 12:26:05 -04:00
Christophe Paquot a838e6e108 Remove use of setLastQueuedCommand
Change-Id: I07bf54dc09905d9a17b059a476df9282eb6f1f51
2020-07-17 11:45:25 -04:00
Evgeny 49091c2463 cleanup: unneeded '\'
Change-Id: I0276312fdb0e4829d678de4281ccfd12eb7f232e
2020-07-16 01:57:07 -05:00
Ashutosh Mishra a77c7e21be Adding "BUILD_SHARED_LIBS" flag to cmake files
JIRA : SWDEV-234471
With this change compilation of the ibamdhip64 to be decied by arguments to build_hip_on_rocclr.sh file
build_hip_on_rocclr.sh -r (current) shall conitnue to create libamdhip64.so;
build_hip_on_rocclr.sh -r a (new) shall create libamdhip64.a
other options remain the same

Changed the targets according to requirement of stage2 dependencies.
Changed find_lib with find_package

Adpated the review comments

Change-Id: I719918f73ab33cd8031a32db6fe9b8adaa1b4b87
2020-07-16 00:29:14 -04:00
Sudheer Kumar 7d77902198 [dtest] Enhanced tests to cover multiple hipmemset and hipmemsetAsync apis
SWDEV-238517 for enhancing hip unit tests

Change-Id: Iba2c419a4487955f34b4f19abe174ef427d289d8
2020-07-15 01:13:07 -04:00
sushantkumar14 fe3cd6ca27 [dtest] Half2 comparison related tests
Tests heq2, hne2, hle2, hge2, hlt2, hgt2 APIs for functionality
and NaN tests

SWDEV-238517 for enhancing hip unit tests

Change-Id: I88a9a8ead0d00a1261f3d650361d655f2f397e48
2020-07-14 23:53:55 -04:00
mshivama 1c5537dde4 Add support for few CUDA compatible reduction operations like __syncthreads_count()
Change-Id: I0917820058f0edad5c0bdd42dea37f06353fc63c
2020-07-14 12:03:14 -04:00
Sarbojit Sarkar 9ba3732180 host pointer check [SWDEV-243104, SWDEV-243206]
Change-Id: Id58dabfe5c35e5f8e42d224e700a431a4a97d003
2020-07-14 07:16:12 -04:00
kjayapra-amd 6be6cd9ebd SWDEV-240165 - Adding a simple test for IPC memory.
Change-Id: Ib33ac20412cafa779fe20ff4df8a76dc22d50421
2020-07-13 10:29:04 -04:00
Tao Sang 19d6a646bb Implement HIP_ENABLE_DEFERRED_LOADING in right way
Change-Id: Ia28dbdea5cde93b3ca69f44c6a3c18ec8a730d42
2020-07-11 18:14:03 -04:00
kjayapra-amd ff36244b9c SWDEV-240165 - Move all amd::MemObjMap_ reference to ROCclr and only allow base ptr to get ipc handle.
Change-Id: I4f11e56ba455a7ce5a066c0e9e49657c5220a211
2020-07-09 21:19:50 -04:00
German Andryeyev ef75a3c1db Host device context should return a valid queue
Host memory allocations use shared device context, which allows
to have access from any device. That breaks default queue detection.

Change-Id: I27ad1234d49ab0ea8f5edd6f2e3ffa93c47d4b1f
2020-07-09 10:56:33 -04:00
sushantkumar14 2dc42154c4 [dtest] Added hipStreamGetPriority API test
SWDEV-238517 for enhancing hip unit tests

Change-Id: Icff175360815ba6e25a6954a67947b65caff3711
2020-07-09 01:59:44 -04:00
jujiang b90f3732ea SWDEV-242207-Update deprecated APIs
Change-Id: I0c1c7f33f75232b210495241d0e5e7e6b90d45f0
2020-07-08 15:23:52 -04:00
jujiang e73e0d2fb3 SWDEV-241903-Add document HIP_logging.md
Change-Id: I348218218b305e845b7e26afaeb4e287bf0387de
2020-07-08 11:19:33 -04:00
Rahul Garg 27002fd792 Bump version to 3.7
Change-Id: Id077c317573e95833c8bc7f16951df776de2a273
2020-07-08 01:54:05 -04:00
Aryan Salmanpour 8f862becd0 add an error message before aborting if a wrong GPU target was used for compilation
Change-Id: I7b41e93d420dbc47978238a681f2956a0def01cb
2020-07-07 14:50:44 -04:00
Lakhan singh Thakur 18f8b15523 [dtest] Enhancing hipStreamAddCallback() api test
-Scenario-1:: This test case is used to verify if the callback function
              called through  hipStreamAddCallback() api completes the
	      execution in order as hipStreamAddCallback() api queued
	      in their respective streams: hipStreamACb_AltEnqueue.cpp
-Scenario-2:: This test case tests if Host thread continues with next
              command after hipStreamAddCallback() api or wait for
	      callback() call to finish. Ideally Host thread should not
              wait for callback to
              finish: hipStreamACb_ThrdBehaviour.cpp
-Scenario-3:: Streams are launched in individual GPUs with different
              kernel Verify that all the kernels queued are executed
	      before the callback is hit: hipStreamACb_MStrm_Mgpu.cpp
-Scenario-4:: Checks the callback execution in the same order it was
              added. Also, it checks if the number of callbacks
	      executed are same as the number of callbacks added:
	      hipStreamACb_order.cpp
-Scenario-5:: This test case checks whether hipStreamSynchronize() is
              taking less time than the time taken by Callback()
	      function launched by hipStreamAddCallback() api :
	      hipStreamACb_StrmSyncTiming.cpp
-Scenario-6:: This test case is used to check if the runtime is ok when
              hipStreamAddCallback() is called back to back multiple
	      calls: hipStreamACb_MultiCalls.cpp
-Scenario-7:: This test case is used to check the behaviour of HIP when
              multiple hipStreaAddCallback() are called over multiple
	      Threads:hipStreamACb_MultiThread.cpp
              (Currently disabled)

SWDEV-238517 for enhancing hip unit tests

Change-Id: I9c7b7df6766c728b2b201df18726b9fbdd434c06
2020-07-07 00:43:32 -04:00
Michael LIAO b39195b639 [hipcc] Only add -x hip on HIP-Clang compilation.
Change-Id: I19704c713ad00f92196d7586498e62f80b8cd177
2020-07-06 15:16:51 -04:00
Yaxun (Sam) Liu b72e8b54e0 Add pow(float/double/_Float16,int)
Change-Id: Ie65d15cd3df9853a3bbd613d8c7188ae39c327c7
2020-07-06 07:38:57 -04:00
Jatin Chaudhary 3173dbdec0 Fix error: cannot pass object of non-trivial type string through variadic function when building in debug mode
Change-Id: Idd55ed422addc815fb56c57b05bd4afa9563f2ac
2020-07-06 00:48:40 -04:00
Jason Tang c371b4e3b0 SWDEV-242879 - Not to use fixnames
Change-Id: I3d0e2f3fe6c773e020c8bf8cdfd75fd565d61505
2020-07-02 08:15:07 -04:00
kjayapra-amd 2f963728f7 SWDEV-236178 - Fixing func_attributes that was over written on redesign.
Change-Id: I157913ae4fa4a3a149817e901f10475b7750188b
2020-07-01 11:52:45 -04:00
German Andryeyev 11b7842f71 Remove hipMemcpyDeviceToDevice check.
There is hipMemcpyDefault that requires validation also.

Change-Id: I5ae0ffa1c023b7774547acbdc049b84a0c2cb4c5
2020-06-30 12:59:54 -04:00
Ronak Chauhan 133251a6e1 Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

This is different from fb6bb04f03.

We try to accomodate the case when a kernel template has multiple
type parameters.

Change-Id: I87577d402c92b0f3b51e298f8293f4065e1f6de8
2020-06-30 10:44:55 -04:00
Daniil Fukalov 359ea4fcaf Add __attribute__((const)) to grid related functions declarations
This is cherrypick of Daniil Fukalov's PR https://github.com/ROCm-Developer-Tools/HIP/pull/2110
which has been committed to master branch.

Make declarations consistent with https://github.com/RadeonOpenCompute/ROCm-Device-Libs/blob/amd-stg-open/ockl/src/workitem.cl
Without the attribute these functions don't have "readnone" LLVM IR attribute. Without it some optimizations fails, e.g. Loop Invariant Code Motion doesn't hoist these calls out of a loop.

Change-Id: Idb599570d142152cc4f6a3c8986384ad7f0c4729
2020-06-29 13:33:18 -04:00
Cole Nelson 0b7703560a packaging/hip-rocclr.txt: multi-version install broken because of 'hip_rocclr'
Versioning understands 'hip-rocclr' not the deprecated 'hip_rocclr'.
Remove this.

Leaving Provides hip-hcc until package shifts settle down.

SWDEV-242143:

Change-Id: I489fa28dd1394625bc6016a3adda4f73d02da202
Signed-off-by: Cole Nelson <cole.nelson@amd.com>
2020-06-25 14:17:16 -04:00
rohit pathania c14e95741b [dtest] hipMemcpyWithStream API multithreaded test scenarios
1.hipMemcpyWithStream with one stream
2.hipMemcpyWithStream with two streams
3.hipMemcpyWithStream multiGPU with one stream
4.hipMemcpyWithStream with kind DtoH
5.hipMemcpyWithStream with HtoH
6.hipMemcpyWithStream with DtoD
7.hipMemcpyWithStream with Default kind
8.hipMemcpyWithStream with Default kind on same device
9.hipMemcpyWithStream with DtoD on same device

SWDEV-238517 for enhancing hip unit tests

Change-Id: I5f55a12bdd7c8d28fcb06db94a491c2ad5ee3004
2020-06-25 12:51:23 -04:00
Ronak Nilesh Chauhan b15e835d9e Revert "Support passing macros to hipLaunchKernelGGL"
This reverts commit fb6bb04f03.

Reason for revert: This patch breaks ROCPrim tests

Change-Id: Ib2235f719861c9f4317c33e86b6c1f8bc669cfd4
2020-06-24 04:28:46 -04:00
Evgeny c148adf362 HIP-PROF: fixing pointers tracing
Change-Id: Id2c35972e1d134012980c95a3649ddfdf9303494
2020-06-23 14:02:35 -04:00
kjayapra-amd a5c437c82e SWDEV-209747 - Staging Copy will not be supported in HIP, adjust test case accordingly.
Change-Id: Iad616ef3990d539cdb82bbd8a22ea2124f7abe50
2020-06-23 13:14:17 -04:00
agodavar 6a47458764 SWDEV-239297:hipMemset fix, getMemoryObject with unaligned ptr
Change-Id: I37b8139c5099d37b42f34d728a3d694fdf9cb55d
2020-06-23 08:56:09 -04:00