Alex Voicu
7bc5d01aaa
Update new tests so as to make them work with new variadic based launch mechanisms.
...
[ROCm/hip commit: bd78459690 ]
2017-11-10 00:14:34 +00:00
Alex Voicu
f08f1efab8
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
[ROCm/hip commit: f7726cd416 ]
2017-11-09 23:43:07 +00:00
Maneesh Gupta
56d3677499
Merge pull request #250 from AlexVlx/feature_add_agent_global_support
...
Support for agent globals
[ROCm/hip commit: 31bcb59f62 ]
2017-11-09 07:52:09 +05:30
Alex Voicu
4950373967
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# tests/src/runtimeApi/stream/hipStreamSync2.cpp
[ROCm/hip commit: 3d248927e4 ]
2017-11-08 10:26:30 +00:00
Maneesh Gupta
6368c2abc7
Merge pull request #255 from AlexVlx/remove_some_trailing_whitespace
...
Clean up trailing whitespace so as to reduce noise in #246 .
[ROCm/hip commit: ebd58d43fa ]
2017-11-08 10:29:19 +05:30
Maneesh Gupta
f71d0a049f
Merge pull request #253 from mangupta/hit_add_cmakecmd
...
[hit] Add support for cmake commands as part of test infra
[ROCm/hip commit: caa7174652 ]
2017-11-08 09:50:29 +05:30
Alex Voicu
35d8af2001
Clean up trailing whitespace so as to reduce noise in #246 .
...
[ROCm/hip commit: d8e323d4b5 ]
2017-11-08 00:08:55 +00:00
Ben Sander
d6764bc6ba
Merge pull request #254 from bensander/event_thread_safe
...
Event thread safe
[ROCm/hip commit: 9fd6c18ef8 ]
2017-11-07 17:59:51 +01:00
Maneesh Gupta
34943a2c40
Merge pull request #252 from phani544/newTests2
...
More tests for memory,stream & error APIs
[ROCm/hip commit: 247d563114 ]
2017-11-07 10:38:18 +05:30
Phaneendr-kumar Lanka
6fd3d9fda5
identation change in hipPeekAtLastError
...
[ROCm/hip commit: e06c546283 ]
2017-11-07 09:51:32 +05:30
Alex Voicu
c3fdb8ab8e
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
[ROCm/hip commit: adaf6b8dff ]
2017-11-07 00:01:22 +00:00
Ben Sander
d9db9dabeb
Check for null event in hipEventElapsedTime
...
[ROCm/hip commit: f278f67d2d ]
2017-11-06 23:49:31 +00:00
Ben Sander
465b24123b
hipStreamWaitEvent returns success if event created but not recorded
...
[ROCm/hip commit: 16708dd2e0 ]
2017-11-06 23:49:31 +00:00
Ben Sander
f80896d58b
Make hipEvent_t thread safe.
...
Support re-recording of same event by different threads.
- Add criticalData structure to hipEvent_t, similar to mechanism used
for streams, contexts, device. Events are always locked
after streams to avoid deadlock.
- ihipEvent_t::locked_copyCrit can be used to copy critical state
including marker. The critical state in the event can then
be re-recorded.
- refactor hipEventElapsedTime. Remmove stale debug code, native signal
refs.
[ROCm/hip commit: 4a2e6f8955 ]
2017-11-06 23:49:25 +00:00
Maneesh Gupta
879699fe0b
[hit] Add support for cmake commands as part of test infra
...
Cmake supports several builtin command-line tools. These tools can
now be specified as part of the HIT block. These commands will be
run during cmake configure step.
Change-Id: I32466c94b2fe1ecdc30249755fc027102295617d
[ROCm/hip commit: 197a7e2600 ]
2017-11-06 16:53:57 +05:30
Phaneendr-kumar Lanka
2f4b59a9b9
Modified tests as per review
...
[ROCm/hip commit: 9ee330451a ]
2017-11-06 15:13:36 +05:30
Phaneendr-kumar Lanka
a8da9c1c3b
More tests for memory,stream & error APIs
...
[ROCm/hip commit: 093279b10b ]
2017-11-06 11:31:52 +05:30
Maneesh Gupta
33836c9521
Merge pull request #251 from ROCm-Developer-Tools/fix_event_state
...
Set event state AFTER it is recorded.
[ROCm/hip commit: 1131c9e41a ]
2017-11-06 07:28:11 +05:30
Maneesh Gupta
8845e38efd
Merge pull request #249 from bensander/warn_event
...
Add HIP_DB=warn + message if sync on dangerous event.
[ROCm/hip commit: a62d5aa875 ]
2017-11-06 07:25:40 +05:30
Maneesh Gupta
3746211481
Merge pull request #239 from phani544/newTests
...
[newTests]Adding tests for device APIs
[ROCm/hip commit: 2f4e1983e2 ]
2017-11-06 07:22:13 +05:30
Ben Sander
6a4c50cf6c
Set event state AFTER it is recorded.
...
[ROCm/hip commit: 4c3b65a5cd ]
2017-11-05 10:33:18 -06:00
Alex Voicu
1c77e8d6b1
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
[ROCm/hip commit: 2932706d47 ]
2017-11-03 10:57:12 +00:00
Alex Voicu
1f911cd23a
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
[ROCm/hip commit: bb1176001f ]
2017-11-03 10:53:39 +00:00
Phaneendr-kumar Lanka
9d7c904529
[newTests]modified the test
...
[ROCm/hip commit: 0599d13b0d ]
2017-11-03 14:52:19 +05:30
Phaneendr-kumar Lanka
0026b0a3d9
[newTests]Modified the test as per review comments
...
[ROCm/hip commit: a764a0980d ]
2017-11-03 10:39:47 +05:30
Maneesh Gupta
04d9ec1400
Merge pull request #248 from mangupta/SWDEV-134531
...
Remove libsupc++ dependency from HIP
[ROCm/hip commit: d90d431490 ]
2017-11-03 08:01:59 +05:30
Alex Voicu
28eb8e2c3e
This introduces correct support for agent global variables, and implements hipModuleGetGlobal as an actual equivalent for cuModuleGetGlobal.
...
[ROCm/hip commit: 328c18b886 ]
2017-11-03 01:44:48 +00:00
Ben Sander
da749d453f
Merge pull request #247 from AlexVlx/feature_cleanup_tests
...
Test cleanup
[ROCm/hip commit: 67dd5303ad ]
2017-11-02 11:31:10 +01:00
Maneesh Gupta
94a22fe015
Remove libsupc++ dependency from HIP
...
Change-Id: Ib843f99dfb3057b7c28029250c2449732ea7f17f
[ROCm/hip commit: f34f5c8684 ]
2017-11-02 12:29:09 +05:30
Alex Voicu
b8a81d2b75
This corrects some interesting choices that were present in the HIP
...
unit tests such as e.g. de-allocating memory allocated with new[] using
free. All of these were identified via cppcheck.
[ROCm/hip commit: a619ac6f92 ]
2017-11-01 22:51:22 +00:00
Alex Voicu
dab971370e
Correctly deal with functions from shared objects, wherein the program visible VA == so_base_va + st_value(function_symbol). Remove quaint usage of pfe for hipMemset (which is actually fill_n).
...
[ROCm/hip commit: 2cacda91bb ]
2017-11-01 22:33:13 +00:00
Ben Sander
2979a99888
Merge pull request #237 from bensander/use_ctxptr_for_p2p
...
Use ctxptr for p2p
[ROCm/hip commit: 09d866a639 ]
2017-11-01 18:55:25 +01:00
Ben Sander
6c60773e82
Add HIP_DB=warn + message if sync on dangerous event.
...
[ROCm/hip commit: 70c25bdf8e ]
2017-11-01 10:44:34 -07:00
Ben Sander
6f3b28d27c
Merge pull request #245 from scchan/centos_fixes
...
various fixes for centos/rhel
[ROCm/hip commit: 86f62accfd ]
2017-11-01 18:10:29 +01:00
Alex Voicu
70a41e7dac
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
...
[ROCm/hip commit: c2482d1255 ]
2017-11-01 15:09:59 +00:00
Siu Chi Chan
d938703f9b
Centos/RHEL - remove usage of constexpr since libc++ doesn't enable ctor for constexpr pair in C++11
...
[ROCm/hip commit: 99d32a195f ]
2017-10-31 18:16:12 +00:00
Siu Chi Chan
b6265074fa
use libc++ on centos 7 and rhel 7.4
...
[ROCm/hip commit: cd6996614f ]
2017-10-31 18:14:07 +00:00
Maneesh Gupta
e6e90e9cfa
Merge pull request #197 from bensander/update_coherency_tests
...
Update coherency tests
[ROCm/hip commit: f27c2c1715 ]
2017-10-31 17:26:50 +05:30
Maneesh Gupta
07b52ec043
Merge pull request #241 from ROCm-Developer-Tools/multi_host
...
Inital codes to remove x86_64 dependency in HIP source build
[ROCm/hip commit: 4d85b6ab29 ]
2017-10-31 16:35:12 +05:30
Maneesh Gupta
b93e9ae1b7
Merge pull request #242 from bensander/time_hip_apis
...
Add ns-level timer for HIP API routines
[ROCm/hip commit: 7026b73905 ]
2017-10-31 16:33:46 +05:30
Ben Sander
e88ef63bc8
Add ns-level timer for HIP API routines
...
Refactor some miuses of ihipLogStatus, these should only be in top-level
HIP APIs and should be paired with HIP_API_INIT calls.
[ROCm/hip commit: 7e908bdec8 ]
2017-10-30 20:20:51 +00:00
Wen-Heng (Jack) Chung
afb75b0b2c
Inital codes to remove x86_64 dependency in HIP source build
...
[ROCm/hip commit: 92fb244841 ]
2017-10-30 15:19:23 -05:00
Ben Sander
51ee7807db
Merge pull request #222 from bensander/fix_device_prop
...
Fix device prop
[ROCm/hip commit: 2e8ec71e40 ]
2017-10-30 17:58:48 +01:00
Ben Sander
ccb8b441a7
Check for null copyEngine before looking at peers.
...
[ROCm/hip commit: d610f16c47 ]
2017-10-30 16:58:03 +00:00
Ben Sander
8242c45eda
Merge pull request #226 from scchan/add_printf3
...
add printf to HIP device functions
[ROCm/hip commit: f8843ae415 ]
2017-10-30 17:08:18 +01:00
Phaneendr-kumar Lanka
a36c3c6d8b
[newTests]Adding tests for device APIs
...
[ROCm/hip commit: 511de63bcb ]
2017-10-30 14:34:24 +05:30
Evgeny Mankov
27c5e94c81
[HIPIFY] fix typo - missing )
...
[ROCm/hip commit: 44c74b6511 ]
2017-10-27 23:31:43 +03:00
Evgeny Mankov
b9a52020b2
Merge pull request #238 from ChrisKitching/statistics
...
[HIPIFY] Decouple the statistics system from the code rewriter
[ROCm/hip commit: b28a69785b ]
2017-10-27 23:17:20 +03:00
Evgeny Mankov
193235bd08
Merge pull request #236 from ChrisKitching/friendlyCmake
...
[HIPIFY] Make the cmake build system more friendly
[ROCm/hip commit: c9b7c43e1c ]
2017-10-27 22:35:13 +03:00
Chris Kitching
54f786583b
Remove commented else-block
...
A warning statement for _string literals_ seems a bit unhelpful.
There's no value in this being here.
[ROCm/hip commit: 20871a3a07 ]
2017-10-27 20:12:33 +01:00