* Fix: Add explicit includes for assert.h and thread in sample/vcopy.cpp
The HIP/CLR change e3cb5399c removed transitive inclusion
of standard headers like assert.h from hip_runtime.h.
This caused build failures in rocprof-compute samples.
This commit explicitly includes <assert.h> and <thread>
in vcopy.cpp to resolve potential missing definitions.
Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
* Update vsequential_access.cpp
Added assert and thread imports
Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
* Update vrandom_access.cpp
Added assert import
Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
* Update vsequential_access.cpp
Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
---------
Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
* Revert of https://github.com/ROCm/rocprofiler-compute/pull/738
* Change default rocprof backend interface to rocprofv3
* Add MI 350 support in documentation
* Added known issue that MI 100 profiling will not work unless rocprofv1
is explicitly opted in
* Remove MI 50 soc gfx python class since MI 50 is not supported
Add option to print out roofline plot in terminal using plotext.
Takes in one datatype and returns the str from plot.build() which contains the visual plot of roofline analysis for said datatype.
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Update roofline binaries from rocm-amdgpu-bench
- uses hip to find number of CUs dynamically instead of hardcoded values in table
Remove duplicate AI plot points printing
- only print ai points once on plot since we are measuring using total flops and value is same
- remove datatype from legend labels
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
--gui option for analyze mode failing due to missing arg in load_kernel_top call in pre_processing
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* add pull_request_template.md
* add bug fix or feature checkboxes
* Address feedback and align more with sdk implementation
* Add other category under PR type if needed
* rocprof-compute TUI (Text User Interface) - providing users interactive analyze experience with visuals.
* Analyze results with tables, charts, plots.
* Add menu bar, terminal, directory dialog. Improve logging and ui.
* Add display config file to manipulate result categorization.
* Add support for recently opened dirs.
* Update licensing and version.
* Setting ROCPROF=rocprofiler-sdk environment variable will use rocprofiler-sdk C++ library instead of rocprofv3 python script
* Add runtime option --rocprofiler-sdk-library-path to use custom version of rocprofiler sdk library
* Add --rocprofiler-sdk-library-path conftest option for tests
* Setup appropriate environment variables to inject rocprofiler sdk code to user command
* Add env. vars. for counter collection and filtering
* Add env. vars. for pc sampling
* Use python bindings to list counters supported by rocprofiler sdk
* Avoid crash when profiling data not generated
-Handle case where program has no kernel launches
-Improve error messages
-Avoid roofline when profiling data is missing
Signed-off-by: benrichard-amd <ben.richard@amd.com>
* Update other soc_gfx files to catch missing pmc_perf.csv
* Fix formatting
* Fix incorrectly ordered imports
---------
Signed-off-by: benrichard-amd <ben.richard@amd.com>
Rework of roofline binaries generated from rocm-amdgpu-bench
- removed arch identifier in bin name
- removed rocm5 bins altogether
Updated required distros for roofline
- updated distro checks and bin naming
- moved up ubuntu20.04->22.04 and sles15.3->15.6 per rocm support
Enabled ctests for mi350 for test_roof_*
- removed mi350 series check to skip these specific tests
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Add rp-compute technical writer directly for any documentation review.
Remove existing packaging review requests for single user; every repo owner should be notified.
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Add test for 9fx942 number of xcds.
* Improve the structure of mi gpu specs, add num_xcds_spec_class test.
* Add to ctest.
---------
Signed-off-by: xuchen-amd <xuchen@amd.com>
vedithal-amd
ywang103-amd
Jason Bonnell
jamessiddeley-amd
David Galiffi
cfallows-amd
Fei Zheng
Pratik Basyal
xuchen-amd
Ben Richard
anisha-amd
Daniel Su