Revīziju grafs

6528 Revīzijas

Autors SHA1 Ziņojums Datums
Evgeny Mankov a8236c22ad [HIPIFY] Fix multiple input files support
Reported in #1168


[ROCm/clr commit: 266cf3cf96]
2019-06-20 18:05:57 +03:00
Aryan Salmanpour 362445220a [hip] implement the hipExtLaunchMultiKernelMultiDevice API (#1165)
* [hip] implement the hipExtLaunchMultiKernelMultiDevice API

* add a guard to check the HCC version for acquire_locked_hsa_queue() API which was introdued in HCC for ROCm 2.5

* modified code based on the requested changes

* changes to lock all streams before launching kernels for each device and unlock them after the dispatches

* check each stream to be valid before starting to lock all the streams


[ROCm/clr commit: d6ad690cb6]
2019-06-20 05:59:05 +05:30
wkwchau 81b5ea1c4a Implement the hipOccupancyMaxPotentialBlockSize function (#1162)
* Implement the hipOccupancyMaxPotentialBlockSize function

* Replaced hipGetDeviceProperties() call by ihipGetDeviceProperties() in ihipOccupancyMaxPotentialBlockSize()

* Add test for hipOccupancyMaxPotentialBlockSize in Module API

* Added extern declaration for ihipGetDeviceProperties() to be accessed inside ihipOccupancyMaxPotentialBlockSize()

* fixed hipOccupancyMaxPotentialBlockSize test build issue

* Fix hipOccupancyMaxPotentialBlockSize dtest

* Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest

* Revert "Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest"

This reverts commit 0480ff56f1441fc515d2c26ce33783e303423938.

* Disable hipOccupancyMaxPotentialBlockSize dtest on NVCC

* move extern declaration of ihipGetDeviceProperties to hip_module.cpp

* Update the limiation of 32 wavefronts per CU and 800/512 SGPRs for VI/pre-VI chips to calculate the occupancy


[ROCm/clr commit: 28c34ead70]
2019-06-20 05:58:29 +05:30
Maneesh Gupta 9ce31b041b Merge pull request #1164 from gargrahul/cleanup_module_api_samples
Add cleanup code in module api samples

[ROCm/clr commit: 439b6e41d4]
2019-06-20 05:57:46 +05:30
Maneesh Gupta c5a26eb941 Merge pull request #1173 from icarus-sparry/icarus-sparry-patch-1
Make hip_prof_gen.py compatible with both python 2 and 3

[ROCm/clr commit: 21d9875046]
2019-06-19 13:37:02 +05:30
Maneesh Gupta 78c1170131 Merge pull request #1171 from mhbliao/hliao/master/hipcc
[hipcc] Revise include path calculation.

[ROCm/clr commit: 3083337056]
2019-06-19 13:36:51 +05:30
Maneesh Gupta 0b3f5d4524 Merge pull request #1167 from eshcherb/hip_prof_refactoring_190611
prof layer includes refactoring

[ROCm/clr commit: 3b3118d459]
2019-06-19 13:36:33 +05:30
Maneesh Gupta f2ba4e98a1 Merge pull request #1163 from gargrahul/fix_module_api_kernarg_sample
Fix sample to use kernelargs for launch

[ROCm/clr commit: ad5a15debd]
2019-06-19 13:36:17 +05:30
Jenkins 91ed3d674a Merge 'master' into 'amd-master'
Change-Id: I640c6dfa3523f006ad0c2e05b325017609192484


[ROCm/clr commit: ff265232e4]
2019-06-18 20:54:26 -04:00
Icarus Sparry 16d9ded677 Make hip_prof_gen.py compatible with both python 2 and 3
Convert python 2 constructs to python 3 compatible ones.

In python 3, print is a function, so use write methods (which are always functions) instead.

In python3 keys() returns an iterator, rather than a list. This means you can't change the data structure that is being iterated over. Converting this iterator into a list mimics the python 2 behavior.

[ROCm/clr commit: 17bebbd0f2]
2019-06-17 12:03:36 -07:00
Michael LIAO 43d194a641 [hipcc] Revise include path calculation.
- Once HIP_VDI_HOME is defined but HIP_CLANG_INCLUDE_PATH is not,
  calculate it directly without HIP_CLANG_PATH is defined or not;
  Otherwise, we may leave HIP_CLANG_INCLUDE_PATH undefined, if clang is
  not installed following the official way (so far, HIP-Clang breaks
  that), we may leave HIP_CLANG_INCLUDE_PATH undefined before its uses.


[ROCm/clr commit: c3604d3120]
2019-06-14 13:35:00 -04:00
Rahul Garg effbc8b212 HACK for SWDEV-173477/SWDEV-190701
[ROCm/clr commit: 107734f7ad]
2019-06-13 18:15:31 -07:00
foreman c12f428d1a P4 to Git Change 1815357 by cpaquot@cpaquot-ocl-lc-lnx on 2019/06/12 16:24:09
SWDEV-192384 - [HIP] Fixed case where start and stop events are the same for ElapsedTime.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#11 edit


[ROCm/clr commit: 5bee4dfe90]
2019-06-13 15:40:39 -04:00
foreman 8b0eaa1c05 P4 to Git Change 1815283 by gandryey@gera-win10 on 2019/06/12 15:26:45
SWDEV-180872 - Runtime support changes for Cooperative Group Features
	- Correct the name in the def files

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#19 edit


[ROCm/clr commit: df1257741c]
2019-06-13 13:00:48 -04:00
foreman 072d96516e P4 to Git Change 1815146 by cpaquot@cpaquot-ocl-lc-lnx on 2019/06/12 13:43:33
SWDEV-192333 - [HIP] Implemented hipExtMallocWithFlags and hipExtGetLinkTypeAndHopCount

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#59 edit


[ROCm/clr commit: 752a4e57b6]
2019-06-13 12:47:17 -04:00
foreman 90dcff1345 P4 to Git Change 1809454 by kjayapra@0_HIPWS_TRT2_ROCM on 2019/06/11 17:45:36
SWDEV-191936 - Implementation of hipMemcpyPeer & hipMemcpyPeerAsync + fix to check source P2PAgents for P2P. RocM Verified.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#76 edit


[ROCm/clr commit: 5c6b42efed]
2019-06-12 10:48:40 -04:00
foreman 76b1d242d2 P4 to Git Change 1809277 by gandryey@gera-win10 on 2019/06/11 17:34:13
SWDEV-180872 - Runtime support changes for Cooperative Group Features
	- Initial implementation of the core functionality. Disabled by default. Use GPU_ENABLE_COOP_GROUPS=1 to enable the feature.
	- Runtime uses device queue for cooperative executions with a synchronization on the launched queue.
	- The current implementation is pure runtime change and it can work if only one app uses this feature. No ROCr/KFD support was added or tested
	- Only inline assembler was tested

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#20 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#28 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#338 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#606 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.hpp#171 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palblit.cpp#31 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palblit.hpp#9 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#142 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#39 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palschedcl.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#135 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#61 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocblit.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocblit.hpp#12 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#127 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#37 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocschedcl.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#75 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.hpp#23 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#94 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#92 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#311 edit


[ROCm/clr commit: 623320cd93]
2019-06-12 10:00:38 -04:00
Evgeny 214c01e6bf prof layer includes refactoring
[ROCm/clr commit: c6600ba26b]
2019-06-11 20:13:29 -05:00
Rahul Garg ebd29537d0 Add cleanup code in module api samples
[ROCm/clr commit: 49ac54abde]
2019-06-07 05:23:11 +05:30
Rahul Garg 14f409548a Fix sample to use kernelargs for launch
[ROCm/clr commit: 4e6ad95403]
2019-06-07 05:17:15 +05:30
foreman 3bc1711330 P4 to Git Change 1792745 by vsytchen@vsytchen-remote-ocl-win10 on 2019/06/06 11:18:13
SWDEV-145570 - Simplify pinned memory allocation logic

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17467/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#58 edit


[ROCm/clr commit: 5683d9d218]
2019-06-06 11:51:22 -04:00
Maneesh Gupta 9b478cb227 Merge pull request #1160 from mhbliao/hliao/master/explicit
[hip] Replace implicit conversions with explicit ones.

[ROCm/clr commit: 580f4a65b2]
2019-06-06 07:27:40 +05:30
Michael LIAO ef6ca030cb [hip] Replace implicit conversions with explicit ones.
[ROCm/clr commit: 4d5cf71c48]
2019-06-05 10:00:35 -04:00
Maneesh Gupta b4fb2b0ab4 Merge pull request #1140 from scchan/program_state_stage_2-rebase-20190524
migrate more program_state logic from header into shared library (phase II)

[ROCm/clr commit: 1d5d923d36]
2019-06-05 16:09:01 +05:30
Maneesh Gupta 932d76e45b Merge pull request #1114 from cdevadas/implicit-kernarg
Runtime changes to append implicit kernel arguments.

[ROCm/clr commit: 3b3c442757]
2019-06-05 16:07:19 +05:30
Maneesh Gupta f616eed25e Merge pull request #1159 from mhbliao/hliao/master/explicit
[hip] Make vector type's scalar conversion explicit.

[ROCm/clr commit: b2c6817df0]
2019-06-05 12:13:56 +05:30
Maneesh Gupta db75e56b70 Merge pull request #1158 from dereklstinson/patch-1
fixed targets flag and TARGET GPU

[ROCm/clr commit: c67b47e87b]
2019-06-05 12:13:46 +05:30
Maneesh Gupta fcb17fb7c9 Merge pull request #1157 from mhbliao/hliao/master/misc
[hip] Minor fix to silence compilation warnings.

[ROCm/clr commit: e088678355]
2019-06-05 12:13:35 +05:30
Michael LIAO 0067b36618 [hip] Make vector type's scalar conversion explicit.
[ROCm/clr commit: 62d70cb2c8]
2019-06-04 15:15:26 -04:00
Derek Stinson 586be507ed fixed targets flag and TARGET GPU
--target-isa= didn't work any longer.

[ROCm/clr commit: c401cb56e3]
2019-06-04 14:19:39 -04:00
Michael LIAO a56332edc7 [hip] Minor fix to silence compilation warnings.
- Add parenthese to silence repeative compilation warnings across
  projects built against hip.


[ROCm/clr commit: 2655003fde]
2019-06-04 10:39:31 -04:00
foreman c10cebcf6f P4 to Git Change 1791519 by vsytchen@vsytchen-remote-ocl-win10 on 2019/06/04 10:06:43
SWDEV-189383 - [HIP CQE][HIPonPAL][WIN] hipDeviceMalloc, hip_test_ldg, hipHostRegister, hipModule, hipStreamSync2 tests failed on VEGA10.

	1. For pinned memory allocations add the host pointer and all of its respective device pointers to the memory object map.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#57 edit


[ROCm/clr commit: 9a301adffe]
2019-06-04 10:24:11 -04:00
Maneesh Gupta 3d6944e0db Merge branch 'master' into implicit-kernarg
[ROCm/clr commit: d4fa74ff09]
2019-06-04 13:24:19 +05:30
Maneesh Gupta fb0b752204 Merge pull request #1156 from yxsamliu/fix-vdi
Fix default HIP_VDI_HOME

[ROCm/clr commit: 48e657b099]
2019-06-04 13:21:48 +05:30
Maneesh Gupta 1a9326b2dd Merge pull request #1155 from gargrahul/fix_kernel_lp_dim_trace
Fix wrong grid dim shown in trace

[ROCm/clr commit: 40a09318e4]
2019-06-04 13:21:39 +05:30
Maneesh Gupta 0853a2dcfb Merge pull request #1154 from yxsamliu/tex
Add device_builtin_texture_type attribute to texture type for hip-clang

[ROCm/clr commit: 8a859f8020]
2019-06-04 13:21:29 +05:30
Maneesh Gupta 601bd522af Merge pull request #1152 from asalmanp/hip_as_b
Header change for new hip API hipExtLaunchMultiKernelMultiDevice

[ROCm/clr commit: ef87f7eaef]
2019-06-04 13:21:13 +05:30
Maneesh Gupta 5ca1fc546e Merge pull request #1149 from zuhaib27/SWDEV-185448
Structured hipFloatComplex as typedef of float2, and hipDoubleComplex as typedef of double2.

[ROCm/clr commit: 98aa6cf895]
2019-06-04 13:21:02 +05:30
Maneesh Gupta 9f35c7bf43 Merge pull request #1130 from lmoriche/master
Add support for code object v3

[ROCm/clr commit: 4b3d59a93e]
2019-06-04 13:20:52 +05:30
cdevadas 8de283ef77 Runtime changes to append implicit kernel arguments.
Appended 48 empty bytes to the kernarg area at runtime. The implicit arguments are enabled primarily for the hostcall services
and it is completely abstracted from the user code. Enabled it for both hip-clang and hip-hcc.


[ROCm/clr commit: 214ec53da3]
2019-06-04 10:45:49 +05:30
Maneesh Gupta 09e28793b5 Merge pull request #1153 from mangupta/disable_hiprtc_tests
[dtests] Temporarily disable hiprtc tests

[ROCm/clr commit: 15abdd838f]
2019-06-03 12:00:03 +05:30
Yaxun Sam Liu 101cb68a36 Fix default HIP_VDI_HOME
There is soft link /opt/rocm/bin/.hipVersion, therefore when hipcc is executed
as /opt/rocm/bin/hipcc, it will set HIP_VDI_HOME to /opt/rocm, which is
incorrect. Check ../lib/bitcode instead to identify HIP_VDI_HOME.


[ROCm/clr commit: 154765df88]
2019-05-31 23:58:59 -04:00
Rahul Garg a8de3fafba Fix wrong grid dim shown in trace
[ROCm/clr commit: 7a2e3b6a1c]
2019-05-31 22:30:24 +05:30
Yaxun Sam Liu 7a4dfd23d5 Add device_builtin_texture_type attribute to texture type for hip-clang
This is required to support texture type for hip-clang.


[ROCm/clr commit: 7c20081f8d]
2019-05-31 12:07:58 -04:00
Maneesh Gupta 33b6b0bba7 [dtests] Temporarily disable hiprtc tests
Change-Id: I87c0c01837e7b59b11d99fb94d679a765f914da5


[ROCm/clr commit: 165d73de9a]
2019-05-31 16:39:33 +05:30
Aryan Salmanpour aab9b5a13b Header change for new hip API hipExtLaunchMultiKernelMultiDevice
[ROCm/clr commit: d8e94fd5b5]
2019-05-30 18:04:05 -04:00
Jenkins 8d1c43c854 Merge 'master' into 'amd-master'
Change-Id: Icb2a5ad71466d9c3478f4ffd9ac96173284dcf23


[ROCm/clr commit: 595226ad36]
2019-05-30 02:21:28 -07:00
foreman 5067bf0fad P4 to Git Change 1789054 by cpaquot@cpaquot-ocl-lc-lnx on 2019/05/29 14:02:50
SWDEV-190565 - [HIP] Don't use clSetEventWaitList and just add the event to the list in HIP.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#10 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_common.hpp#24 edit


[ROCm/clr commit: 6b4be4fe35]
2019-05-29 14:38:26 -04:00
Maneesh Gupta 3ad6635c63 Merge pull request #1148 from kpyzhov/fix-windows-hip-clang-path
Fixed setting HIP_CLANG_PATH on Windows.

[ROCm/clr commit: 690fa7b29b]
2019-05-29 12:35:00 +05:30
Siu Chi Chan 339a048377 fix compilation error when host compiler is clang (#1147)
* fix compilation error when host compiler is clang

* use a macro specifically for hcc && hip-clang


[ROCm/clr commit: b2ffd6afc2]
2019-05-29 12:34:48 +05:30