Commit Graph

437 Commits

Author SHA1 Message Date
dependabot[bot] 7f2b19882d Bump rocm-docs-core[api_reference] from 1.18.1 to 1.18.2 in /docs/sphinx (#159)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.18.1 to 1.18.2.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.1...v1.18.2)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.18.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-03 09:46:25 -04:00
Ben Richard ee11f5b206 rocprof-sys-run: Change terminal color back to normal after printing usage (#155)
* Change terminal color back to normal after printing usage

* Format source

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-04-01 11:06:40 -04:00
David Galiffi beae5e5b44 Update dyninst submodule (#153)
Fix GGC 13 build failure caused by a missing include of <array>

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-03-31 11:10:48 -04:00
David Galiffi 7bb45aba1c Additional AMD-SMI Updates (#149)
- Check AMDSMI header version to fix compilation failure with v2.0 header change
- Fix ROCM-SMI references in documentation and tests
- Check AMDSMI library version at runtime and output in logs
- Fix a possible exception occurring when an in-flight sample is outstanding while the component is shutting down.
2025-03-31 11:07:50 -04:00
David Galiffi b6b39af011 Fix "ROCPROFSYS_USE_ROCM" runtime config setting. (#144) 2025-03-27 16:03:46 -04:00
Aleksandar Djordjevic 2bad0e941b Disable RCCL, load libamdhip64.so (#150)
Disable RCCL and load libamdhip64.so as a fix for sw509497.
2025-03-27 16:02:17 +01:00
Wileam Phan 2805631ccd Fix rocprof-sys-instrument default linkage and visibility criteria (#95)
* Fix default linkage and visibility criteria
* Fix processing of linkage and visibility CLI flags
* Format source

Signed-off-by: Wileam Yonatan Phan <wileamyonatan.phan@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-03-27 18:33:35 +08:00
David Galiffi 85bbea4954 Reapply "Upgrade ROCm-SMI to AMD SMI (#86)" (#147)
* Reapply "Upgrade ROCm-SMI to AMD SMI (#86)"

This reverts commit b3eee295dd.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-03-25 17:31:27 -04:00
David Galiffi e9603238f7 Ignore updates to .wordlist.txt for certain workflows (#148) 2025-03-24 18:16:46 -04:00
Pranjal Swarup 1e9a82fe54 Timemory and Dyninst were updated to use BinUtil v2.42 (#146)
Timemory and Dyninst were updated to use BinUtil v2.42 by the default 
Update Dyninst submodule
Update Timemory submodule
2025-03-21 17:23:20 -04:00
David Galiffi 9b7d70fcc8 Add extra validation to the openmp target ctest (#141)
Update openmp-target ctest.

- Add a validation step to check the proto file for the offloaded kernel name

- Update the validation script to add an option to validate a substring of the perfetto label rather than an exact match.
2025-03-20 15:18:25 -04:00
David Galiffi 9c6be7433a Update CHANGELOG.md (#142)
* Update CHANGELOG.md
2025-03-20 12:33:48 -04:00
ajanicijamd 26bb604215 Fix a RCCL initialization to avoid a deadlock (#136)
Also fixes: 

- crash while finalizing rocprof-sys-causal
2025-03-19 14:48:04 -04:00
dependabot[bot] b621691a53 Bump rocm-docs-core[api_reference] from 1.17.1 to 1.18.1 in /docs/sphinx (#137)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.17.1 to 1.18.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.17.1...v1.18.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-17 13:50:58 -04:00
Sajina PK e605e5d33f Fix for excluding JPEG and VCN activity test. (#135)
JPEG activity recording is currently only supported on MI300 serries.
VCN activity is supported in MI100 also but there is a bug currently being fixed by FW.

- Currently only testing the Activity verification tests for MI300
- Also moves the Jpeg image copying code to after the package is found.
2025-03-11 14:12:28 -04:00
dependabot[bot] ccb315787e Bump jinja2 from 3.1.4 to 3.1.6 in /docs/sphinx (#134)
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.6.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](https://github.com/pallets/jinja/compare/3.1.4...3.1.6)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-07 13:55:51 -07:00
Sajina PK 0071fd2d81 Add contributing guidelines (#119)
---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-03-07 14:47:30 -05:00
David Galiffi 5fc495c1e7 Update libraries' SOVERSION to match other ROCm components (#98)
set SOVERSION to ${PROJECT_VERSION_MAJOR}

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-03-07 10:18:36 -05:00
David Galiffi fdb6f4f6b4 Update runners to use ubuntu-latest (#131) 2025-03-06 18:11:19 -05:00
Sajina PK 2222ce9b83 Documentation update for VCN, JPEG, rocDecode and rocJPEG feature (#109)
* Documentation update for VCN, JPEG, rocDecode and rocJPEG feature

Update documents to include the new tracks for tracing VCN and JPEG
activity.
Update the rocDecode and rocJPEG tracing enabled using ROCprofiler-SDK.
Update headings to the perfetto output images.

* Add few more lines about domain values.

* Add missing words to the dictionary
2025-03-06 18:03:33 -05:00
David Galiffi eb0a969a9c Fix logging error (#130)
When we create profile config with rocprofiler we log the counters being registered. However, this log was being skipped in certain cases.
2025-03-06 14:30:45 -05:00
Sohaib Nadeem 42922ec851 Fix hardware counter summary files not being generated after profiling (#124)
- Register a cleanup function in tim::manager instance to write out data in
counter storages

- The counter_storage::write() calls in tool_fini happen after the storage is destroyed
which is too late for the write to happen.

- Adjust traits for counter_data_tracker

- Add MIN, MAX, VAR, STDDEV columns
- Remove DEPTH, UNITS, %SELF columns

- Update "add_validation_test" to test for the existence of output file(s).
- Added step to test perfetto output for `transpose-rocprofiler-sampling`
and `transpose-rocprofiler-binary-rewrite`

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-03-05 16:05:18 -05:00
arvindcheru c3138e1962 Move install location of internal papi files to lib/<pkgnm> (#118)
Signed-off-by: ArvindCheru <acheruva@amd.com>
2025-03-05 10:23:58 -05:00
David Galiffi a25554359b Update workflow runners due to the deprecation of ubuntu-20.04 runners (#102)
* Update runners to `ubuntu-latest`.

The `ubuntu-20.04` runner is deprecated and will be removed.

* Add 'vim' and 'perfetto' to CI docker images

For convenience when using the images locally.
2025-03-04 19:31:13 -05:00
David Galiffi a588f53d3e Move cmake files to .../lib/cmake/rocprofiler-systems (#128)
* Move cmake files to `.../lib/cmake/rocprofiler-systems`
2025-03-04 19:28:59 -05:00
dependabot[bot] 9b4ec6adb9 Bump rocm-docs-core[api_reference] from 1.17.0 to 1.17.1 in /docs/sphinx (#127)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.17.0 to 1.17.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.17.0...v1.17.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-03 22:55:17 -05:00
David Galiffi 610cd00971 fix false positive in perfetto validation (#125)
- The Perfetto validation script was generating false positives if the queried Perfetto data was empty.
- Fixed some failures that appeared after fixing the script.
2025-03-03 10:32:54 -05:00
David Galiffi a18d00d784 Add doc formatting to workflow (#123)
- Add document formatting workflow from ROCm/rocm-docs-core/.github/workflows/linting.yml
- Updated runners to use ubuntu-22.04, since 20.04 is being deprecated.
2025-02-27 23:25:03 -05:00
Sohaib Nadeem 43f900d01e Fix an application crash when collecting performance counters with rocprofiler (#117)
* Add check to skip counter_storage::write() if internal storage field is destroyed.
* Output warning message if counter data is not available when trying to write out to Timemory

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-02-27 14:34:52 -05:00
Sajina PK 3bea1d8eac Add support for rocJPEG API tracing (#116)
- Add rocDecode API Tracing support using domain `rocjpeg_api` in ROCPROFSYS_ROCM_DOMAINS.
- Modify existing `videodecode` and `jpegdecode` ctests to verify API tracing
- Print Perfetto values for easy debugging in verbose mode
- Convert CMake error to a warning and skip building the "decode" examples if requirements are not found
2025-02-25 21:14:14 -05:00
David Galiffi a03770c060 Update VERSION to 1.1.0 (#115)
Bump minor version now that the `release/rocm-rel-6.4` branch has been created.
2025-02-21 11:07:10 -05:00
Sajina PK 59d3399901 JPEG Activity tracing in Perfetto (#108)
- Add JPEG activity track in perfetto trace
- Add JPEG decode tests to the examples
- Change existing videodecode test to include JPEG testing
- Rename videodecode test file to decode to include jpeg tests too
- Fix a bug in the test which checks for total activity of 0
- Disable rocDecode and rocJPEG samples from the github image files
2025-02-21 10:25:01 -05:00
dependabot[bot] c1d8799f92 Bump rocm-docs-core[api_reference] from 1.15.0 to 1.17.0 in /docs/sphinx (#114)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.15.0 to 1.17.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.15.0...v1.17.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-20 09:44:29 -05:00
David Galiffi b1d0c431c7 Update python documentation (#106)
* Fix a couple typos. Add note about limitations with AI / ML workloads.

* Updated note based on feedback.
2025-02-19 18:38:42 -05:00
David Galiffi 349c7d3de6 Add note to documentation about Perfetto workaround (#103)
Users viewing the "latest" documentation may still be using a version of omnitrace / rocprofiler-systems prior to 6.3.1. Re-add this warning so it is easier to find a workaround.
2025-02-12 21:16:00 -05:00
David Galiffi 3833c8d162 Fix hang in config file generation (#101)
- Updated Timemory module.
- Fixes a crash when running rocprof-sys-avail -G without explicitly providing -F <format>. The default value of "txt" was not being used.
- Define "choices" before "default" when defining the "--config-format" argument in the parser.
2025-02-11 17:36:31 -05:00
Sajina PK 697d1ac02f Add support for VA-API and rocDecode tracing (#92)
- VA API tracing using Timemory gotcha wrappers.
- rocDecode API tracing integration using callback to ROCPROFILER_CALLBACK_TRACING_ROCDECODE_API
- Updated videodecode ctest to validate rocDecode APIs in perfetto trace.
2025-02-11 13:08:23 -05:00
David Galiffi e437200e9e Remove remaining roctracer references (#82) 2025-02-07 23:27:58 -05:00
David Galiffi b3eee295dd Revert "Upgrade ROCm-SMI to AMD SMI (#86)" (#100)
This reverts commit 0c32dfd6bc.
2025-02-07 11:45:26 -05:00
ajanicijamd fc5b325979 Added libamd_comgr.so to internal modules and fix argument parsing module in Timemory (#96)
Updates Timemory submodule
2025-02-03 14:43:14 -05:00
David Galiffi 80dc2efc50 Disable the weekly sync
Disable the weekly sync from staging to mainline. We'll do this manually with CQE approval.
2025-02-03 13:13:22 -05:00
Young Hui - AMD 10ba4b76de DOCs: update index and TOC to better organize how-to docs (#78) 2025-01-31 21:03:18 -05:00
cfallows-amd 0c32dfd6bc Upgrade ROCm-SMI to AMD SMI (#86)
* Integrating amd-smi into rocprofiler-systems due to rocm-smi deprecation.
* No functionality changes to users other than naming conventions.
* New tracks available in perfetto- gpu busy percentage metrics now splits gfx busy into separate gfx, umc, and mm engine measurements.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-01-30 21:32:07 -05:00
dependabot[bot] af3a8f695f Bump rocm-docs-core[api_reference] from 1.14.1 to 1.15.0 in /docs/sphinx (#94)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.14.1 to 1.15.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.14.1...v1.15.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-30 11:59:56 -05:00
David Galiffi 8deebb607b Update CODEOWNERS (#91)
Use GitHub Org Teams
2025-01-29 16:55:39 -05:00
Pranjal Swarup 4c4d0dea85 Update RHEL Docker Images & Fix CTest (#90)
- Fixed type in script name to fix CTest. Should be: `run-rocprof-sys-pid.sh`
- Add `/usr/lib64/openmpi/bin` to Docker Image PATH to help ctests to discover `mpiexec`
- `pip install perfetto` in the CI Docker file, for convenience.
2025-01-29 16:55:39 -05:00
dependabot[bot] b3e754ecb7 Bump rocm-docs-core[api_reference] from 1.13.0 to 1.14.1 in /docs/sphinx
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.13.0 to 1.14.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.13.0...v1.14.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-29 16:55:31 -05:00
David Galiffi 5b439d80a0 Update the videodecode ctest (#85)
- Copy sample videos and include in install.
- Only using the H26* videos, so the same tests can be used on MI100, which lacks AV1 decode support
- Update test parameters to videodecode test, based on feedback from the rocDecode team.
2025-01-29 16:53:16 -05:00
Peter Park 0a15d355e0 Update copyright year to 2025 (#83) 2025-01-29 16:53:16 -05:00
Peter Park 3b8c75cf47 [6.3.2] Update changelog for 0.1.1 (#80) 2025-01-29 16:53:16 -05:00