AI/rocm-systems
2
0
Forka 0
Codice Problemi Pull Request Actions Pacchetti Progetti Rilasci Wiki Attività
275 Commit 3 Rami (Branch) 0 Tag
83e2d7d8afda93a2d0a6edfe356b4ebb6ee67182
Grafico dei commit

275 Commit

This Branch
This Branch
Tutti i branch
Autore SHA1 Messaggio Data
Gopesh Bhardwaj 83e2d7d8af SWDEV-458796,458610 doc updates (#854) 
* SWDEV-458796,458610 doc updates

* updating --stats and scratch memory docuemntation

* Adding usage for --stats option
 2024-05-21 23:59:19 -05:00
Benjamin Welton 28e6430d04 [2/N] Agent Counter implementation with unit tests to check functionality (#846) 
Agent Counter Collection API with tests and samples.
---------

Co-authored-by: Benjamin Welton <ben@amd.com>
 2024-05-21 13:34:54 -07:00
Jonathan R. Madsen 7eeb7376b4 Fix ROCP_CI_LOG when ROCPROFILER_CI not defined (#864) 2024-05-20 16:04:28 -05:00
Jonathan R. Madsen 4d5b71b0e7 Update logging (#838) 
* Update logging

* Remove unused function

* Fix lib/rocprofiler-sdk/hsa/pc_sampling.cpp logging compilation

* Fix logging FLAGS_vmodule string leak and numerical log level

* Update logging

* Update glog submodule

* Leak fixes

* format
 2024-05-20 15:38:18 -05:00
Ammar ELWazir 2c7e9e8e8b Removing EXPECT_EQ() that checks for rocminfo (#858) 2024-05-17 04:19:13 -05:00
Ammar ELWazir ea4b793e73 Fixing rocminfo path for multiple installation ways (#857) 
* Fixing rocminfo path for multiple installation ways

* Update source/lib/rocprofiler-sdk/tests/agent.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-15 15:35:53 -05:00
Ammar ELWazir 91e7dfb24e Fixing build issues with HSA (#856) 2024-05-15 14:12:44 -05:00
Jonathan R. Madsen dcba111ed5 Fix code coverage GitHub workflow (#853) 
- sync gcov version with gcc/g++ version
 2024-05-15 01:37:06 -05:00
Gopesh Bhardwaj 5efede4de5 Fixing multi pmc line tests (#848) 
* Fixing multi pmc line tests

* Fixing cmake-format from commandline locally
 2024-05-09 10:26:53 +05:30
Vladimir Indic 358c599c3f avoiding early destruction of code objects list (#847) 2024-05-08 11:00:08 +02:00
Jonathan R. Madsen 1f96593b4f Test using HIP Graphs (#835) 
* Test using hip graphs

* Remove assert for api_end < async_end

* Update rocprofv3/tracing-hip-in-libraries::test_api_trace

* Update rocprofv3/tracing-hip-in-libraries::test_api_trace

* Increase rocprofv3-test-trace-hip-in-libraries-validate timeout

* Update rocprofv3/tracing-hip-in-libraries::test_api_trace

* Remove submit retry

* Update rocprofv3/tracing-hip-in-libraries::test_api_trace

* Increase rocprofv3-test-trace-hip-in-libraries-validate timeout

* Update lib/common/container/record_header_buffer.hpp

- minor tweaks

* Update lib/rocprofiler-sdk/buffer.hpp

- tweak ROCPROFILER_BUFFER_POLICY_LOSSLESS flush behavior

* Increase rocprofv3-test-trace-hip-in-libraries-validate timeout

* Update rocprofv3/tracing-hip-in-libraries::test_api_trace

* Revert rocprofv3-test-trace-hip-in-libraries-validate timeout

* Update run-ci.py

- RETRY_COUNT set to zero
 2024-05-07 15:10:22 -05:00
Giovanni Lenzi Baraldi 099ac7c72d Gbaraldi/att tool (#766) 
* Enabling codeobj and thread trace samples

* Updating aqlprofile_v2 header

* Codeobj and thread trace samples with output log files

* Fixing clang format

* Cmake formatting

* Adding coverage to codeobj

* Comment trace sample

* Adding ATT Parser API

* Fixing forwarding to aqlprofile

* Clang formatting

* Clang tidy

* Adding option to print memory kernels

* Clang format

* Remove default from switch case

* Separating  client/main on codeobj sample for ASAn

* Formatting

* Gbaraldi/att tool rebase (#801)

* Enabling codeobj and thread trace samples

* Updating aqlprofile_v2 header

* Codeobj and thread trace samples with output log files

* Fixing clang format

* Cmake formatting

* Adding coverage to codeobj

* Comment trace sample

* Removing python from workflow

* Adding ATT Parser API

* Fixing forwarding to aqlprofile

* Clang formatting

* Clang tidy

* Adding option to print memory kernels

* Clang format

* Remove default from switch case

* Separating  client/main on codeobj sample for ASAn

* Formatting

* Enabling codeobj and thread trace samples

* Updating aqlprofile_v2 header

* Codeobj and thread trace samples with output log files

* Fixing clang format

* Cmake formatting

* Adding coverage to codeobj

* Comment trace sample

* Adding ATT Parser API

* Fixing forwarding to aqlprofile

* Clang formatting

* Clang tidy

* Adding option to print memory kernels

* Clang format

* Remove default from switch case

* Separating  client/main on codeobj sample for ASAn

* Formatting

* Fix codeobj library

* Allow thread trace in parallel with other service

* Zeroing the HSA signals

* Adding exception wrappers in ATT sample

* Removed force configure

* Remove force configure from ISA decode

* Removing codecov flag

* Gbaraldi/att tool tests (#828)

* Adding tests for codeobj ISA decode

* Adding ATT tests

* Adding ATT integration tests

* Formatting

* Changing codeobj binary extension

* Renaming codeobj library spaces

* Fixing samples

* Formatting

* Formatting

* Fixing int test

* Fixing linker error

* Fixing memory fault

* Moving kernel ot inside namespace

* ASAN linking fix

* Removing unecessary headers

* Formatting

* Fixing target_cu

* Remove codeobj binary

* Revert "Remove codeobj binary"

This reverts commit 7d286f89d8096bc36925cd79cd742a5e6d10d179.

* Enable memory snapshot

* adding comgr

---------

Co-authored-by: Ammar ELWazir <ammar.elwazir@amd.com>
 2024-05-03 18:45:47 -03:00
Ammar ELWazir 6d3fbcffad Adding --stats examples (#842) 2024-05-03 10:25:04 -05:00
Jonathan R. Madsen bf75579566 C++ headers for std::hash, operator==, operator!= (#833) 
* C++ headers for std::hash, operator==, operator!=

* std::hash specializations for some HSA types
 2024-05-02 01:50:28 -05:00
Jonathan R. Madsen d15cf17635 Relax default CDash submission requirements in run-ci.py (#836) 
* Update run-ci.py to not require successful CDash submission by default

* Minor tweak to run-ci.py
 2024-05-02 00:15:20 -05:00
Benjamin Welton cb3fc070c7 [1/N] Agent Counter Collection Implementation (#832) 
Added public API call to setup agent counter collection on a context.

Refactored the return types internally for dispatch counter collection
to use rocprofiler_status_t (allow for more verbose failures to be
surfaced via the API)

Subsequent commits will fill out the sampling functionality for agent
counter collection.

Co-authored-by: Benjamin Welton <ben@amd.com>
 2024-05-01 13:34:54 -07:00
Benjamin Welton e21609c80e Code migration and include fixes (#830) 
* Migrating code/reformatting

* Remove unnecessary includes
---------

Co-authored-by: Benjamin Welton <ben@amd.com>
 2024-04-29 15:48:50 -07:00
Jonathan R. Madsen de13d2ac5d Public C++ header files and samples updates (#819) 
* Public C++ header files (source/include/rocprofiler-sdk/cxx)

* Update samples/api_buffered_tracing

- scratch memory and page migration
- README

* Update samples/api_buffered_tracing

- page migration component in sample

* Update tests/page-migration/validate.py

- fix checks for page migration operation names

* Update tests/page-migration/validate.py

- fix get_allocated_pages

* Update scratch memory and page migration validations

* Fix include/rocprofiler-sdk/cxx installation

* Rework include/rocprofiler-sdk/cxx

- Improve name_info to support const char*, string_view, string

* Update samples/api_{buffered,callback}_tracing

* External correlation ID request sample

- includes correlation ID retirement demo

* Update samples/api_buffered_tracing/README.md

* Update lib/rocprofiler-sdk/hsa/queue.cpp

- generate correlation ID for kernel launch if one doesn't exist

* Remove priority check from tool libraries (samples/tests)

- if(priority > 0) return nullptr check in rocprofiler_configure has proliferated beyond its intended use

* Apply suggestions from code review
 2024-04-25 20:09:11 -05:00
Jonathan R. Madsen e2bce49655 Correct timestamp skew adjustments for kernel and async copy tracing (#827) 2024-04-25 14:36:11 -05:00
Vladimir Indic 733aa8e438 Restructure code object source code (#826) 
* public codeobj info

* Restructure code object source code file layout

* Update get_unloaded_code_objects + add iterate_loaded_code_objects

* Remove get_unloaded_code_objects from visible internal API

- iterate_loaded_code_objects + functor which filters on the hsa_executable_t effectively reproduces this behavior

* Whitespace removal

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
 2024-04-25 14:03:04 -05:00
Jonathan R. Madsen 67dbe3f47f Update CMake config install location + env setup files (#821) 
- install cmake config files to CMAKE_INSTALL_LIBDIR instead of CMAKE_INSTALL_DATAROOTDIR per ROCm standards
- Provide setup-env.sh and modulefiles for rocprofiler-sdk and rocprofiler-sdk-roctx
 2024-04-24 14:43:47 -05:00
Jonathan R. Madsen 8c985543d9 Rework counter collection sample app (#822) 
* Sync more often in counter collection samples

* Update samples/counter_collection/main.cpp

- support command line arguments
  - number of iterations
  - iterations per sync
  - number of devices to use
 2024-04-24 14:00:59 -05:00
Jonathan R. Madsen 5d365bb8b8 Fix LICENSE install location + CPACK_RPM_PACKAGE_LICENSE (#820) 
- LICENSE needs to be installed in share/doc/rocprofiler-sdk not share/doc/rocprofiler
- CPACK_RPM_PACKAGE_LICENSE should be set to license type not the license location
 2024-04-24 01:19:32 -05:00
Ammar ELWazir 777add01d1 Update rocprofiler_config_packaging.cmake (#817) 2024-04-23 18:43:41 -05:00
Ammar ELWazir c93a55b070 Update docs.yml (#815) 2024-04-22 22:50:34 -05:00
Jonathan R. Madsen 48273d6a65 Remove -Wno-missing-field-initializers from build flags (#810) 
* Remove -Wno-missing-field-initializers

- Compiler errors if missing field initializers

* Update lib/rocprofiler-sdk/counters/evaluate_ast.cpp

- copy over dispatch ID in perform_reduction/evaluate
 2024-04-22 22:26:01 -05:00
Vladimir Indic deabd869b5 Introducing PcSamplingExtTable (#735) 
* pcs: updating the PCS table

* Fixing Clang Tidy errors

* pcs: reverting old table version

* testint wrong table size

* new size

* testing step

* reverting old steps

* hsa_amd_queue_get_info introduced

* pcs: testing table version

* formatting

* removing redundand declarations

* removing unnecessary files

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/hsa/pc_sampling.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Enable function pointer offset check in hsa::pc_sampling::copy_table

- add offset() to HSA_API_META_DEFINITION
- check if offset() >= size of struct

* Support build without PC sampling API table

* ids for ROCr's PC sampling public functions

---------

Co-authored-by: Ammar ELWazir <aelwazir@hpe6u-21.amd.com>
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
 2024-04-22 20:07:28 -05:00
Ammar ELWazir 7589084197 GPUs not needed for doc action (#804) 2024-04-22 11:00:43 -05:00
Benjamin Welton 29bc84ec0c Add default values for kernel struct (#798) 
* Add default values for kernel struct

* Update hsa-queue-dependency app

- default initializers
- check HSA_AMD_MEMORY_POOL_INFO_RUNTIME_ALLOC_ALLOWED for memory pools
- clang-tidy fixes (member -> static, etc.)

* Update run-ci.py

- add --progress --output-on-failure -V if no other options regarding verbosity are passed
- improve the ability to control the stages

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
 2024-04-18 21:07:20 -05:00
Benjamin Welton c668028781 clang-18 warning fixes (part 1) (#785) 
* clang-18 warning fixes (part 1)

* format fixes

* More format fixes

* More format fixes
 2024-04-18 18:28:32 -05:00
Ammar ELWazir 21170b870d Enabling Mi200 & Mi300 Testing (#797) 
* Enabling Mi200 & Mi300 Testing

* Update continuous_integration.yml
 2024-04-18 15:47:52 -05:00
Ammar ELWazir ae2abb584b Stabilizing the machines used for testing (#771) 
* Stabilizing the machines used for testing

* Update .github/workflows/continuous_integration.yml

* Update continuous_integration.yml

* Delete .github/workflows/ci_pc_sampling.yml

* Update continuous_integration.yml

- add mi300
- use if conditions for whether to run "extended" core tests

* Consistency in matrix for each job

* Update continuous_integration.yml

- include runner in core CDash name

* Update continuous_integration.yml

- remove mi300

* Update continuous_integration.yml

- add mi300

* Update CI workflow

- tweak "Install requirements" step

* Update CI workflow

- timeout on install requirements

* Update CI workflow

- revert sanitizers to gcc-12

* Update CI workflow

- remove core installation of clang-tidy (handled by python pip)

* Update CI workflow

- disable fast-fail

* Update CI workflow

- add runner to all build names
- remove mi200 and mi300

* Update CI workflow

- code coverage runs on navi3

* Update CI workflow

- add runner to all build names

* Tweak to CI sanitizer jobs

* Update CI workflow

- Handle excluded tests

* Update CI workflow

- Handle excluded tests (part 2)

* Update CI workflow

- Handle excluded tests (fix quotations)

---------

Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
 2024-04-18 13:48:57 -05:00
Jonathan R. Madsen b953774580 Improve testing stability (#796) 
- Update tests/bin/reproducible-runtime
  - tweak algorithm for sleeping
- Update lib/rocprofiler-sdk/hsa/async_copy
  - handle egregious skews for async copy times
- Update kernel tracing
  - handle egregious skews for kernel dispatch times
- Update lib/rocprofiler-sdk/hsa/code_object
  - use static object wrappers for code object info
- Update lib/rocprofiler-sdk-tool/config.cpp
  - fix data race in output_keys / get_local_datetime
 2024-04-18 11:42:51 -05:00
Giovanni Lenzi Baraldi b6c0b50d3e Removed duplicated code (#784) 
* Removed duplicated code

* Clang format

* Removing union from pc_sampling API

* Clang format
 2024-04-18 07:42:26 -03:00
Jonathan R. Madsen b570ff5273 Update samples/intercept_table (#792) 
- install function wrappers around HIP runtime API
  - easily correlated to the executable
  - safer than HSA runtime due to potential for HSA to get invoked after main returns
 2024-04-18 05:30:34 -05:00
Jonathan R. Madsen 12c836f95f Async memory copy callback tracing + memory copy size (#791) 
* Async memory copy tracing update

- rocprofiler_buffer_tracing_memory_copy_record_t: thread_id and bytes
- support ROCPROFILER_CALLBACK_TRACING_MEMORY_COPY
- init_public_api_struct can fully construct

* Testing for callback async copy tracing
 2024-04-18 04:31:59 -05:00
Benjamin Welton edb1883a05 Modified hipMalloc size for main.cpp in sample (#786) 
* Modified hipMalloc size for main.cpp in sample

* Update samples/counter_collection/main.cpp

---------

Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
 2024-04-18 04:28:56 -05:00
Jonathan R. Madsen 32bc339789 Simplify json-tool JSON schema for callback records (#790) 
- formerly, the rocprofiler_callback_tracing_record_t data was stored in itr["record"], e.g. itr["record"]["correlation_id"]
  - dropped "record" key, e.g. itr["correlation_id"]
 2024-04-18 03:58:10 -05:00
Jonathan R. Madsen 39dd5a81df PyTest utilities (#789) 
- tests/pytest-packages/pytest_utils containing utilities for pytest validation tests
- example:

```python
from rocprofiler_sdk.pytest_utils.dotdict import dotdict
```
 2024-04-18 03:09:01 -05:00
Jonathan R. Madsen 93136ec042 Fix kernel dispatch tracing operation names (#787) 
- "ENQUEUE" -> "KERNEL_DISPATCH_ENQUEUE"
- "COMPLETE" -> "KERNEL_DISPATCH_COMPLETE"
 2024-04-18 01:06:39 -05:00
Jonathan R. Madsen b7b2c294e0 Update lib/rocprofiler-sdk/hsa/queue.cpp (#788) 
- fix heap-use-after-free
 2024-04-18 00:05:55 -05:00
Benjamin Welton 81afb310ff Remove duplicate entries from derived counters (#782) 2024-04-17 13:47:02 -07:00
Jonathan R. Madsen 8cc28ae51d Enable HSA packet write interception for callback kernel tracing (#780) 2024-04-17 14:55:04 -05:00
Benjamin Welton d173dd5c04 Small error printout on test (#781) 2024-04-17 08:54:56 -07:00
Ammar ELWazir 7ace7c5303 Update ci_pc_sampling.yml (#744) 2024-04-16 23:24:33 -05:00
Vladimir Indic 200da0f274 pcs: API updated (#770) 2024-04-16 22:51:16 -05:00
Ammar ELWazir 9ace9d5450 Update continuous_integration.yml 2024-04-16 22:24:06 -05:00
Ammar ELWazir 27f3c36b41 Create scan.yaml 2024-04-16 22:23:50 -05:00
Ammar ELWazir f6eb84a83e Fixing CI 2024-04-16 22:16:46 -05:00
Ammar ELWazir fa882dbebb Update continuous_integration.yml (#779) 2024-04-16 22:09:46 -05:00