AI/rocm-systems
2
0
Forkuj 0
Kod Zgłoszenia Oczekujące zmiany Actions Packages Projekty Wydania Wiki Aktywność
13 510 Commity 3 Gałęzie 0 Tagi
84a4f293f4cb9a1f7777b5d378ddb64a1fa1b876
Wykres commitów

53 Commity

Autor SHA1 Wiadomość Data
Rahul Manocha 5930f047bb SWDEV-489106 - Linker API addition to runtime 
1) Add Linker APIs to runtime to support SPIRV linking
2) Migrate Internal implementations to runtime and share with rtc
3) Add Support to bundled and unbundled SPIRV Code object linking.

Change-Id: Ic1fd4431f842a208a2468e8aec54a65b5fa6b0e3
 2025-02-22 13:39:23 -05:00
Jacob Lambert 33e48b9629 SWDEV-387063 - Use clang default for C++ version 
Instead of enforcing c++14 here, we can instead use the current
clang default

Change-Id: Ib0a178a53c1377f2910edf6fab82b2bac6567ac7
 2025-02-03 11:07:52 -05:00
Marko Arandjelovic 78f62d3230 SWDEV-495609 - Change include path for rocclr/utils 
- Header files inside rocclr/utils when included from hipamd or opencl should be included as #include "rocclr/utils/xxx.h" instead of "utils/xxx.h"

Change-Id: Ic0760c33b9d091f5620dec67e5482c9698d22093
 2024-12-05 11:44:20 -05:00
Satyanvesh Dittakavi 522ae8ead4 SWDEV-483241 - Add a compile option to avoid including default hiprtc header 
Change-Id: Ic23b41395588e6183abac36cb7543da02b0aba29
 2024-10-07 07:56:29 -04:00
kjayapra-amd 12a39fbf22 SWDEV-480772 - Remove name variable from amd::Monitor class. 
Change-Id: Ie2a4fa44f485786227230f8a892e090e718aa30e
 2024-09-19 11:55:01 -04:00
Ioannis Assiouras 7b0259c4b7 SWDEV-465236 - Changed RTCProgram::findIsa to not dlopen amdhip64 for static build 
Change-Id: I322ef4ca96ea426a0953f1234e60db6cebb09886
 2024-06-20 10:55:57 -04:00
Tao Sang a1350fe8c1 Revert "SWDEV-433371 - use comgr to unbundle code objects" 
This reverts commit e53df57ffe.

Reason for revert: <INSERT REASONING HERE>
New comgr unbundling action leads to perf drop for uncompressed code object.   Will create a new patch to use old path for uncompressed , new unbundling api for compressed . 

Change-Id: I41ef53b71fc9f7aaa8cf231d4d70945f1117db52
 2024-05-28 06:31:10 +00:00
taosang2 e53df57ffe SWDEV-433371 - use comgr to unbundle code objects 
1.Make runtime use comgr to unbundle code objects
2.Support compressed/uncompressed modes
3.Remove HIP_USE_RUNTIME_UNBUNDLER and
  HIPRTC_USE_RUNTIME_UNBUNDLER to simplify logics
4.Add comgr wrapper for
  amd_comgr_action_info_set_bundle_entry_ids()

Change-Id: Ic41b1ad1b64cca1e31986437983a5146d52a7329
 2024-05-01 16:09:12 -04:00
Jatin Chaudhary 7f9651d4bb SWDEV-441629 - add some missing hiprtc link options 
Change-Id: I10019823e212c6d4de6df30c0fe1c20d9e992f29
 2024-03-01 07:49:57 -05:00
Satyanvesh Dittakavi 15a058cb60 SWDEV-446781 - Check validity of hiprtc link state before using it 
Change-Id: I864e8d1a79bb28d9df0e4ee528cb50a96bc245cc
 2024-02-28 00:27:17 -05:00
Ajay b53fcb4d02 SWDEV-440718 - Suffix hip bin name with _6. 
Link to amd_comgr_2.dll

Change-Id: I5d21af0cc91f2082099273f75ebe1c3279b6365d
 2024-02-05 05:08:11 +00:00
Jatin Chaudhary aacdb00759 SWDEV-425605 - remove exe_options, it was unused 
Change-Id: I0651f6a836d2f063caf651520de96d7675428771
 2024-02-05 05:08:11 +00:00
Jatin Chaudhary f017777a97 SWDEV-425605 - Add new comgr compile to reloc 
use AMD_COMGR_ACTION_COMPILE_SOURCE_TO_RELOCATABLE action
to compile source to realoc. Currently we have source->bc,
link->bc and bc->realoc. This new action replaces the
three steps with one.

Change-Id: I8089cbef681e079702fefc2d2085a23bc3578d02
 2024-02-05 05:08:11 +00:00
Jatin Jaikishan Chaudhary baf61b6a02 Revert "SWDEV-425605 - Add new comgr compile to reloc" 
This reverts commit 551cdcd4cfc1a9bb8b8ebfd315320629baf05655.

Reason for revert: breaks windows-psdb

Change-Id: I8b2fcaf0d0be09a9364e386127cabafb68a67e0d
 2024-02-05 05:08:11 +00:00
Jatin Chaudhary ea1487d84d SWDEV-425605 - Add new comgr compile to reloc 
use AMD_COMGR_ACTION_COMPILE_SOURCE_TO_RELOCATABLE action
to compile source to realoc. Currently we have source->bc,
link->bc and bc->realoc. This new action replaces the
three steps with one.

Change-Id: I6ba551b8d04c7e06f41c4324026e4dcd2db1970f
 2024-02-05 05:08:11 +00:00
Jatin Chaudhary 49369f0851 SWDEV-436233 - fix the cumode in hiprtc 
cumode should be active when wgp mode is off

Change-Id: I12f2e55d942ddeb0fb4470de7abc3caff1f430f7
 2024-01-02 17:43:32 -05:00
Satyanvesh Dittakavi dc8f66b86f SWDEV-379212 - Handle template kernels with hiprtc lowered names 
Change-Id: Ib8e6493a1f342f92a35031d5ee39b2e22132b56a
 2024-01-02 03:28:28 -05:00
Jatin Chaudhary ce27581465 SWDEV-431399 - fix first set of memory leaks in clr, found in rtc tests 
change constexpr variable names to match the C++ style we follow.

Change-Id: Ibc59a65d8ff2ca765da7bf5e653c0650fb3714c4
 2023-11-14 20:39:45 -05:00
Jatin Chaudhary 2989840511 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries 
- alias hipGetDeviceProperties to hipGetDevicePropertiesR0600
- alias hipDeviceProp_t to hipDeviceProp_tR0600
- remove gcnArch from new device property struct
- add new requested struct members

Change-Id: If3f5dbef3d608487d9f6f419285f4bf577ea9bf0
 2023-10-12 11:16:18 -04:00
Satyanvesh Dittakavi 2764b85ca5 SWDEV-402080 - Add options such as -Rpass=inline to exe_options in RTC if the user passes it 
Change-Id: I12fcf200ed9d3112b014f3d426d5fe504eeca163
 2023-09-25 04:03:44 -04:00
Jaydeep Patel a37c95d7ed SWDEV-418038 - Drop GPU_ENABLE_WAVE32_MODE from RTC. 
Change-Id: Iac11f26714e8b3bae14cbf69933ef7c8c8be47da
 2023-09-08 02:13:41 -04:00
kjayapra-amd 6a0f80a03d SWDEV-381625 - Parse compiler and linker options from environment variable. 
Change-Id: Id5a012b678e5973c4b64dff84444a909aefae006
 2023-08-29 20:24:27 -04:00
Vikram cec579c006 SWDEV-378651 - add proper wavefrontsize link time option to hipRTC, in accordance with env variable GPU_ENABLE_WAVE32_MODE 
This is a copy of http://gerrit-git.amd.com/c/compute/ec/hipamd/+/841299
Raising this here again since hipamd repo is frozen.

Change-Id: I8722ef55f78a9176e131fd5766fb11101b51f1b5
 2023-08-15 00:12:31 -04:00
Satyanvesh Dittakavi 8ee985a67b SWDEV-415439 - Address segfault issues with hiprtcLinkCreate 
Change-Id: I5c5898a9d0afadc344ae2fafc371e9ed647cec6e
 2023-08-10 08:28:11 -04:00
Ioannis Assiouras 791cea44f1 SWDEV-407818 - Fixed bug when opening LinkerFile fstream on windows 
Change-Id: If6f083d9fa83066eb2b20ab24dceaa9df7a2f0a0
 2023-07-07 13:25:04 -04:00
Ioannis Assiouras 0af9788e32 SWDEV-406894 - Fix segfault when access HIPRTC_JIT_LOG_VERBOSE from options buffer 
Change-Id: I24143dfb726d9a71fdb17b03d5b5dd910b54f5bb
 2023-06-22 00:53:29 -04:00
sdashmiz 38a67df312 SWDEV-403638 - Fix warnings 
- disable deprecated function use warning
- disalbe size_t to .type' warning
- disable conversion from 'type1' to 'type2' warning

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I64161fd37cf56de3d132102103267ae8da40193a
 2023-06-15 12:17:22 -04:00
Jacob Lambert 1171518b97 SWDEV-380857 - Remove space in "Linker Program" used to set Comgr object name 
Not a required change, but it does make dealing with temporary files generated
by Comgr easier.

Change-Id: I9c43138dd2a6c4fea965b57fbce7a087ab2bbd28
 2023-05-30 13:47:26 -04:00
Jatin Chaudhary 8753db5446 SWDEV-384013 - Print link options being passed to compiler with AMD_LOG_LEVEL 
Change-Id: I556ed434587cff07a634796da51dcbb9ae78ef21
 2023-05-15 15:52:04 -04:00
Jacob Lambert b17056cb93 SWDEV-380857 - Fix bug when reading bitcode file into vector<char> buffer 
The previous implementation using std::copy() resulted in
differences between the in-memory and on-disk representations.
With the updated implementation, we get the same contents.

Change-Id: Iadfae3cd7f7ba99538da2ac4f11f30f5a78260d8
 2023-05-08 16:25:01 -04:00
Jatin Chaudhary 300ba5b1f1 SWDEV-384013 - Add HIPRTC_JIT_IR_TO_ISA_OPT_EXT 
Change-Id: Icfc06c19af32f41d603bf880ab1927bffb391097
 2023-04-05 10:52:48 +00:00
Satyanvesh Dittakavi 99556449b6 SWDEV-370552 - Correct the HIPRTC behavior to optimize the ISA only once 
Change-Id: Idaf0ea8294657db3666e9548deb6a9629e0ee718
 2023-02-09 11:55:41 -05:00
Satyanvesh Dittakavi 0ccd41050b SWDEV-372396 - Address the errors in hiprtc headers with -Werror 
Change-Id: Ied553216dfc2ff8b5c72de617cb47b6ca8f52063
 2023-01-23 17:25:42 +00:00
Jacob Lambert 7dd54c746e SWDEV-356171 - Adding support for name lowering for bitcodes (-fgpu-rdc) via 
Comgr mangled name fetching APIs

Change-Id: I10ce2b1288c459e3e61218d68a270aba2148376e
 2023-01-09 14:49:51 -05:00
Satyanvesh Dittakavi 516acd4e60 SWDEV-375020 - Revert "SWDEV-370552 - Improve hiprtc performance by passing the right flags to comgr" 
This reverts commit 627e689ad7.

Reason: Adding "-Xclang" and "-disable-llvm-passes" in hiprtc
compilation seem to cause perf issues and memory fault in few apps.

Change-Id: I12ff46293c7b7afb24d570351736d884d2881b77
 2023-01-06 00:09:06 -05:00
Satyanvesh Dittakavi 627e689ad7 SWDEV-370552 - Improve hiprtc performance by passing the right flags to comgr 
Change-Id: I99674b033d1248d9b34ac598b4780bd84a38c279
 2022-12-19 06:16:56 -05:00
kjayapra-amd 2f8847bfbd SWDEV-363865 - Use COMGR path to unbundle code object in HIPRTC. 
Change-Id: Ifca29ea0c6ff319c3f584397e542a1658d220c4a
 2022-12-15 07:16:55 -05:00
Jacob Lambert 2835ff1a63 SWDEV-322000 - Removing scoped locks in code regions with Comgr calls 
Comgr now internally locks to avoid multi-threading issues with LLVM

Change-Id: I74b903d373af55c2efade17a9caf31fda3ca1795
 2022-12-14 12:40:45 -05:00
Maneesh Gupta 8e10332ff1 Revert "SWDEV-339488 - Address HIPRT tests failure with spaces in the include path" 
This reverts commit 89355fb586.

Change-Id: I10f91ec0205cd4276b141aade5728fdc20030195
 2022-09-13 23:06:23 -04:00
Satyanvesh Dittakavi 89355fb586 SWDEV-339488 - Address HIPRT tests failure with spaces in the include path 
Change-Id: Ic9ed57e44fcfdf82a0d066483bc73e1d59c39e30
 2022-08-26 06:47:56 -04:00
kjayapra-amd f15016227b SWDEV-351609 - Updating the right structure with file info. 
Change-Id: Ia4e1195df0669450162b2df4de50197ff27cfcae
 2022-08-22 21:54:35 -04:00
Satyanvesh Dittakavi 651f333140 SWDEV-336448 - Load comgr versioned dll in hiprtc 
Change-Id: I9c966ac6e3beae707d732e4bf84f88457d6265de
 2022-08-19 00:38:08 -04:00
kjayapra-amd 9e9754be80 SWDEV-351508 - Change the data_kind to BC from FATBIN, since unbundling happens in runtime now. 
Change-Id: Iaf6e85637edaa92171edc4edc650a0b4598bf625
 2022-08-12 19:52:29 -04:00
kjayapra-amd 4bba4faa0c SWDEV-346018 - Support unbundling of code object in runtime for hiprtc. 
Change-Id: Idda30def999b28500738c7b48560d36ca6a8e730
 2022-08-03 17:57:29 -04:00
Satyanvesh Dittakavi ee27685ac4 SWDEV-340226 - SWDEV-340692 - Fix minor issues with hiprtc Link APIs 
- hiprtcAddLinkData should accept 0 or null as input name
- hiprtcLinkCreate should accept 0 or null as options ptr
- hiprtcCompile should send -fgpu-rdc option to comgr if its present in the options

Change-Id: I84f6e36df5c99b719ee9c67dfc1b4dbcfd8e3172
 2022-07-22 07:23:26 -04:00
Satyanvesh Dittakavi b263ab3248 SWDEV-341360 - Handle named expressions with space in hipRTC 
Change-Id: I1c26855d8a94e0a4d818664ca71094c6992221c9
 2022-06-22 14:19:16 +00:00
kjayapra-amd 2731d03f03 SWDEV-339995 - Adding hiprtcGetBitcode and hiprtcBitcodeSize changes. 
Change-Id: I378f1ac98de3b11fa3f74161abd036702c7b479b
 2022-06-22 04:17:56 -04:00
kjayapra-amd 5d385fa0e2 SWDEV-340226 - Fixing conversion to void* from size_t instead of size_t*. 
Change-Id: Ib7e083395d4fbbe2a6f3012fce5b268e108ad62a
 2022-06-21 06:28:06 -04:00
Satyanvesh Dittakavi bf4cf3c369 SWDEV-327563 - Fix the hip runtime library name to load in hiprtc on Windows 
Change-Id: Ib4988dd8677da907bec8e59b1b4ce3e57aad2bb7
 2022-06-16 00:45:43 -04:00
kjayapra-amd 84f94fd134 SWDEV-290384 - Add Linker API support in hiprtc 
Change-Id: I4621a033a22e4da0201c3804e2b357470a681ab0
 2022-05-24 09:16:14 -04:00