Граф коммитов

485 Коммитов

Автор SHA1 Сообщение Дата
Ammar ELWazir 84d6f080db Removing the compilation of PC Sampling sample
Change-Id: Ice539983e7f1d9510a2fa227a2620f0877fcbb5a


[ROCm/rocprofiler commit: 044669a83b]
2023-03-09 13:20:36 +00:00
Ammar ELWazir b9efba7737 Excluding PC Sampling Sample from samples package
Change-Id: I27865f8040ea519909db45041b0aaad6b786ce8e


[ROCm/rocprofiler commit: e58e4f2a72]
2023-03-09 13:20:36 +00:00
Ranjith Ramakrishnan f1bcc8c67b Get ROCm path relative to hsakmt header file path
SWDEV-351540 - ROCm path was derived from hsakmt library path.
For ASAN build, the library will be installed in <Install_prefix>/lib/asan rather than <Install_Prefix>/lib
Since the header file installation path remains the same for ASAN and normal build, using the same for getting the ROCm path

Change-Id: I735dbd3c0f67a69e833059a05851da3971098ec5


[ROCm/rocprofiler commit: 2cd0e093ef]
2023-03-09 13:20:36 +00:00
gobhardw b88e157425 Fixed Outpt Path and recv_0 for ATT
Change-Id: I94248e217d5af14152be82cbe6095de90a489387


[ROCm/rocprofiler commit: 602ac83ce7]
2023-03-09 13:20:36 +00:00
Ammar ELWazir 81de65e8dc Modifying Public header file with gpu index definition
Change-Id: I9c07ac419b9894c6dc65daa763bbc4cd4a7511b0


[ROCm/rocprofiler commit: f9a096a194]
2023-03-09 13:20:35 +00:00
Saurabh Verma 4aa2491e48 Adding Make for bulding code samples
Change-Id: I7b62a4c65c5560239e69ea121c6fdaef188f709d


[ROCm/rocprofiler commit: 763799349b]
2023-03-09 13:20:35 +00:00
gobhardw 4f742d346b Making ATT work with Profilerv2
Change-Id: Ic9334aa80e40faaaf5c1a79ba37dbe52e8d31253


[ROCm/rocprofiler commit: 03c305dbd4]
2023-03-09 13:20:35 +00:00
Ammar ELWazir f7772fb704 GPU ID issue
Before, the GPU IDs were counted starting from zero, now CPU IDs are counted from zero and then GPU IDs from the last CPU_ID+1

Change-Id: I3f815195ad97933e02f249841e53b64b674370d9


[ROCm/rocprofiler commit: 6dda141e4b]
2023-03-09 13:20:35 +00:00
Ranjith Ramakrishnan d72dca799b SWDEV-366831 - File reorg backward compatibility message changed to #error
Change-Id: Ic47e8d32846e5c15ee7449e53ccea52041862299


[ROCm/rocprofiler commit: 7f413038d2]
2023-03-09 13:20:34 +00:00
Ammar ELWazir de4abd0d0f Adding rocprofilerv2
Change-Id: Ic0cc280ba207d2b8f6ccae1cd4ac3184152fc1ad


[ROCm/rocprofiler commit: 8032adb64f]
2023-03-09 13:20:33 +00:00
Konstantin Zhuravlyov b23a2f3029 Explain why kernels are compiled with code object v4
Change-Id: Ib0502f005faa513105cf570a0013517d6c6349c3


[ROCm/rocprofiler commit: e0e5f7336b]
2023-02-03 21:54:33 -05:00
Konstantin Zhuravlyov 2f773d893c Compile kernels with code object v4
Change-Id: I3dc05dff07888cea79ba0a51eaac17ed64f5fec0


[ROCm/rocprofiler commit: d9c9d39902]
2023-02-03 16:17:34 -05:00
Ranjith Ramakrishnan 9460b4e4f6 Split rocprofiler to runtime and dev/devel package
SWDEV-356024 - Development package name will have suffix dev or devel based on OS
Devel pacakge contents - Header files and non verioned lib file librocprofiler64.so
Runtime package contents - Binaries, xml files, python files , script files, license file, librocprof-tool.so and versioned library files

Change-Id: Id416b11f49a7d0acb917bc4936cc0cba0d101bee


[ROCm/rocprofiler commit: ba5c843b04]
2023-01-13 14:52:02 -08:00
Saurabh Verma 6dc0459613 Adding missing MI200 metrics
Change-Id: I410f50e03d38bb03cf43e743318eb1242e7d6518


[ROCm/rocprofiler commit: 225bddf148]
2023-01-11 18:00:46 +00:00
Ranjith Ramakrishnan 3472d17813 Removed the initialization of cmake_install_libdir
The initialization should be controlled from build scripts. Removing the same from source code
Build scripts is initializing  the variable to "lib"

Change-Id: I55b6cf4752e692735c2a0be13b79f5988137e3a6


[ROCm/rocprofiler commit: b4258de318]
2022-12-15 23:15:58 -08:00
Kiumars Sabeti f893fecf87 SWDEV-369023: Added two new counters SQ_INSTS_TEX_LOAD and SQ_INSTS_TEX_STORE for gfx10.These two new counters are replacement for SQ_INSTS_VMEM_RD and SQ_INSTS_VMEM_WR which are not supported in gfx10 architecture
Change-Id: I4c4101eea27f9073492ae42c70a30a002f4d8834


[ROCm/rocprofiler commit: a9a82ee107]
2022-12-09 20:41:45 -05:00
Ranjith Ramakrishnan e1569471ad SWDEV-368058 - Change pragma message to warning
File reorganization feature was implemented with backward compatibility
The backward compatibility support will be deprecated in future release.
Changed the #pragma message to #warning for a smooth transition

Change-Id: Ieb7726ef219af20b9260c1e35444813a36cd8508


[ROCm/rocprofiler commit: aae692c674]
2022-11-21 16:22:09 -05:00
Ammar ELWazir c256910fe8 GPU Index to use HSA AMD Agent Driver Node ID
Change-Id: Ia814f64419615f1d77fc09fc88f11bbaf75afd45


[ROCm/rocprofiler commit: 553a4c7ee7]
2022-11-21 14:05:33 -05:00
Ammar ELWazir be0c6a3380 Suppressing the hipGraphLaunch issue
hipGraphs acts as a separate activity group as they have their own memory copies and their kernel dispatches and more activities, currently hip api that roctracer depend on doesn't have a way to represent this type, so we are temporarily suppressing the issue up till we have a complete support for the hipGraphs

Change-Id: I5d889be05c9414530672c781e5a712d572ea4104


[ROCm/rocprofiler commit: bbbd177dd7]
2022-11-01 23:29:05 -05:00
Ammar ELWazir 39c2d67ce8 Fixing merge_traces.sh
merge_traces.sh was depending on tblextr.py, and the location of tblextr.py changed from bin to libexec/rocprofiler

Change-Id: I76f1a0f41ffcff26e6a1119dacfb8b2ebd56d17d


[ROCm/rocprofiler commit: 7e8df53c44]
2022-10-28 10:28:36 -05:00
Laurent Morichetti ee8efd3e2b SWDEV-362165 - Escape argument strings in the JSON file
"a_string\x000" -> \"a_string\\x000\"

Change-Id: I8bf054702b34577f84080080d9538b16abc996fe


[ROCm/rocprofiler commit: 3b61d6bd8c]
2022-10-18 01:47:46 -04:00
Sriraksha Nagaraj 1e64045fb1 SWDEV-359118 - fix for misrepresentation for stream ids in Json file
Some trace entries report the stream argument as 'stream=' and some report it as 'hStream='.
Change-Id: I9e7c7af162db72ddadf6f2a3fe4f44a04bf77ed6


[ROCm/rocprofiler commit: 3bb853c56d]
2022-10-13 21:48:48 -04:00
Sriraksha Nagaraj 2e04bf0f2a SWDEV-356279: Adding backward compatibility in installing gfx_metrics.xml
Change-Id: If8e796103def0ec17866bd6d9c2ff7460d8a2594


[ROCm/rocprofiler commit: 316404ef08]
2022-09-16 17:40:20 +00:00
Kiumars Sabeti d5974aba78 SWDEV-302380: [ROCm QA][Mainline][Navi21] 6 tests are failing in rocprofiler-stg2
This is an attempt to support basic and derived counters for navi21.  This code will not work correctly unless we add navi counters to metrics.xml and gfx_metrics.xml

Change-Id: Ied06a81345a6fbb02fa0fde1889d94bbe64e9a03


[ROCm/rocprofiler commit: b53fd84ade]
2022-08-05 17:31:37 -04:00
Laurent Morichetti 6e1ea79067 Fix vgpr count calculation for gfx90a and gfx940
Read accum_offset from compute_pgm_rsrc3 to report both the arch vgprs
and the accum vgprs

Change-Id: I99e746d54a6a1671e343da5658cc6ce970f79939


[ROCm/rocprofiler commit: 5fd1c7e8e3]
2022-08-03 14:02:36 -07:00
Saurabh Verma eaebfe0954 SWDEV-297195: Corrected units for some counters. Units changed to quad-cycles units where required.
Change-Id: Ia6b0387ac6ec4210bb9482d85ae5635fc7c3c9d0


[ROCm/rocprofiler commit: 18dedbaee8]
2022-07-21 17:22:17 -05:00
Ranjith Ramakrishnan a5a941cbfc SWDEV-345870 - Correct include paths for new directory layout
Use hsa header files from /opt/rocm-ver/include rather than using wrapper files from /opt/rocm-ver/hsa/include/hsa

Change-Id: Id7a9bde19447cd2a0fd6e03b11c08471f09c2a46


[ROCm/rocprofiler commit: e7eb195924]
2022-07-14 16:08:41 -07:00
Sriraksha Nagaraj 615dd27e77 SWDEV-287352 - Changing the description for timestamp option
Change-Id: Ie1d942f7560838efbc38394b21facf04df9bbda5


[ROCm/rocprofiler commit: c565e2f329]
2022-07-07 15:08:53 -04:00
Sriraksha Nagaraj 541764daad SWDEV-323976 - changes in the scripts to display copy activity in the trace output
Change-Id: If8f7df3668c075a8f21508c796220693be9b40d3


[ROCm/rocprofiler commit: b0152e0091]
2022-07-05 16:24:45 -04:00
Sriraksha Nagaraj 5272d9dc81 SWDEV-287352: Fixing typos in the rocprof --help description
Change-Id: I39739e53e477c9e621da1b686e248b5d7aff5ad2


[ROCm/rocprofiler commit: c9efa4891e]
2022-06-29 16:26:25 +00:00
Ammar ELWazir e09315af9f Enabling ROCP_STATS_OPT
Enabling the new methodology of ROCP_STATS_OPT of getting HIP activities while the application is running

Change-Id: I19d09e2f2abe16e6528240bf55d6048645aaa09f


[ROCm/rocprofiler commit: 6f97e15d55]
2022-06-21 19:30:38 -05:00
Ammar ELWazir 9c0cdcd184 SWDEV-341811: backward compatibility fix for metrics.xml
Change-Id: Idd0535d399e211664a64390ebc97036495d02511


[ROCm/rocprofiler commit: 57fb3abb31]
2022-06-17 13:29:09 -04:00
Ammar ELWazir a5bd7dd935 Google-Chrome Tracer parser attaching flow events to the wrong time slice
This issue happens when we have slices that have overlapping
timestamp values (i.e. start_ts + dur = start_ts of next slice)
and the flow event references that shared timestamp value.
The google chrome parser sorts all the events
and just taking the most recent one.
Rocprof is outputting flow attachment points as start+dur;
the end ts of the slice that can overlap with the next slice
if no gap between them.

Solution proposal by Michael Steffen (Michael.Steffen@amd.com)

Change-Id: Ifcde142144033c9012b01a78c95f047384f972dd


[ROCm/rocprofiler commit: 93a79eb99a]
2022-06-13 14:53:14 -04:00
Icarus Sparry 48d6f03c07 Adding missing commits
Adding commits found in mainline and not in staging: Add dependency on rocm-core

Signed-off-by: Icarus Sparry <icarus.sparry@amd.com>
Change-Id: Icb935e9230888fd005d9ca3617e28f6173173cc8


[ROCm/rocprofiler commit: 22f2e593c2]
2022-06-01 13:21:04 -04:00
Ammar ELWazir 48e2400848 SWDEV-338186: Fixing Roctracer tool name, path
Using libroctracer_tool.so instead of libtracer_tool.so and fixing the paths for the tracer tool

Change-Id: I9b3ca885f3ca5385b106d5376894b1b4054f9c1d


[ROCm/rocprofiler commit: 0be6306cae]
2022-05-20 05:26:33 -04:00
Ranjith Ramakrishnan c4428cc945 Merge "SWDEV-321112: Use GNUInstallDirs" into amd-staging
[ROCm/rocprofiler commit: 44cbb66a16]
2022-05-19 14:11:17 -04:00
Ranjith Ramakrishnan ee6ea623e2 SWDEV-321112: Use GNUInstallDirs
Use GNUInstallDirs variables to determine the location of BINDIR,
LIBDIR, INCLUDEDIR, DOCDIR, LIBEXECDIR and SYSCONFDIR.

Note that CMAKE_INSTALL_LIBDIR is overriden, since the default for RHEL
is lib64, but ROCm packaging wants it to be lib always. Distros or users
can easily override this.
Project name changed from rocprofiler64 to rocprofiler,since CMAKE_INSTALL_DOCDIR uses the project name

Change-Id: Iff2622b4bfc38ce5caea270e6e44ba74485cb9e4


[ROCm/rocprofiler commit: b24e05e138]
2022-05-19 14:07:42 -04:00
Saurabh Verma e27d5da8c0 SWDEV-298750:Approval to make internal profile counters public
Added approved HW counters for MI200. Also added derived metrics for the same

Change-Id: I1c6abfdfde4e4fd4ba8bd5eec0557ad08fd71c77


[ROCm/rocprofiler commit: 6d233c65d7]
2022-05-17 16:44:16 -05:00
Laurent Morichetti d4241d5241 Register the tracer API as a tool library
In a future change, the tracer API library (libroctracer64.so) will be
automatically registered as a tool library. Until then, explicitly
register it by adding it to the HSA_TOOLS_LIB environment variable.

Change-Id: I44d78ac38608e6da5edf04b498a73485f5609d06


[ROCm/rocprofiler commit: 0123aa61fa]
2022-05-04 19:19:34 -07:00
Ammar ELWazir 9c0bb64c22 SWDEV-296010: Fixing RPATH & CMAKE files
Fixing the RPATH skip & Removed the export line from the build.sh as we have find_library with giving it a path to /opt/rocm & easy to use build.sh

Change-Id: I1ac5b51eafb54ef0359bf6fb55f2fe2d39a6cafa


[ROCm/rocprofiler commit: 0faaa83de7]
2022-05-03 20:13:02 -05:00
Kiumars Sabeti 32684591d2 Merge "SWDEV-320429: wrapping the comma-containing names in the .csv in double quotes at the time the .csv is generated" into amd-staging
[ROCm/rocprofiler commit: 94004e592c]
2022-04-29 17:37:41 -04:00
Kiumars Sabeti 08c1267bbb SWDEV-320429: wrapping the comma-containing names in the .csv in double quotes at the time the .csv is generated
Change-Id: I62f94a1cf8895eb324080f8aacac3f13c02d7050


[ROCm/rocprofiler commit: 4d99f8d8e5]
2022-04-27 20:45:51 -04:00
Ammar ELWazir 63964277e5 Fixing header file location
prof_protocol.h is now located in /opt/rocm/include/roctracer/ext instead /opt/rocm/roctracer/include/ext

Change-Id: I98623dcf3c2e6bcef128c1ef35959ef0a4a1d63f


[ROCm/rocprofiler commit: 1f5b02f9c8]
2022-04-23 13:22:36 +00:00
Sriraksha Nagaraj 19f8e3147a SWDEV-311412: Fixing rocprof application runs fail. Added a check in cmake_modules/env.cmake to check if aqlprofile library is found.
Change-Id: I9ff702bc0b4074101cca7beb78e711ce417308cd


[ROCm/rocprofiler commit: 071379be99]
2022-04-18 17:38:49 -04:00
Ammar ELWazir 8594855227 SWDEV-332635: Fixing the effect of roctx-rename feature
HIP/HSA traces were asked to access range_data list, however, it was not initialized because roctx tracing was not enabled, moved lists initialization before roctx check

Change-Id: I9942876445cb1b2f69c6bb0d8986d6d9234f1441


[ROCm/rocprofiler commit: 1f925b3f16]
2022-04-13 12:58:31 +00:00
Laurent Morichetti 26bb13ade0 SWDEV-318682: Using roctx to rename long kernel names to shorter ones.
To enable this feature use the --roctx-rename rocprof option. This
implementation records all messages received in roctxPush calls and
use them to replace corresponding kernel names.

Tested with the following HIP program:

\#include <hip/hip_runtime.h>
\#include <roctracer/roctx.h>

__global__ void
ThisIsALongKernelName ()
{
}

int
main (int argc, char* argv[])
{
  hipSetDevice (0);

  // Not in a roctx range.
  ThisIsALongKernelName<<<1, 1>>> ();

  roctxRangePush ("A");
  // In a simple first level roctx range.
  ThisIsALongKernelName<<<1, 1>>> ();
  roctxRangePop ();

  roctxRangePush ("B");
  roctxRangePush ("C");
  // In a nested roctx range.
  ThisIsALongKernelName<<<1, 1>>> ();
  roctxRangePop ();
  roctxRangePop ();

  roctxRangePush ("D");
  roctxRangePush ("E");
  roctxRangePop ();
  // In a first level roctx range, but after a nested range.
  ThisIsALongKernelName<<<1, 1>>> ();
  roctxRangePop ();

  hipDeviceSynchronize ();
  return 0;
}

Change-Id: I629312234468daff8b017caa5cb0773707d98cce


[ROCm/rocprofiler commit: 1078a088e9]
2022-04-07 18:03:03 -07:00
Ammar ELWazir 6da8b33053 SWDEV-329270: fixed the multiline input.txt issue
In a previous change the key for the var_table in tblextr.py script has been changed from one value to a tuple without changing the usage of the var_table in the rest of the script

Change-Id: I38964f61afad5323d1ca9b64d538cec426298842


[ROCm/rocprofiler commit: 46c4e5045a]
2022-03-25 05:09:52 +00:00
Ammar ELWazir 314abc4cca SWDEV-329261: Fix for Post-Processing HSA Memcopy Async Activities
The Post-Processing script was depending HSA API call for async mem copies to correlate it with the HSA Async Memcpy Activity, now if user decided to include input file with filtering HSA Api calls without adding HSA Memcpy, then all the correlation data will be dropped and the Async activity will be reported with the information given from the HSA async activity result file

Change-Id: I5123a5acab9b35a4c25793e7953fdfb74929c999


[ROCm/rocprofiler commit: fd4767d954]
2022-03-24 10:22:52 -04:00
Saravanan Solaiyappan bd56d8eb67 Merge "rocprofiler: Consider apt upgrade operation check in package scripts." into amd-staging
[ROCm/rocprofiler commit: a1dde130de]
2022-03-22 12:40:31 -04:00
MarkDavid Laws e664ef8f48 Merge "SWDEV-283957 : Emit correct group name for rocprof split metrics" into amd-staging
[ROCm/rocprofiler commit: 4998b150ee]
2022-03-22 11:52:47 -04:00