Commit Graph

6161 Commits

Author SHA1 Message Date
dkrottap 8763c8c2ad SWDEV-289405 - [catch2][dtest][module] Migration of Module files to CATCH2 framework (#2351)
Migrated all module related files to CATCH2 framework and optimized to
have single module kernel file

Change-Id: I39aa28ef22c1b2f4d0014ca32b59b9c645b725dc
2021-09-17 11:39:36 +05:30
sumanthtg bef1aa7ee6 SWDEV-292643 - [dtest] Catch2 additional unit tests for stream management apis. (#2349)
APIs covered :
hipStreamGetPriority, hipStreamCreate, hipStreamGetFlags, hipExtStreamGetCUMask apis.

Change-Id: I238b4e631938471eab05c598f91477eeb0856054
2021-09-17 11:39:25 +05:30
sumanthtg f7be53ba75 SWDEV-294470 - [dtest] Catch2 unit tests for memset related tests. (#2345)
Change-Id: Ib227e75cb0bef9273bc787e47fa5b713086fac46
2021-09-17 11:37:05 +05:30
sumanthtg 2a17c5662d SWDEV-292643 - [dtest] Catch2 unit tests for stream management apis. (#2343)
Catch2 tests for : hipStreamAddCallback, hipStreamCreateWithFlags, hipStreamCreateWithPriority, hipExtStreamCreateWithCUMask

Change-Id: Ia99c06b1e97fc945f1a740e47710f4dcd70f38cd
2021-09-14 13:38:07 +05:30
TomSang de8bb09c29 SWDEV-299755 - Fix hiprtc failure on NV (#2341)
1. Add missing nvrtc lib.
2. Add context creation before call module(driver) api.
3. Remove obsolete saxpy_pch test.

Change-Id: I5add27ebabcf021fa3ef99d09004c5d13423a297
2021-09-14 13:37:56 +05:30
TomSang ae73179d40 SWDEV-298338 - Fix memory test failure on NV MGPUs (#2339)
1. Fix hipMallocManagedMultiChunkMultiDevice
Add device setting before kernel launching
Add stream sync

2. Fix hipMemcpyAtoH and hipMemcpyHtoA
Fix primary context initialization issue when device
is changed on cuda

Change-Id: I3fe6dbc35b7b24abb21ada297b7885df83d28152
2021-09-14 13:37:46 +05:30
TomSang 7dba6dc28e SWDEV-299960 - Fix .hipTestAtomicAdd test on NV (#2338)
1. Add --gpu-architecture=compute_60 to fully support AtomicAdd()
2. Add atomicAddNoRet() for NV.

Change-Id: I5add28ebabcfa21fb3ef99d09004c5d13423a290
2021-09-14 13:37:30 +05:30
TomSang 9035ae3154 SWDEV-299773 - Enable performance tests on NV (#2337)
1. Simply enable test on NV
   Some need minor fix
performance/compute/hipPerfDotProduct.cpp
performance/dispatch/hipPerfDispatchSpeed.cpp
performance/memory/hipPerfBufferCopyRectSpeed.cpp
performance/memory/hipPerfBufferCopySpeed.cpp
performance/memory/hipPerfDevMemReadSpeed.cpp
performance/memory/hipPerfDevMemWriteSpeed.cpp
performance/memory/hipPerfMemcpy.cpp
performance/memory/hipPerfMemset.cpp
performance/memory/hipPerfSharedMemReadSpeed.cpp
performance/stream/hipPerfDeviceConcurrency.cpp
performance/stream/hipPerfStreamCreateCopyDestroy.cpp

2. Enable and fix on NV
performance/compute/hipPerfMandelbrot.cpp
   Root cause: coordIdx is random
   Solution: Initialize coordIdx correctly
performance/memory/hipPerfMemFill.cpp
   Root cause: Hip ext Apis called.
   Solution: Exclude case with Hip ext Apis involved
performance/memory/hipPerfMemMallocCpyFree.cpp
   Root cause: Test allocates device memory more than GPU has.
   Solution: Allocate device memory in terms of GPU capacity.
tests/performance/memory/hipPerfSampleRate.cpp
   Root cause: Cuda has no operators += for float2 and float4.
   Solution: Provide the operators.
performance/stream/hipPerfStreamConcurrency.cpp
   Root cause:float4 format doesn't match cude.
              operators are missing in cuda lib.
   Solution: Use (x, y, z, w) format.
             Add necessary float4 operatoris for cuda.

Change-Id: I5add29ebabcfb21fb3ef89d09004c5d13423a291
2021-09-14 13:37:13 +05:30
TomSang 3fd16c0b5b SWDEV-266829 - Enable more tests on AMD and NV devices (#2336)
* SWDEV-266829 - Enable more tests on AMD and NV devices

1. Enable tests on AMD and NV devices
  tests/src/runtimeApi/event/hipEventMultiThreaded.cpp
    Loops and threads per core are changed smaller so that test can
    finish in a shorter time.
  tests/src/runtimeApi/stream/hipStreamCreateWithPriority.cpp
    Fix logic error on how to get priority_normal

2. Simply enable test on AMD device
  tests/src/runtimeApi/memory/hipManagedKeyword.cpp
  tests/src/runtimeApi/module/hipManagedKeyword.cpp
  tests/src/runtimeApi/stream/hipStreamACb_MultiThread.cpp
  tests/src/runtimeApi/memory/p2p_copy_coherency.cpp

3. Simply enable test on NV device
 tests/src/runtimeApi/module/hipModuleLoadDataMultThreaded.cpp

4. Fix typo
  tests/src/runtimeApi/stream/hipStreamAddCallbackCatch.cpp

5. Remove useless tests
 tests/src/hipC.c
 tests/src/hipHcc.cpp

Change-Id: Ia4406353e64d69bd34c58ebb56185701f7ce1caa

* Remove tests/src/runtimeApi/module/hipModuleLoadDataMultThreaded.cpp for cuda test

Co-authored-by: anusha GodavarthySurya <Anusha.GodavarthySurya@amd.com>
Co-authored-by: Jenkins <jenkins-compute@amd.com>
2021-09-14 13:36:32 +05:30
Julia Jiang 346117774c SWDEV-291894 - Update the launch bounds error message and version note in FAQ (#2335)
Change-Id: I5b876e80c69d3e04fec92bc3eb995fcd3e94edcd
2021-09-14 13:35:51 +05:30
Julia Jiang 0e48f796cd SWDEV-291894 - update warning message for hipRuntimeGetVersion (#2334)
Change-Id: Ibec032765cc53c1a438272b0114d57947c9fded7
2021-09-14 13:35:37 +05:30
Jatin Chaudhary 6a09344dba SWDEV-296918 - Adding unsafe atomics test for gfx90a (#2331)
Change-Id: I3936e0b30e15aff154bdab3efe3f6da2ccce3578
2021-09-06 12:21:38 +05:30
Julia Jiang 56d6d27a6f SWDEV-286322 - remove unnecessary executable permission in some HIP files (#2329)
Change-Id: If992963761a73d709e08330bc36f2c979d5dcae9
2021-09-02 08:47:57 +05:30
Julia Jiang af3c38c477 SWDEV-291894 - Add doxygen for hip graph APIs (#2328)
Change-Id: Id878125b34711fc43570dd680c05310d9e2a4015
2021-09-02 08:47:38 +05:30
TomSang c57e0f8fe5 SWDEV-294589 - Fix hipCGMultiGridGroupType* failure on NV (#2326)
Fix the following failed tests on NV,
hipCGMultiGridGroupType
hipCGMultiGridGroupTypeViaBaseType
hipCGMultiGridGroupTypeViaPublicApi

1. Fix wrong logic in kernel for both AMD and NV.
2. Remove unnecessary hipDeviceSynchronize().
3. In hipCGMultiGridGroupTypeViaBaseType.cpp, change
   multi_grid_group as thread_group which is originally expected.
4. hipFree(syncResultD) is fixed as hipHostFree(syncResultD)
5. Optimize some host codes.

Change-Id: I3fe6dac35a7b14bab12adf397b7885df83d28059
2021-08-27 08:51:15 +05:30
TomSang 67b3681d26 SWDEV-298459 - Fix cooperative_streams on NV (#2325)
Enable cooperativeGrps/cooperative_streams on NV.
Add test cases of the least/half/full capacity.
Verify data in terms of AMD/NV devices.
Optimize codes

Change-Id: I3fe6dbc35b7b24abb11adf297b7885df83d28154
2021-08-27 08:51:02 +05:30
Julia Jiang b2425ef68a SWDEV-291894 - update branch info in hip install/readme (#2324)
Change-Id: Ie737bfbe3333973d6b42c496b23edcdc0966b9a1
2021-08-26 09:19:54 -07:00
Julia Jiang c2be66db76 SWDEV-286322 - remove unnecessary executable permission (#2323)
Change-Id: I61674df72bc1d42d4e0d56bf66f08abe85269697
2021-08-25 16:57:22 -07:00
gandryey 1f53fbea8f SWDEV-295555 - Add coherency mode query (#2316)
Add the new extension to HIP for quering coherency mode.
The new enum hipMemRangeAttributeCoherencyMode can be used in
hipMemRangeGetAttribute(s), which will return one of the following
values:
hipMemRangeCoherencyModeFineGrain, hipMemRangeCoherencyModeCoarseGrain,
hipMemRangeCoherencyModeIndeterminate

Change-Id: I8717873c254888ea69facc1178d3682e8747c3a7
2021-08-19 10:29:23 +05:30
dkrottap 05e230f5c1 SWDEV-294643 - [catch2][dtest] Migration of Malloc related files to Catch2 (#2314)
Migrated malloc related files under memory folder into catch2 framework

Change-Id: I5aa07fc8148bdf6bef135947091aaf1d3c54663b
2021-08-19 10:29:07 +05:30
Satyanvesh Dittakavi 6cc162f6cf SWDEV-289401 - update hipEvent unit test (#2312)
Reduce the data size as unit tests are expected to take lesser time

Change-Id: Ic30be2ba3e0ff5fff19404b46163b79878716b70
2021-08-19 10:28:51 +05:30
ansurya 6c9f2c1857 SWDEV-287884 - [HIP] Package versioning (#2311)
Change-Id: Icb2b9e7ed83b02e0ae38816a9a8200333b1e252d
2021-08-19 10:28:37 +05:30
TomSang 48d8040b06 SWDEV-294597 - Add more hipNormalizedFloatValueTex cases (#2310)
Add test cases for filter modes: hipFilterModePoint and hipFilterModeLinear

Change-Id: I3fe6dbc35a7b14aab12adf297b7885df83d28056
2021-08-19 10:28:14 +05:30
René Widera 7eaa45d2d5 fix documentation for popcll (#2309)
Change return type from int to unsigned int.
It is correctly documented in hip-math-api.md but not at the place where this PR is updating the documentation.
2021-08-19 10:27:51 +05:30
gilbertlee-amd 32b53b2b13 Clarifying that hipExtLaunch timing does not include cache flush time (#2308) 2021-08-19 10:27:20 +05:30
Nagy-Egri Máté Ferenc 2cdf39edfd Fix nvcc hipconfig (#2307)
hipconfig tries printing the version of nvcc assumed to be on the PATH, not the one that actually gets picked up.
2021-08-19 10:27:06 +05:30
Harmen Stoppels b248df8653 Fix -Wl,--rpath -> -Wl,-rpath (#2305) 2021-08-19 10:26:23 +05:30
Harmen Stoppels 526d0bf97b Use perl from PATH, not from absolute shebang (#2304) 2021-08-19 10:26:03 +05:30
arjun-raj-kuppala 402211e28e Jenkins pipeline code to enable external ci on develop branch (#2302)
* Create Jenkinsfile
* Temporarily disable hipModuleLoadDataMultThreaded test on nvidia

Change-Id: Id061e8a43cccdf0d944081268758b946d2448a6e
2021-08-10 10:16:04 +05:30
Tao Sang 148f1bd59d SWDEV-294597 - Fix hipNormalizedFloatValueTex
Enable hipNormalizedFloatValueTex on AMD and NV.
Add thresh_hold for comparing data.

Change-Id: I3fe6dbc35a7b14aab11adf297b7885df83d28049
2021-08-02 16:54:51 -04:00
Rahul Garg 03e205a1c8 SWDEV-297563 - Move surface types
Change-Id: I1dbb3affce688b75d866917592c497df0cfd358d
2021-08-02 18:50:33 +00:00
Rahul Garg 54e703b17e SWDEV-297563 - Update hip-common declarations
Change-Id: I2545489e3dde55fb9375b9f4cc20ea271fafd3f0
2021-08-02 11:56:28 -04:00
DURGESH KROTTAPALLI 346a77b4c0 SWDEV-292393 - [catch2][dtest] Tests for hipMemcpy related apis.
Migrated all hipMemcpy related APIs to CATCH2 framework by optmizing
the code and moving the stress related tests to stress folder.

Change-Id: Id47669b49304c35d1a68fabdaaf3f6e3ab0428a5
2021-07-31 00:48:43 +05:30
Rahul Garg a797475e35 SWDEV-294828 - Move roc-obj binaries from hip to hipamd
Change-Id: I2a234c46d8516737b7153594e7f978ce3247d6e8
2021-07-30 15:11:47 -04:00
Sourabh Betigeri 8dfb12b6d2 SWDEV-292523 - Marking streamOperations as a Beta feature in documentation
Change-Id: Ib7323ff92df1bd111891b0c7c5e69b31e8ad8e68
2021-07-30 15:09:59 -04:00
Satyanvesh Dittakavi 5816d20752 SWDEV-289401 - Catch2 tests for hip event APIs
Change-Id: I7c28f842282e07c21656fb92ddbb1a9ad32d752c
2021-07-30 07:15:00 -04:00
Tao Sang 5b739b0373 SWDEV-294586 - Fix hipDynamicShared failure on NV
1. In kernel/hipDynamicShared
 Fix shared memory size and type mismatch in host and kernel.

2. In kernel/hipDynamicShared2
Cuda kernels relying on shared memory allocations over 48 KB require
to explicitly set size using hipFuncSetAttribute().

Change-Id: I4248b6cebd3dc156f9d5d427e1897da22fb964ed
2021-07-29 16:59:25 -04:00
Satyanvesh Dittakavi 80d2fee4d8 SWDEV-295427 - Update hipStreamACb_StrmSyncTiming test inorder to fix random failures
Change-Id: I5167fba79338fd2fdd059a9ad83007570bae46be
2021-07-29 12:32:57 -04:00
Tao Sang ec7e25b7e0 SWDEV-294591 - Fix hipEventIpc failure on NV
Remove unnecessary codes

Change-Id: I4248b2cebd3dd156f9d5d427e1897da22fb964ec
2021-07-29 10:16:07 -04:00
anusha GodavarthySurya 25a142dc69 SWDEV-287869 - [HIP] Package rename
Change-Id: I8690c02a8c210c11ad9f7037314ad8cc2124dfc9
2021-07-29 06:56:52 -04:00
kjayapra-amd f61dff826a SWDEV-292175 - Use gfx90a guards around image kernel device library call.
Change-Id: I29aaac940c75fcab0cddbc263d60c0076ea76068
2021-07-29 06:55:18 -04:00
Jatin Chaudhary cc7237d27d SWDEV-289409 - minor fixes for hipStream tests
Change-Id: I68288f33724b636715ee732e9044f82790e5da47
2021-07-29 02:04:31 -04:00
jujiang 5bcd842486 SWDEV-288929 - update document for the flag __HIP_USE_CMPXCHG_FOR_FP_ATOMICS
Change-Id: If7027d6a63c524e4c829288fe794258c7ecbf064
2021-07-28 20:16:54 -04:00
Tao Sang c053d60282 SWDEV-294591 - Fix hipEventIpc failure on NV
make hipIpcOpenEventHandle has the same behavour of cudaIpcOpenEventHandle.
Add Api usages.

Change-Id: I4248b2cebd3de156f9d5d427e1797da22fb964eb
2021-07-28 15:28:39 -04:00
jujiang 5d6ed58dcb SWDEV-288929 - add HIP version in FAQ
Change-Id: I260133a95e484919a362106e1bd36715358247f2
2021-07-28 12:47:51 -04:00
Tao Sang 5a0b463d60 SWDEV-294594 - Enable hipPointerGetAttributes test on NV
Change-Id: I3fe6dbc45a7a149a9109df297b7885df83d2804d
2021-07-28 08:59:34 -04:00
Anusha GodavarthySurya 08aa662166 SWDEV-240806 - Update graph test to use hipGraphGetNodes, hipGraphGetRootNodes and hipGraphAddDependencies
Change-Id: I33249d2b625d8ff03c9fe4a71a541cac5fef9d24
2021-07-27 02:12:26 -04:00
Tao Sang a0b301089c SWDEV-294596 - Fix module test failure on NV
Remove unecessary codes

Change-Id: I4248b2cebd3de156f9d5d427e0697da22fb964ea
2021-07-25 21:21:12 -04:00
Tao Sang ae30c5cd6b SWDEV-294596 - Fix module test failure on NV
1.Fix hipModuleNegative failure on all NV GPUs
a.Add signal handler for signal sent by cuda functions.
b.Make hipModuleGetGlobal match cuModuleGetGlobal behavour.
That is, if one of the first two parameters is nullptr, ignore it.

2.Fix hipModuleLoadDataMultThreaded failure on NV RTX5000
Improve lamda function.

Change-Id: I3fe6dbc35a7a14aa9119df197b7885df83d28047
2021-07-23 22:04:19 -04:00
Rahul Garg a7f321dfae SWDEV-288929 - Fix typo
Change-Id: I076bc34779f92820cbd8a36c1dfc62a45d6de9b5
2021-07-23 07:13:55 -04:00