8c62d0fbc4
Update new tests so as to make them work with new variadic based launch mechanisms.
2017-11-10 00:14:34 +00:00
1518611976
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-09 23:43:07 +00:00
925f97fac7
Merge pull request #250 from AlexVlx/feature_add_agent_global_support
...
Support for agent globals
2017-11-09 07:52:09 +05:30
f7919a8321
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# tests/src/runtimeApi/stream/hipStreamSync2.cpp
2017-11-08 10:26:30 +00:00
6f1298d9f6
Merge pull request #255 from AlexVlx/remove_some_trailing_whitespace
...
Clean up trailing whitespace so as to reduce noise in #246 .
2017-11-08 10:29:19 +05:30
86f5934beb
Merge pull request #253 from mangupta/hit_add_cmakecmd
...
[hit] Add support for cmake commands as part of test infra
2017-11-08 09:50:29 +05:30
0ad1308efd
Clean up trailing whitespace so as to reduce noise in #246 .
2017-11-08 00:08:55 +00:00
7b534885e6
Merge pull request #254 from bensander/event_thread_safe
...
Event thread safe
2017-11-07 17:59:51 +01:00
52c8c4b03c
Merge pull request #252 from phani544/newTests2
...
More tests for memory,stream & error APIs
2017-11-07 10:38:18 +05:30
2a1d7db371
identation change in hipPeekAtLastError
2017-11-07 09:51:32 +05:30
8854dec897
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-07 00:01:22 +00:00
e71456cc6c
Check for null event in hipEventElapsedTime
2017-11-06 23:49:31 +00:00
b5911acce2
hipStreamWaitEvent returns success if event created but not recorded
2017-11-06 23:49:31 +00:00
955cfbfdc7
Make hipEvent_t thread safe.
...
Support re-recording of same event by different threads.
- Add criticalData structure to hipEvent_t, similar to mechanism used
for streams, contexts, device. Events are always locked
after streams to avoid deadlock.
- ihipEvent_t::locked_copyCrit can be used to copy critical state
including marker. The critical state in the event can then
be re-recorded.
- refactor hipEventElapsedTime. Remmove stale debug code, native signal
refs.
2017-11-06 23:49:25 +00:00
f92648e447
[hit] Add support for cmake commands as part of test infra
...
Cmake supports several builtin command-line tools. These tools can
now be specified as part of the HIT block. These commands will be
run during cmake configure step.
Change-Id: I32466c94b2fe1ecdc30249755fc027102295617d
2017-11-06 16:53:57 +05:30
e18f4239b6
Modified tests as per review
2017-11-06 15:13:36 +05:30
7427abba04
More tests for memory,stream & error APIs
2017-11-06 11:31:52 +05:30
dbb6b2bab8
Merge pull request #251 from ROCm-Developer-Tools/fix_event_state
...
Set event state AFTER it is recorded.
2017-11-06 07:28:11 +05:30
958ca62c63
Merge pull request #249 from bensander/warn_event
...
Add HIP_DB=warn + message if sync on dangerous event.
2017-11-06 07:25:40 +05:30
544538fd88
Merge pull request #239 from phani544/newTests
...
[newTests]Adding tests for device APIs
2017-11-06 07:22:13 +05:30
1c65bb1684
Set event state AFTER it is recorded.
2017-11-05 10:33:18 -06:00
394886903c
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-03 10:57:12 +00:00
17753cbd92
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
2017-11-03 10:53:39 +00:00
fa32a1924a
[newTests]modified the test
2017-11-03 14:52:19 +05:30
19946ca43d
[newTests]Modified the test as per review comments
2017-11-03 10:39:47 +05:30
afd3a6786d
Merge pull request #248 from mangupta/SWDEV-134531
...
Remove libsupc++ dependency from HIP
2017-11-03 08:01:59 +05:30
d12cf0da7d
This introduces correct support for agent global variables, and implements hipModuleGetGlobal as an actual equivalent for cuModuleGetGlobal.
2017-11-03 01:44:48 +00:00
3c024a9cc7
Merge pull request #247 from AlexVlx/feature_cleanup_tests
...
Test cleanup
2017-11-02 11:31:10 +01:00
473208368e
Remove libsupc++ dependency from HIP
...
Change-Id: Ib843f99dfb3057b7c28029250c2449732ea7f17f
2017-11-02 12:29:09 +05:30
58a18eaf0c
This corrects some interesting choices that were present in the HIP
...
unit tests such as e.g. de-allocating memory allocated with new[] using
free. All of these were identified via cppcheck.
2017-11-01 22:51:22 +00:00
4693c5e56c
Correctly deal with functions from shared objects, wherein the program visible VA == so_base_va + st_value(function_symbol). Remove quaint usage of pfe for hipMemset (which is actually fill_n).
2017-11-01 22:33:13 +00:00
fe32685fbc
Merge pull request #237 from bensander/use_ctxptr_for_p2p
...
Use ctxptr for p2p
2017-11-01 18:55:25 +01:00
172b9f96e6
Add HIP_DB=warn + message if sync on dangerous event.
2017-11-01 10:44:34 -07:00
5a80c4108e
Merge pull request #245 from scchan/centos_fixes
...
various fixes for centos/rhel
2017-11-01 18:10:29 +01:00
28f87f7d2e
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
2017-11-01 15:09:59 +00:00
c1a4ff7b20
Centos/RHEL - remove usage of constexpr since libc++ doesn't enable ctor for constexpr pair in C++11
2017-10-31 18:16:12 +00:00
cb454d5366
use libc++ on centos 7 and rhel 7.4
2017-10-31 18:14:07 +00:00
a6458616f5
Merge pull request #197 from bensander/update_coherency_tests
...
Update coherency tests
2017-10-31 17:26:50 +05:30
fc5a86d595
Merge pull request #241 from ROCm-Developer-Tools/multi_host
...
Inital codes to remove x86_64 dependency in HIP source build
2017-10-31 16:35:12 +05:30
5e1a721a05
Merge pull request #242 from bensander/time_hip_apis
...
Add ns-level timer for HIP API routines
2017-10-31 16:33:46 +05:30
dc7d993a02
Add ns-level timer for HIP API routines
...
Refactor some miuses of ihipLogStatus, these should only be in top-level
HIP APIs and should be paired with HIP_API_INIT calls.
2017-10-30 20:20:51 +00:00
b98dede49a
Inital codes to remove x86_64 dependency in HIP source build
2017-10-30 15:19:23 -05:00
7e8b39fc96
Merge pull request #222 from bensander/fix_device_prop
...
Fix device prop
2017-10-30 17:58:48 +01:00
4c7b2be1c2
Check for null copyEngine before looking at peers.
2017-10-30 16:58:03 +00:00
4debd30c3d
Merge pull request #226 from scchan/add_printf3
...
add printf to HIP device functions
2017-10-30 17:08:18 +01:00
71434383a3
[newTests]Adding tests for device APIs
2017-10-30 14:34:24 +05:30
a469e785f2
[HIPIFY] fix typo - missing )
2017-10-27 23:31:43 +03:00
5e5ef3e3f4
Merge pull request #238 from ChrisKitching/statistics
...
[HIPIFY] Decouple the statistics system from the code rewriter
2017-10-27 23:17:20 +03:00
f19fcb7a42
Merge pull request #236 from ChrisKitching/friendlyCmake
...
[HIPIFY] Make the cmake build system more friendly
2017-10-27 22:35:13 +03:00
ec2a6ba446
Remove commented else-block
...
A warning statement for _string literals_ seems a bit unhelpful.
There's no value in this being here.
2017-10-27 20:12:33 +01:00
Alex Voicu
Maneesh Gupta
Ben Sander
Phaneendr-kumar Lanka
Siu Chi Chan
Wen-Heng (Jack) Chung
Evgeny Mankov
Evgeny Mankov
Chris Kitching