AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,423 Commits 3 Branches 0 Tags
8e9541dbbdc75b95143feddcd732ce443b8f66bf
Commit Graph

297 Commits

Author SHA1 Message Date
Satyanvesh Dittakavi 23ba31d7bf SWDEV-332606 - SWDEV-333585 - Fix hipMemcpySymbol* and hipGetSymbol* APIs 
This also fixes the QMCPack staging (SWDEV-335826) test failures related
to hipMemcpyToSymbol

Change-Id: Icc3ff04fb1e17999f5bddf12e1a7266e2289032f


[ROCm/clr commit: 8a333a989b]
 2022-05-16 04:27:02 -04:00
Rakesh Roy 5a9a25fcb6 Revert "SWDEV-332606 - SWDEV-333585 - Fix hipMemcpySymbol* and hipGetSymbol* APIs" 
This reverts commit 1ab7f22334 due to QMCPack test failure (SWDEV-335826)

Change-Id: I40397b345aa60f43afc17853bc72426daf385cf7


[ROCm/clr commit: 84c46047e5]
 2022-05-10 11:20:36 +05:30
Rakesh Roy b175689cd2 SWDEV-333598 - Use flags field of amd::Memory UserData for hip flags 
Change-Id: I492c7fe54dba4380fcc53eed1df36bf5ac0af852


[ROCm/clr commit: 4e86d538e5]
 2022-05-06 13:42:19 +05:30
sdashmiz 3e667fc98f 200~SWDEV-333583 : hipMallocArray bad channel format 
- channel format should be consistent accross parameters

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I1e7680ab9262a66e7bea4aaa21f061044b0f7956


[ROCm/clr commit: 8ed471f210]
 2022-04-29 09:15:41 -04:00
Satyanvesh Dittakavi a6f1bde5d7 SWDEV-330667 - SWDEV-333599 - Fix hipHostRegister and hipMallocPitch APIs 
- hipHostRegister should return hipErrorInvalidValue when size is 0 or
size doesn't match the actual allocated size
- hipMemAllocPitch should return hipErrorInvalidValue when width or height
is 0 and elementSizeBytes should be 4, 8 or 16

Change-Id: I43c9fe4ac1ef0a6ac2f953908d301508a7bc5aa3


[ROCm/clr commit: 06203c251e]
 2022-04-28 13:07:08 +00:00
Ajay 12df44b4fc SWDEV-332522 - ipcEvents Avoid deadlock b/w streamWait & Event 
Using device write to set 0 to signal while streamWaitEvent is checking
the signal.
Use app in SWDEV-314307 to verify this fix
Requires vdi #668012 change to work

Change-Id: Ie329a29cfaeb5d144b92cda36773646f913ca73d


[ROCm/clr commit: 1abd0d6ecf]
 2022-04-26 11:59:01 -04:00
Satyanvesh Dittakavi 1ab7f22334 SWDEV-332606 - SWDEV-333585 - Fix hipMemcpySymbol* and hipGetSymbol* APIs 
- hipMemcpy[From/To]Symbol APIs to return hipErrorInvalidMemcpyDirection
if the copy kind is incorrect
- hipGetSymbolSize and hipGetSymbolAddress APIs to return hipErrorInvalidValue
if the pointer is null

Change-Id: I32f428045c804b1e4f648e91b507f749f60c09d0


[ROCm/clr commit: f1fb612774]
 2022-04-25 08:25:29 -04:00
Rakesh Roy cba04140c0 SWDEV-332603 - Check validity of ihipArrayCreate() first argument 
Change-Id: Ifd0bdb5708c110da45e4baa9426cccd749732822


[ROCm/clr commit: 8ea74366d7]
 2022-04-22 11:08:37 +05:30
Rakesh Roy 7a572e0162 SWDEV-332604 - Add nullptr check for argument pitch 
Change-Id: I6d7aa5356a74b92f21f7a51a7d3e2f8d0b920e07


[ROCm/clr commit: 2613ebf157]
 2022-04-22 00:13:24 -04:00
German Andryeyev ecb4165943 SWDEV-333607 - Avoid synchronization of all GPU(s) 
Use the original device from creation to sync before host memory
free.

Change-Id: I510e34afa7accf69e3d01338587bbc817b981cec


[ROCm/clr commit: b4c5a01fbc]
 2022-04-21 15:36:04 -04:00
Sarbojit Sarkar e22f2e1714 SWDEV-323441 - support for default stream per thread 
Change-Id: I0032da0357f5cffbf5e4ec4a02435d2a128a262b


[ROCm/clr commit: fc1f02bbed]
 2022-04-18 23:19:55 -04:00
Jaydeep Patel 583aa7f008 SWDEV-330661 - devicePointer null checking. 
Change-Id: I3366031954330143109d0a79e86fd0e0ec996f01


[ROCm/clr commit: ff78c439ef]
 2022-04-08 00:08:37 -04:00
Satyanvesh Dittakavi 83e2a8a892 SWDEV-326796 - Fix hipMemset crash when the size passed is more than allocated 
Change-Id: If3b15da0960f3af347fca62beedd8003cb958c2e


[ROCm/clr commit: c0ada4320b]
 2022-04-07 08:49:54 -04:00
Saleel Kudchadker 3cec88a755 SWDEV-331152 - Add back HIP_HOST_COHERENT support 
Change-Id: I1971df55913498df801ad319a20b95380a2c136f


[ROCm/clr commit: b1436f6451]
 2022-04-06 12:26:01 -04:00
German Andryeyev 593844fdd6 SWDEV-328670 - Pass the size of allocation 
The actual size of allocation can be different from the original
request due to alignments. Pass the size of the original request
for validation during the arena object look-up

Change-Id: I30000046b1ec56abe743e43113046144fd3edbc6


[ROCm/clr commit: fb835c6f3e]
 2022-04-01 11:18:55 -04:00
Satyanvesh Dittakavi cb4625e5b7 SWDEV-329082 - Return right error code for hipHostUnregister 
hipErrorHostMemoryNotRegistered should be returned when an
unregistered pointer is passed to hipHostUnregister

Change-Id: Ie76086b602bde2cd7a7a2b049cd03d29454ff306


[ROCm/clr commit: ed4014e519]
 2022-03-28 07:24:25 -04:00
sdashmiz c308cf0951 SWDEV-303187: find the device pointer is for 
- the pointer attribute is fetched for might not be the current device

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ibcea92b52da31adba5f62baae25b55671704c005


[ROCm/clr commit: ae506b40c0]
 2022-03-22 10:55:28 -04:00
Satyanvesh Dittakavi 6a849eb690 SWDEV-327967 - Fix Segmentation fault in hipFree 
Queue creation and release fails during hipFree causing seg fault
if the null queue was not created until then and there is no
device memory left.

Change-Id: I118b86b58e777dac5415bc9ba0c4e23c986efa7d


[ROCm/clr commit: 4a90c3ccaf]
 2022-03-22 00:34:40 -04:00
Satyanvesh Dittakavi 90e339cf95 SWDEV-324016 - Refactor hipDrvPointerGetAttributes 
Addresses the negative scenarios and assigns default NULL values to
the queried attributes when the pointer encountered is not valid.
This is to match the corresponding API's behavior in CUDA.

Change-Id: I4ce400b02416d455ec9649f731af2e327dccfe71


[ROCm/clr commit: a554d03b9a]
 2022-03-16 05:30:28 -04:00
Sourabh Betigeri 7649115859 SWDEV-326791 - Fixes hipHostRegister's inconsistent behavior when invalid parameter is passed 
Change-Id: I5d5d979485cfd99908f84cc92648177cb8a569c7


[ROCm/clr commit: 0a76232c97]
 2022-03-11 12:24:35 -05:00
Sourabh Betigeri 9a25ec266b SWDEV-326380 - Fixes a regression by verifying the device virtual address already exists in the memObjMap 
Change-Id: Ibe29f3c6b77385a8e264ab523cafa4b5d2b41325


[ROCm/clr commit: 85a25a4be2]
 2022-03-09 20:52:45 -05:00
Satyanvesh Dittakavi 98fef69edd SWDEV-313867 - SWDEV-314101 - Address Negative scenarios with hipGraphAddMemcpyNode and hipGraphAddMemsetNode 
Change-Id: I51527ce6953aee9a3ef7d821754819b6c8087939


[ROCm/clr commit: c58ba64a0b]
 2022-03-05 07:37:46 -05:00
Sourabh Betigeri eca06b35b9 SWDEV-273026 - Fixes a bug that skipped looping through all devices to book keep its corresponding memory in roclr 
Change-Id: I404f6d2bcd0c0e31b9b0237903f26f0af19bc735


[ROCm/clr commit: 545cfaf428]
 2022-03-02 20:26:28 -05:00
Saleel Kudchadker 49a1d54a5d SWDEV-321723 - Refactor hipHostMalloc flags 
Always choose fing grain memory pool for hipHostMalloc
Choose coarse grain only if hipHostMallocNonCoherent is passed.

Change-Id: I9a67ba77335d4f373d32fea4ecd7848c77f9c190


[ROCm/clr commit: 0da908ec79]
 2022-03-02 16:24:40 -05:00
Saleel Kudchadker 57b1cd0cf2 SWDEV-321723 - Pass correct flags 
Pass CL_MEM_SVM_ATOMICS with hipHostMallocNumaUser.

Change-Id: I7b8010c5584ffd2fbebb964832dcfa270d430830


[ROCm/clr commit: a3f4d9410c]
 2022-02-23 18:23:35 -08:00
Julia Jiang e6f8c4dc23 SWDEV-321654 - fix hipPointerGetAttribute API 
Change-Id: Icafdda147eb16e08048d6c435c0c5714f3f8d143


[ROCm/clr commit: dabed031a0]
 2022-02-22 21:32:28 -05:00
Payam 01bd9ba844 SWDEV-316050, SWDEV-316292 - Graph api matching error with Cuda 
Change-Id: I80c9358e9ad3a2d57fca53e6ff7679f1e3953328


[ROCm/clr commit: c0b859641f]
 2022-02-21 16:29:50 -05:00
Satyanvesh Dittakavi 51f8fc06e1 SWDEV-306940 - Fix hipamd errors/warnings found by CppCheck 
Change-Id: Ia93d4f5262ea4269d8031edbfd27033b887e5300


[ROCm/clr commit: 6e562f4d83]
 2022-02-05 08:42:47 -05:00
Satyanvesh Dittakavi 6bbcf08fc8 SWDEV-292714 - Added support for hipPointerGetAttribute and 
hipDrvPointerGetAttributes

Change-Id: I44a0b5c5d9eb5a9a63406b11e8de83e5cb245a59


[ROCm/clr commit: 760f275861]
 2022-02-02 05:33:07 -05:00
Ajay 91ba078604 SWDEV-313082 - hipGraphMemsetNodeSetParams invalid params 
Change-Id: Ibe57df8d7d583daf9ba9c7a86863eacca4868f3a


[ROCm/clr commit: cb79dc7486]
 2022-01-28 19:27:32 -05:00
Maneesh Gupta 501b613442 Revert "SWDEV-316155 - Fix for P2P sample failure" 
This reverts commit 74269eb547.

Reason for revert: Fixed via a different patch

Change-Id: I1743afdd7b8516b39501839d74bbed6bdb797e0c


[ROCm/clr commit: ff1f1ba867]
 2022-01-13 02:27:47 -05:00
Sarbojit Sarkar 641d0b9d6f SWDEV-315545 - Fix for hipMemsetAsync crash 
Change-Id: I39ad0dacf4357aa6f9d0c6cf92a6a7d14bd219c0


[ROCm/clr commit: c4f6037ae8]
 2022-01-10 06:48:10 -05:00
Sarbojit Sarkar 74269eb547 SWDEV-316155 - Fix for P2P sample failure 
Change-Id: I95a70d44949c59319a9a09f84be771740c3f0521


[ROCm/clr commit: 845b923507]
 2022-01-06 06:35:15 -05:00
Satyanvesh Dittakavi 74bd37bd34 SWDEV-309286 - Add check to limit host malloc upto system memory size 
Change-Id: I4a0f55d6f7faa323b16d9b8fb12e876900da1bbc


[ROCm/clr commit: c9532093ce]
 2021-12-07 12:02:29 -05:00
Sarbojit Sarkar b1ac216804 SWDEV-310181 - Fix for hipMemcpy2DFromArray dtest failure 
Change-Id: I4284cc543c5ebd5f09254d570230a25742e9dc3c


[ROCm/clr commit: 2cbdadd037]
 2021-11-29 22:56:09 -05:00
anusha GodavarthySurya 5e8ecdf9f9 SWDEV-240806 - Fix compilation warning 
Change-Id: I1b540059b1e386bc7b6f4493226c45199542bfc3


[ROCm/clr commit: d2f202b116]
 2021-11-19 20:46:18 -05:00
anusha GodavarthySurya 71215f1231 SWDEV-240806 - hip stream capture handling for memory APIs 
Change-Id: Ie29493cd09421175c3ce5a198f8c2c299739f997


[ROCm/clr commit: 3e2c2dfb71]
 2021-11-17 00:15:13 -08:00
kjayapra-amd a1917d6593 SWDEV-310194 - Return hipSuccess early if fill_size is 0. 
Change-Id: I79d8c94b099d441f14f938205e007ae521649672


[ROCm/clr commit: 2f87d24dd2]
 2021-11-09 09:28:25 -05:00
anusha GodavarthySurya ad0dc7dd0e SWDEV-307642 - Fix memcpy directed tests failure 
Change-Id: I7a835a5a519b35fcda813c2acc1ac3cf5d0b5f23


[ROCm/clr commit: 63c6799130]
 2021-10-26 00:15:11 -04:00
Satyanvesh Dittakavi 933df7235b SWDEV-305163 - Do not limit hipHostMalloc upto max GPU memory available 
Change-Id: Iea934088bcbef6cbd5c3f9f97767042fcaf71062


[ROCm/clr commit: 1da4bb21b9]
 2021-10-20 01:33:44 -04:00
kjayapra-amd 7c4dfc27a7 SWDEV-232903 - Move hipmemset dword optimization into ROCclr. 
Change-Id: I1af437de2771f6a48d06ce643ade6b79f551a55c


[ROCm/clr commit: 4d1195f0a7]
 2021-10-13 11:32:00 -04:00
anusha GodavarthySurya be487b261b SWDEV-24806 - Added support for memcpy related graph APIs 
hipGraphMemcpyNodeSetParams1D, hipGraphExecMemcpyNodeSetParams1D, hipGraphExecMemcpyNodeSetParams, hipGraphAddMemcpyNodeFromSymbol, hipGraphMemcpyNodeSetParamsFromSymbol, hipGraphExecMemcpyNodeSetParamsFromSymbol, hipGraphAddMemcpyNodeToSymbol, hipGraphMemcpyNodeSetParamsToSymbol, hipGraphExecMemcpyNodeSetParamsToSymbol

Change-Id: I6896144f340867d938aa1777880c78c46ca6f893


[ROCm/clr commit: c4eda85835]
 2021-10-05 22:43:49 -07:00
Ajay 48316f63e9 SWDEV-301069 - save device id during hipHostRegister 
Change-Id: I789b2252fa1a131ed1924b47718e355cb4fc9037


[ROCm/clr commit: 361dec890c]
 2021-10-04 12:07:29 -04:00
Sarbojit Sarkar 8923e6d97d SWDEV-301823 - Optimized hipMemset2D/3D 
Change-Id: I1e817ab135bfdf9b8f9af18c1bf2cd2e926db729


[ROCm/clr commit: 98c172c2e4]
 2021-09-28 00:05:33 -04:00
Ajay 918575f762 SWDEV-301069 - null ptr check before calling getUserData 
Change-Id: Iaff3acd44d89a9629efe0672cb45138942d7fa28


[ROCm/clr commit: 198530143c]
 2021-09-17 19:25:24 -04:00
agunashe 0cf25d1fd3 SWDEV-301069 - current device id saved while allocating memory 
Change-Id: I57045119e7adf915074c547cbe76349a4cfd72d9


[ROCm/clr commit: 29adfcd3c0]
 2021-09-14 12:19:44 -04:00
Sarbojit Sarkar 87862528be SWDEV-276319 - Added missing null check 
Change-Id: I0fcaa55b9a793cbb6c1d2f3022edf288dabea757


[ROCm/clr commit: 88186db4cd]
 2021-09-08 06:53:02 -04:00
anusha GodavarthySurya 64799f183f SWDEV-300471 - updated hipFree to wait for all streams to finish 
Change-Id: I4983ef48a9e720ed03128d83a8d23ad11024fd8f


[ROCm/clr commit: c9d9fd992a]
 2021-09-02 00:45:24 -04:00
Julia Jiang 6883ccde42 SWDEV-286322 - Remove execution permission 
Change-Id: I96e603fc8d407c3a76fa1053bad81e45744b59ad


[ROCm/clr commit: 8835b897d5]
 2021-08-05 14:04:06 -04:00
agunashe fae697b4d6 SWDEV-293742 - Update copyrights end year for hipamd 
Change-Id: I08f620f84563a9214b59f1b943ed091b67229eab


[ROCm/clr commit: d9d9e81acb]
 2021-07-09 12:08:39 -04:00