Commit Graph

8920 Commits

Author SHA1 Message Date
Choudhary, Rahul 9a5dec1c26 Update palamida.yml (#49) - removing url 2025-05-12 21:49:08 -07:00
Hila, Nino 8c536c9c8d Add palamida.yml 2025-05-12 21:43:56 -07:00
Hila, Nino f5daf75abf Update palamida.yml (#158)
* Update palamida.yml

Signed-off-by: Hila, Nino <Nino.Hila@amd.com>

* Add palamida.yml

---------

Signed-off-by: Hila, Nino <Nino.Hila@amd.com>
2025-05-12 21:37:36 -07:00
cfallows-amd d527d77337 Fix setting roofline-data-type option in both profile and analyze modes (#702)
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-05-12 23:02:47 -04:00
David Galiffi 45b600b34e Fix openmp-target test on gfx950 (#204)
for SWDEV530112
2025-05-12 14:20:24 -04:00
Bhardwaj, Gopesh fbab96e552 Replacing ROCm 6.5 mentions with ROCm 7.0 (#391) 2025-05-12 17:05:45 +05:30
Saleel Kudchadker 1eb8694dd2 rocr: Expose hsa_amd_memory_get_preferred_copy_engine api 2025-05-09 17:13:27 -07:00
David Galiffi 82d5b8c64f Update containers.yml (#205)
Add the rhel-9.5 container to the recurring updates
2025-05-09 17:50:44 -04:00
Kuricheti, Mythreya f3ea8b1178 Fix fold expr (#389) 2025-05-09 14:18:19 -07:00
xuchen-amd 4e24b2c60a Improve gpu spec tests using chip ids. (#701) 2025-05-09 11:48:25 -04:00
Galantsev, Dmitrii 6d33c08346 CMAKE - Fix libc6 RPM dep issue
Change-Id: Id68e8a268f1b7e8561b9c9f741ae6e10b4ad7d8a
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-05-08 10:56:38 -05:00
Shane Xiao 82a88f2e2b rocr: Set rec_sdma_eng_override_ for all gpus
Set the rec_sdma_eng_override_ for other gpus, or DmaCopyOnEngine
will use sdma for D<->D copy, which will trigger invalid argument.
2025-05-08 23:52:12 +08:00
adapryor 33924ea79e Profiler - Fix SIMD Utilization
Change-Id: I6775cce9901a714d20e80c8c17e7a563edeb48a4
2025-05-07 00:56:52 -05:00
Galantsev, Dmitrii a355bb6664 CMAKE - Fix lintian issues
Change-Id: Ie0099a27986eec017ea1e554c15dc06e6bd35c76
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-05-07 00:35:09 -05:00
christian-heusel 5cc61b714d rocr:Add missing cstdint include 2025-05-06 20:52:48 -04:00
Galantsev, Dmitrii fa8b89f4ae CMAKE - Format with cmake-format
Change-Id: I08e71fc5060b1f6e0168225cc5fe66886c2044bd
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-05-06 17:28:14 -05:00
Galantsev, Dmitrii f89beb90f5 CMAKE - Add cmake-format
Change-Id: I4036859491934ed26303530d0dc1afb4f1b0d0cd
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-05-06 17:28:14 -05:00
vedithal-amd dbb7f4d493 Use gpu model series instead of gpu model name for testing (#696) 2025-05-06 18:23:08 -04:00
vedithal-amd abd500593b Fix PC sampling analysis config issue (#697) 2025-05-06 18:22:15 -04:00
Galantsev, Dmitrii 02c0786a2c Profiler - Add SIMD_UTILIZATION (#171)
Change-Id: I19d5acd80dbed8c4fc4e1c85eec71ca89398d299

Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-05-06 13:20:03 -07:00
Kuricheti, Mythreya eaf3bbceb7 Add enum to string cxx utils (#153)
* Add enum to string cxx utils

* Add license header

* Address review comments

* Add version assertions

* Address review comments

* Fix thread trace header include

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-05-05 21:02:13 -05:00
David Galiffi 96b31d92c3 Fix build failure for the openmp-target example when building in docker. (#197)
- Add cmake formatting rule for `rocprofiler-systems-custom-compilation`
- Resolve build failure observed with the `openmp-target` example when building in some environments
  - Observed in our docker images
  - Ensure `libomptarget-amdgpu-gfx*.bc` files are found
2025-05-05 21:49:46 -04:00
Hila, Nino 73a75f839f Add palamida.yml 2025-05-05 16:35:21 -04:00
Hila, Nino 24b083e317 Add palamida.yml 2025-05-05 16:31:25 -04:00
Hila, Nino 59c5213367 Add palamida.yml 2025-05-05 16:27:51 -04:00
Searles, Mark ac1e6d59c2 Update createMCObjectStreamer() to use new LLVM API (#156) (#157)
* Update createMCObjectStreamer() to use new LLVM API

Obsolete interfaces were removed via llvm-project's
f2ff298867d7733122e32eead5a8c524b09dfdb1

* Fix typo: LLVM_VERSION -> LLVM_VERSION_MAJOR

* Fix typo
2025-05-05 13:18:05 -07:00
Ben Richard 35493f440c Avoid crash when profiling data not generated (#694)
* Avoid crash when profiling data not generated

-Handle case where program has no kernel launches
-Improve error messages
-Avoid roofline when profiling data is missing

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Update other soc_gfx files to catch missing pmc_perf.csv

* Fix formatting

* Fix incorrectly ordered imports

---------

Signed-off-by: benrichard-amd <ben.richard@amd.com>
2025-05-05 16:09:48 -04:00
Pratik Basyal f7c7cd297e Changelog for ROCm Systems Profiler 1.0.1 added to develop (#199)
* Changelog for ROCm 6.4.1 added

* Reference docs added

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-05-05 15:06:37 -04:00
Rawat, Swati 3e653b7ab3 RDC Doc formatting (#166)
* doc formatting

* Update job_stats_sample.rst

* Doc formatting

---------

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>
2025-05-05 13:08:33 -05:00
dependabot[bot] a5c56a665d Bump rocm-docs-core[api_reference] from 1.18.2 to 1.18.4 in /docs/sphinx (#196)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.18.2 to 1.18.4.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.2...v1.18.4)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.18.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-05 13:10:38 -04:00
David Galiffi 83a9eb3d7c Updating release build dockers (#195)
- Bringing in recent changes from rocm-6.4 branch (https://github.com/ROCm/rocprofiler-systems/pull/171)
- Add libdrm-devel to rhel and suse files
- Update ROCm installation method in Ubuntu file
- Add additional output to `test-release.sh` to catch failures due to a Python version not included
- Add Python 3.13 to Dockers
2025-05-02 19:29:15 -04:00
David Galiffi adc66956b0 Fix path to post-processing merge script (#187)
- Path to merge script not found unless user explicitly sources "share/rocprofiler-systems/setup-env.sh" to setup PATHs.
- Instead, let's derive the path when the application loads and use it when executing the helper script
- Rename script to rocprof-sys-merge-output.sh.
- Change install folder to <prefix>/libexec/rocprofiler-systems based on dev-ops feedback.
- Updated PATH variable in the modulefile and source scrtipt.
- For SWDEV-528101
2025-05-02 16:52:54 -04:00
anujshuk-amd ff109912c2 Reverting PR-154 Changes since VCN data not seen on Perfetto file (#191) 2025-05-02 16:19:43 -04:00
Welton, Benjamin 65f60bbb96 Remove unnecessary log line (#387)
Co-authored-by: Benjamin Welton <bewelton@amd.com>
2025-05-02 12:25:32 -07:00
David Galiffi 0f16d45445 Conditionally include ROCPROFILER_BUFFER_TRACING_PAGE_MIGRATION (#193)
- Include only if ROCPROFILER_SDK_VERSION < 1.0.0, as it is being removed
- For SWDEV-530639
2025-05-02 15:05:27 -04:00
David Galiffi 7d74dc7d5d Install rocprof-sys-causal-print to /opt/rocm/libexec/rocprofiler-systems (#175)
For SWDEV-528225

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-05-01 19:49:11 -04:00
David Galiffi e9e194a3ca Re-enable RPM_PACKAGE_AUTOREQ (#174)
Removes workaround for SWDEV-525268

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-05-01 19:46:24 -04:00
Sajina PK 99a411fe52 Fix to overlapping VCN and JPEG tracks in perfetto (#192)
- Fix overlapping VCN and JPEG activity values in Perfetto output.
- Modify the storage of the activity values to be more efficient.
2025-05-01 19:40:49 -04:00
Rawat, Swati 4a230f0180 fix broken link (#169)
Update job_stats_sample.rst

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>
2025-05-01 10:49:31 -05:00
Apurv Mishra aa0a32a166 kfdtest: Update ROCr homepage in CMakeLists.txt
Signed-off-by: Apurv Mishra <Apurv.Mishra@amd.com>
2025-05-01 11:22:49 -04:00
Kandula, Venkateshwar reddy b69e12032e [PSDB] [CI] SWDEV-528922: Modify summary MEMORY_ALLOCATION for summary.txt (#375)
* Update validate.py

* increase memalloc to 4 to account new vmem.

* Format.

* modify test to work when vmem using and not to work.

* address comments.

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
2025-05-01 00:58:00 -05:00
Madsen, Jonathan e9757e46ce [Build System] Install FindrocDecode.cmake and FindrocJPEG.cmake (#382)
Install FindrocDecode.cmake and FindrocJPEG.cmake

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-05-01 00:57:37 -05:00
Trowbridge, Ian e626df43eb Fix HIP Streams Duplication Error (#313)
* Fix stream duplication and fixed tests

* Added comments to explain stream.cpp code, change stream nullptr check to occur in update table to prevent readding null stream, simplified hip-streams bin file code, add destroyStreams to hip-streams bin file code

* Removed roctx from CMakeLists.txt

* Updated documentation

* Fix documentation

* Removed update_table for HIP compiler table and updated stream.cpp to remove support for HIP compiler table

* Added runtime initialization check for HIP

* Changed tool name, working on fixing memory management

* Added context for counter collection kernel rename combination

* Changed name from map to set and changed description

* Fix documentation description for group-by-queue

* Merged memory copy and kernel operations onto a single track when on the same stream

* Updated perfetto output to remove hardware information from track name to merge all memory copy and kernel operations on the same stream to the same track:

* Most pr comments addressed

* Added filter for counter collection and removed kernel buffer tracing hack

* Added PR comment fixes

---------

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
2025-05-01 00:56:15 -05:00
Luca Bruni 8ae6651357 Appropriately filter data based on -D and -H options (#163)
- Addresses concern that device metric tracks are still shown in Perfetto trace file even when only -H is specified to rocprof-sys-sample (and vice versa).
- Update sampling call-stack docs.
2025-04-30 09:50:51 -04:00
Bhardwaj, Gopesh 4427f2bd6d updating fmt submodule to latest release tag (#13)
* updating fmt submodule to latest release tag

* fix configuration error
2025-04-30 09:57:37 +05:30
David Yat Sin 4ed5950beb rocr: Fix logic for scratch reclaim
Fix logic error that can cause scratch memory to be reclaimed while a
dispatch is still using it.
2025-04-29 17:23:45 -04:00
cfallows-amd 41e73650d5 Enable roofline for MI350 series (#677)
Rework of roofline binaries generated from rocm-amdgpu-bench
- removed arch identifier in bin name
- removed rocm5 bins altogether

Updated required distros for roofline
- updated distro checks and bin naming
- moved up ubuntu20.04->22.04 and sles15.3->15.6 per rocm support

Enabled ctests for mi350 for test_roof_*
- removed mi350 series check to skip these specific tests

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-04-28 16:08:23 -04:00
cfallows-amd ad17c4d587 Update CODEOWNERS (#680)
Add rp-compute technical writer directly for any documentation review.
Remove existing packaging review requests for single user; every repo owner should be notified.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-04-28 16:05:51 -04:00
Daniel Su b77fcf575e Set rocprofV3 agent-index to absolute (#675)
Signed-off-by: Daniel Su <danielsu@amd.com>
2025-04-28 15:38:07 -04:00
Pryor, Adam 2db6ddea69 [SWDEV-523349/SWDEV-527257] Fix Rdci Config (#161)
Change-Id: Iae21ea8061205f186086a3ed59c6259ddeb1dbe7

Signed-off-by: adapryor <Adam.pryor@amd.com>
2025-04-28 11:57:51 -05:00