Commit Graph

8920 Commits

Author SHA1 Message Date
Mallya, Ameya Keshava 685c057acb Fixed Workflow for updated KWS structure 2025-03-09 14:23:22 -05:00
Mallya, Ameya Keshava d5cbe04ecf Create kws-caller.yml 2025-03-09 14:23:22 -05:00
Galantsev, Dmitrii 898ae4ffc1 [SWDEV-495169] Update ROCm SMI CLI and Error handling (#3)
Issues include:

Update ROCm SMI displaying None or Not Supported to N/A
Update ROCm SMI displaying err msg to instead log err

Signed-off-by: Juan Castillo juan.castillo@amd.com
Change-Id: I1a2ce6e4f329666b5666664a7d7b4475d6c1cbc7
2025-03-09 14:23:22 -05:00
James Xu fdc8d73c64 [SWDEV-501108] Update Doxygen note on rsmi_dev_pci_id_get
- To address https://github.com/ROCm/rocm_smi_lib/issues/208
where use of fake BDFs for partitions can cause confusion. This note
is already in the comments of the function definition, but was not
updated in the function declaration.
- Fix broken formatting for the location table for PCIE coordinate fields
- Tracked in SWDEV-501108

Change-Id: Ic85439866cb836bb43acc52314a7f1d026c3215d
2025-03-09 14:23:21 -05:00
Choudhary, Rahul 78f66f81de Create rocm_ci_caller.yml init file to call shared workflow 2025-03-09 14:23:21 -05:00
gabrpham 76ac0808fe Fixed reset event issues
Issues include:
	SWDEV-480250
	SWDEV-480255
	SWDEV-480248

Signed-off-by: gabrpham <Gabriel.Pham@amd.com>
Change-Id: Icf12211e4b136f26fce18f09a7bf8b7e9cd20691
2025-03-09 14:23:21 -05:00
Charis Poag 88a7e4b8ad [SWDEV-496693] GPU metrics 1.7
Changes:
    - Added new GPU metrics:
      1) XGMI link status - Up/Down; 1 = up; 0 = down
      2) Graphics clocks below host limit (per XCP)
         accumulators -> used to help calculate a violation status
      3) VRAM max bandwidth at max memory clock
    - Updated rocm-smi --showmetrics to include new metrics.
    Units/values reflect as indicated by driver, may differ
    from AMD SMI or other ROCm SMI interfaces which
    use these fields.
    - N/A fields means the device does not support providing this
    data.

Change-Id: I17b313345f15070a76b3a30dd8d5645d212d601b
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2025-03-09 14:23:21 -05:00
Charis Poag d2efac3d93 [SWDEV-475712] Fix MI2x target_graphics_version
Removed correcting target_graphics_version by
product name. Instead detected target_graphics_version which
needs to be corrected -> populate accordingly.

Change-Id: I90765c87e0629daea5c732dace8acfd17e8c62c7
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2025-03-09 14:23:21 -05:00
Poag, Charis 23e945c6b3 [SWDEV-514998/SWDEV-511662] Fix tests for Guest and BM with static CPX config (#26)
Guest: Tests needed to account for not supporting changing compute
partitions.

BM: Tests need to account for invalid responses from Driver (due to
static CPX config).

Change-Id: I09ccee981c6b73684b64e5053068920a6c1b6439

Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2025-03-09 14:08:02 -05:00
Poag, Charis 08fee73075 Revert "[SWDEV-514998/SWDEV-511662] Fix tests for Guest and BM with static CPX config" (#25)
* Revert - this reverts commit a73e47591c7ea0ed5a7fc217211872d74be64206.

* Revert "[SWDEV-514998/SWDEV-511662] Fix tests for Guest and BM with static CPX config"

This reverts commit 5a71fd9d75d4d6a9bdd7fa3e652eeb12336a1d6a.
2025-03-09 14:08:02 -05:00
Arif, Maisam d953b2ce66 [SWDEV-517717] Maintence Mode Notice (#20)
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
2025-03-09 14:08:02 -05:00
Kanangot Balakrishnan, Bindhiya 1d6b8d9422 SWDEV-510419: Restore compute partition after memory partition test (#15)
Memory partition test was changing original compute partiton based
on default compute mode. Corrected this to set back to original
compute partition.

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
2025-03-09 14:08:02 -05:00
Charis Poag 1dd9ca9df4 [SWDEV-514998/SWDEV-511662] Fix tests for Guest and BM with static CPX config
Guest: Tests needed to account for not supporting changing compute
partitions.

BM: Tests need to account for invalid responses from Driver (due to
static CPX config).
2025-03-09 14:07:51 -05:00
Galantsev, Dmitrii 6769f64ba0 CHANGELOG - Add 6.4.0 updates
Change-Id: Ia788b1b51d6ef93c5d065c70a31a029d76fdab98
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com>
2025-03-07 20:02:07 -06:00
srawat a865793b70 Refactor RDC documentation
Change-Id: Ieaba84992a8cbd185f4c2d1dc36a175c0429b754
2025-03-07 19:50:08 -06:00
Galantsev, Dmitrii 3ec9d6c2d2 Fix workflow until grpc updates on github
Change-Id: Idf3faa9f7991e4a7ecf78dfb13aafe5c6533fa01
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-03-07 19:25:53 -06:00
Galantsev, Dmitrii 8b249046c0 Update gRPC to 1.67.1
Change-Id: I911878a3aeec8c9234b0e1ac4447364f2ed845cc
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-03-07 18:36:34 -06:00
dependabot[bot] ccb315787e Bump jinja2 from 3.1.4 to 3.1.6 in /docs/sphinx (#134)
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.6.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](https://github.com/pallets/jinja/compare/3.1.4...3.1.6)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-07 13:55:51 -07:00
AL Musaffar, Yazen cf566ebd31 RDC REST API (Sample code)
Please follow the README file

Update README_rdc_rest_api.txt

Update RDC_REST_API.py

Error handling updates

Updates for error handling

Updates

Updates for rdc_field_watch/rdc_field_unwatch and delete query

Updates for rdc_field_watch/rdc_field_unwatch and delete query

SWDEV-479738 [RDC] - Rest API

Delete python_binding/RDC_REST_API.py

new rdc_rest_api.py file for SWDEV-479738 [RDC] - Rest API
2025-03-07 20:48:15 +00:00
adapryor e847f74f78 Fix Prometheus counters
default to gauage

Change-Id: Ia0428e61f023f10b02b3ebe103870d40c057abe3

Change values in question to gauges

Change-Id: I81c91c880246342a0ad0586f6dbe50b247a01117

fixes

Change-Id: I949438d3d3b511c22649640e082b59a3fb7696e0

Fix info handling

Change-Id: I8091fbfa55ba5a9c21c4569dd40e37fb432924f3

fix default

Change-Id: Ia449fed18730a06a858107e9218dc7b443a681fb
2025-03-07 20:48:11 +00:00
Kandula, Venkateshwar reddy cc18b95c7f rocprofv3-test-trace-hip-in-libraries-validate failed in PSDB (#248)
* capture streams by reference

* Fix sync_stream in tests/bin/vector-operations

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>
2025-03-07 14:43:29 -06:00
zichguan-amd 3415a500c7 Throw exception when runtime not initialized for hsa_amd_signal_wait_*
Signed-off-by: zichguan-amd <zichuan.guan@amd.com>
2025-03-07 15:17:10 -05:00
zichguan-amd e4d027191c rocr: Allow 0/NULL/invalid signal handles for wait operations to be no-op
Remove hard assertions for signal validation on hsa_amd_signal_wait_* operations, instead ignore 0/NULL/invalid signals in the dependency condition evaluation to align with HSA specs for barrier-AND and barrier-OR packets.

Signed-off-by: zichguan-amd <zichuan.guan@amd.com>
2025-03-07 15:17:10 -05:00
Sajina PK 0071fd2d81 Add contributing guidelines (#119)
---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-03-07 14:47:30 -05:00
Khatri, Shweta 9638da7467 Added gfx94x and gfx11xx IDs to enumerator (#5) 2025-03-07 13:56:43 -05:00
cfallows-amd 848fa1dc18 FP8 roofline support (#592)
Adding FP8 datatype to roofline feature in rocprof-compute on MI300-based systems.
FP8 now shows in terminal output and roofline csv, and outputs a standalone PDF.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-03-07 11:27:01 -05:00
Fei Zheng f64c83fc5e fix specs-correction 2025-03-07 11:27:01 -05:00
xuchen-amd 1b6bc89137 Disable --kokkos-trace in rocprof-compute (#594)
.
2025-03-07 11:27:01 -05:00
xuchen-amd b81310070e Fix rocprofv1 output processing. (#588) 2025-03-07 11:27:01 -05:00
vedithal-amd 0b3114fa88 Fix post analysis gui in standalone binary (#591)
* Fix post analysis gui in standalone binary

* Add post analysis gui assets and required server libraries for GUI
  server and web page

* Add port forwarding to docker test compose

* Update README me to use `docker compose up` instead of `docker compose run`
  to run containers with port forwarding and to leverage other
  functionalities of docker compose
2025-03-07 11:27:01 -05:00
David Galiffi 5fc495c1e7 Update libraries' SOVERSION to match other ROCm components (#98)
set SOVERSION to ${PROJECT_VERSION_MAJOR}

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-03-07 10:18:36 -05:00
David Galiffi fdb6f4f6b4 Update runners to use ubuntu-latest (#131) 2025-03-06 18:11:19 -05:00
Sajina PK 2222ce9b83 Documentation update for VCN, JPEG, rocDecode and rocJPEG feature (#109)
* Documentation update for VCN, JPEG, rocDecode and rocJPEG feature

Update documents to include the new tracks for tracing VCN and JPEG
activity.
Update the rocDecode and rocJPEG tracing enabled using ROCprofiler-SDK.
Update headings to the perfetto output images.

* Add few more lines about domain values.

* Add missing words to the dictionary
2025-03-06 18:03:33 -05:00
David Yat Sin 02b38d0614 rocr: Put back scratch_backing_memory_byte_size
The scratch_backing_memory_byte_size is not used by CP, but it is
currently used by rocgdb. Putting the field back, but we need to find a
solution for alt_scratch_backing_memory_byte_size.

Also, completely disabling alternate scratch as we need some changes to
support debugger.
2025-03-06 16:23:38 -05:00
David Galiffi eb0a969a9c Fix logging error (#130)
When we create profile config with rocprofiler we log the counters being registered. However, this log was being skipped in certain cases.
2025-03-06 14:30:45 -05:00
Jonathan Kim c879fdefcf kfdtest: Add KFD SDMA queue reset testing
The KFD can per-SDMA queue reset similar to compute queue reset.
Add test.
2025-03-06 14:04:42 -05:00
Jonathan Kim ee890e7d2b kfdtest: Add KFD SDMA queue reset testing
The KFD can per-SDMA queue reset similar to compute queue reset.
Add test.
2025-03-06 14:04:42 -05:00
Jonathan Kim d047708317 kfdtest: Allow user to modify packet size for SDMA write packets
This is primarily used for debug and negative testing for SDMA queue
reset and shouldn't be used for normal run cases.
2025-03-06 14:04:42 -05:00
Jonathan Kim 9e57ce48e8 kfdtest: Add create SDMA queue by target engine
KFD supports SDMA queue creation by target engine.
Enable this for testing.
2025-03-06 14:04:42 -05:00
Jonathan Kim a957b24153 kfdtest: Add SDMA poll memory register packet support
The SDMA can wait on poll user memory.  This is being added to
support per-SDMA queue reset testing.
2025-03-06 14:04:42 -05:00
Jonathan Kim e3d09e30dc hsakmt: Expose per-SDMA queue reset capabilities
Expose new capabilities field that flags per-sdma queue reset
support.
2025-03-06 14:04:42 -05:00
Su, Daniel 11823451e6 External CI: change trigger from amd-master to amd-mainline 2025-03-06 10:29:58 -05:00
Rawat, Swati d74ea0876f Update CHANGELOG.md: editorial review (#254)
Update CHANGELOG.md

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>
2025-03-06 12:32:02 +05:30
Su, Daniel 70b44c576c External CI: change trigger from amd-master to amd-mainline
Signed-off-by: Su, Daniel <Daniel.Su@amd.com>
2025-03-05 16:24:29 -05:00
Sohaib Nadeem 42922ec851 Fix hardware counter summary files not being generated after profiling (#124)
- Register a cleanup function in tim::manager instance to write out data in
counter storages

- The counter_storage::write() calls in tool_fini happen after the storage is destroyed
which is too late for the write to happen.

- Adjust traits for counter_data_tracker

- Add MIN, MAX, VAR, STDDEV columns
- Remove DEPTH, UNITS, %SELF columns

- Update "add_validation_test" to test for the existence of output file(s).
- Added step to test perfetto output for `transpose-rocprofiler-sampling`
and `transpose-rocprofiler-binary-rewrite`

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-03-05 16:05:18 -05:00
Madsen, Jonathan e7c64e12f9 [rocprofv3] Fix calculation of services which collected data (#265)
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-03-05 10:59:06 -06:00
David Yat Sin 6dac90c89a rocr: Only expose ext-fine-grain pool on xgmi-hive systems
We cannot guarrantee system-scope coherency on systems with only PCIe
connections, so do not expose extended fine-grain memory pool on these
systems.
2025-03-05 10:41:38 -05:00
arvindcheru c3138e1962 Move install location of internal papi files to lib/<pkgnm> (#118)
Signed-off-by: ArvindCheru <acheruva@amd.com>
2025-03-05 10:23:58 -05:00
David Galiffi a25554359b Update workflow runners due to the deprecation of ubuntu-20.04 runners (#102)
* Update runners to `ubuntu-latest`.

The `ubuntu-20.04` runner is deprecated and will be removed.

* Add 'vim' and 'perfetto' to CI docker images

For convenience when using the images locally.
2025-03-04 19:31:13 -05:00
David Galiffi a588f53d3e Move cmake files to .../lib/cmake/rocprofiler-systems (#128)
* Move cmake files to `.../lib/cmake/rocprofiler-systems`
2025-03-04 19:28:59 -05:00