Commit Graph

8920 Commits

Author SHA1 Message Date
Madsen, Jonathan 470f347e50 SDK: remove majority of exceptions (#176)
* SDK: remove majority of exceptions

- replace with ROCP_FATAL, ROCP_CI_LOG(WARNING), etc.
- improve logging of symbolic link
- add --readlink and --realpath (hidden options) to rocprofv3 to follow symlinks for preloaded libraries

* Add rocprofv3 --rocm-root argument

* Fix registration resolved_exists

* Fix rocprofv3_avail.py

* Update logging for rocprofiler_configure search

- relax failure conditions

* Misc clang-tidy fixes

* Fix merge

* Fix merge

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>
2025-02-18 10:44:37 -06:00
Longlong Yao 26f001d3cb libhsakmt: allocate va in host path
Change-Id: I40a4395aca99ea8dfd8ff0ecde64eb2c3840d867
Signed-off-by: Longlong Yao <Longlong.Yao@amd.com>
2025-02-15 07:56:45 -05:00
ywang103-amd b9fc44992a fix missing parameter of spatial multiplexing for create_df_pmc (#567) 2025-02-14 14:23:16 -05:00
Adel Johar b4f8b5c202 Docs: Update environment variables page 2025-02-14 10:15:20 -05:00
Fei Zheng 8c3895e1d1 Update changelog 2025-02-13 18:05:49 -07:00
Welton, Benjamin fd99654433 Fix install for conversion-script (#211) 2025-02-13 19:00:20 -06:00
ywang103-amd 808a9a79ed Spatial multiplexing: part2, analysis (#542)
Co-authored-by: Yang Wang <ywang103@amd.com>
2025-02-13 15:38:59 -08:00
Peter Park 9643afa62d Fix links in docs (#564) 2025-02-13 16:24:48 -05:00
Bhardwaj, Gopesh 1fcb951d0e swdev-515336: removing deprecated features from documentation (#12) 2025-02-13 13:04:29 -06:00
Elwazir, Ammar 376c2a96ad Lowering log level for COMGR logs (#210)
* Lowering log level for COMGR logs

* Format Fix
2025-02-13 12:59:29 -06:00
Bhardwaj, Gopesh 215875de32 Adding CodeQL Analysis Workflow (#172)
* adding codeql.yml

* update codeql

* update codeql

* excluding external repos

* filter external

* filter external  and build

* Apply suggestions from code review

* Removed experimental test line

* Adding config

* moving codeql config out of workflows

* Disable Cdash

* update codeql

* replacing run-ci with simple cmake build

* cmake fix

* removing codeql_config

* Adding rule for python and actions

---------

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
2025-02-13 12:55:44 -06:00
Madsen, Jonathan 0d7ca72d84 SWDEV-514449: Fix missing thread pre/post callbacks (#204)
* SWDEV-514449: Fix missing thread pre/post callbacks

- invoke pre/post-callback around internal thread creation

* Update changelog

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-02-13 12:39:10 -06:00
Bhardwaj, Gopesh 848242eb5c SWDEV-514046 documentation build fix (#208) 2025-02-13 09:25:30 -06:00
Welton, Benjamin 27c4277222 Update VERSION (#207)
* Update VERSION

Update version to 0.7.0

* Fixing test install build step issue

* Updates from editor

---------

Co-authored-by: Ammar ELWazir <Ammar.ELWazir@amd.com>
2025-02-13 08:51:10 -06:00
David Galiffi 349c7d3de6 Add note to documentation about Perfetto workaround (#103)
Users viewing the "latest" documentation may still be using a version of omnitrace / rocprofiler-systems prior to 6.3.1. Re-add this warning so it is easier to find a workaround.
2025-02-12 21:16:00 -05:00
Jakaraddi, Manjunath c77596b703 SWDEV-499989: Conversion Script to change counter collection output format from v3 to v1 (#107)
* SWDEV-499989: Add script to convert rocprofv3 counter collection output format to that of v1

* Add logging and argparsing

* Dropping duplicated counters in pmc multiple lines

* Adding test for conversion

* moving conversion script to test files

* copy conversion script from scripts folder
2025-02-12 11:31:17 -08:00
Trowbridge, Ian cc0c401615 Memory Allocation Counter Track Shows Total Allocation (#71)
* Counter track for memory allocation is now a running sum showing total allocation

* Address review comments

* Update source/lib/output/generatePerfetto.cpp

Co-authored-by: Meserve, Mark <Mark.Meserve@amd.com>

* Updated to reflect review comments

* Fix compilation errors on CI

* remove braces on scalar

* Fix struct compilation issues

* Removed name_to_id for sanitizer

---------

Co-authored-by: Meserve, Mark <Mark.Meserve@amd.com>
2025-02-12 12:59:53 -06:00
Nagaraj, Sriraksha 5d0b220c37 target cu to string input (#198)
* target cu to string input

* review comments

* review comments
2025-02-12 12:51:39 -06:00
Kandula, Venkateshwar reddy 6427fbafc2 Accum_vgpr support in Rocprofv3 (#70)
* output accumulate vgpr count

* fix logic for computing accum_vgpr

* add accum_vgpr to csv.

* accumulation vgpr's docs and support for rocprofv3

* CHANGELOG.md

---------

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
Co-authored-by: Elwazir, Ammar <Ammar.Elwazir@amd.com>
2025-02-12 10:47:46 -08:00
Bhardwaj, Gopesh 075d36eb82 output format envs doc update (#173) 2025-02-11 21:37:12 -06:00
Baraldi, Giovanni 831e469320 SWDEV-513725: Update readme for gfx11+ power states (#193)
* Update readme

* Update README.md

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Address review comments

* Update README.md

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
2025-02-11 18:12:41 -06:00
Madsen, Jonathan 59b41ab5aa rocprofv3: Update rocprofv3 command line for ATT (#201)
* rocprofv3: suppress agent info when no data collected

* Update output config serialization

- full serialization of output configuration

* Update rocprofiler-sdk-att/tests

- add version and soversion
- change output directory
- generate libatt_decoder_summary
- disable tests instead of removing them

* Update rocprofv3 command-line

- make --att-library-path hidden by default
- simplify check_att_capability
- reorder pc sampling options
- add hidden --echo option
- remove ROCPROF_LIST_AVAIL_TOOL_LIBRARY from preload

* Add new rocprofv3 tests for specify the ATT library path

* Tweak to rocprofv3-test-hsa-multiqueue-att tests

* Update rocprofv3 tool to enable output with att

* Fix standalone test installation

* Revert to fetchcontent_makeavailable to fetchcontent_populate

* Revert tests/common/CMakeLists.txt

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-02-11 18:10:48 -06:00
David Galiffi 3833c8d162 Fix hang in config file generation (#101)
- Updated Timemory module.
- Fixes a crash when running rocprof-sys-avail -G without explicitly providing -F <format>. The default value of "txt" was not being used.
- Define "choices" before "default" when defining the "--config-format" argument in the parser.
2025-02-11 17:36:31 -05:00
Madsen, Jonathan 6246ec4040 SDK: Agent UUIDs, agent runtime visibility, kernel symbol address (#154)
* [DO NOT MERGE] Misc UUID updates

- this is WIP

* Agent visibility

- Support for ROCR_VISIBLE_DEVICES, HIP_VISIBLE_DEVICES, CUDA_VISIBLE_DEVICES, GPU_DEVICE_ORDINAL

* Update CHANGELOG

* tweak to rocprofiler_agent_runtime_visiblity_t

* Code object kernel address

- new fields in code_object_kernel_symbol_register_data_t
  - kernel_code_entry_byte_offset
  - kernel_address

* Support ROCR_VISIBLE_DEVICES reordering devices for HIP

* Addressed code review changes

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-02-11 14:36:23 -06:00
Madsen, Jonathan 3071199386 rocprofv3: do not abort if counter does not have dimensions (#150)
* rocprofv3: do not abort if counter does not have dimensions

* Relax error handling further in rocprofv3 metadata

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-02-11 14:31:25 -06:00
Kandula, Venkateshwar reddy 143f84fe6b [BUG FIX] store dimensions in counter id when used reduce operator (#181)
* save other dimension in counter id.

* Formating

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
2025-02-11 13:05:57 -06:00
Sajina PK 697d1ac02f Add support for VA-API and rocDecode tracing (#92)
- VA API tracing using Timemory gotcha wrappers.
- rocDecode API tracing integration using callback to ROCPROFILER_CALLBACK_TRACING_ROCDECODE_API
- Updated videodecode ctest to validate rocDecode APIs in perfetto trace.
2025-02-11 13:08:23 -05:00
cfallows-amd c03cbf2389 Update CHANGELOG and docs 2025-02-11 10:46:33 -07:00
Madsen, Jonathan 070b659a9a Re-enable clang-tidy for core workflows + clang-tidy fixes (#197)
* Ensure the clang-tidy is updated + clang-tidy fixes

* update-ci workflow

* Enable clang-tidy checks

* Add extra logging to device counter collection samples

* Misc clang-tidy fixes

* Disable device counter collection samples for ThreadSanitizer

* Formatting

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-02-11 10:58:47 -06:00
Arif, Maisam 552f15a1fb Fixed RDC to work with updated amdsmi_get_power_info() (#115)
Change-Id: Ic9e7a68ae58f61dbe73fc7d1b17af34152933e71

Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
2025-02-11 00:51:29 -06:00
Bhardwaj, Gopesh cdf22eba7d Adding pc sampling how to guide (#160)
* Adding pc sampling how to guide

* doc update

* Fixing indentation

* updating index

* udpating doc

* updating doc

* Added field information

* Fixing Formatting

* fix formatting error

* Added json format for pc sampling

* feedback resolved

* formatting for text

* PC Sampling API doc

* Reformatted

* Note for shared systems

* update docs

* correcting relative path for cross-referencing

---------

Co-authored-by: vlaindic_amdeng <vladimir.indic@amd.com>
2025-02-10 20:33:05 -06:00
Elwazir, Ammar c478c24616 Disabling Mi325 temp. (#199) 2025-02-10 20:07:20 -06:00
ywang103-amd 5ee37b3353 fix crash for running rocprofv3 on mi100 (#557)
* initial hack to fix for v3 stucking on mi100 becasue of -m parameter and missing counter csv file

* proper formating

* refactored profiler option function to take soc arch

* resolve missing step that casued error for profiler option

* fix typo of arch name

* change method of putting soc info into profiler option

* isort and black format

* add comment for the part that handles missing counter csv file

* remove unncecessary import

---------

Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>
2025-02-10 17:59:03 -05:00
xuchen-amd 6391b3ca76 Change profiler mode trace options, the different trace modes (kernel, kokkos (marker), and hip) are now exclusive of each other based on rocprofv3 updates. (#561) 2025-02-10 16:11:03 -05:00
Harish Kasiviswanathan 2a64fa5e06 libhsakmt: gfx950: Add option to enable HIGH_PRECISION
Environment variable HSA_HIGH_PRECISION_MODE can be used to control MFMA
precision

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: Ib78dd9dd8867025e090a3cca96ab6db4f65dea12
2025-02-10 16:05:25 -05:00
Welton, Benjamin 080b2ba451 [SWDEV-513658] Force HSA_AMD_MEMORY_POOL_EXECUTABLE_FLAG value to be used with HSA calls (#192)
* Force HSA_AMD_MEMORY_POOL_EXECUTABLE_FLAG  value to be used with HSA calls

Fix for CI

* More tweaks

* Increase reproducible-runtime kernel sleep granularity

* Fix data race in synchronous device counter collection sample

* Update device counting service

- add get_active_context function

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-02-10 11:34:26 -06:00
Indic, Vladimir e67a4451d8 Show host-trap configurations only (#194) 2025-02-10 11:32:53 -06:00
Bhardwaj, Gopesh 0bb6be99cb Disbaling #pragma deprecation warnings (#11) 2025-02-10 10:11:17 -06:00
Pryor, Adam 93a8ab8915 SWDEV-512736 Fix RDC Policy callback printout (#114)
Change-Id: I6e018dcb0a6b272812c959649d913e3ba33def40
2025-02-10 08:40:03 -06:00
benrichard-amd 0607268260 Obey CMAKE_BUILD_TYPE
Obey CMAKE_BUILD_TYPE when it is passed on the command line. Previous
behavior remains:

Debug by default
ROCRTST_BLD_TYPE can set build type
2025-02-08 13:33:12 -05:00
Elwazir, Ammar 5410fabd3d Fixing Clang tidy errors (#195)
* Fixing Clang tidy errors

* format-fix

* Update code_object.hpp

* Clang Tidy Fixes on the whole Source folder

* Update source/CMakeLists.txt

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Addressing reviews

* Correcting the logic for parsing att counters

* Format Fix

* Update source/lib/rocprofiler-sdk-att/tests/dummy_decoder.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk-att/tests/standalone_tool_main.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk-tool/config.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Formatting

* Deactivate clang-tidy in source/lib/rocprofiler-sdk-att/tests

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-02-07 22:33:32 -06:00
David Galiffi e437200e9e Remove remaining roctracer references (#82) 2025-02-07 23:27:58 -05:00
Elwazir, Ammar 5d6d089c53 Adding Public Sync GH Action (#6)
Adding Public Sync to ROCTracer

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
2025-02-07 20:20:48 -06:00
Elwazir, Ammar 835e466b65 Temp: Disable Navi3/4 from CI (#196)
Update continuous_integration.yml
2025-02-07 15:21:14 -06:00
vedithal-amd bceddb0943 Add broken mclk workaround for all arch #453 (#556)
* Add the missing commit from #453

* Remove unnecessary conditional and use 'is' operator

Co-authored-by: Richard Ben <ben.richard@amd.com>
2025-02-07 14:54:17 -05:00
Ranjith Ramakrishnan 3be9c49b63 CMake: Add package conflict for the deprecated package hsakmt
For debian use cases, package conflict is required to remove the
deprecated package during package upgrade Also removed the duplicate
setting of package obseletes in RPM usecase.
2025-02-07 11:57:32 -05:00
David Galiffi b3eee295dd Revert "Upgrade ROCm-SMI to AMD SMI (#86)" (#100)
This reverts commit 0c32dfd6bc.
2025-02-07 11:45:26 -05:00
Elwazir, Ammar 5891f34f85 Adding Public Sync GH Action (#10)
Adding Public Sync to ROCProfiler

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
2025-02-07 09:11:51 -06:00
Bhardwaj, Gopesh 7821657d65 SWDEV-510794 Adding MPI usage with rocprofv3 (#183)
* swdev-510794 Adding MPI usage with rocprofv3

* update doc

* Fixed build issues

* updating doc

* doc update

* Fixed Typos

* csv format

* change format to shell
2025-02-07 12:01:31 +05:30
Saleel Kudchadker 890399a7cf rocr: Skip uSleep for non-interrupt signals
- When waiting on non-interrupt signals, do not uSleep. This causes
  regressions compared to interrupt signal usage.
- Cleanup code.

Change-Id: I706bda0b13e64ffec0b607c1915d8380a2ce0dea
2025-02-06 23:48:35 -05:00