Commit Graph

8920 Commits

Author SHA1 Message Date
Giovanni LB b93d5e7e79 SWDEV-432445: Handling multiple agents for ATT
Change-Id: I41d30baf2c469d8ddb58e3385b88a7b04a30422e
2023-12-12 17:43:24 -05:00
Giovanni LB edf93d48ab SWDEV-432445: ATT continuous mode update part2. Added codeobj tracking.
Change-Id: I1b58af70d221bbeb9b4cab960d26357a504045dd
2023-12-12 17:40:59 -05:00
dependabot[bot] 9f821652bd Bump actions/deploy-pages from 2 to 3 (#285)
Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 2 to 3.
- [Release notes](https://github.com/actions/deploy-pages/releases)
- [Commits](https://github.com/actions/deploy-pages/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/deploy-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-12 13:44:53 -06:00
dependabot[bot] 93e3ca7660 Bump actions/setup-python from 4 to 5 (#284)
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-12 13:44:37 -06:00
dependabot[bot] a6754ceac7 Bump actions/configure-pages from 3 to 4 (#283)
Bumps [actions/configure-pages](https://github.com/actions/configure-pages) from 3 to 4.
- [Release notes](https://github.com/actions/configure-pages/releases)
- [Commits](https://github.com/actions/configure-pages/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/configure-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-12 13:44:17 -06:00
Galantsev, Dmitrii 82e4ea3b6f SWDEV-436561 - Add CODEOWNERS
Change-Id: Ie806f1ba714a88643c0e5f9cb65bf70f8d59f1fb
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-12-12 12:07:47 -06:00
Galantsev, Dmitrii 8615d096c3 SWDEV-436561 - Add CODEOWNERS
Change-Id: I4201a0fa76f61dd56c84d644bca049f9846b27fe
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-12-12 11:18:23 -06:00
Vladimir Indic 0666f6a197 AmdExtTable updated (#292)
* AmdExtTable updated

* hsa_amd_agent_set_async_scratch_limit introduced

* source formatting (clang-format v11) (#294)

Co-authored-by: vlaindic <vlaindic@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com>
2023-12-12 10:36:38 -06:00
Giovanni LB aba6a1d986 SWDEV-432445: ATT continuous mode
Change-Id: I52732fc1dba41df3373ef6a19a428b00d729bf04
2023-12-12 10:55:23 -03:00
colramos-amd 97c5b2c0a1 Add a supported_archs property to Omniperf base class
Signed-off-by: colramos-amd <colramos@amd.com>
2023-12-11 16:49:06 -06:00
colramos-amd fbe6b2d683 Move perfmon_configs dir into omniperf_soc dir. Rename config dirs for clarity
Signed-off-by: colramos-amd <colramos@amd.com>
2023-12-11 16:49:06 -06:00
colramos-amd b99d448d3b Move error logging to util.py
Signed-off-by: colramos-amd <colramos@amd.com>
2023-12-11 16:49:06 -06:00
Karl W Schulz eaae69e2a6 fix comment typo
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2023-12-11 16:49:06 -06:00
colramos-amd 57a63b6eb1 Initial overhaul of Analyze mode. Basic CLI is enabled.
Signed-off-by: colramos-amd <colramos@amd.com>
2023-12-11 16:49:06 -06:00
Benjamin Welton d2a6eec1bf Added kernel id to enqueue callback for kernel dispatch (#276)
Adds kernel id as parameter to rocprofiler_profile_counting_dispatch_callback_t.
Small cleanup of code in core.cpp.
2023-12-11 09:13:48 -08:00
vlaindic 8d80b2969d SWDEV-428255: CTF plugin shows hipDeviceReset
rocprofv2's CTF plugin is adapted to show hipDeviceReset in the
HIP API trace. Credits to Philippe Proulx <pproulx@efficios.com>

Change-Id: I870458758402e76f736007f8f2ca807059a02559
2023-12-11 08:56:10 +01:00
Sam Wu 5890852ff1 Standardize documentation for ReadtheDocs
Relates to https://github.com/RadeonOpenCompute/rocm-docs-core/issues/330

Change-Id: Ic9370548bb8d919376b20f7e1800fe620369e69b
2023-12-08 16:56:59 -05:00
gaba 4bf73f521b libhsakmt: Fix CPU cache issue
For "Intel Meteor lake Mobile", the cache info is not in sysfs,
    That means /sys/devices/system/node/node%d/%s/cache is not exist,
    but system working fine.

Change-Id: Ie7c04426791a84c2288ff21df093226828a5f629
Signed-off-by: Gang Ba <Gang.Ba@amd.com>
2023-12-08 15:29:19 -05:00
Vladimir Indic 200be03bb4 pcs parser: includes fixed, GLOB removed (#286)
* pcs parser: includes fixed, GLOB removed

* source formatting (clang-format v11) (#287)

Co-authored-by: vlaindic <vlaindic@users.noreply.github.com>

* cmake formatting (cmake-format) (#288)

Co-authored-by: vlaindic <vlaindic@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com>
2023-12-08 17:36:32 +01:00
Benjamin Welton efbb154515 Fix clock check for reproducible runtime (#281)
* Fix clock check for reproducible runtime

* source formatting (clang-format v11) (#282)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
2023-12-08 01:25:23 -08:00
Karl W Schulz 98b18d9f39 disable coverage comment
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2023-12-07 17:30:07 -06:00
Karl W Schulz 7f0fbc0a9a update vcopy execution in profile testing mode to match latest
command-line usage

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2023-12-07 17:15:03 -06:00
Giovanni Lenzi Baraldi cce7fda5fb Gbaraldi/pcparser2 (#266)
* Rollback PCparser. Separated GFX9 and ID tests. Fixed flags for GFX9 tests.

* Removing C++ header from rocr.h. Fixing CMakeLists.

* Moved PCS benchmark to separate unit.

* Fixed workgrouP naming

* Adding inline on header functions

* Fixing pull conflicts.

* source formatting (clang-format v11) (#268)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

* cmake formatting (cmake-format) (#267)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

* Removed leftover rocprofiler folder for pcparser

* Adding <array> header on translation.hpp

* Fixing PCS test names.

* Chaging parser tests failure to the status_t value

* Renaming pcs_parser tests

* Removing benchmark test

* Adding const to a few variables

* source formatting (clang-format v11) (#269)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>
2023-12-07 19:42:56 -03:00
Karl W Schulz 3ba5f1d337 Update return code error checks for roofline-only analysis on MI100
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2023-12-07 15:57:45 -06:00
Karl W Schulz 9b4b6aee8e restore formal call to sys.exit() in top-level main; this is needed
for companion testing collateral which expects SystemExit exceptions
to be raised.

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2023-12-07 14:40:07 -06:00
David Yat Sin c86837d8d6 Add query for agent memory and aql ext properties
Add query to return flags for GPU agent memory properties and AQL
extensions.

Implement flag to determine that GPU agent is an APU

Change-Id: Ic04c51290b2b9763e14989c117f35a2e22297453
2023-12-07 14:41:37 -05:00
Giovanni LB d5e968989c SWDEV-409155: Adding ATT plugin tests
Change-Id: I684affa4a63ed1c6fd7d8a4bb18f83697c3181a3
2023-12-07 13:01:43 -03:00
JoseSantosAMD 2bf487ca4a update CMakeLists.txt
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
2023-12-07 08:40:19 -06:00
JoseSantosAMD 92f91e4715 Enable running on mi100 and fixed typos
- Also enables RHEL9 roofline

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
2023-12-07 08:40:19 -06:00
guanyu12 6793fda4ef Merge amd-staging into amd-master 20231207
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: Ic67feea6e7d21338cc3bbd76220f03effec59cbf
2023-12-07 13:21:57 +08:00
Charis Poag c6b0c93e6f Memory partition permission denied fix
Received EACCES return for file that does not have
write access (read only). Permissions would be an
issue, but we check for sudo/root permissions early on.

Change-Id: I98615b02e4acccc59facb42225887a6b7273716b
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2023-12-06 21:51:30 -05:00
Lancelot SIX c5db063b2f trap_handler: Set status.skip_export when halting a wave
When inspecting waves on architectures where SPI may not initialize TTMP
registers, the debugger cannot reliably know if the trap handler was
entered and if it saved valuable information in TTMP registers.

This patch uses the status.skip_export bit (unused by the compute
shaders) to indicate that it got executed before halting a wave.
This is done except for gfx940, where ttmp11[31] can be used (as long as
TTMP registers are always initialized by SPI for this architecture).  It
could be possible to be more selective as architectures always
initializing TTMP registers do not require this step, but always doing
is makes maintenance simpler.

Change-Id: I314db6b37772f7daa8bd405e6662a86658d3f5e0
2023-12-06 21:20:03 -05:00
Galantsev, Dmitrii 48163b8d4f TESTS - Temporarily disable overdrive tests
Change-Id: Ice06d31e874621abf3135548eedfe2158281891d
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-12-06 19:33:17 -06:00
Benjamin Welton 35928e6008 Align calculation of cu_per_engine with compute_unit/shader_engs (#278)
* Align calculation of cu_per_engine with compute_unit/shader_engs

* source formatting (clang-format v11) (#279)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Update agent.cpp

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
2023-12-06 17:39:43 -06:00
Benjamin Welton 7ab334b432 Reduce max memory usage of buffer-parallel test (#280) 2023-12-06 14:00:22 -08:00
David Yat Sin ed1b0b9b1a Add queries for HSA Ext interface version
Change-Id: I26860fb1364cd3a33cdc9b284ac807b2702bb241
2023-12-06 13:58:52 -05:00
Youssef Aly 9f30432dd7 SWDEV-411647: enabling kernel trace flag with sys-trace option
To allow results_<XXXXX>.csv to be regenerated as it contains extra information not present in hcc_ops_trace, hip_api_trace, hsa_api_trace CSV files. The extra information is Dispatch_ID,GPU_ID,Queue_ID,PID,TID,Grid_Size,Workgroup_Size,LDS_Per_Workgroup,Scratch_Per_Workitem,Arch_VGPR,Accum_VGPR,SGPR,Wave_Size.

Change-Id: Ief371b41aa41d77397c00e6b4281568e494b26dc
2023-12-06 12:29:57 -05:00
Benjamin Welton b19b4eddc7 Reduce gate capacity further for NAVI3 cards (#277) 2023-12-06 07:55:21 -08:00
Galantsev, Dmitrii 102c2c692a TESTS - Fix overdrive error on not-supported
Change-Id: I47e7f499229b47b151f4ba4d5fa9c59ac04d6816
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-12-06 02:43:04 -06:00
Alex Sierra 803e37ded5 core dump: Generates a core dump from a fault event
Extracts and creates a core dump ELF file from a fault event, using
core dump front end.

Signed-off-by: Alex Sierra <Alex.Sierra@amd.com>
Change-Id: Ibbbe41b3d13dd3fcb90161e927d48c329cf513a9
2023-12-05 23:19:14 -05:00
Alex Sierra 54604654bd reports KFD core dump support through hsakmt API
Member added to KFDVersion to report if KFD supports core dump
mechanism. This is done through hsaKmtRuntimeEnable API call while
the topology is being built. It also dictates if core dump will be
generated by either KFD or hsa-runtime.

Signed-off-by: Alex Sierra <alex.sierra@amd.com>
Change-Id: I2e9d4166563402f78613d728446feb692c52d9d1
2023-12-05 23:19:14 -05:00
Alex Sierra 91f2a70817 core dump: ulimit check mechanism added
Core dump generation considers ulimit to generate the proper size
file.

Signed-off-by: Alex Sierra <Alex.Sierra@amd.com>
Change-Id: I61d991fc003b173f9075b66bff6a931447720695
2023-12-05 23:19:14 -05:00
Alex Sierra 514b222368 core dump: Front end core dump API
This API consists in one function to be called from a fault event at the
hsa-runtime to generate a core dump.

Signed-off-by: Alex Sierra <alex.sierra@amd.com>
Change-Id: Ib1b90d5beb13f93c4e8ebd21fd61705ebb12ca5d
2023-12-05 23:19:14 -05:00
Alex Sierra 1083d5c35f core dump: SegmentBuilder classes added
SegmentBuilder classes are used to get core dump data from the GPUs.
So far, it uses thunk API calls and smaps to collect all data from
the Hardware.

Signed-off-by: Alex Sierra <alex.sierra@amd.com>
Change-Id: I2ad70ca5a951885181d3142653b186b0f6be739e
2023-12-05 23:19:14 -05:00
Youssef Aly bfd4730cb0 Disabling Tracer Gtest: Async_mem_copy
Test fails with a generic HsA_STATUS_ERROR

Change-Id: Icf076124304797169f848cdc524f3d52f161f54e
2023-12-06 00:30:35 +00:00
colramos-amd cddc57bf08 Added missing hasattr checker
Signed-off-by: colramos-amd <colramos@amd.com>
2023-12-05 13:06:44 -06:00
Giovanni LB 71bc875ccd Adding coordinate query to aqlprofile
Change-Id: I9f2fee62a24cf2a4784ba9e8c813b7b7296d034b
2023-12-05 13:25:30 -05:00
Giovanni LB e8920cacc8 : Adding ATT API extension to aqlprofile
Change-Id: Ic511cf871d5d98638d7041ca277f945ae8ced3a5
2023-12-05 13:25:10 -05:00
Galantsev, Dmitrii 1ae7164f20 Merge amd-staging into amd-master 20231205
Change-Id: Ib8b0672f8993cfd995d567f582dd9b33d03ddac4
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-12-05 10:28:15 -06:00
Oliveira, Daniel 8e0d3d5a39 rocm_smi_lib: Fix GPU Metrics Max Elements Read Exceeded
Code changes related to the following:
  * Check smallest copy size for multi-valued metrics
  * Unit tests: gpu_metric_read
  * ROCMSMI examples

Build changes related to the following:
  * CMakeLists.txt

Change-Id: Ieb2363020fa21c93fbacd0edcc1d394eed183051
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>
2023-12-04 17:01:08 -06:00