Commit-Graf

8920 Incheckningar

Upphovsman SHA1 Meddelande Datum
colramos425 ff1b9cc540 Update min ROCm version in docs #64
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-20 12:34:55 -06:00
colramos425 9e32168a65 Merge branch 'main' of github.com:AMDResearch/omniperf into dev 2023-01-20 12:30:23 -06:00
colramos425 0c38813f33 Fix broken links in docs
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-20 12:08:49 -06:00
colramos425 1526a0e8f1 Reorganize docs with Analyze and Profile sections
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-20 11:45:20 -06:00
David Yat Sin 2c92e790f0 Add display for IOMMU Support
Change-Id: I5af127ef1f9c1ae4b3b86b9e38272eb4f032191a
2023-01-20 02:56:45 +00:00
Bill(Shuzhou) Liu f467f802ad The RAS library SIGSEGV
When librdc_ras.so is fail to find librocm_smi64.so, it will crash.

Change-Id: I611465f6b5de87cd41ba9be9bd6ae35f66d92a3b
2023-01-19 13:09:22 -06:00
colramos425 15ed9317dd Add BW label to all roof plots
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-19 12:41:13 -06:00
colramos425 813ce52fc1 Add Python dependency for static file saving
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-19 12:40:14 -06:00
David Yat Sin e30be76f37 Add query for IOMMU support
Reporting whether IOMMU V2 is supported.
IOMMU V1 support is not relevant to user, so not reporting it.

Change-Id: I77389484a87a352da9c2f7b2a5d9de264f90ee53
2023-01-19 11:33:21 -05:00
David Yat Sin 722794e258 Add memory pool query to return location
Change-Id: I240b77119d7b8ccfc5ff6a3190d6669d69f243e8
2023-01-19 08:45:05 -05:00
colramos425 fca1001a4c Modify GUI roofline to accomidate standalone option
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-18 11:46:12 -06:00
Galantsev, Dmitrii 4d35ff6092 Format DOUBLE as a fixed floating point number
previous format:
1.20758e+06
0.370689
0.00014128

new format:
1207583.000
0.371
0.000

Change-Id: I00f41d841e5e62c4b25dc5e646b6487449773e01
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-01-18 11:18:57 -05:00
Hao Zhou 0802602499 Merge amd-staging into amd-master 20230118
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I3672f4919d7636f2a9521f0364e65c0dda1c2b2b
2023-01-18 09:13:06 +08:00
Ranjith Ramakrishnan 9acba8b4a1 Split roctracer to runtime and dev/devel package
SWDEV-356024 - Development package name will have suffix dev or devel based on OS
Devel package contents - Header files, name link of public library files, html files and roctracer manual file
Runtime package contents - Versioned public library files, private library files and license file

Change-Id: I8ced3eab5d8824a66be39b9e777368506516b155
2023-01-17 14:10:58 -08:00
Ashutosh Mishra b89ee9ff8b Correcting version information
Correted version in header
for ROCm and so version.
Computed libpatchversion from
ROCm version.Corrected so
version during build

Signed-off-by: Ashutosh Mishra <ashutosh.mishra@amd.com>
Change-Id: I55ad6c69352369872a40529cd5b108cbd4cd4bb1
2023-01-17 12:44:13 -05:00
colramos425 263ca0fe77 Clean up roofline code #62
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-17 10:26:48 -06:00
colramos425 c3e3c9982b Catch any import errors from matplotlib #62
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-17 10:26:00 -06:00
colramos425 32444e43de Add mult-normalization to MFMA Arithmetic Instr Mix #68
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-17 09:46:27 -06:00
Galantsev, Dmitrii 35edaa2322 Remove rocmtools environment variable
- Set ROCMTOOLS_METRICS_PATH inside rdcd
- Add nullptr checks for rocmtools library functions

Change-Id: Ibbe4fed90df20e68b1a7971533765d831860c16f
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-01-16 19:16:26 -06:00
Elena Sakhnovitch 2b449fe58d Measure api execution time
Add new test to measure api execution time.

Change-Id: I0ad10c822bad4a2ae04b5785173b4ff21996021d
2023-01-16 17:00:36 -05:00
colramos425 c27274837e Hide kernel section in CLI output
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-16 11:33:15 -06:00
Bill(Shuzhou) Liu 99034af009 Add missing string header for memcpy
Fix compile error: ‘memcpy’ was not declared

Change-Id: I54d1849a3a18901baac1e24986b82067eb2fd6b4
2023-01-16 12:11:10 -05:00
Jonathan R. Madsen 12001d9633 Fix release workflow (#228)
- remove docs updates and release step from cpack.yml workflow
- create docs.yml workflow
- create release.yml workflow
- update source/docs/environment.yml
- add status badge for documentation
2023-01-15 23:04:15 -06:00
Jonathan R. Madsen 1f35d58f47 CPack support for ROCm 5.4 (#227)
- add ROCm 5.4 to CPack variants
2023-01-15 19:20:50 -06:00
Jonathan R. Madsen e08591d65a Fix OpenSUSE ROCm install for CPack workflow (#226)
- updates perl repo URL
2023-01-15 19:07:43 -06:00
Ranjith Ramakrishnan ba5c843b04 Split rocprofiler to runtime and dev/devel package
SWDEV-356024 - Development package name will have suffix dev or devel based on OS
Devel pacakge contents - Header files and non verioned lib file librocprofiler64.so
Runtime package contents - Binaries, xml files, python files , script files, license file, librocprof-tool.so and versioned library files

Change-Id: Id416b11f49a7d0acb917bc4936cc0cba0d101bee
2023-01-13 14:52:02 -08:00
Bill(Shuzhou) Liu 6687239cff Add the changelog
Add the CHANGELOG.md for the release.

Change-Id: Ia6f0afaece9fca4df4dd2042e7a41fd91edd853c
2023-01-13 16:07:34 -05:00
colramos425 000867e106 Comply to Python formatting
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-13 13:58:21 -06:00
colramos425 03b93fb06b Update logic in CLI baseline comparison
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-13 13:57:31 -06:00
David Yat Sin a4f898ad15 Add env variable to print image SRD contents
Add environment variable HSA_IMAGE_PRINT_SRD to print contents of SRD
registers for image functions

Change-Id: Ifb47a73dcfad8745ee7445e20de96e1021b80bd6
2023-01-13 11:01:04 -05:00
Charis Poag 4d7f3f2bc7 SWDEV-335697- Add support for dynamic partitioning
Original updates:
    * Added .gitignore to help with future commits
    * Updated/added copyrights on modified or added files
    * Updated rocm_smi.h/.cc
      - Added 3 new SMI API functions:
          rsmi_dev_compute_partition_set &
          rsmi_dev_compute_partition_get
      - Added helpful maps/enums used in
        new get/set compute_partition API calls
    * Updated rocm_smi.py
      - Added --showcomputepartition
      - Added --setcomputepartition
      - Fixed a few mistypes
    * Updated rsmiBindings.py - added helpful class/dict/list
    * Updated rocm_smi_example.cc
      - Added helpful MACRO to detect if api is not supported.
      - Added current_compute_partition set/get rocm lib calls
      - Added helpful macro to discover future RSMI errors
      - Commented out test_set_freq, was having permission issues
        on a Navi21
    * Updated rocm_smi_main.cc
      - Added helpful map to debug API calls, left in for future use
      - Added comment to better understand a non-class function returns
    * Added computepartition_read_write.cc/.h
      - Added get/set compute partition API test calls
      - Confirmed on devices that do not support the API calls, tests pass
    * Updated rocm_smi_test/main.cc
      - Calls new compute partition gtests

Added following updates from review feedback:
   * Updated rocm_smi.h/cc
       - Removed C++ API calls, adding support for both C/C++
         API calls could cause confusion and adds extra work for us
       - rsmi_dev_compute_partition_get -> Fixed an edge case where
         user gives a small buffer length size (smaller than data
         received), but does not receive the partial buffer back.
         google Tests are updated to reflect this find.
   * Updated rocm_smi_example.cc
       - Fixed test_set_freq, issue was that file was not writable.
         We now indicate this warning, so prior errors make sense.
       - General test code cleanup. Removed extra code,
         by creating loops for tests.
   * Updated rocm_smi_main.cc
     - Moved and got rid of an external reference to a map used
       for debugging RSMI enums, now is a const public reference.
   * Updated rocm_smi.py
     - Updated python code to identify NOT_SUPPORTED due to
       (currently) only a few GPU support the feature

Change-Id: I4a567acbb59d6771fb64df08d19175fe3604fd1b
2023-01-13 10:46:40 -05:00
Jonathan R. Madsen bb591c82cb HIP API and Activity Config Options + metadata JSON PID tagging (#225)
* library metadata/functions JSON

- remove always tagging metadata.json and functions.json with PID

* roctracer options for HIP API vs. HIP activity

* opensuse docker update for ROCm

- remove adding perl repo (does not exist)
2023-01-13 07:48:42 -06:00
Alexander Turek f7e3782b42 isa: Add fix for hsa_isa_iterate_wavefronts always returns 64
Currently, Wavefront::GetInfo(HSA_WAVEFRONT_INFO_SIZE.. always returns
64. Instead, return the proper wavefront size based on the ISA.

Temporarily, we only return 1 wavefront size for each ISA. As we do not
have mechanism from upper layers to determine correct wavefront when
there are multiple wavefronts supported. We are temporarily
returning 32 for all gfx1xxx cards even though they support 64 as the
kernels for gfx1xxx are compiled for wavefront-32 by default.

Change-Id: Ic6c2917b7e6d3704daf742d243f5ec7f49430de9
2023-01-12 08:40:07 -05:00
Galantsev, Dmitrii fc097d44ff SWDEV-376779 - Fix linking for rdctst
Ieb198ad96e26e89b09cb85986214a5b1451b17a6 broke linking
for rdctst and rdcd by removing "../lib/rdc" path.
This change adds it back and makes the paths more visible.

- Link librdc_ras and librdc_rocp to rdctst
- Add longer RUNPATH for rdctst to link rdc libraries

Change-Id: Id4f128c217a6de8bb67df6750ecafdb96545811b
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-01-11 19:40:59 -05:00
colramos425 7af97fc84e Comply to Python formatting
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-11 17:29:14 -06:00
colramos425 6f6c07b34f Build chart for L2 Cache per channel in GUI
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-11 17:28:23 -06:00
colramos425 f167ff3658 Tweak L2 Cache per channel config for graphic
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-11 17:26:43 -06:00
David Belanger b25867c4b8 libhsakmt: Disabled allocation of CWSR with SVM for GFX11.
This is a temporary work around for GPU hang issues observed on GFX11.

Change-Id: I98fbedbbd1c51fe402c2116b35ca548931a390c9
Signed-off-by: David Belanger <david.belanger@amd.com>
2023-01-11 17:28:31 -05:00
Shweta Khatri ed0a1be2c3 Enforce uncached memory on AllocatePCIeRW request
Change-Id: Ib5a624ab979220d50205448ef37b4550672fb97d
2023-01-11 16:52:15 -05:00
Saurabh Verma 225bddf148 Adding missing MI200 metrics
Change-Id: I410f50e03d38bb03cf43e743318eb1242e7d6518
2023-01-11 18:00:46 +00:00
Ranjith Ramakrishnan dbf8905dd1 Revert "Remove RPATH/RUNPATH from ROCm libraries"
This reverts commit ac66865385.

Reason for revert:  is blocked due to new proposal. so reverting the changes 

Change-Id: Id9b8cc1560ba3eea6e484e67df3fdc647da9f37d
2023-01-10 13:52:02 -05:00
colramos425 664a0fe366 Refine barchart data structure
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-10 11:18:18 -06:00
Jonathan R. Madsen 2096f1f0c2 Remove temporary files (#223)
* config updates

- remove temporary file when destroyed
- extend parse_numeric_range: support vector, increment, better delimit
- git version info in omnitrace banner
- use OMNITRACE_BASIC_VERBOSE instead of OMNITRACE_VERBOSE

* Fix array-bounds warning in openmp lu.cpp

* Bump version to 1.7.4

* Update run-ci.py

- options to repeat
  - until-pass (default: 3)
  - until-fail (default: None)
  - after-timeout (default: 2)
2023-01-10 01:06:12 -06:00
colramos425 e19bf4d7e1 Comply to Python formatting
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-09 16:53:41 -06:00
colramos425 42edb1c559 New GUI graphics for L1 and L2 panels
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-09 16:52:27 -06:00
Galantsev, Dmitrii 2787767bf0 SYSTEMD: Remove set -e to allow failure
'set -e' flag doesn't allow to fall back to 'return 0' when a command
fails. As installation/removal should not fail in most cases - 'set -e'
flag has been removed.

Below page recommends to be careful with 'set -e' usage:
https://www.debian.org/doc/debian-policy/ch-opersys.html#writing-the-scripts

Change-Id: If4439aaff66747bceabd3beb7e00ae12ce950e43
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-01-09 13:18:47 -06:00
Karl W. Schulz 3f6f0a2b10 Remove debug print introduced in #57
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2023-01-09 09:10:14 -05:00
Galantsev, Dmitrii 6e0c5d1d56 Fix rdcd crash on rocmtools fields read
- Solve issue that resulted in rdcd crash when reading registers 700-799
  by setting ROCMTOOLS_METRICS_PATH in rdc.service

README changes:
- Change default install path for gRPC
- Simplify install instructions
- Make more commands copy-pasteable
- Replace /opt/rocm-<version> with /opt/rocm
- Misc fixes

Change-Id: I39a2896ed2af5a3889f4b36cd8bcc8d3e9593585
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-01-06 16:39:17 -06:00
Eric Huang 505287412f Revert "libhsakmt: Remove unnecessary CPU unmap"
This reverts commit 7787a039bd.

It causes a regression in pytorch benchmark.

Change-Id: I96173dbd061cf38d6f451c02cb181ae51b7f625e
Signed-off-by: Eric Huang <jinhuieric.huang@amd.com>
2023-01-06 17:16:40 -05:00
colramos425 7d719f5624 Rename GitHub action
Signed-off-by: colramos425 <colramos@amd.com>
2023-01-06 15:33:52 -06:00