Commit Graph

8920 Commits

Author SHA1 Message Date
Cole Ramos 76623fe7e7 Merge pull request #55 from AMDResearch/dev
Merge features for v1.0.5
2022-12-12 16:43:52 -06:00
colramos425 9fa2d39f4a Using xml configs from rocprofiler
Signed-off-by: colramos425 <colramos@amd.com>
2022-12-12 16:03:40 -06:00
Karl W. Schulz c64dbb1ed8 Include bibtex reference example directly within top-level README 2022-12-12 15:55:49 -06:00
Karl W. Schulz dceabb9ddc changelog additions for next release
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2022-12-12 15:01:35 -05:00
Karl W. Schulz 477de3588a move DOI badge to top of README. Include pointer to bibtex-style generation.
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2022-12-12 14:33:55 -05:00
Karl W. Schulz 2f04b5b6b1 Only update template VERSION.sha file when running within git clone. Fixes #53.
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2022-12-12 13:28:39 -06:00
Hao Zhou 34f4b63853 Merge amd-staging into amd-master 20221212
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I555da02f58185a9eca00954755c2bfd8e418e153
2022-12-12 16:25:01 +08:00
Kiumars Sabeti a9a82ee107 SWDEV-369023: Added two new counters SQ_INSTS_TEX_LOAD and SQ_INSTS_TEX_STORE for gfx10.These two new counters are replacement for SQ_INSTS_VMEM_RD and SQ_INSTS_VMEM_WR which are not supported in gfx10 architecture
Change-Id: I4c4101eea27f9073492ae42c70a30a002f4d8834
2022-12-09 20:41:45 -05:00
Nirmal Unnikrishnan 38959daacd SWDEV-354524 : Changing the module file name.
Now modules can be loaded as module load rocm/x.x.x

Change-Id: I6fe5b5fb9bb852a2bfac9b69ac0c96b75d4fb959
2022-12-08 22:16:27 -06:00
Alex Sierra f2bda56d04 Revert "src: use SVM mechanism to register userptr memory"
This reverts commit 178a619b80.
There are some openMP issues that were introduced after SVM userptr
feature was added.

Signed-off-by: Alex Sierra <Alex.Sierra@amd.com>
Change-Id: I7ef87c5232a3bcbe594c743fa4b4958601845ba5
2022-12-08 17:33:51 -06:00
Alex Sierra d9f86ae02b Revert "libhsakmt: query svm info from userptrs at fault events"
This reverts commit 45fad29752.
There are some openMP issues that were introduced after SVM userptr
feature was added.

Signed-off-by: Alex Sierra <Alex.Sierra@amd.com>
Change-Id: I6566c9f0d39d05ecb92f38159880763f432939a5
2022-12-08 17:33:50 -06:00
Alex Sierra 21e95a4f2a Revert "libhsakmt: add env var to en/dis registration through SVM"
This reverts commit 8a746bdaed.
There are some openMP issues that were introduced after SVM userptr
feature was added.

Signed-off-by: Alex Sierra <Alex.Sierra@amd.com>
Change-Id: Ib01046571d2c84fa0fd228ecba0dee0eae3f994d
2022-12-08 17:33:48 -06:00
David Yat Sin 6bfe57aeb2 Add Stream Performance Monitor(SPM) APIs
Change-Id: I0d48782887814ef245b7e0182e2d5570aa8c3f50
2022-12-08 13:56:29 -05:00
kent.russell@amd.com 248c6f79f4 rocm_smi.py: Fix order of CE and UE reporting
We append CE then UE, but in the table right after, it goes UE then CE.
Fix the order of the table, and add capitals for consistency

Change-Id: I208f37685508ab1e2ff83d3456620bbbf3a16268
2022-12-08 12:28:37 -05:00
David Yat Sin ecdebef0b9 Add agent info for fw and sdma ucode
Add two new agent info fields:
HSA_AMD_AGENT_INFO_UCODE_VERSION
HSA_AMD_AGENT_INFO_SDMA_UCODE_VERSION

Change-Id: I51cb853724b23a26e945e5c1ac32c16d0cb3bc31
2022-12-07 19:07:31 -05:00
Cole Ramos 7aa073d91c Merge pull request #50 from AMDResearch/python-logging
Python subprocess logging
2022-12-06 16:22:17 -06:00
colramos-amd efe6d9f19a Throw a warning if unable to update timestamps
Signed-off-by: colramos-amd <colramos@amd.com>
2022-12-06 15:24:36 -06:00
colramos-amd 99d603b9dd Merge branch 'dev' of github.com:AMDResearch/omniperf into python-logging 2022-12-06 14:50:14 -06:00
Cole Ramos 8741bb0930 Merge pull request #49 from AMDResearch/37-add-l1-l2-bw
Add metric for L1-L2 BW
2022-12-06 14:34:16 -06:00
colramos-amd b0542923e2 Add L1-L2 BW metric to configs and dashboard #37
Signed-off-by: colramos-amd <colramos@amd.com>
2022-12-06 13:44:00 -06:00
Cole Ramos 80b03bc8a5 Merge pull request #48 from AMDResearch/36-update-l1-bw-calculations
Update L1D BW calculations
2022-12-06 11:36:24 -06:00
colramos425 5cd0503a11 Merge branch 'dev' of github.com:AMDResearch/omniperf into python-logging 2022-12-06 10:38:10 -06:00
colramos425 0b01dc7ec7 Add VL1D BW to the L1D Cache Accesses table
Signed-off-by: colramos425 <colramos@amd.com>
2022-12-06 10:32:23 -06:00
Laurent Morichetti 91b449d0d5 SWDEV-361912 - Fix kernel demangling
Older GNU C++ runtimes cannot demangle symbol names generated by recent
versions of LLVM. To work around this issue, use the LLVM demangler to
process kernel names.

Change-Id: I595f900d06360bb5acce542955cf1f5aed81f00e
2022-12-05 20:36:04 -08:00
Bill(Shuzhou) Liu 73d8b35610 gcc error when const is used
Change to #define to be compatible with gcc.

Change-Id: Id2a2b3dbeaaf7aea9b0e2075320c30f8bad50fc7
2022-12-05 16:27:59 -06:00
raghavmedicherla 5727a10a1b [hsa-runtime] Modify elfsection checks in amd_elf_image class
Modified If condition checks in GElfImage::pullElf() of amd_elf_image.cpp to
 check using section types instead of a string check.

Change-Id: I1ab92f0a9118fb2382652a1cc900a3150cbee2da
2022-12-05 14:42:02 -05:00
colramos425 a2149871ff Comply to Python formatting
Signed-off-by: colramos425 <colramos@amd.com>
2022-12-02 12:02:00 -06:00
colramos425 f9f8b749c8 Merge branch '30-multi-normalization' into dev
Signed-off-by: colramos425 <colramos@amd.com>
2022-12-02 11:56:56 -06:00
Ashutosh Mishra 6abd8b4da4 Adding version info
External modules are dependant on
scraping .info/version file for
their processing. This change is
putting the file back for the same.

Signed-off-by: Ashutosh Mishra <ashutosh.mishra@amd.com>
Change-Id: I0a5b7b9c1e9902de6c374d770c6ba4b29e62c2fe
2022-12-02 22:43:40 +05:30
David Yat Sin e39ad34d9c Check for debug support after parsing topology
Thunk keeps an internal cache of system topology that can be used to
speed up subsequent calls to hsaKmtAcquireSystemProperties(). This cache
is cleared by calling hsaKmtReleaseSystemProperties() at the beginning
of BuildTopology().
hsaKmtRuntimeEnable() also calls hsaKmtAcquireSystemProperties() inside
Thunk. Move call to hsaKmtRuntimeEnable() after BuildTopology() so that
we can re-use Thunks internal cache.
Parsing of of topology can take ~150 ms on systems for large number of
nodes.

Change-Id: I741709d49d67d244f5fbd707fe8f01ab923bb153
2022-12-02 11:26:00 -05:00
colramos-amd c32e2f9141 Lock Grafana UI dependencies to specific version
Signed-off-by: colramos-amd <colramos@amd.com>
2022-12-01 15:45:59 -06:00
James Zhu 7db29c4797 kfdtest: track Test Status in syslog
Track Test Status in syslog, it will help understand
sys log assoicated with test cases.

Change-Id: I7c0749102db9bc73d6ae3a237ec347a8fefb12e9
Signed-off-by: James Zhu <James.Zhu@amd.com>
2022-11-29 17:46:40 -05:00
Ashutosh Mishra 68c763f3d0 Inital commit of the new lib package
Signed-off-by: Ashutosh Mishra <ashutosh.mishra@amd.com>
Change-Id: I605c3fb56584806dc6b392230e64d304449819f6
2022-11-29 00:25:06 -05:00
Felix Kuehling 7787a039bd libhsakmt: Remove unnecessary CPU unmap
This is handled by __fmm_release calling aperture_release_area.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Change-Id: Ib8ed300e1734f03aeb9dfc8074897ece310b8af9
2022-11-28 17:18:13 -05:00
Felix Kuehling 73b0fb3d7c libhsakmt: Refactor and clean up CPU mappings
Use a common helper for CPU mappings to reduce duplicate code.
Consistently use MAP_SHARED for all render_fd mappings.
Remove double-mapping for AQL queue buffers on the CPU. This workaround
is only needed on the GPU.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Change-Id: Iff86c8cc9f1e5c982614b3f11129bc2cf8cbba02
2022-11-28 17:18:05 -05:00
Felix Kuehling 2d53430ce3 libhsakmt: Fix and simplify debug_get_reg_status
The NULL pointer check was the only way for that function to fail. And it
was done after the pointer was accessed. Simplify this by just returning
the result as a return value instead of using a pointer as output
parameter. This way the function can never fail and the caller doesn't
need to do any error handling.

Declare the function in libhsakmt.h instead of duplicating the
declaration in fmm.c.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Change-Id: I91b90d66166fd3b5cdc47c73a9bbc369c45b51fe
2022-11-28 17:17:43 -05:00
Cole Ramos cc6c639dac Merge pull request #43 from AMDResearch/36-update-l1-bw-calculations
Update calc for L1 Cache BW
2022-11-28 11:47:03 -08:00
colramos-amd 7b09d94684 Update calc for L1 Cache BW #36
Signed-off-by: colramos-amd <colramos@amd.com>
2022-11-28 13:27:53 -06:00
Alex Sierra 8a746bdaed libhsakmt: add env var to en/dis registration through SVM
Setting this variable to '0' will force to disable memory
registration/allocation through SVM API mechanism.
Not setting this or setting to '1', SVM API will be used only if all
GPUs support it.

Signed-off-by: Alex Sierra <Alex.Sierra@amd.com>
Change-Id: Icdf7656de09aa9988b567ec6c024953398e9bb48
2022-11-28 13:42:43 -05:00
colramos-amd 9af8a595b7 Add clarifications to docs (#38 & #41)
Signed-off-by: colramos-amd <colramos@amd.com>
2022-11-28 10:55:06 -06:00
Daniel Phillips e71eb13784 kfdtest: Also detect under-reporting of available memory
Detect under-reporting of available memory by initially attempting to
allocate substantially more than reported available memory, and ensure
that the allocation fails. Continue shrinking the attempted allocation
until it succeeds, then fail the test if the successful allocation is
either too much more than or too much less than reported available.

Signed-off-by: Daniel Phillips <daniel.phillips@amd.com>
Change-Id: Ib418f0aa26e8db80590a6c5f2578da56a4b60f2b
2022-11-28 11:43:48 -05:00
Felix Kuehling 8e69b9c70e libhsakmt: Fix use of uninitialized variable
When is hsaKmtCreateQueue called first time for node
doorbells[NodeId].size is initialized to zero in init_process_doorbells
but used to calculate the doorbell offset. It works just by accident
because doorbells[NodeId].size is uint32_t so -1 will be 0xFFFFFFFF which
is zero extended into 0x00000000FFFFFFFF and it will work as long as mmap
offset bits are not within lower 32 bits.

Bug: https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/issues/78
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Change-Id: Ia791adfc51363d4704cb50fa4f01137b7dd48a75
2022-11-25 14:07:45 -05:00
Eric Huang 8e8aa024fd kfdtest: remove scc test in MapUnmapToNodes for gfx90a A+A
Modifier scc is disabled from gfx90a's asm, so remove the
shader for gfx90a A+A and keep it for newer asics with scc
support.

Signed-off-by: Eric Huang <jinhuieric.huang@amd.com>
Change-Id: Iec3c7ccd5156a855adb2b02feb3db0761876aa2f
2022-11-25 13:55:28 -05:00
David Yat Sin f46ddb7ead libhsakmt: Initialize fd to -1
Fix compile error due to warning in some environments

Change-Id: Ie5fcfabb872c27c0de349eb215345b997fae7201
2022-11-25 15:01:53 +00:00
Hao Zhou 3a5765fbcf Merge amd-staging into amd-master 20221124
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: Iff6f3f5c66a33f703588b2afbf767777564c178b
2022-11-24 17:18:44 +08:00
Karl W. Schulz 1cda5ff30e cmake-format por favor to keep the bots happy
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2022-11-23 15:52:56 -06:00
Karl W. Schulz 4f5998397d Update error message to be more accurate when roofline binary is
missing (but with a supported OS and rocm version).  In response to
debugging #34 a second time.

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2022-11-23 15:41:18 -06:00
Ranjith Ramakrishnan 01fd84db5e Change pragma message to warning
File reorganization feature was implemented with backward compatibility
The backward compatibility support will be deprecated in future release.
Changed the #pragma message to #warning for a smooth transition

Change-Id: I21025f4cefb40721f095130263b4247877979d36
2022-11-23 13:06:34 -05:00
Ranjith Ramakrishnan ca1726f80d SWDEV-366823 - Change pragma message to warning
File reorganization feature was implemented with backward compatibility
The backward compatibility support will be deprecated in future release.
Changed the #pragma message to #warning for a smooth transition

Change-Id: I85e14470cce0f3d7c14ecb40e0e9e8b29c977c9f
2022-11-22 14:10:34 -05:00
Bill(Shuzhou) Liu 76b5528feb Remove the shared mutex if no process is using it
If the code is crashed and the mutex may be in bad status. The user
has to mannually remove it. The fix will remove the shared mutex
if no process is using it.

Change-Id: I18bf562f2e0a7de8b3f0cccf72d60950b0d9bb2d
2022-11-22 10:30:58 -05:00