Graf commitů

6039 Commity

Autor SHA1 Zpráva Datum
Rahul Garg 93b53dc6fa Revert "SWDEV-289854 - Revert to using hardcoded library destination"
This reverts commit ed9e4ee7df.

Reason for revert: Reverting this change to enable split project flow working. Once that is enabled this change will be submitted in hipamd project.

Change-Id: Iad2e044a173787a57a80c5a3d04795e7c2dc5ad5
2021-06-09 16:31:10 -04:00
Vladislav Sytchenko ed9e4ee7df SWDEV-289854 - Revert to using hardcoded library destination
Current packaging assumes that HIP runtime will always be installed in
/opt/rocm/lib. This is false to assume, because some distros like CentOS
will use the lib64 directory instead of lib. Relying on CMake to choose
the library directory for us will default in that case to lib64. Hence
there will be a mismatch between where HIP is installed and where CMake
thinks it is.

Change-Id: If6f881eab027bdbe8435d3de5295b00277e96a6a
2021-06-08 10:11:47 -04:00
jujiang d8b2571d47 SWDEV-288929 - Add atomic system functions in HIP doc
Change-Id: Ic9ec276c1c486c4e1d3b83e1578081673f97efa2
2021-06-07 18:00:24 -04:00
cjatin 575be36c2e SWDEV-245414 - Add Copyright and exlude mipmap test on Nvidia platform
Change-Id: Iba29caa0e9021488378625506197384c275a3282
2021-06-07 11:15:00 -04:00
Rahul Garg 5d5e57ed60 SWDEV-288707 - Move amdhip.def
Change-Id: I77f9519d0d098b9cfdd1d09f67b3ab38d848620b
2021-06-07 05:16:16 +00:00
Rahul Garg ce76ec8b88 SWDEV-288707 - Merge HIP refactored code to staging
These changes move-
- rocclr based implementation inside src/hipamd/src
- platform specific (both nvidia and amd) headers inside
src/hipamd/include/hip

Change-Id: Ia29791a727244952591fe1d813dcef0303b73a9e
2021-06-07 00:07:24 +00:00
Tao Sang 792415f960 SWDEV-287768 - Fix hipTestClock test
Use long long instead of int as clock64() return.

Change-Id: Id3e4645c05959e13f58efd88bc43f3a1d3e50d59
2021-06-04 15:45:07 -04:00
Aaron En Ye Shi b982637965 SWDEV-283266 - Fix hipRTC script bugs
Remove extra -isystem causing --cuda-device-only flag
to be dropped. Fix missing __hipRTC_header_size symbol.
Add macros which were consumed during pre-processor
generation. Add INT_MAX and CHAR_BIT macros used in
HIP headers.

Change-Id: Id5143e3c8a2b1e7c78658ba84d5ab3b55ac1fa72
2021-06-04 13:58:32 -04:00
Saleel Kudchadker 995706ec7b SWDEV-286092 - Guarantee flush for event record
Every event record will guarantee completion when its called.

Change-Id: I8de34714a4ca2e105f36de2818e95ec2903143ce
2021-06-03 15:41:28 -07:00
cjatin d8ca73da6a SWDEV-277697 - Fix ununsed variable error with -Werror,-Wunused-parameter
Change-Id: Iadd0050e6cf4e4858e1508c1f24f73732a1af443
2021-06-03 13:25:07 -04:00
jujiang 52b4faef3b SWDEV-279885 - correct HIP doc for managed memory
Change-Id: I94bb307dbe12692eb60cce744424fb18deea28ba
2021-06-03 11:05:18 -04:00
Vladislav Sytchenko 118714d1b6 SWDEV-273235 - Correct linker export file usage
CMake doesn't handle linker export files in a general way well. On
Windows it is able to recognize a .def file and pass it to the linker.
Unfortunately it cannot do the same thing on Linux, so we have to
manually specify it.

Note that CMake can't recognize the current Windows export file due to
the .in suffix, hence why the amdhip.def file is being added. The
hip_hcc.def.in file will be removed later, as the Makefile build still
uses it.

Change-Id: Id3e4645c95959e13f50efd88bc43f3a1d3e50d58
2021-06-03 11:00:26 -04:00
Robert Maynard 641514cdb1 SWDEV-288593 - hip-config only adds compile and link options to C++
Change-Id: Iefc7c3597fc8c8864621ad6154352c9dd56a3e74
2021-06-03 00:18:12 -04:00
German Andryeyev c80955b569 SWDEV-240804 - Add hipMemAdvise() extension
Add coarse grain memory extension. The new advice will allow HMM
to disable cache coherency policy to improve performance

Change-Id: I3c792d6a96896b983a7ffccddaa0ded06d183212
2021-06-02 16:16:14 -04:00
agodavar 8ce8a7ef75 SWDEV-288510 - Add hip shared library path to run-time search for linker
Change-Id: I7eaf712c01556933b881b983a8994f4e06333116
2021-06-02 12:57:12 -04:00
Vladislav Sytchenko 00dc7068fc SWDEV-288814 - Revert back to old target naming
HIP exports the runtime target as amdhip64. This target was recently
renamed to amdhip. It is unclear as to who uses this target, as HIP
clients need to use the device/host targets instead, but we still need
to support it for backwards compatability.

Change-Id: I68b9798ab967420e0642d50621d3c8b577a05435
2021-06-01 17:37:30 -04:00
Vladislav Sytchenko b7c59cda76 SWDEV-288814 - Remove dependency on ROCclr
HIP only has a dependency on ROCclr at build time. When exporting HIP,
ROCClr is already embedded into the shared/static library. There is no
reason to search for it.

Change-Id: I8d7e8e58164e5585a1dfc9c998ecf02ca42d8aac
2021-06-01 17:37:30 -04:00
Vladislav Sytchenko 444d54df12 SWDEV-273235 - Partial cleanup of HIP installation logic
Don't install HIP source code.

Correctly install the HIP shared library based on platform. On Linux,
it will be installed to lib/, but on Windows it will be installed to
bin/. CMake will handle this for us.

Change-Id: I00cc074ad8e13b1b953b21444f0c2b5f50dc03c0
2021-06-01 17:37:30 -04:00
Vladislav Sytchenko 88242ad446 Revert "SWDEV-255979 - Enable __managed__ test for amd platform"
This reverts commit e519600383.

Change-Id: Ib1be007535dcfb24d9e4eddbdb706d3be4acc20c
2021-06-01 17:37:30 -04:00
Joseph Greathouse bec284b26a SWDEV-288361 - Implement funnel shift operators
Change-Id: I0c73809366f2d21e75f98fdeac7fed0c7591ee34
2021-06-01 11:10:11 -04:00
cjatin a47bb99db9 SWDEV-277697 - [CatchTest] Disable CXX Extensions (gnu++11 etc) on CMake
Change-Id: I17abd329c16cf0a61316186558828d0524b98281
2021-06-01 06:48:05 -04:00
Anusha GodavarthySurya d9fffacfb3 SWDEV-255979 - Add support for dynamic __managed__ variables
Change-Id: I62b790853ea3ab3b7ac57bab389046c627fdecce
2021-06-01 05:09:51 -04:00
agodavar eb2c98bb00 SWDEV-288708 - Rationalize HIP runtime and device version reporting
Change-Id: I49a7ee1fa9ae3ef5f26d99d18c0b8bb58cb9d5ce
2021-06-01 05:09:36 -04:00
Tao Sang 9ba66fc157 SWDEV-276853 - Add kernelVerify
Add kernelVerify for data verification and memory
reading performance checking in kernel.

Change-Id: Id3f9bcad75d643f493daf9d5f47b3a012a427179
2021-05-31 12:45:10 -04:00
Anusha GodavarthySurya e519600383 SWDEV-255979 - Enable __managed__ test for amd platform
Change-Id: I0cb31c1983e68e9010340770a56fc45b2a619dcd
2021-05-31 05:35:05 -04:00
Satyanvesh Dittakavi da9564e302 SWDEV-286231 - Fix hipMallocManaged tests failure
Test is modified as hipMemAttachHost is accepted now by hipMallocManaged

Change-Id: If73d210297cde7a92960eef57a902dbd6402a173
2021-05-31 04:10:47 -04:00
Anusha GodavarthySurya 5cad1c9b1b SWDEV-287027 - Improve launch bounds error log message
Change-Id: I3229580daa97f141de89bacddfce45cd43f24b19
2021-05-31 01:51:58 -04:00
German Andryeyev b01b048e08 SWDEV-240804 - Fix typos in the comments
Change-Id: Ic1385daf1e685772b02a11d43fb13f6cde74c4b7
2021-05-29 00:31:46 -04:00
Vladislav Sytchenko 080577d6bd SWDEV-273235 - Fix warning in the cmake build
Change-Id: I8f9d51ea676cb015abf47a2998fa053c2d4a6e81
2021-05-28 11:20:52 -04:00
Vladislav Sytchenko 4c36651aa1 SWDEV-273235 - Disable versioning for Windows
Not yet supported.

Change-Id: I9840120e1e5c40c6d3004229c4a5b06fd42cf4b6
2021-05-28 11:20:37 -04:00
Vladislav Sytchenko cd8d7aa230 SWDEV-273235 - Fix Windows CMake build
Change-Id: Idcf89ac20b4f275de33e9f6edd009706f8c432fb
2021-05-28 11:20:23 -04:00
Vladislav Sytchenko db4df4fb2e SWDEV-273235 - Restore 93b9384
Change-Id: Id2d3e54dc4f35974c12ecbec661a005cac90e5b1
2021-05-28 11:08:17 -04:00
German Andryeyev e43696d7ca SWDEV-287137 - Add extra blocking marker
HIP should block the stream until callback is done. This change
will introduce extra marker that will block the queue.
Note: MT path doesn't really require extra marker, but the logic
is identical to avoid extra checks for direct dispatch

Change-Id: Ib90fd2d751adf337f5e43ac6098e84767530233b
2021-05-27 21:17:18 -04:00
Vladislav Sytchenko 30f1fcaf53 SWDEV-273235 - Initial support for Windows CMake
This change is tied to the ROCclr cmake rework. ROCclr will now be built
as part of HIP itself.

All the dependencies on comgr and rocr have been moved into ROCclr
itself. This allows HIP to pull in all the required compiler/runtime
dependencies by simply linking against ROCclr. Note that ROCclr needs to
be configured from HIP cmake command line. If not, we will default to
LC + ROCr support.

Since HIP depends on ROCclr and ROCclr depends on OpenCL, HIP will
transitevly pull in all the required OpenCL headers. No need to keep a
local copy of them anymore.

Change-Id: Ib39f4929e88da1248be962490c150b10fc7abd3a
2021-05-27 15:21:05 -04:00
Anusha GodavarthySurya 093af3cf25 SWDEV-288065 - allow hipcc to recognize .C files
Change-Id: I0ec884eb6e083e823cf27ca1251c354a7f3b744c
2021-05-26 10:25:57 -07:00
Aaron En Ye Shi 93b9384529 SWDEV-283266 - Fix Linux Pro build for hiprtc
Linux Pro build uses the LLVM_ROOT variable to
specify where llvm is located. We must use a different
name, HIP_LLVM_ROOT for LLVM's prefix location.

Change-Id: I28baf8672217a438a5dd45829d9af04b3553f615
2021-05-26 10:37:44 -04:00
Tao Sang adf58d4ef1 SWDEV-288106 - Fix g++/hipMalloc
Fix a typo

Change-Id: I71328687b2dd4a3f563571f2b755079d83dca63e
2021-05-25 17:23:36 -04:00
jujiang 187a33434a SWDEV-286322 - add an attribute file to modify EOL
Change-Id: I5ca49a0107e129a2f949d767d2d6e0169140191d
2021-05-25 15:19:29 -04:00
Tao Sang 9ed71ade6e SWDEV-276853 - Add test for mem perf
Add memory filling performance test for large bar device memory,
hip managed memory, conherent/non-coherent host memory and fine
grained device memory

Change-Id: Id3f9bcad45d643e493daf9d5f47b3a012a427178
2021-05-25 12:32:44 -04:00
Jatin Chaudhary a4c9db8e17 SWDEV-277697 - Make sure hipcc can handle standard CXX options when being used with nvcc
Change-Id: I76b1f2943a660eefda858397218a775083b99228
2021-05-25 07:35:02 -04:00
Jatin Chaudhary c088ddbe7c SWDEV-277697 - [CatchTest] Fix Documentation, Add test to AMD specific, Add HIP Macros, New Binary for multiproc tests
Change-Id: I3783caf85c694b724ed55b778220b8ef9a39f84b
2021-05-25 07:12:54 -04:00
Jatin Chaudhary f7a2758bdf SWDEV-280067 - Document hipErrorNoBinaryForGpu error in hip faq
Change-Id: Ie8cab47ecac5a1b0972041d6e3e58e4fca278c41
2021-05-25 15:14:08 +05:30
Satyanvesh Dittakavi 03ae7251de SWDEV-286830 - Fix hipStreamACb_ThrdBehaviour on windows
use sleep_for which works cross-platform
for other tests as well

Change-Id: I915444d620e9fad0b9eda93bcdd244f9956ab8d5
2021-05-24 03:18:36 -04:00
Aaron En Ye Shi 3899687b8d SWDEV-283266 - Workaround RTC macro in vector types
Temporarily disable __HIPCC_RTC__ in hip_vector_types.h
while the upstream clang headers are outdated on mainline.
Once upstream patch has landed in mainline, revert this
change. This is a workaround for hiprtc testing.

Change-Id: Ib2cf6023b71431bbfbe3c699076caa4f90f7170c
2021-05-21 15:53:59 +00:00
Satyanvesh Dittakavi f300d11931 SWDEV-278464 - Update unit test hipEventMultiThreaded
Run with multiple threads to catch possible race condition
Disable running the test by default on CI as this takes lot of time

Change-Id: I1c1a66fd5c72f8d2bf7ad120461384488b46abbd
2021-05-21 02:57:14 -04:00
Satyanvesh Dittakavi acafb344c0 SWDEV-285521 - SWDEV-284626 - Fix P2P and Caffe2 test failures
- waitList was released before the awaitcompletion
causing stream sync after the async copies fail

- Enable the hipPeerToPeer_simple test

Change-Id: I1eeaa7e6320ab38c106902078f034dfec4c3f3ea
2021-05-21 02:54:22 -04:00
Aaron En Ye Shi ad570e3b99 SWDEV-283266 - Fix hipRTC mcin missing symbol
Add back the .type directive needed for ELF
format to add the section to symbol table.
For COFF format the symbol is already added
to the symbol table.

Change-Id: I4920e8dae0af23b4dcabd324b47abc228fcab10f
2021-05-20 20:24:55 +00:00
Julia Jiang f8a08e2429 SWDEV-286322 - Fix EOL in files
Change-Id: I1746e80aceeeaa4fc5df65c858f4816d99010186
2021-05-19 14:48:53 -04:00
cjatin 8084df7b49 SWDEV-277697 - Adding Infra and dependent libs: Catch2 and json parser, for new HIP Testing framework
Change-Id: Iedfa041ec9acc13eeb631ff67e1677e2fe29463d
2021-05-19 00:47:00 -04:00
kjayapra-amd 871c167fd0 SWDEV-286346 - Implement Arena Memory Object for externally created memory.
Change-Id: I1aae0d24b28eebaf7f67e941aaa475a53831e9b8
2021-05-18 10:24:40 -04:00