Satyanvesh Dittakavi
94e70bee26
SWDEV-419034 - Use MADV_HUGEPAGE for large host allocations
...
Change-Id: I80bb1839cdd47eb64a97467c8b01fcdf37195ad5
2023-08-30 14:03:26 -04:00
Juan Manuel Martinez
f3dc04a50d
SWDEV-410182: Link device-libs when compiling source to bitcode
...
This is related to SWDEV-410182, but it's not enough to fix it.
Functions from device-libs are precompiled into llvm-ir in a "target agnostic" way
(in reality, it's not 100% target agnostic, which brings us many headaches).
When linking builtins (like device-libs) from the command line, we use the flag
-mlink-builtin-bitcode. The difference between regular linking of bitcode and
this flag is that the later propagates target-specific attributes. If this
attributes are not propagated, we can end up with incosistent target attributes.
Comgr provides the action AMD_COMGR_ACTION_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC
for this exact reason. The old action is currently deprecated and this one should
be used.
Change-Id: I518415214debdf4fedf0b1d81456d6e9fb8a3d19
2023-08-30 04:24:17 -04:00
kjayapra-amd
6a0f80a03d
SWDEV-381625 - Parse compiler and linker options from environment variable.
...
Change-Id: Id5a012b678e5973c4b64dff84444a909aefae006
2023-08-29 20:24:27 -04:00
German
bd00826446
SWDEV-3 - Move PAL to version 818
...
Restore PAL platform destruction.
Update CmdAllocatorCreateInfo::AllocInfo for the new interface.
Change-Id: Iea418eed7ee26166039a4a9cc1999438856e9097
2023-08-29 12:46:28 -04:00
Jaydeep Patel
d2655d84fd
SWDEV-375596 - Device context should not be changed while graph exec update for graph nodes other than empty and host node.
...
Change-Id: I89d734b111aae5b042386175d2786ce9002771b9
2023-08-27 22:58:32 -04:00
Saleel Kudchadker
1ec0ba3537
SWDEV-301667 - Use large signal pool
...
Use large signal pool if profiler is connected or profiling forced
enabled. This is needed to mitigate signal creation overhead when
profiling as signals are attached to every packet and deeper batch may
show overhead of signal allocation.
Change-Id: I8034b8a20b55328b87d593bf044f59672f9653e8
2023-08-24 19:17:05 -04:00
German
077311153a
SWDEV-407533 - [ABI Break]Purge unused env vars
...
Change-Id: I627950e8ebb6299affc602754a20d442dbe42b14
2023-08-24 14:11:40 -04:00
Jatin Chaudhary
8fe5100d16
SWDEV-418230 - fix warning seen in HIP headers
...
This PR fixes warning seen on HIP headers due to -Wignored-attributes.
The warning is attributes for a variable must precede definition.
This also fixes a potential issue with C-style header where templates
were declared outside __cplusplus.
Change-Id: I78bfd391717c7891afb442ef79812ea630c0ff49
2023-08-24 08:41:08 -04:00
Tao Sang
d433df4761
SWDEV-417727 - Fix hipSignalExternalSemaphoresAsync()
...
This reverts commit 44a3935cda .
Implement the right way to make ExternalSemaphores be signalled
only after prior works on the stream have been finished.
Change-Id: I9d5974e05d5f229170b928db4566c14e40e3cbaa
2023-08-23 22:31:27 -04:00
Saleel Kudchadker
e1e5d071ba
SWDEV-301667 - Port optimization to save extra packet to graphs
...
Change-Id: Ibaf64a4efe070c42620e6e153c1862a4a0b15664
2023-08-23 16:58:21 -04:00
taosang2
44a3935cda
SWDEV-417727 - Fix hipSignalExternalSemaphoresAsync()
...
Let ExternalSemaphores be signalled only after prior works on the
stream have been finished.
Change-Id: I856917db905f68f55fdf484f5267f7fe8ea3117f
2023-08-23 14:58:37 -04:00
German
d97cc0abbd
SWDEV-404889 - Inital change for debugger support
...
- Program unique AQL index for debugger. The logic manages AQL array of packets per HW queue.
- Provide debug state to PAL
Change-Id: I38fa1f5435fa711fd1d44dc391f2e61eb2a25efa
2023-08-23 13:21:58 -04:00
kjayapra-amd
6f5277c701
SWDEV-408473 - Add wait time of 10 us if the waiting signal copy was < 24K.
...
Change-Id: I438ec9eb07e5034042a4a9a5e6e51d74daba2c83
2023-08-23 10:46:33 -04:00
Jatin Chaudhary
19afdf719e
SWDEV-414425 - __half2's member variable should be __half instead of unsigned short
...
We currently have __half2 made up of unsigned short instead of __half.
This prevents users to do operation seamlessly when they want to operate on individual components.
Change-Id: I856917db905f68055fdf484f526707fe8ea3117d
2023-08-22 04:25:19 -04:00
Satyanvesh Dittakavi
84eae1f0a9
SWDEV-416443 - hipPointerGetAttributes should return correct type for managed memory
...
Change-Id: Ic197cd8c9d3f5405616ed6e4924ed5577e636b94
2023-08-21 07:47:32 -04:00
Juan Manuel MARTINEZ CAAMAÑO
06dcaae619
Revert "SWDEV-410182: Do not force wave64 for geekbench"
...
This patch did not consider the dicussions in SWDEV-270908
> "we found that in GeekBench5, forcing Wave64 instead of the default
> Wave32 compute policy yields big gains in every subtest except one"
This reverts commit d6dc82b220 .
Change-Id: Ice1728585b9d1b2c1b36a06cfa0b8c47cb2bfa49
2023-08-21 03:29:32 -04:00
Jaydeep Patel
7a10423a44
SWDEV-417691 - Error handling for MemoryMap OS calls.
...
Change-Id: I0a823289b274e118c8440f2d372a5216bf4ba6aa
2023-08-21 00:01:06 -04:00
German
9bd592e2ff
SWDEV-415115 - Fix memory commit in SVM on large bar systems
...
Skip memory commit for linux only.
Change-Id: I6304607f7c5516c76e59afa6da57de5b088f6a8c
2023-08-18 11:25:28 -04:00
Todd tiantuo Li
b4933f1d00
SWDEV-403758 - support new ASIC Revisions for Hawk Point1 and Hawk Point2
...
Change-Id: Ib8383b16e85abaa0bbf481c1aac71a11cd5b9218
2023-08-18 10:32:09 -04:00
Vikram
62464ca4c3
SWDEV-417558 - Fix dynamic linker error caused by SWDEV-378651 fix
...
Seems the windows linker error seen with https://gerrit-git.amd.com/c/compute/ec/clr/+/886078
also exists for linux, but only appears with dynamic linker. This fixes both usecases.
Change-Id: I1bb6df151eb1e09f75af4d461ead28bcbaa5f236
2023-08-18 02:21:14 -04:00
Anusha GodavarthySurya
f76a40c26d
SWDEV-415772, SWDEV-414682 - Fix childgraph node execution
...
Change-Id: If9ffc08d98a57b8daa5f131f72ef1bf2317f29e1
2023-08-18 00:45:00 -04:00
victzhan
b14bd96d3c
SWDEV-274425 - fix bad assignment of imageOffset.y and imageOffset.z to PAL
...
Change-Id: I6adce05928f6ff61aad845f289687d9bc0d17476
2023-08-18 00:17:31 -04:00
victzhan
cb426df1bd
SWDEV-416580 - Add condition when memory has direct access, only use host fill if image is small
...
Change-Id: I3509c4aa21f6413adad3b46273ec650f5c577ddd
2023-08-17 17:23:49 -04:00
Ajay
0d3a5c4c81
SWDEV-414828 - set AMD_DK_ROOT variable to env DK_ROOT
...
this ensures python to be picked from DK
Change-Id: Idd006b7a2bb819c6aa747136aa55cfc28737a5a9
2023-08-17 12:21:16 -04:00
Jaydeep Patel
289535e805
SWDEV-412393 - Force alloc memory to avoid another hsa image creation.
...
Change-Id: Ia3cd99eb736231e6dfe013ebae6c41fd4cc657bc
2023-08-17 05:18:43 +00:00
Juan Manuel MARTINEZ CAAMAÑO
d6dc82b220
SWDEV-410182: Do not force wave64 for geekbench
...
Change-Id: I505af6b0ca70e54a963abe9b097b91eea94d3268
2023-08-16 10:22:52 -04:00
Alex Xie
dc401c520b
SWDEV-416457 - clr to handle metadata ActualAccQual
...
Change-Id: I4e4c52093ed0f65830dbba19266872d3405c4916
2023-08-15 13:47:34 -04:00
victzhan
4fb24c48b0
SWDEV-274425 - fix bad initialization of array slice index for 1d image array in partialMemCopyTo()
...
Change-Id: Id9a0c55d4296de8cd89f1870b2c8028ce6cf601b
2023-08-15 12:55:10 -04:00
David Salinas
b00e6fe89e
Correct HIPAMD cmake file to install hipcc.bin
...
Change-Id: Ie90dddbcebba29d4c06cf1485581c9742dd1ad70
2023-08-15 11:51:02 -04:00
Vikram
cec579c006
SWDEV-378651 - add proper wavefrontsize link time option to hipRTC, in accordance with env variable GPU_ENABLE_WAVE32_MODE
...
This is a copy of http://gerrit-git.amd.com/c/compute/ec/hipamd/+/841299
Raising this here again since hipamd repo is frozen.
Change-Id: I8722ef55f78a9176e131fd5766fb11101b51f1b5
2023-08-15 00:12:31 -04:00
victzhan
7e3d8243b7
SWDEV-385303 - remove bad row pitch assignment
...
Change-Id: If959be2fa51035c54c3b08e74711077ad52ac4c8
2023-08-14 15:21:56 -04:00
Saleel Kudchadker
8a538b5639
SWDEV-384557 - Reset mask at in the constructor
...
Change-Id: I15dafd281213c03590bcae4bf4544e33c4a7e277
2023-08-11 17:22:27 -04:00
German
618cc4d9ee
SWDEV-416527 - Disable PAL platform destruction until a proper fix in PAL
...
Change-Id: I465aa15959187eb27354caa9b8308f1266be46ed
2023-08-11 10:51:37 -04:00
taosang2
d2cfb86ddc
SWDEV-408843 - Fix vulkan_interop failure
...
Fix runtime issues found in vulkan_interop test
Change-Id: I32c9bed861ddf4fe1d7bba21dce9bd720168c399
2023-08-11 10:13:56 -04:00
kjayapra-amd
f2c07d9bc2
SWDEV-416262 - Adding missing AMD headers on hip files.
...
Change-Id: I45531004e57c664df5ce4275a49f07ebbad08b7f
2023-08-11 10:00:23 -04:00
taosang2
051e1005f4
SWDEV-415029 - [ABI Break] Remove hcc symbols
...
Change-Id: Ic0082d3960aadbb7ac559141b6e84bd29a75b5cd
2023-08-10 21:21:01 -04:00
kjayapra-amd
d18f4b1ad4
SWDEV-416218 - Set the image mapped flag correctly on COMGR path.
...
Change-Id: I6c0908731f10c8ff5b3e159c0cfb68ce096c7bdf
2023-08-10 15:52:30 -04:00
Alex Xie
4969004422
SWDEV-411369 - printf parameter is wrong
...
Change-Id: I3c6752bd0266919215de6282d289afd04c77d8ef
2023-08-10 11:31:58 -04:00
Satyanvesh Dittakavi
8ee985a67b
SWDEV-415439 - Address segfault issues with hiprtcLinkCreate
...
Change-Id: I5c5898a9d0afadc344ae2fafc371e9ed647cec6e
2023-08-10 08:28:11 -04:00
Jaydeep Patel
34d071c767
SWDEV-415421 - End is relative to start and so no need to offset.
...
Change-Id: Icd65227d9879d9ee4e0bd2795f112b4d5e8c8e9e
2023-08-10 00:41:01 -04:00
Ranjith Ramakrishnan
5671badef9
SWDEV-413429 - Removed the dependency of hip-dev/devel package to hipcc
...
Change-Id: Ic3505be69e6c484ac05580a7e58d9e3e5c1c8c80
2023-08-09 12:30:49 -04:00
Ioannis Assiouras
5262693da0
SWDEV-415849 - Revert "SWDEV-386448 - Remove setting of HIP_CLANG_ROOT, HIP_PATH and ROCM_PATH in hip-config.cmake"
...
This reverts commit 24f1368ad3 .
HIP_PATH is still needed on windows as amd_build.py injects
depedency to HIP_PATH variable in hip-targets.cmake
Change-Id: I57d9aff3e8046a7381affaf5adc5b130d5702190
2023-08-08 18:11:19 -04:00
Julia Jiang
ad18362822
SWDEV-415212 - Fix OCLruntime DeviceQuery test failure
...
Change-Id: I2e47c76d2145716fe6eeea81d68adbfa7f8b9be8
2023-08-08 14:00:38 -04:00
Ranjith Ramakrishnan
03ad34a6c6
SWDEV-366827 - Disable file reorg backward compatibility support by default
...
Change-Id: Ifb0e3ea1a2217e287498efc26369596209be8c93
2023-08-08 13:32:17 -04:00
Rakesh Roy
76c8b3157b
SWDEV-415265 - Fix segfault when library isn't built with current GPU arch
...
- Return error code instead of segfault during kernel launch when library isn't built with current gpu arch
- Fix string print bug
Change-Id: I91aaa50150fee220317cd2eb4e075d825cc448b2
2023-08-08 00:41:54 -04:00
David Salinas
c1126fc727
SWDEV-404809 - hip packages shouldn't depend in non-default perl modules
...
Change-Id: I30829a735dd6a6f1d5780578e30701e3f8d3394a
2023-08-04 12:34:44 -04:00
Satyanvesh Dittakavi
ee3714e916
Github-3225 - Fix hip on cuda build issue with -default-stream=per-thread
...
Change-Id: I0485891c265617c213964f4130e90fbca9d801d4
2023-08-04 06:15:47 -04:00
Ioannis Assiouras
63af50b6e0
SWDEV-415160 - Added fix in kernel argument logging
...
Change-Id: Ic54d51264602c7bf0c91b5273f9519da3fbb1062
2023-08-03 21:39:41 +01:00
Ioannis Assiouras
97403db468
SWDEV-414194 - Make hip-lang available on nvidia platform
...
Change-Id: Ic0082d3960aadbb7ac559140b6e84bd29a75b5cb
2023-08-02 05:19:34 -04:00
Saleel Kudchadker
aa6eb555e2
SWDEV-384557 - Enable SDMA query
...
Change-Id: Ibb0a8d131f799985a4d4adbf753261e58c04157f
2023-08-01 18:41:23 -04:00