7046ea15bd
Comply to formatting
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-06-03 13:47:45 -05:00
1d19ae9483
Detection of MI308X and hardcode mclk to address bug in rocm-smi
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-06-03 13:47:45 -05:00
295b344646
Re-implementing HBM stack / XCD info for incoming product sku
...
Co-authored-by: Nicholas Curtis <nicholas.curtis@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
2024-06-03 13:47:45 -05:00
49371cacec
Create dedicated subdirectory in perfmon configs for archs supporting roofline
...
Separate subdirs allows us to target different roofline counters for different archs (i.e. MI300 vs MI200)
Signed-off-by: coleramos425 <colramos@amd.com >
2024-05-31 16:09:58 -05:00
7a01f499d7
remove use of distutils package entirely to avoid future deprecation
...
issues
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
2024-05-28 15:34:00 -05:00
aca084f41c
updated approach for runtime dependency check that does use "pkg_resources"
...
which will reportedly be deprecated at some point in the future.
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
2024-05-28 15:34:00 -05:00
c6cfa9cc26
Wrap text displayed in 'Top Dispatch' table for neatness
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-05-28 15:34:00 -05:00
047d7771f3
Add fix for case where we pass a single 'nan' value to to_avg
...
This is triggered by doing e.g., analyze -p <whatever> -k <kernel> -n per_kernel -b 17 18
Manifests as e.g.:
```
ERROR [analysis] 'float' object has no attribute 'empty'
```
because of:
https://github.com/ROCm/omniperf/blob/d1ee2ec8709b21f2e72536cc14dba8ac2f8621ab/src/utils/parser.py#L135
Instead, we first check whether numpy thinks the whole array is nan's, and bail early if so
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-05-28 15:34:00 -05:00
1f584c1612
handle unspecified case
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-05-28 15:34:00 -05:00
5579beeed5
fix formatting
...
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com >
2024-05-28 15:34:00 -05:00
989dd3b7ae
Add ability to overide arch when name missing in rocminfo
...
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com >
2024-05-28 15:34:00 -05:00
1f370c9fe7
Format CMake and Python
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-05-10 09:07:40 -06:00
dba868973b
Add support for --quiet flag to roofline
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-05-10 09:07:40 -06:00
3ab51735b5
Add docs for --quiet mode and update README
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-05-10 09:07:40 -06:00
8bca70a6ef
Update docs for new Grafana reorg
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-05-10 09:07:40 -06:00
519bcb9b3e
Update from https://github.com/ROCm/mibench/commit/b704bd3ec439f8cbece6713852fcafc855c5b07e
2024-05-10 09:07:40 -06:00
d1ee2ec870
Adding a top-level runtime python dependency checker. Goal is to
...
provide a kinder error message in the case where python dependencies
are not available locally. This is motivated for future execution by
users who are running from rocm-based binary packaging instead of using
normal cmake build system which would have verified the dependencies.
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
2024-05-03 15:26:27 -05:00
7d34e80567
Replace deprecated roofline warning with logging helper function
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-25 18:43:20 +00:00
0fc620ce79
Add TCC_TOO_MANY_EA_WRREQS_STALL to gfx940 input configs ( #349 )
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-25 18:22:00 +00:00
b5011ff0ae
additional mod needed to support roofline binaries potentially
...
executing from two different locations
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-22 09:00:18 -05:00
093a4511ee
update logic to detect roofline binaries in two alternate paths
...
depending on whether user is running within local clone or from form
install.
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-21 14:53:14 -05:00
3c562588ff
update logic to detect VERSION file to accommodate rocm packaging;
...
check two locations to cover case where user is running within local
git clone directly or alternatively, from package install.
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-21 14:53:14 -05:00
65967658e9
fix execution error when OMNIPERF_COLOR env is set; update coloring to
...
support four modes:
(0) - no coloring and no loglevel delimiters
(1) - colored loglevel delimiters
(2) - non-colored loglevel delimiters
(3) - fully colored messages for all levels besides INFO
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-04 14:44:51 -05:00
9403dce667
Define a README for /src subdir
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-01 14:30:21 -05:00
aac471c0fa
Reorganizing docs runner and setting archive subdir for old docs
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-01 14:30:21 -05:00
9c93449cc7
Remove hardcoded URLs from docs in favor of relative links
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-01 14:30:21 -05:00
e0556f32ab
Move dispatch id patch to proper util func in utils. Enable in rocprofv2 post-processing
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-01 14:30:21 -05:00
a1017b68e9
implement rocprofv2 workaround for dispatch ids ( #336 )
...
* implement rocprofv2 workaround for dispatch ids
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
* formatting
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
---------
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
2024-04-01 14:30:21 -05:00
1a3bdad90a
Adding documentation for global command line options
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-01 14:30:21 -05:00
6cc8f0154f
Restore OMNIPERF_COLOR global to disable default log coloring
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
b1d0b3905c
Extending log coloring to message text. Enable by default.
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
78c48eaed5
Remove superfluous logging statement
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
f47b8d2547
Throw more helpful warning on missing csv in analyze mode ( #313 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
706afa7f37
Register TRACE loglevel ahead of parse_args to avoid error in --specs printout
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-01 14:30:21 -05:00
f7394bf272
Revert #333 deterministic ordering ( #337 )
...
* Revert "formatting"
This reverts commit e387561791898467371b6219921f10447d3486b3.
* Revert "Implement deterministic ordering of perfmon"
This reverts commit 2a24600a37c8002838145962a957cea447555b0c.
2024-04-01 14:30:21 -05:00
f6f6165379
formatting
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-04-01 14:30:21 -05:00
97af96e435
Implement deterministic ordering of perfmon
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-04-01 14:30:21 -05:00
3928f36d5e
Adding redirect to help button in standalone GUI
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
33e763178e
Removing unused modules
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
3d8b748924
Documentation enhancements and removing watermark
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
73ac6c9561
Adding comments to roofline and changing output file name for specificity
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
cf36fb7fbf
Implementing docs feedback with typos and minor enhancements
...
Co-authored-by: Jose Santos <josantos@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
6cfdca93b9
Correct typo in Mi100 metric defs for missing SQ_INSTS_VMEM
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
20670da2b7
Responding to first round of Ben R.'s docs feedback.\n\nThis round includes fixes for comments up to the 'Performance Model' section. I will need to work with our documentation group to respond to those higher level comments.
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
dfdd8dd21d
Add timestamp override to rocprofv2 and format Python
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
482fd6f2ca
Create general_options() func to reduce code in parser
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-04-01 14:30:21 -05:00
d72ef52208
Fix for #300 ( #331 )
...
On some versions of numpy/pandas, applying a str map to an empty series doesn't change the type.
As a result, when adding a float to a string, sometimes numpy dies with a uadd error.
We fix this by explicitly casting to a str first
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
2024-04-01 14:30:21 -05:00
ddb5c0ccc9
Updated links in documentation. ( #329 )
...
Updated to reflect new GitHub organization.
Fixed broken links to GitHub pages.
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
2024-04-01 14:30:21 -05:00
f5712875aa
Updated links in documentation. ( #328 )
...
Updated to reflect new GitHub organization.
Fixed broken links to GitHub pages.
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
2024-03-21 10:14:37 -05:00
62221383a7
Fixing visualization for Compute Pipeline SOL. Need to consider 'Pct of Peak' rather than 'Avg'
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-18 14:28:14 -05:00
coleramos425
Karl W. Schulz
Nicholas Curtis
Nick Curtis
coleramos425
Nick Curtis
David Galiffi