Γράφημα Υποβολών

3337 Υποβολές

Συγγραφέας SHA1 Μήνυμα Ημερομηνία
searlmc1 a82b834fc4 Fix typo ( T in Vec3_cmp = needs to be int ). (#1203)
Typo introduced here:
commit e474469213
Author: Alex Voicu <alexandru.voicu@amd.com>
Date:   Mon Jun 24 20:02:09 2019 -0500

    Put 3-wide vector types on a ketogenic diet. (#1180)

[ROCm/hip commit: a9870f0465]
2019-07-04 00:44:26 +00:00
kpyzhov e1c47e773c Change the type of hipTextureObject_t to pointer to a struct. (#1199)
This is necessary to allow Runtime to perform required texture buffer handling.

[ROCm/hip commit: b6b749f714]
2019-07-04 00:44:06 +00:00
Jannik caf1f4fbb4 Fix call to cuda library (#1197)
* Remove flags parameter from hipOccupancyMaxPotentialBlockSize

This commit makes the hipOccupancyMaxPotentialBlockSize method consistent with hcc path and the CUDA API.


[ROCm/hip commit: 2a1b0ba27d]
2019-07-04 00:43:22 +00:00
Aryan Salmanpour a2655fd90a [hip] Move _criticalData of ihipStream_t class to private section and use criticalData() to access it (#1177)
[ROCm/hip commit: 999f45fc11]
2019-07-04 00:42:19 +00:00
Maneesh Gupta 01ee58e0c7 Fix sample module_api_global for hip-clang (#1201)
module_api_global relies on a HCC only feature which allows host code
to write to device variables. This feature does not exist in CUDA
or hip-clang, which causes the sample not working in CUDA or hip-clang.

This patch fixes the sample by using standard features of CUDA and
hip-clang. The fixed sample works in HCC, CUDA and hip-clang.

[ROCm/hip commit: 502a734ebf]
2019-07-03 08:52:19 +00:00
Yaxun (Sam) Liu 4d2f0de651 Add __hip_pinned_shadow__ for hip-clang and fix texture reference tests (#1200)
[ROCm/hip commit: 85c3b903df]
2019-07-03 08:51:59 +00:00
Maneesh Gupta b7fe02394f Added missing NULL checks and corrected API return values (#1188)
* Added missing NULL checks and corrected API return values as per validation

* Added missing NULL checks


[ROCm/hip commit: d57946275b]
2019-07-03 08:51:39 +00:00
Jatin Chaudhary 9484eb6831 Adding new unroll example (#1187)
[ROCm/hip commit: 3152af0175]
2019-07-03 08:51:19 +00:00
Yaxun Sam Liu afa71d710c Fix sample module_api_global for hip-clang
module_api_global relies on a HCC only feature which allows host code
to write to device variables. This feature does not exist in CUDA
or hip-clang, which causes the sample not working in CUDA or hip-clang.

This patch fixes the sample by using standard features of CUDA and
hip-clang. The fixed sample works in HCC, CUDA and hip-clang.


[ROCm/hip commit: 60e1733afe]
2019-07-02 16:36:53 -04:00
eshcherb 9a1e96321e hip_api_name fixed to be inline to suppress not used warning (#1194)
[ROCm/hip commit: e72893a771]
2019-06-30 03:38:43 +00:00
Evgeny Mankov eeb66048f3 [HIPIFY] Clang 7.1.0 support
+ Provide patch for clang's bug 38811
+ Update Readme.md accordingly


[ROCm/hip commit: 36cda83066]
2019-06-29 17:23:18 +03:00
Anusha Godavarthy Surya 7eedb4d047 Added missing NULL checks
[ROCm/hip commit: 7a4c3f61c8]
2019-06-27 20:19:30 +05:30
Anusha Godavarthy Surya f1d6b56fc4 Added missing NULL checks and corrected API return values as per validation
[ROCm/hip commit: 3d5f6be1c7]
2019-06-27 00:19:05 +05:30
Maneesh Gupta c1b0d625d7 Add dependency on amd_comgr in hip-config-*.cmake.in (#1179)
Change-Id: Ia12a40cd5c89920a50ec714ceae99f60259a6f66

[ROCm/hip commit: 573978625b]
2019-06-26 15:18:11 +05:30
wkwchau 3c963cc0e1 Fixed bug in hipOccupancyMaxPotentialBlockSize for the SGPRs limitation of gfx8 devices (#1176)
[ROCm/hip commit: 47f16264ed]
2019-06-26 15:18:00 +05:30
Maneesh Gupta 7874e84d3d [packaging] Add dependency on comgr to hip_hcc package (#1182)
[ROCm/hip commit: d4a92519eb]
2019-06-25 06:32:46 +05:30
Aaron Enye Shi 52614c2729 Fix dlpi_name info empty when using GCC on ub18 (#1181)
This fixes a bug where GCC++ on Ubuntu 18.04 creates failing executables compared to GCC++ on 16.04 and clang++. While creating function names on Ubuntu 18.04, dl_phdr_info seems to provide a non-zero value for dlpi_addr on initial iteration, and an empty string in dlpi_name. This is causing failure when linking with g++, since the empty string prevents the kernel function from being loaded. Clang++ and GCC on UB16 provide a zero value for dlpi_addr. To fix this, we need to verify both addr and name exists, so that /proc/self/exe can be properly loaded.

[ROCm/hip commit: 77bef86949]
2019-06-25 06:32:29 +05:30
Alex Voicu e474469213 Put 3-wide vector types on a ketogenic diet. (#1180)
* Put 3-wide vector types on a ketogenic diet.

* Remove needless include.

* Do not be narrow-minded.

* Do not be narrow-minded.

* Put the C people on a diet too.


[ROCm/hip commit: 67abac1365]
2019-06-25 06:32:09 +05:30
Evgeny Mankov 7cb92aeb9a [HIPIFY] Fix multiple input files support
Reported in #1168


[ROCm/hip commit: db6571ae75]
2019-06-20 18:05:57 +03:00
Aryan Salmanpour 45fa752888 [hip] implement the hipExtLaunchMultiKernelMultiDevice API (#1165)
* [hip] implement the hipExtLaunchMultiKernelMultiDevice API

* add a guard to check the HCC version for acquire_locked_hsa_queue() API which was introdued in HCC for ROCm 2.5

* modified code based on the requested changes

* changes to lock all streams before launching kernels for each device and unlock them after the dispatches

* check each stream to be valid before starting to lock all the streams


[ROCm/hip commit: 96dc74897d]
2019-06-20 05:59:05 +05:30
wkwchau 40bd111519 Implement the hipOccupancyMaxPotentialBlockSize function (#1162)
* Implement the hipOccupancyMaxPotentialBlockSize function

* Replaced hipGetDeviceProperties() call by ihipGetDeviceProperties() in ihipOccupancyMaxPotentialBlockSize()

* Add test for hipOccupancyMaxPotentialBlockSize in Module API

* Added extern declaration for ihipGetDeviceProperties() to be accessed inside ihipOccupancyMaxPotentialBlockSize()

* fixed hipOccupancyMaxPotentialBlockSize test build issue

* Fix hipOccupancyMaxPotentialBlockSize dtest

* Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest

* Revert "Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest"

This reverts commit 0480ff56f1441fc515d2c26ce33783e303423938.

* Disable hipOccupancyMaxPotentialBlockSize dtest on NVCC

* move extern declaration of ihipGetDeviceProperties to hip_module.cpp

* Update the limiation of 32 wavefronts per CU and 800/512 SGPRs for VI/pre-VI chips to calculate the occupancy


[ROCm/hip commit: d492f1fd6b]
2019-06-20 05:58:29 +05:30
Maneesh Gupta 57e0c02e28 Merge pull request #1164 from gargrahul/cleanup_module_api_samples
Add cleanup code in module api samples

[ROCm/hip commit: ba323cdef1]
2019-06-20 05:57:46 +05:30
Maneesh Gupta 2238e6671e Merge pull request #1173 from icarus-sparry/icarus-sparry-patch-1
Make hip_prof_gen.py compatible with both python 2 and 3

[ROCm/hip commit: a8f8c8994d]
2019-06-19 13:37:02 +05:30
Maneesh Gupta 2a41dc2a64 Merge pull request #1171 from mhbliao/hliao/master/hipcc
[hipcc] Revise include path calculation.

[ROCm/hip commit: 6b83b6bfca]
2019-06-19 13:36:51 +05:30
Maneesh Gupta cd72288515 Merge pull request #1167 from eshcherb/hip_prof_refactoring_190611
prof layer includes refactoring

[ROCm/hip commit: fc074d96d0]
2019-06-19 13:36:33 +05:30
Maneesh Gupta f16a25dd64 Merge pull request #1163 from gargrahul/fix_module_api_kernarg_sample
Fix sample to use kernelargs for launch

[ROCm/hip commit: 0ad0d06930]
2019-06-19 13:36:17 +05:30
Icarus Sparry b5a26215cc Make hip_prof_gen.py compatible with both python 2 and 3
Convert python 2 constructs to python 3 compatible ones.

In python 3, print is a function, so use write methods (which are always functions) instead.

In python3 keys() returns an iterator, rather than a list. This means you can't change the data structure that is being iterated over. Converting this iterator into a list mimics the python 2 behavior.

[ROCm/hip commit: cc374b2bd3]
2019-06-17 12:03:36 -07:00
Michael LIAO 49fce7ba8a [hipcc] Revise include path calculation.
- Once HIP_VDI_HOME is defined but HIP_CLANG_INCLUDE_PATH is not,
  calculate it directly without HIP_CLANG_PATH is defined or not;
  Otherwise, we may leave HIP_CLANG_INCLUDE_PATH undefined, if clang is
  not installed following the official way (so far, HIP-Clang breaks
  that), we may leave HIP_CLANG_INCLUDE_PATH undefined before its uses.


[ROCm/hip commit: e32940357f]
2019-06-14 13:35:00 -04:00
Rahul Garg 884d0fef76 HACK for SWDEV-173477/SWDEV-190701
[ROCm/hip commit: bc528b1e8b]
2019-06-13 18:15:31 -07:00
Evgeny 5a004eb676 prof layer includes refactoring
[ROCm/hip commit: 19ca7a2a08]
2019-06-11 20:13:29 -05:00
Rahul Garg 545b6e60ee Add cleanup code in module api samples
[ROCm/hip commit: f2b3526503]
2019-06-07 05:23:11 +05:30
Rahul Garg f2ff00db17 Fix sample to use kernelargs for launch
[ROCm/hip commit: 7a3bda3c2f]
2019-06-07 05:17:15 +05:30
Michael LIAO 96cc54ab79 [hip] Replace implicit conversions with explicit ones.
[ROCm/hip commit: 52a8f2fed4]
2019-06-05 10:00:35 -04:00
Maneesh Gupta 58caf3c615 Merge pull request #1140 from scchan/program_state_stage_2-rebase-20190524
migrate more program_state logic from header into shared library (phase II)

[ROCm/hip commit: 7013f87885]
2019-06-05 16:09:01 +05:30
Maneesh Gupta bdbf4dc45e Merge pull request #1114 from cdevadas/implicit-kernarg
Runtime changes to append implicit kernel arguments.

[ROCm/hip commit: 2bec6804d6]
2019-06-05 16:07:19 +05:30
Maneesh Gupta 95368b8b28 Merge pull request #1159 from mhbliao/hliao/master/explicit
[hip] Make vector type's scalar conversion explicit.

[ROCm/hip commit: 0982bb52f2]
2019-06-05 12:13:56 +05:30
Maneesh Gupta b0f53114f0 Merge pull request #1158 from dereklstinson/patch-1
fixed targets flag and TARGET GPU

[ROCm/hip commit: 7b0c88b63a]
2019-06-05 12:13:46 +05:30
Michael LIAO e5d347a679 [hip] Make vector type's scalar conversion explicit.
[ROCm/hip commit: 9bb4ecfcfe]
2019-06-04 15:15:26 -04:00
Derek Stinson 604adc707e fixed targets flag and TARGET GPU
--target-isa= didn't work any longer.

[ROCm/hip commit: 754d745d84]
2019-06-04 14:19:39 -04:00
Michael LIAO de162fa300 [hip] Minor fix to silence compilation warnings.
- Add parenthese to silence repeative compilation warnings across
  projects built against hip.


[ROCm/hip commit: 498fe92734]
2019-06-04 10:39:31 -04:00
Maneesh Gupta cedc88d40f Merge branch 'master' into implicit-kernarg
[ROCm/hip commit: 080e2c16ec]
2019-06-04 13:24:19 +05:30
Maneesh Gupta 654f61549d Merge pull request #1156 from yxsamliu/fix-vdi
Fix default HIP_VDI_HOME

[ROCm/hip commit: ad7e545dc1]
2019-06-04 13:21:48 +05:30
Maneesh Gupta 40076bca45 Merge pull request #1155 from gargrahul/fix_kernel_lp_dim_trace
Fix wrong grid dim shown in trace

[ROCm/hip commit: c99d011898]
2019-06-04 13:21:39 +05:30
Maneesh Gupta 1d4edf5379 Merge pull request #1154 from yxsamliu/tex
Add device_builtin_texture_type attribute to texture type for hip-clang

[ROCm/hip commit: 0564d8af57]
2019-06-04 13:21:29 +05:30
Maneesh Gupta 67145c20c2 Merge pull request #1152 from asalmanp/hip_as_b
Header change for new hip API hipExtLaunchMultiKernelMultiDevice

[ROCm/hip commit: 49e254f5e8]
2019-06-04 13:21:13 +05:30
Maneesh Gupta 0ba8db8f7e Merge pull request #1149 from zuhaib27/SWDEV-185448
Structured hipFloatComplex as typedef of float2, and hipDoubleComplex as typedef of double2.

[ROCm/hip commit: b0d90ac2ed]
2019-06-04 13:21:02 +05:30
Maneesh Gupta fa9d60e163 Merge pull request #1130 from lmoriche/master
Add support for code object v3

[ROCm/hip commit: 792706ff71]
2019-06-04 13:20:52 +05:30
cdevadas 5dac708dbb Runtime changes to append implicit kernel arguments.
Appended 48 empty bytes to the kernarg area at runtime. The implicit arguments are enabled primarily for the hostcall services
and it is completely abstracted from the user code. Enabled it for both hip-clang and hip-hcc.


[ROCm/hip commit: 9c03a5f948]
2019-06-04 10:45:49 +05:30
Yaxun Sam Liu d1ffde1c66 Fix default HIP_VDI_HOME
There is soft link /opt/rocm/bin/.hipVersion, therefore when hipcc is executed
as /opt/rocm/bin/hipcc, it will set HIP_VDI_HOME to /opt/rocm, which is
incorrect. Check ../lib/bitcode instead to identify HIP_VDI_HOME.


[ROCm/hip commit: 71f6bf4e67]
2019-05-31 23:58:59 -04:00
Rahul Garg ccd7b1f120 Fix wrong grid dim shown in trace
[ROCm/hip commit: a489f583bb]
2019-05-31 22:30:24 +05:30