Граф коммитов

1244 Коммитов

Автор SHA1 Сообщение Дата
xuchen-amd a91363744c Update TUI docs. (#796)
[ROCm/rocprofiler-compute commit: bfb2dc0795]
2025-07-15 11:13:24 -04:00
Fei Zheng 1050e0201c Update peak flops for MI350 (#810)
[ROCm/rocprofiler-compute commit: e1da9355c2]
2025-07-15 08:46:13 -06:00
xuchen-amd 65673617e0 Remove rocm-smi for ROCm 7.1 (#809)
[ROCm/rocprofiler-compute commit: b4b50502e3]
2025-07-15 10:28:53 -04:00
Fei Zheng e0ba0631b0 Update cli doc description (#804)
[ROCm/rocprofiler-compute commit: 5b8d12fde2]
2025-07-14 13:05:01 -06:00
Fei Zheng 769caa3124 Update PC sampling doc (#798)
[ROCm/rocprofiler-compute commit: 78c1898ba0]
2025-07-14 13:04:14 -06:00
xuchen-amd 06b24cbfe1 rocm-smi deprecation warning (#806)
[ROCm/rocprofiler-compute commit: a3dc98e251]
2025-07-14 13:35:47 -04:00
Pratik Basyal 2cfcd9baab roofline footnote updated (#808)
[ROCm/rocprofiler-compute commit: 81d95d8e4a]
2025-07-14 13:27:43 -04:00
xuchen-amd 0ac856237a tui user experience improvement (#805)
[ROCm/rocprofiler-compute commit: 23664c72f7]
2025-07-11 16:51:55 -04:00
vedithal-amd ce73a5ef74 Fix roofline and TUI bugs (#803)
* Fix roofline rocm version bug
* Fix utils bug
* Remove unnecessary tests
* Do not check textual-fspicker package in cmake build
* Use rocprofv3 to test MI 100 and fix tests

[ROCm/rocprofiler-compute commit: 000fd4f5b2]
2025-07-09 19:15:46 -04:00
xuchen-amd 9ebbf4bb03 Generalize config path. (#802)
* Generalize config path.

* Fix format.

* Fix typo.

[ROCm/rocprofiler-compute commit: 8585cd8e8f]
2025-07-09 18:57:21 -04:00
vedithal-amd f730199ef7 Fix util tests (#797)
* Fix profile tests
* Update known issue for corrupted memory chart

[ROCm/rocprofiler-compute commit: c51b9d16c3]
2025-07-08 17:15:09 -04:00
cfallows-amd 7862701993 Update roofline bins for rocm7 changes (#755)
* Update current bins to have rocm6 suffix. Add new rocm7 bins, built on rocm7.0 latest due to hip updates.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Re-add rocm version check for roof bins.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Rebuild roofline binaries on top of latest rocm7 (#16379) after recent mainline promotions.
Adjusting version and distro combinations of bins following rocm6 vs rocm 7 supported OS.
*rhel8 not supported on rocm7, also not built anymore
*sles15 not supported on rocm7 but is still being built
*ubuntu stays as 22.04 and above for rocm7

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Minor fixes after testing.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Fixed bad copy after finding it in testing ctest.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Remove runpath from new bin

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Rework target_binary map return in detect_roofline- we should not be returning maps of different sizes or with different keys for the same method. Expected output should be consistent in case we run into bad position, or for testing purposes. Manually tested all possible roofline bin expected cases to comfirm functionality and expected user output.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Update changelog with new roofline distro minimums

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 3df0d1dded]
2025-07-08 16:51:50 -04:00
xuchen-amd bac7fde4f4 Add tui cmake install. (#794)
[ROCm/rocprofiler-compute commit: 60a50e681b]
2025-07-08 11:18:26 -04:00
Fei Zheng 09ec955554 PC Sampling: fix potential_end_offset (#792)
* fix potential_end_offset

* format code: unrelated

[ROCm/rocprofiler-compute commit: 1b7445faa4]
2025-07-08 08:52:01 -04:00
Fei Zheng c867eaa9cd format with isort (#793)
[ROCm/rocprofiler-compute commit: 239e6550f4]
2025-07-08 08:51:20 -04:00
fxmarty-amd a91e3f74f3 fix normalization (#789)
[ROCm/rocprofiler-compute commit: c58ee9e73b]
2025-07-08 08:50:41 -04:00
cfallows-amd 30466f6bfa Adjust csv output list for test_block_SPI for MI350 (#785)
Adjusting expected output list for test_block_SPI for MI350 series products.
Run formatter.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 61a9381edf]
2025-07-03 01:58:11 -04:00
jamessiddeley-amd 94ea0fbf2f additional-code-coverage-compute (#763)
* added additional functions to test_utils.py

* added code coverage for db_connector.py

* Update test_profile_general.py

Added additional roofline test cases

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* updated coverage mi_gpu_spec.py 73% -> 94%

* added parser.py coverage

* removed redundant comments

* added test_utils and test_db_connector

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

[ROCm/rocprofiler-compute commit: a6463f5e98]
2025-07-02 13:29:10 -04:00
cfallows-amd e085f3cc54 Fix method return for python version compatibility (#784)
Support for python3.8 and above means union defined in one of the methods was throwing errors for anything less than python3.10. Swapping out | operand for Optional[] resolves errors on systems using <3.10. No functional changes.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: a59b1ea6e6]
2025-07-02 10:36:37 -04:00
vedithal-amd 740fe492c2 Fix rocprofiler sdk list counters (#765)
[ROCm/rocprofiler-compute commit: 894046f283]
2025-07-02 09:41:51 -04:00
xuchen-amd bfe24beec6 Remove cell backgrouund colors. (#778)
[ROCm/rocprofiler-compute commit: 222dbdc6bd]
2025-06-28 10:38:28 -04:00
jamessiddeley-amd 60ace87e1a added 0400 analysis config yaml files (#779)
[ROCm/rocprofiler-compute commit: 1bb7bf4dd4]
2025-06-27 16:21:19 -04:00
vedithal-amd 86e243201e Fix SPI block counter limit (#780)
* Fix SPI counter collection limit

* Update counter collection limits from aqlprofile

* Remove special handling for MI 350 SPI pipe counters

[ROCm/rocprofiler-compute commit: 6e1bbb5efb]
2025-06-27 14:07:56 -04:00
Fei Zheng 2ffaf5b453 Documentation update for FP8 on MI300 (#766)
[ROCm/rocprofiler-compute commit: f5bc717fe1]
2025-06-26 13:35:36 -06:00
vedithal-amd 1d59cbb06d Add support for MI 100 with rocprofiler-sdk (#768)
* Add custom rocprofiler-sdk counter definitions file for MI 100

* Update CHANGELOG to mention that accumulation counters will not be
  collected when profiling on MI 100 using rocprofiler-sdk/rocprofv3

* Migrate accum_counters.yaml to code

[ROCm/rocprofiler-compute commit: a95a45d69a]
2025-06-26 09:03:18 -04:00
David Galiffi 3a703cec00 Provide a version for RPM Obsoletes attribute (#670)
Fix RPM generation warning

[ROCm/rocprofiler-compute commit: 1903e8e748]
2025-06-25 12:36:47 -04:00
Kunal Malviya fba643793b Adding verbose and changing threads (#771)
Co-authored-by: rocm <rocm@rocm-System-Kunal.amd.com>

[ROCm/rocprofiler-compute commit: 661de1d483]
2025-06-25 18:49:46 +05:30
cfallows-amd 429b17a1e0 Add roofline PDF output to general profiling runs (#774)
Change when Roofline PDFs are generated- during general profiling and --roof-only profiling (skip only when --no-roof option is present)

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 630bc149ff]
2025-06-25 01:19:28 -04:00
dependabot[bot] 8c3c708eef Bump rocm-docs-core from 1.18.2 to 1.21.1 in /docs/sphinx (#775)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.18.2 to 1.21.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.2...v1.21.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-version: 1.21.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 181e4f44c7]
2025-06-24 21:04:16 -04:00
xuchen-amd b7c6c4eaac Fix system sol units, remove units if None value. (#773)
* Fix system sol units.

[ROCm/rocprofiler-compute commit: 74e9853f8e]
2025-06-24 16:37:55 -04:00
xuchen-amd 7ab4a3f03f GUI: prevent big number overflow (#772)
* Prevent number overflow by formatting values.

* Improve value formatting logic based on comments.

[ROCm/rocprofiler-compute commit: 92ce4732bc]
2025-06-24 16:27:06 -04:00
vedithal-amd 9873460265 Fix counter collection for MI 350 (#764)
* Fix TCC counter collection bug
* Fix accumulate counter collection
* Fix formatting

[ROCm/rocprofiler-compute commit: 5950a02ff6]
2025-06-21 08:48:25 -04:00
Jason Bonnell dde3d61739 Ignore certain workflows when changes are only for .md, docs, and docker (#754)
* add paths-ignore for both push and PR to rhel-8.yml and ubuntu-jammy.yml

* add paths-ignore for PR only in tarball.yml

* add rocm-docs-core linting.yml workflow to formatting.yml

* fix small mistake in github directory path

* remove rocm-docs-core linting

[ROCm/rocprofiler-compute commit: 44c3516b8b]
2025-06-20 09:26:28 -04:00
jamessiddeley-amd 979c59fadc added progress printout in rocprof-compute profile (#727)
* added progress printout for profiler

* added comments and fixed readability

* removed redundant newlines

* moved format_time helper function to utils

* removed tqdm and redundant time calc

[ROCm/rocprofiler-compute commit: 036866fc12]
2025-06-18 14:09:09 -04:00
xuchen-amd 9d50115bd7 Integrate roofline in tui (#762)
* Update changelog, remove unused code.

* enable roofline in TUI.

* Remove roofline section when data not available.

* Fix workload dir path.

[ROCm/rocprofiler-compute commit: 5d8fd55e36]
2025-06-18 13:58:42 -04:00
xuchen-amd 0b6e03adb0 CLI: enable roofline plot (#760)
* enable roofline plot in cli.

* Add roofline to analysis config.

* Unify global variables.

* Disable roofline for baseline comparison and gfx908.

* Add check for roofline.csv

[ROCm/rocprofiler-compute commit: 80159ee117]
2025-06-18 13:19:58 -04:00
vedithal-amd ab985464ef Add docker files for testing (#761)
[ROCm/rocprofiler-compute commit: b16256fd07]
2025-06-17 16:18:35 -04:00
Vladimir Indic f49b70142f [PC Sampling] Separate counts for issued and stalled samples (#756)
[ROCm/rocprofiler-compute commit: 451be8a600]
2025-06-16 15:09:21 -06:00
vedithal-amd fccb9195ff Print counter list in DEBUG level (#758)
[ROCm/rocprofiler-compute commit: 7c0ffd14a9]
2025-06-16 16:53:00 -04:00
ywang103-amd 72e8576a7e format the code after mem chart's fix of test (#753)
[ROCm/rocprofiler-compute commit: b8dd6d049d]
2025-06-13 12:03:42 -04:00
Jason Bonnell 503e2a8061 Move pr template file (#746)
* updated documentation wording, added cherry pick option for PR type

* moved pull_request_template to base .github directory

[ROCm/rocprofiler-compute commit: da6bf4b5c9]
2025-06-13 11:37:56 -04:00
vedithal-amd 917634d332 fix test_gpu_specs.py (#752)
[ROCm/rocprofiler-compute commit: fa1e9965f8]
2025-06-13 10:01:59 -04:00
ywang103-amd dab2c49342 fix broken test with --cols options (#750)
[ROCm/rocprofiler-compute commit: bb0c417871]
2025-06-12 19:45:24 -04:00
jamessiddeley-amd 05aba003c9 Fix: Add explicit includes for assert.h and thread in sample files (#751)
* Fix: Add explicit includes for assert.h and thread in sample/vcopy.cpp

The HIP/CLR change e3cb5399c removed transitive inclusion  
of standard headers like assert.h from hip_runtime.h.  
This caused build failures in rocprof-compute samples.  

This commit explicitly includes <assert.h> and <thread>  
in vcopy.cpp to resolve potential missing definitions.  


Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vsequential_access.cpp

Added assert and thread imports

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vrandom_access.cpp

Added assert import

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vsequential_access.cpp

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

[ROCm/rocprofiler-compute commit: 667128e3c7]
2025-06-12 17:03:48 -04:00
Vignesh Edithal 696c1407af Bugfix for PR #744
[ROCm/rocprofiler-compute commit: 6054b3b7fd]
2025-06-12 16:09:15 -04:00
vedithal-amd 89bc1fc812 Change default rocprof to rocprofv3 (#748)
* Revert of https://github.com/ROCm/rocprofiler-compute/pull/738

* Change default rocprof backend interface to rocprofv3

* Add MI 350 support in documentation

* Added known issue that MI 100 profiling will not work unless rocprofv1
  is explicitly opted in

* Remove MI 50 soc gfx python class since MI 50 is not supported

[ROCm/rocprofiler-compute commit: d27ee69b52]
2025-06-12 15:45:11 -04:00
vedithal-amd 9e743cdff2 Remove rocscope related code and add deprecation warning for mongo db usecase (#744)
* Remove rocscope related code

* Add deprecation warning for database update mode which is used for grafana and mongodb functionality

[ROCm/rocprofiler-compute commit: cdd41dee40]
2025-06-12 14:21:24 -04:00
David Galiffi a153c96c7b Copyright Header Compliance (#745)
- for SWDEV-537492

[ROCm/rocprofiler-compute commit: 1cd989a110]
2025-06-12 12:02:58 -04:00
jamessiddeley-amd 218d77b88f fixed long kernel names cut off in --kernel-names option (#728)
* reformatted kernel roofline PDF to use table

* restored kernel symbol icons

* enhance code readability

* restored cell text wrap

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

[ROCm/rocprofiler-compute commit: f004aeebe9]
2025-06-12 10:23:40 -04:00
jamessiddeley-amd 2b60d10e49 increased utils.py code coverage to ~84% (#742)
* code coverage file cover: utils.py

* added code coverage 82% for utils.py

* reverted unused_code rebase

[ROCm/rocprofiler-compute commit: 97dad3f7f1]
2025-06-12 10:21:40 -04:00