Alex Voicu
30d90dab38
Re-sync with upstream.
2017-11-20 15:34:50 +00:00
Ben Sander
a1e0c96689
Merge pull request #264 from pzins/missing_end_marker
...
Fix missing MARKER_END
2017-11-20 06:08:01 -06:00
Rahul Garg
eff09fcd86
-Moved coGlobals in hipModule class (takes care of multi module case)
...
-Used mutex scope for updating coGlobals
2017-11-20 16:23:18 +05:30
Rahul Garg
76f174b536
Update hipModuleGetTexRef API
2017-11-19 22:10:46 +05:30
Alex Voicu
0cc921f103
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
2017-11-19 01:54:12 +00:00
Rahul Garg
e2e499461a
Removed redundant desc variable
2017-11-15 18:28:27 +05:30
Rahul Garg
edbfeeb141
-Fixed texture driver API sample
...
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs
2017-11-15 18:23:28 +05:30
Rahul Garg
e536eb038d
Texture code reorganized
2017-11-14 11:09:35 +05:30
Pierre
e60a95d7dd
Fix missing MARKER_END
...
Logging status of hipCtxSynchronize was missing
Test if hip profiling is active for MARKER_END in ihipPostLaunchKernel
Add MARKER_END after the completion of a kernel launched through
the "grid launch"
2017-11-13 16:13:19 -05:00
Alex Voicu
1518611976
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-09 23:43:07 +00:00
Rahul Garg
1851c153f6
Texture driver APIs support
2017-11-09 22:10:55 +05:30
Maneesh Gupta
925f97fac7
Merge pull request #250 from AlexVlx/feature_add_agent_global_support
...
Support for agent globals
2017-11-09 07:52:09 +05:30
Alex Voicu
f7919a8321
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# tests/src/runtimeApi/stream/hipStreamSync2.cpp
2017-11-08 10:26:30 +00:00
Alex Voicu
0ad1308efd
Clean up trailing whitespace so as to reduce noise in #246 .
2017-11-08 00:08:55 +00:00
Alex Voicu
8854dec897
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-07 00:01:22 +00:00
Ben Sander
e71456cc6c
Check for null event in hipEventElapsedTime
2017-11-06 23:49:31 +00:00
Ben Sander
b5911acce2
hipStreamWaitEvent returns success if event created but not recorded
2017-11-06 23:49:31 +00:00
Ben Sander
955cfbfdc7
Make hipEvent_t thread safe.
...
Support re-recording of same event by different threads.
- Add criticalData structure to hipEvent_t, similar to mechanism used
for streams, contexts, device. Events are always locked
after streams to avoid deadlock.
- ihipEvent_t::locked_copyCrit can be used to copy critical state
including marker. The critical state in the event can then
be re-recorded.
- refactor hipEventElapsedTime. Remmove stale debug code, native signal
refs.
2017-11-06 23:49:25 +00:00
Maneesh Gupta
dbb6b2bab8
Merge pull request #251 from ROCm-Developer-Tools/fix_event_state
...
Set event state AFTER it is recorded.
2017-11-06 07:28:11 +05:30
Maneesh Gupta
958ca62c63
Merge pull request #249 from bensander/warn_event
...
Add HIP_DB=warn + message if sync on dangerous event.
2017-11-06 07:25:40 +05:30
Ben Sander
1c65bb1684
Set event state AFTER it is recorded.
2017-11-05 10:33:18 -06:00
Alex Voicu
17753cbd92
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
2017-11-03 10:53:39 +00:00
Alex Voicu
d12cf0da7d
This introduces correct support for agent global variables, and implements hipModuleGetGlobal as an actual equivalent for cuModuleGetGlobal.
2017-11-03 01:44:48 +00:00
Alex Voicu
4693c5e56c
Correctly deal with functions from shared objects, wherein the program visible VA == so_base_va + st_value(function_symbol). Remove quaint usage of pfe for hipMemset (which is actually fill_n).
2017-11-01 22:33:13 +00:00
Ben Sander
fe32685fbc
Merge pull request #237 from bensander/use_ctxptr_for_p2p
...
Use ctxptr for p2p
2017-11-01 18:55:25 +01:00
Ben Sander
172b9f96e6
Add HIP_DB=warn + message if sync on dangerous event.
2017-11-01 10:44:34 -07:00
Ben Sander
5a80c4108e
Merge pull request #245 from scchan/centos_fixes
...
various fixes for centos/rhel
2017-11-01 18:10:29 +01:00
Alex Voicu
28f87f7d2e
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
2017-11-01 15:09:59 +00:00
Siu Chi Chan
c1a4ff7b20
Centos/RHEL - remove usage of constexpr since libc++ doesn't enable ctor for constexpr pair in C++11
2017-10-31 18:16:12 +00:00
Ben Sander
dc7d993a02
Add ns-level timer for HIP API routines
...
Refactor some miuses of ihipLogStatus, these should only be in top-level
HIP APIs and should be paired with HIP_API_INIT calls.
2017-10-30 20:20:51 +00:00
Ben Sander
7e8b39fc96
Merge pull request #222 from bensander/fix_device_prop
...
Fix device prop
2017-10-30 17:58:48 +01:00
Ben Sander
4c7b2be1c2
Check for null copyEngine before looking at peers.
2017-10-30 16:58:03 +00:00
Siu Chi Chan
cf98d0e37d
Merge remote-tracking branch 'origin/master' into HEAD
2017-10-27 01:18:28 -04:00
Ben Sander
8a64feef61
Merge pull request #198 from AlexVlx/feature_support_globals_for_module_api
...
Feature support globals for module api
2017-10-27 01:53:34 +02:00
Ben Sander
a417241507
Fix bug with peer-to-peer combined with context API
...
- Store context inside the tracker rather than using int deviceID that
was always mapped to primary context
- IsPeerWatcher now based on device IDs rather than specific peers.
2017-10-26 19:44:22 +00:00
Aditya Atluri
698721be34
Enhance debug for copy pointers
...
- show more pointer tracking fields
- show pointer info before and after "tailoring'
2017-10-26 19:44:22 +00:00
Siu Chi Chan
085d63099c
add HC_FEATURE_PRINTF around the printf buffer definition
2017-10-25 12:00:02 -04:00
Siu Chi Chan
4ed3e9e15f
printf support for module API
2017-10-24 00:55:41 -04:00
Siu Chi Chan
da7c37947c
replace __hcc_workweek__ with HC_FEATURE_PRINTF flag
2017-10-23 18:30:08 -04:00
Maneesh Gupta
281c543bc3
Make elfio headers private
...
Change-Id: I3ba174bb46e84a75380207d93a0da6fe3703689e
2017-10-23 10:24:36 +05:30
Ben Sander
b4c7876244
Remove printf
2017-10-20 13:24:04 -07:00
Ben Sander
ed85b15c3e
Update device properties.
...
- clear properties to defined initial state.
- enable some property flags which are now supported.
2017-10-20 15:52:13 +00:00
Ben Sander
e738fa66b5
Modify device properties to use pool API.
...
- Also better error code checking
2017-10-20 14:49:29 +00:00
Siu Chi Chan
a1956f64e6
hipDeviceReset(): make sure to reinitialize the printf buffer in hcc RT
2017-10-18 16:26:13 -04:00
Alex Voicu
b222448efd
This fixes incorrect usage of the reader object, which created arcane
...
mismatches when one reader accessed another's section.
2017-10-09 15:46:38 +01:00
Alex Voicu
582779c6c6
This adds cursory support for globals to the HIP module loading API. The
...
style is purposefully alien so as to signal that HIP experts should turn
it into HIP worthy code as soon as possible.
2017-10-09 13:27:11 +01:00
Rahul Garg
9e07b08ce5
Fixed hipTexture fetch issue
2017-09-25 06:54:29 +05:30
Wen-Heng (Jack) Chung
1efc99e69f
Bump device major version from 2 to 3
...
This would significantly improve performance for certain apps in kernel
selection logic.
2017-09-15 15:47:39 +00:00
Ben Sander
b54ab82694
Merge pull request #179 from gargrahul/fix_hipmallocarray
...
Fixed hipMallocArray for 1D cases
2017-09-14 12:59:33 -05:00
Ben Sander
1ea468e279
Merge branch 'master' into hip_init_alloc
2017-09-14 11:53:33 -05:00