Граф коммитов

3683 Коммитов

Автор SHA1 Сообщение Дата
Evgeny Mankov ac2357aa0a Merge pull request #1206 from emankov/master
[HIPIFY] Statistics to CSV file dumping revise
2019-07-07 20:58:16 +03:00
Evgeny Mankov 60a9143d6d [HIPIFY] Statistics to CSV file dumping revise
+ Add option -print-stats-csv to dump statistics to CSV file
+ If -o-dir is specified, CSV file will be dumped there
+ Generate 1 summary file sum_stat.csv in case of multiple sources
2019-07-07 20:55:17 +03:00
searlmc1 f3bbad0716 Fix typo ( T in Vec3_cmp = needs to be int ). (#1203)
Typo introduced here:
commit 87eac86298
Author: Alex Voicu <alexandru.voicu@amd.com>
Date:   Mon Jun 24 20:02:09 2019 -0500

    Put 3-wide vector types on a ketogenic diet. (#1180)
2019-07-04 00:44:26 +00:00
kpyzhov 43ffe25979 Change the type of hipTextureObject_t to pointer to a struct. (#1199)
This is necessary to allow Runtime to perform required texture buffer handling.
2019-07-04 00:44:06 +00:00
Jannik a401997b8e Fix call to cuda library (#1197)
* Remove flags parameter from hipOccupancyMaxPotentialBlockSize

This commit makes the hipOccupancyMaxPotentialBlockSize method consistent with hcc path and the CUDA API.
2019-07-04 00:43:22 +00:00
Aryan Salmanpour 7e48231252 [hip] Move _criticalData of ihipStream_t class to private section and use criticalData() to access it (#1177) 2019-07-04 00:42:19 +00:00
Maneesh Gupta 3541d18528 Fix sample module_api_global for hip-clang (#1201)
module_api_global relies on a HCC only feature which allows host code
to write to device variables. This feature does not exist in CUDA
or hip-clang, which causes the sample not working in CUDA or hip-clang.

This patch fixes the sample by using standard features of CUDA and
hip-clang. The fixed sample works in HCC, CUDA and hip-clang.
2019-07-03 08:52:19 +00:00
Yaxun (Sam) Liu 3169f3a881 Add __hip_pinned_shadow__ for hip-clang and fix texture reference tests (#1200) 2019-07-03 08:51:59 +00:00
Maneesh Gupta a220a8e8e9 Added missing NULL checks and corrected API return values (#1188)
* Added missing NULL checks and corrected API return values as per validation

* Added missing NULL checks
2019-07-03 08:51:39 +00:00
Jatin Chaudhary 3cb87cdc46 Adding new unroll example (#1187) 2019-07-03 08:51:19 +00:00
Yaxun Sam Liu 98648828c0 Fix sample module_api_global for hip-clang
module_api_global relies on a HCC only feature which allows host code
to write to device variables. This feature does not exist in CUDA
or hip-clang, which causes the sample not working in CUDA or hip-clang.

This patch fixes the sample by using standard features of CUDA and
hip-clang. The fixed sample works in HCC, CUDA and hip-clang.
2019-07-02 16:36:53 -04:00
eshcherb 0218f95c32 hip_api_name fixed to be inline to suppress not used warning (#1194) 2019-06-30 03:38:43 +00:00
Evgeny Mankov 54dab53c04 Merge pull request #1195 from emankov/master
[HIPIFY] Clang 7.1.0 support
2019-06-29 17:25:07 +03:00
Evgeny Mankov b1bc9caef9 [HIPIFY] Clang 7.1.0 support
+ Provide patch for clang's bug 38811
+ Update Readme.md accordingly
2019-06-29 17:23:18 +03:00
Anusha Godavarthy Surya 1a7c7e3b06 Added missing NULL checks 2019-06-27 20:19:30 +05:30
Anusha Godavarthy Surya 4989452413 Added missing NULL checks and corrected API return values as per validation 2019-06-27 00:19:05 +05:30
Maneesh Gupta a90871aefe Add dependency on amd_comgr in hip-config-*.cmake.in (#1179)
Change-Id: Ia12a40cd5c89920a50ec714ceae99f60259a6f66
2019-06-26 15:18:11 +05:30
wkwchau 3742f24477 Fixed bug in hipOccupancyMaxPotentialBlockSize for the SGPRs limitation of gfx8 devices (#1176) 2019-06-26 15:18:00 +05:30
Maneesh Gupta e0b86d890c [packaging] Add dependency on comgr to hip_hcc package (#1182) 2019-06-25 06:32:46 +05:30
Aaron Enye Shi f87b900f96 Fix dlpi_name info empty when using GCC on ub18 (#1181)
This fixes a bug where GCC++ on Ubuntu 18.04 creates failing executables compared to GCC++ on 16.04 and clang++. While creating function names on Ubuntu 18.04, dl_phdr_info seems to provide a non-zero value for dlpi_addr on initial iteration, and an empty string in dlpi_name. This is causing failure when linking with g++, since the empty string prevents the kernel function from being loaded. Clang++ and GCC on UB16 provide a zero value for dlpi_addr. To fix this, we need to verify both addr and name exists, so that /proc/self/exe can be properly loaded.
2019-06-25 06:32:29 +05:30
Alex Voicu 87eac86298 Put 3-wide vector types on a ketogenic diet. (#1180)
* Put 3-wide vector types on a ketogenic diet.

* Remove needless include.

* Do not be narrow-minded.

* Do not be narrow-minded.

* Put the C people on a diet too.
2019-06-25 06:32:09 +05:30
Evgeny Mankov 65e012e5b1 Merge pull request #1175 from emankov/LLVM
[HIPIFY] Fix multiple input files support
2019-06-20 18:08:46 +03:00
Evgeny Mankov 266cf3cf96 [HIPIFY] Fix multiple input files support
Reported in #1168
2019-06-20 18:05:57 +03:00
Aryan Salmanpour d6ad690cb6 [hip] implement the hipExtLaunchMultiKernelMultiDevice API (#1165)
* [hip] implement the hipExtLaunchMultiKernelMultiDevice API

* add a guard to check the HCC version for acquire_locked_hsa_queue() API which was introdued in HCC for ROCm 2.5

* modified code based on the requested changes

* changes to lock all streams before launching kernels for each device and unlock them after the dispatches

* check each stream to be valid before starting to lock all the streams
2019-06-20 05:59:05 +05:30
wkwchau 28c34ead70 Implement the hipOccupancyMaxPotentialBlockSize function (#1162)
* Implement the hipOccupancyMaxPotentialBlockSize function

* Replaced hipGetDeviceProperties() call by ihipGetDeviceProperties() in ihipOccupancyMaxPotentialBlockSize()

* Add test for hipOccupancyMaxPotentialBlockSize in Module API

* Added extern declaration for ihipGetDeviceProperties() to be accessed inside ihipOccupancyMaxPotentialBlockSize()

* fixed hipOccupancyMaxPotentialBlockSize test build issue

* Fix hipOccupancyMaxPotentialBlockSize dtest

* Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest

* Revert "Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest"

This reverts commit 0480ff56f1441fc515d2c26ce33783e303423938.

* Disable hipOccupancyMaxPotentialBlockSize dtest on NVCC

* move extern declaration of ihipGetDeviceProperties to hip_module.cpp

* Update the limiation of 32 wavefronts per CU and 800/512 SGPRs for VI/pre-VI chips to calculate the occupancy
2019-06-20 05:58:29 +05:30
Maneesh Gupta 439b6e41d4 Merge pull request #1164 from gargrahul/cleanup_module_api_samples
Add cleanup code in module api samples
2019-06-20 05:57:46 +05:30
Maneesh Gupta 21d9875046 Merge pull request #1173 from icarus-sparry/icarus-sparry-patch-1
Make hip_prof_gen.py compatible with both python 2 and 3
2019-06-19 13:37:02 +05:30
Maneesh Gupta 3083337056 Merge pull request #1171 from mhbliao/hliao/master/hipcc
[hipcc] Revise include path calculation.
2019-06-19 13:36:51 +05:30
Maneesh Gupta 3b3118d459 Merge pull request #1167 from eshcherb/hip_prof_refactoring_190611
prof layer includes refactoring
2019-06-19 13:36:33 +05:30
Maneesh Gupta ad5a15debd Merge pull request #1163 from gargrahul/fix_module_api_kernarg_sample
Fix sample to use kernelargs for launch
2019-06-19 13:36:17 +05:30
Icarus Sparry 17bebbd0f2 Make hip_prof_gen.py compatible with both python 2 and 3
Convert python 2 constructs to python 3 compatible ones.

In python 3, print is a function, so use write methods (which are always functions) instead.

In python3 keys() returns an iterator, rather than a list. This means you can't change the data structure that is being iterated over. Converting this iterator into a list mimics the python 2 behavior.
2019-06-17 12:03:36 -07:00
Michael LIAO c3604d3120 [hipcc] Revise include path calculation.
- Once HIP_VDI_HOME is defined but HIP_CLANG_INCLUDE_PATH is not,
  calculate it directly without HIP_CLANG_PATH is defined or not;
  Otherwise, we may leave HIP_CLANG_INCLUDE_PATH undefined, if clang is
  not installed following the official way (so far, HIP-Clang breaks
  that), we may leave HIP_CLANG_INCLUDE_PATH undefined before its uses.
2019-06-14 13:35:00 -04:00
Rahul Garg 107734f7ad HACK for SWDEV-173477/SWDEV-190701 2019-06-13 18:15:31 -07:00
Evgeny c6600ba26b prof layer includes refactoring 2019-06-11 20:13:29 -05:00
Rahul Garg 49ac54abde Add cleanup code in module api samples 2019-06-07 05:23:11 +05:30
Rahul Garg 4e6ad95403 Fix sample to use kernelargs for launch 2019-06-07 05:17:15 +05:30
Maneesh Gupta 580f4a65b2 Merge pull request #1160 from mhbliao/hliao/master/explicit
[hip] Replace implicit conversions with explicit ones.
2019-06-06 07:27:40 +05:30
Michael LIAO 4d5cf71c48 [hip] Replace implicit conversions with explicit ones. 2019-06-05 10:00:35 -04:00
Maneesh Gupta 1d5d923d36 Merge pull request #1140 from scchan/program_state_stage_2-rebase-20190524
migrate more program_state logic from header into shared library (phase II)
2019-06-05 16:09:01 +05:30
Maneesh Gupta 3b3c442757 Merge pull request #1114 from cdevadas/implicit-kernarg
Runtime changes to append implicit kernel arguments.
2019-06-05 16:07:19 +05:30
Maneesh Gupta b2c6817df0 Merge pull request #1159 from mhbliao/hliao/master/explicit
[hip] Make vector type's scalar conversion explicit.
2019-06-05 12:13:56 +05:30
Maneesh Gupta c67b47e87b Merge pull request #1158 from dereklstinson/patch-1
fixed targets flag and TARGET GPU
2019-06-05 12:13:46 +05:30
Maneesh Gupta e088678355 Merge pull request #1157 from mhbliao/hliao/master/misc
[hip] Minor fix to silence compilation warnings.
2019-06-05 12:13:35 +05:30
Michael LIAO 62d70cb2c8 [hip] Make vector type's scalar conversion explicit. 2019-06-04 15:15:26 -04:00
Derek Stinson c401cb56e3 fixed targets flag and TARGET GPU
--target-isa= didn't work any longer.
2019-06-04 14:19:39 -04:00
Michael LIAO 2655003fde [hip] Minor fix to silence compilation warnings.
- Add parenthese to silence repeative compilation warnings across
  projects built against hip.
2019-06-04 10:39:31 -04:00
Maneesh Gupta d4fa74ff09 Merge branch 'master' into implicit-kernarg 2019-06-04 13:24:19 +05:30
Maneesh Gupta 48e657b099 Merge pull request #1156 from yxsamliu/fix-vdi
Fix default HIP_VDI_HOME
2019-06-04 13:21:48 +05:30
Maneesh Gupta 40a09318e4 Merge pull request #1155 from gargrahul/fix_kernel_lp_dim_trace
Fix wrong grid dim shown in trace
2019-06-04 13:21:39 +05:30
Maneesh Gupta 8a859f8020 Merge pull request #1154 from yxsamliu/tex
Add device_builtin_texture_type attribute to texture type for hip-clang
2019-06-04 13:21:29 +05:30