AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,802 Commits 3 Branches 0 Tags
b1470b4e50ca0e2c6dde07560b285a4936b46845
Commit Graph

1802 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bertan Dogancay b1470b4e50 [GRAPH] Pass rank instead of busId due to a change in an internal function signature (#1792) 
[ROCm/rccl commit: 9c89573580]
 2025-07-08 08:45:54 -04:00
Marius Brehler 5d753cb871 Set GTEST_BOTH_LIBRARIES appropriately (#1669) 
If `find_package()` succeeds to find GTest and `INSTALL_DEPENDENCIES`
is set to OFF, `GTEST_BOTH_LIBRARIES` is not set and thus
`rccl-UnitTests` fails with trying to link unkown symbols.

[ROCm/rccl commit: dac0e528a0]
 2025-07-05 20:38:31 -05:00
Bertan Dogancay 471fc6bff2 [DEVICE] Enable PAT algo for RCCL 1ppn (#1756) 
* Enable PAT algo for RCCL 1ppn


[ROCm/rccl commit: e96c8473a1]
 2025-07-04 13:45:18 -04:00
Rakesh Roy 82a822b646 Fix chrono build error (#1790) 
[ROCm/rccl commit: dd3b1d816c]
 2025-07-04 08:27:30 -05:00
Wenkai Du e031a4a2f4 msccl: use special send for LL on gfx950 (#1788) 
[ROCm/rccl commit: ae9642d4bc]
 2025-07-03 04:16:18 -05:00
ryanhankins f910d25563 Adding #include <dlfcn.h> in nccl_net.h to pass build (#1786) 
[ROCm/rccl commit: 9d35581d5e]
 2025-07-02 19:21:53 -05:00
Nilesh M Negi 23618f9e65 [MSCCLPP] Disable format checks in MSCCLPP by default (#1781) 
[ROCm/rccl commit: 9e99c18f6e]
 2025-07-02 09:11:42 -05:00
Wenkai Du 6db3b4cd4f Add support for extended fine grained system memory pool (#1770) 
* Add support for extended fine-grained system memory pool
* Use hipHostRegisterUncached
* Add "sc0 sc1" flags for LL store on gfx950
* Update after HIP flag is changed to hipExtHostRegisterUncached

[ROCm/rccl commit: 4640ab19b3]
 2025-07-01 16:38:49 -05:00
Nilesh M Negi fd0d9ac44c [BUILD] Fix packaging for RAS (#1784) 
[ROCm/rccl commit: 3e51c41dcb]
 2025-07-01 16:37:14 -05:00
Nilesh M Negi d88d033aba [RAS] Add support for RAS client (#1748) 
Enable RAS client binary `rcclras`

[ROCm/rccl commit: 8d3a5542fb]
 2025-06-29 18:53:16 -05:00
isaki001 79473681e5 added tuning table for gfx950 (#1779) 
* added tuning table for mi350

* remove erroneous string

[ROCm/rccl commit: 75d22b47cb]
 2025-06-29 15:45:39 -05:00
Bertan Dogancay ac5dad287a Switch to linear channel mapping for 2 nodes (#1777) 
[ROCm/rccl commit: 358dc1bc84]
 2025-06-28 09:10:18 -05:00
Arm Patinyasakdikul 4d71cae249 [topo-expl] update header file location. (#1769) 
[ROCm/rccl commit: 35024ca1cb]
 2025-06-27 15:29:37 -05:00
gilbertlee-amd 23e5680038 Fixing HelloRccl include path to RCCL, fixing some warnings (#1778) 
[ROCm/rccl commit: 16101e654f]
 2025-06-27 09:12:59 -06:00
Arm Patinyasakdikul c3b110f9e9 add warning if workFIFO is not available after multiple retries. (#1772) 
* add warning if workFIFO is not available after multiple retries.

* Update src/enqueue.cc

Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com>

---------

Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com>

[ROCm/rccl commit: 265b1b3775]
 2025-06-26 19:49:52 -05:00
Arm Patinyasakdikul 32e80aedc0 Update plugin to look for librccl-net.so. (#1768) 
[ROCm/rccl commit: 71c788d4d7]
 2025-06-26 16:59:38 -05:00
mberenjk 2c02ee0a99 changing the HIP-VERSION to 6.3 to avoid using hip_fp8 for older ROCm versions (#1764) 
Co-authored-by: Marzieh Berenjkoub <mberenjk@.amd.com>

[ROCm/rccl commit: 5fb9d8f828]
 2025-06-26 11:15:01 -05:00
Mustafa Abduljabbar ffb17bd9d7 Revert LL64 cutoff points based on internal tuning (#1771) 
[ROCm/rccl commit: 7e2ac00980]
 2025-06-26 11:59:42 -04:00
Dingming Wu d34a38ccfc Add proxyTrace (#1732) 
This feature tracks the proxy events and status of each send/recv op. ProxyTrace keeps a fixed number of active ops in host mem and dumps the status of each op when the program crashes or hangs.

[ROCm/rccl commit: 020dcf0a7c]
 2025-06-25 23:01:34 -05:00
Nilesh M Negi 0c41f27b10 [BUILD] Move NPKit flags from install.sh to CMakeLists.txt (#1741) 
[ROCm/rccl commit: 568777a9bf]
 2025-06-23 21:51:49 -05:00
corey-derochie-amd 37ab47fab4 Updated CHANGELOG for LL128 support for gfx942 in 7.0 (#1719) 
* Updated CHANGELOG for LL128 support for gfx942 in 7.0

Also ported 6.4.2 section

* Removed unnecessary note from 7.0

[ROCm/rccl commit: e73db11819]
 2025-06-23 08:50:12 -06:00
jonatluu 590fb2798b Remove File reorganization backward compatibility (rccl) (#1753) 
[ROCm/rccl commit: 709140204a]
 2025-06-22 17:18:26 -05:00
Grant Pinkert 1d68693a2e Fix continuous build hang on extract_metadata.cmake (#1668) 
When the `roc-obj-ls` executable fails, it sometimes does not return. Since the `execute_process` command will wait until the executable finishes, this means that in some cases, the build will hang indefinitely. There is no error message, and no indication that anything is wrong. This commit fixes that by introducing timeouts into the code and better error reporting.

[ROCm/rccl commit: 2482d1475f]
 2025-06-22 05:54:44 -05:00
Bertan Dogancay eaa770a017 [NPKit] Create dump dir regardless of default or user provided path (#1757) 
[ROCm/rccl commit: 675b495a00]
 2025-06-21 21:18:20 -05:00
Bertan Dogancay 1e42d866da Merge pull request #1721 from BertanDogancay/2.26-sync 
[SYNC] 2.26.6-1

[ROCm/rccl commit: 0c1795c64b]
 2025-06-20 09:57:09 -04:00
BertanDogancay c0c9312e38 Merge remote-tracking branch 'nccl/master' into develop 
[ROCm/rccl commit: aaf023976a]
 2025-06-20 07:54:49 -05:00
Joseph Macaranas b37518663a [Azure CI] rccl nightly pipeline that runs on slurm (#1723) 
* [Azure CI] rccl nightly pipeline that runs on slurm
- Login node will be set up as a self-hosted agent on Azure Pipelines.
- Login node will run this job nightly.
- Login node will checkout the latest develop source, and then run build and test through sbatch calls, and then waiting for the jobs to complete. When the jobs are complete, print out the logs.

[ROCm/rccl commit: 12315c259a]
 2025-06-19 10:41:40 -05:00
Nilesh M Negi 7c422271a8 [MSCCLPP] Disable MSCCLPP Executor (#1744) 
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com>

[ROCm/rccl commit: 92a5d225d9]
 2025-06-17 01:29:55 -05:00
Sarat Kamisetty e359e834f5 generic net plugin ctxt that is extensible for use in multiple APIs (#1735) 
Co-authored-by: Sarat Kamisetty <sakamiset@amd.com>

[ROCm/rccl commit: fa0422f174]
 2025-06-16 14:48:08 -07:00
Bertan Dogancay 9fa53cc454 [NPKit] Use default output directory when env var is not set (#1747) 
[ROCm/rccl commit: 39211c6b41]
 2025-06-16 15:26:53 -04:00
Mustafa Abduljabbar 3e5dc99aa6 Fix topo_explorer compatibility and capture WarpSize (#1743) 
[ROCm/rccl commit: fb4ad82d0d]
 2025-06-16 08:18:35 -04:00
Tim 7051f217a7 replayer update v0 (#1733) 
* First version of new replayer, with comments on future TODOs

* plus minor fixes for UT

* Updated format of recorder, especially in binary department, according to replayer's need

[ROCm/rccl commit: ba97c9c18b]
 2025-06-13 15:05:34 -04:00
Richard Barnes 2c0cc20a76 Enable -Wdeprecated-copy-with-user-provided-copy (#1643) 
[ROCm/rccl commit: 4486d091b8]
 2025-06-13 08:23:31 -07:00
Arm Patinyasakdikul 7f7f1cede3 Added missing copyright message. (#1742) 
* Added missing copyright message.

* addressed comments.

[ROCm/rccl commit: 6c37ae9470]
 2025-06-12 09:58:01 -05:00
corey-derochie-amd 2e7aa3556e Deprecated MSCCL API functions (#1740) 
[ROCm/rccl commit: 03fba66e71]
 2025-06-11 17:52:09 -06:00
Nusrat Islam 99813a3288 msccl: adjust msccl threshold for bf16 (#1736) 
* msccl: adjust msccl threshold for bf16

* Update src/collectives.cc

Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com>

---------

Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com>

[ROCm/rccl commit: 75c3c8215c]
 2025-06-11 09:09:57 -05:00
Arm Patinyasakdikul 69f7167b74 Fixed errorneous parenthesis. (#1739) 
[ROCm/rccl commit: 600ace7f19]
 2025-06-11 09:08:00 -05:00
Nilesh M Negi 4cadf3597c [DEVICE] Adding ability to choose unroll factor at runtime (#1734) 
* Adding runtime unroll factor selection via RCCL_UNROLL_FACTOR
* [BUILD] Add support for user-defined UNROLL for debugging
* Update CHANGELOG.md
* Fix COLLTRACE errors in CI
* Add debug statements for unroll and resolve warnings
* Incorporate UNROLL into ONLY_FUNCS for debugging

---------

Signed-off-by: nileshnegi <Nilesh.Negi@amd.com>
Co-authored-by: gilbertlee-amd <44450918+gilbertlee-amd@users.noreply.github.com>
Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

[ROCm/rccl commit: 9d72be7b2f]
 2025-06-11 00:07:59 -05:00
Atul Kulkarni 4cd71722f2 Added new ENABLE_CODE_COVERAGE option. (#1664) 
Modified install.sh script to add this new option

[ROCm/rccl commit: 682ed36fe6]
 2025-06-10 12:12:36 -05:00
Nilesh M Negi b797b62f6b [DEVICE] Use threadfence on gfx950 for LL protocol (#1686) 
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com>

[ROCm/rccl commit: b926203c05]
 2025-06-09 01:26:07 -05:00
Nilesh M Negi 7abc3160e7 [BUILD] Enable LL128 on gfx950 (#1731) 
* [BUILD] Enable LL128 on gfx950
* Modify comment in src/rccl_wrap.cc
* Update CHANGELOG

Signed-off-by: nileshnegi <Nilesh.Negi@amd.com>
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com>

[ROCm/rccl commit: ef5b4ff630]
 2025-06-09 00:25:54 -05:00
vstojilj bbe7422279 SWDEV-536040 - Include <thread> header (#1724) 
[ROCm/rccl commit: 2ac44cfe4e]
 2025-06-06 10:28:11 -06:00
Arm Patinyasakdikul f65777536f Remove 'warpSize' compiler constant as it is deprecated in ROCm 7.0. (#1720) 
* Remove 'warpSize' compiler constant as it is deprecated in ROCm 7.0.

* Create ncclShmemScratchWarpSize on host side for enqueue.cc.

* Update src/enqueue.cc

Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com>

* address comments

* fix number of threads

---------

Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com>

[ROCm/rccl commit: ec6efa9b26]
 2025-06-06 07:34:43 -05:00
Arm Patinyasakdikul 8dd9747504 Increase default WORK_FIFO size to accommodate larger alltoall. (#1722) 
[ROCm/rccl commit: d5b5f6b159]
 2025-06-05 09:02:45 -05:00
Pedram Alizadeh 1ace5d05ed Reapplying PR #1641 [AG and RS channel tuning] Add thread work threshold to tuning models and precompute reg index in LL128 (#1713) 
* Reapply "[AG and RS channel tuning] Add thread work threshold to tuning models and precompute reg index in LL128 (#1641)"

This reverts commit 943ad6f7820739385a0b54e81f823d0df1dbf71c.

* Decreasing NCCL_LL128_SHMEM_ELEMS_PER_THREAD from 16 to 8

[ROCm/rccl commit: 3f7c08648f]
 2025-06-04 13:22:11 -04:00
Avinash a50ff2c3d3 SPLITCOMM design fix in src/misc/msccl (#1715) 
* Fix TOC-TOU in mcclInit

* Improving vector resize thread safety

* Initial commit rank to comm change

* Removing unwanted include header changes

* Updated CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

---------

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

[ROCm/rccl commit: e94b360246]
 2025-06-01 21:00:38 -05:00
alex-breslow-amd 4277b5aa88 Use One Slice per Basic Primitive for AllReduce, ReduceScatter, AllGather (#1681) for Single Node on Some GFX9 Systems 
Using a single slice rather than the typical two provides about 5% speedup (sometimes more or less) on some GFX9 systems for single node.

[ROCm/rccl commit: 2f6b20c00a]
 2025-05-29 16:17:35 -07:00
Nilesh M Negi 19ed482121 Re-apply unroll=1 and 112 channels for gfx950 (#1706) 
* Reapply "[SRC] Enable unroll=1 for gfx950 (#1602)" (#1667)
This reverts commit a6972c0d09.

* Reapply "[GRAPH] Increase default nChannels to 112 for gfx950 (#1596)" (#1620)
This reverts commit 1a2eca1756.

[ROCm/rccl commit: 12517a957e]
 2025-05-28 14:58:10 -05:00
corey-derochie-amd 22120c6303 Fixed errors in the CHANGELOG for ROCm 7.0 (#1702) 
* Updated 6.5 release to be 7.0
* Corrected the RCCL version for 6.4.1
* Moved items to the correct releases
* Added NCCL 2.25.1 compatibility item
* Fixed wording
* Added entry for `ManagedMem` and `ManagedMemGraph` test fix

[ROCm/rccl commit: 7b633d5844]
 2025-05-23 15:47:59 -05:00
akolliasAMD 6e2f75d424 remove user from code owner file (#1709) 
[ROCm/rccl commit: aabd181fe4]
 2025-05-23 15:45:15 -05:00