Commit Graph

3668 Commits

Author SHA1 Message Date
Evgeny Mankov b1bc9caef9 [HIPIFY] Clang 7.1.0 support
+ Provide patch for clang's bug 38811
+ Update Readme.md accordingly
2019-06-29 17:23:18 +03:00
Maneesh Gupta a90871aefe Add dependency on amd_comgr in hip-config-*.cmake.in (#1179)
Change-Id: Ia12a40cd5c89920a50ec714ceae99f60259a6f66
2019-06-26 15:18:11 +05:30
wkwchau 3742f24477 Fixed bug in hipOccupancyMaxPotentialBlockSize for the SGPRs limitation of gfx8 devices (#1176) 2019-06-26 15:18:00 +05:30
Maneesh Gupta e0b86d890c [packaging] Add dependency on comgr to hip_hcc package (#1182) 2019-06-25 06:32:46 +05:30
Aaron Enye Shi f87b900f96 Fix dlpi_name info empty when using GCC on ub18 (#1181)
This fixes a bug where GCC++ on Ubuntu 18.04 creates failing executables compared to GCC++ on 16.04 and clang++. While creating function names on Ubuntu 18.04, dl_phdr_info seems to provide a non-zero value for dlpi_addr on initial iteration, and an empty string in dlpi_name. This is causing failure when linking with g++, since the empty string prevents the kernel function from being loaded. Clang++ and GCC on UB16 provide a zero value for dlpi_addr. To fix this, we need to verify both addr and name exists, so that /proc/self/exe can be properly loaded.
2019-06-25 06:32:29 +05:30
Alex Voicu 87eac86298 Put 3-wide vector types on a ketogenic diet. (#1180)
* Put 3-wide vector types on a ketogenic diet.

* Remove needless include.

* Do not be narrow-minded.

* Do not be narrow-minded.

* Put the C people on a diet too.
2019-06-25 06:32:09 +05:30
Evgeny Mankov 65e012e5b1 Merge pull request #1175 from emankov/LLVM
[HIPIFY] Fix multiple input files support
2019-06-20 18:08:46 +03:00
Evgeny Mankov 266cf3cf96 [HIPIFY] Fix multiple input files support
Reported in #1168
2019-06-20 18:05:57 +03:00
Aryan Salmanpour d6ad690cb6 [hip] implement the hipExtLaunchMultiKernelMultiDevice API (#1165)
* [hip] implement the hipExtLaunchMultiKernelMultiDevice API

* add a guard to check the HCC version for acquire_locked_hsa_queue() API which was introdued in HCC for ROCm 2.5

* modified code based on the requested changes

* changes to lock all streams before launching kernels for each device and unlock them after the dispatches

* check each stream to be valid before starting to lock all the streams
2019-06-20 05:59:05 +05:30
wkwchau 28c34ead70 Implement the hipOccupancyMaxPotentialBlockSize function (#1162)
* Implement the hipOccupancyMaxPotentialBlockSize function

* Replaced hipGetDeviceProperties() call by ihipGetDeviceProperties() in ihipOccupancyMaxPotentialBlockSize()

* Add test for hipOccupancyMaxPotentialBlockSize in Module API

* Added extern declaration for ihipGetDeviceProperties() to be accessed inside ihipOccupancyMaxPotentialBlockSize()

* fixed hipOccupancyMaxPotentialBlockSize test build issue

* Fix hipOccupancyMaxPotentialBlockSize dtest

* Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest

* Revert "Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest"

This reverts commit 0480ff56f1441fc515d2c26ce33783e303423938.

* Disable hipOccupancyMaxPotentialBlockSize dtest on NVCC

* move extern declaration of ihipGetDeviceProperties to hip_module.cpp

* Update the limiation of 32 wavefronts per CU and 800/512 SGPRs for VI/pre-VI chips to calculate the occupancy
2019-06-20 05:58:29 +05:30
Maneesh Gupta 439b6e41d4 Merge pull request #1164 from gargrahul/cleanup_module_api_samples
Add cleanup code in module api samples
2019-06-20 05:57:46 +05:30
Maneesh Gupta 21d9875046 Merge pull request #1173 from icarus-sparry/icarus-sparry-patch-1
Make hip_prof_gen.py compatible with both python 2 and 3
2019-06-19 13:37:02 +05:30
Maneesh Gupta 3083337056 Merge pull request #1171 from mhbliao/hliao/master/hipcc
[hipcc] Revise include path calculation.
2019-06-19 13:36:51 +05:30
Maneesh Gupta 3b3118d459 Merge pull request #1167 from eshcherb/hip_prof_refactoring_190611
prof layer includes refactoring
2019-06-19 13:36:33 +05:30
Maneesh Gupta ad5a15debd Merge pull request #1163 from gargrahul/fix_module_api_kernarg_sample
Fix sample to use kernelargs for launch
2019-06-19 13:36:17 +05:30
Icarus Sparry 17bebbd0f2 Make hip_prof_gen.py compatible with both python 2 and 3
Convert python 2 constructs to python 3 compatible ones.

In python 3, print is a function, so use write methods (which are always functions) instead.

In python3 keys() returns an iterator, rather than a list. This means you can't change the data structure that is being iterated over. Converting this iterator into a list mimics the python 2 behavior.
2019-06-17 12:03:36 -07:00
Michael LIAO c3604d3120 [hipcc] Revise include path calculation.
- Once HIP_VDI_HOME is defined but HIP_CLANG_INCLUDE_PATH is not,
  calculate it directly without HIP_CLANG_PATH is defined or not;
  Otherwise, we may leave HIP_CLANG_INCLUDE_PATH undefined, if clang is
  not installed following the official way (so far, HIP-Clang breaks
  that), we may leave HIP_CLANG_INCLUDE_PATH undefined before its uses.
2019-06-14 13:35:00 -04:00
Rahul Garg 107734f7ad HACK for SWDEV-173477/SWDEV-190701 2019-06-13 18:15:31 -07:00
Evgeny c6600ba26b prof layer includes refactoring 2019-06-11 20:13:29 -05:00
Rahul Garg 49ac54abde Add cleanup code in module api samples 2019-06-07 05:23:11 +05:30
Rahul Garg 4e6ad95403 Fix sample to use kernelargs for launch 2019-06-07 05:17:15 +05:30
Maneesh Gupta 580f4a65b2 Merge pull request #1160 from mhbliao/hliao/master/explicit
[hip] Replace implicit conversions with explicit ones.
2019-06-06 07:27:40 +05:30
Michael LIAO 4d5cf71c48 [hip] Replace implicit conversions with explicit ones. 2019-06-05 10:00:35 -04:00
Maneesh Gupta 1d5d923d36 Merge pull request #1140 from scchan/program_state_stage_2-rebase-20190524
migrate more program_state logic from header into shared library (phase II)
2019-06-05 16:09:01 +05:30
Maneesh Gupta 3b3c442757 Merge pull request #1114 from cdevadas/implicit-kernarg
Runtime changes to append implicit kernel arguments.
2019-06-05 16:07:19 +05:30
Maneesh Gupta b2c6817df0 Merge pull request #1159 from mhbliao/hliao/master/explicit
[hip] Make vector type's scalar conversion explicit.
2019-06-05 12:13:56 +05:30
Maneesh Gupta c67b47e87b Merge pull request #1158 from dereklstinson/patch-1
fixed targets flag and TARGET GPU
2019-06-05 12:13:46 +05:30
Maneesh Gupta e088678355 Merge pull request #1157 from mhbliao/hliao/master/misc
[hip] Minor fix to silence compilation warnings.
2019-06-05 12:13:35 +05:30
Michael LIAO 62d70cb2c8 [hip] Make vector type's scalar conversion explicit. 2019-06-04 15:15:26 -04:00
Derek Stinson c401cb56e3 fixed targets flag and TARGET GPU
--target-isa= didn't work any longer.
2019-06-04 14:19:39 -04:00
Michael LIAO 2655003fde [hip] Minor fix to silence compilation warnings.
- Add parenthese to silence repeative compilation warnings across
  projects built against hip.
2019-06-04 10:39:31 -04:00
Maneesh Gupta d4fa74ff09 Merge branch 'master' into implicit-kernarg 2019-06-04 13:24:19 +05:30
Maneesh Gupta 48e657b099 Merge pull request #1156 from yxsamliu/fix-vdi
Fix default HIP_VDI_HOME
2019-06-04 13:21:48 +05:30
Maneesh Gupta 40a09318e4 Merge pull request #1155 from gargrahul/fix_kernel_lp_dim_trace
Fix wrong grid dim shown in trace
2019-06-04 13:21:39 +05:30
Maneesh Gupta 8a859f8020 Merge pull request #1154 from yxsamliu/tex
Add device_builtin_texture_type attribute to texture type for hip-clang
2019-06-04 13:21:29 +05:30
Maneesh Gupta ef87f7eaef Merge pull request #1152 from asalmanp/hip_as_b
Header change for new hip API hipExtLaunchMultiKernelMultiDevice
2019-06-04 13:21:13 +05:30
Maneesh Gupta 98aa6cf895 Merge pull request #1149 from zuhaib27/SWDEV-185448
Structured hipFloatComplex as typedef of float2, and hipDoubleComplex as typedef of double2.
2019-06-04 13:21:02 +05:30
Maneesh Gupta 4b3d59a93e Merge pull request #1130 from lmoriche/master
Add support for code object v3
2019-06-04 13:20:52 +05:30
cdevadas 214ec53da3 Runtime changes to append implicit kernel arguments.
Appended 48 empty bytes to the kernarg area at runtime. The implicit arguments are enabled primarily for the hostcall services
and it is completely abstracted from the user code. Enabled it for both hip-clang and hip-hcc.
2019-06-04 10:45:49 +05:30
Maneesh Gupta 15abdd838f Merge pull request #1153 from mangupta/disable_hiprtc_tests
[dtests] Temporarily disable hiprtc tests
2019-06-03 12:00:03 +05:30
Yaxun Sam Liu 154765df88 Fix default HIP_VDI_HOME
There is soft link /opt/rocm/bin/.hipVersion, therefore when hipcc is executed
as /opt/rocm/bin/hipcc, it will set HIP_VDI_HOME to /opt/rocm, which is
incorrect. Check ../lib/bitcode instead to identify HIP_VDI_HOME.
2019-05-31 23:58:59 -04:00
Rahul Garg 7a2e3b6a1c Fix wrong grid dim shown in trace 2019-05-31 22:30:24 +05:30
Yaxun Sam Liu 7c20081f8d Add device_builtin_texture_type attribute to texture type for hip-clang
This is required to support texture type for hip-clang.
2019-05-31 12:07:58 -04:00
Maneesh Gupta 165d73de9a [dtests] Temporarily disable hiprtc tests
Change-Id: I87c0c01837e7b59b11d99fb94d679a765f914da5
2019-05-31 16:39:33 +05:30
Aryan Salmanpour d8e94fd5b5 Header change for new hip API hipExtLaunchMultiKernelMultiDevice 2019-05-30 18:04:05 -04:00
Maneesh Gupta 690fa7b29b Merge pull request #1148 from kpyzhov/fix-windows-hip-clang-path
Fixed setting HIP_CLANG_PATH on Windows.
2019-05-29 12:35:00 +05:30
Siu Chi Chan b2ffd6afc2 fix compilation error when host compiler is clang (#1147)
* fix compilation error when host compiler is clang

* use a macro specifically for hcc && hip-clang
2019-05-29 12:34:48 +05:30
Maneesh Gupta 8a8658975e Merge pull request #1146 from mangupta/coop
Header changes for cooperative groups
2019-05-29 12:34:33 +05:30
Zuhaib Khan 6aa704e7b9 Structured hipFloatComplex as typedef of float2, and hipDoubleComplex as typedef of double2. 2019-05-28 16:57:51 -04:00
Konstantin Pyzhov 332b19023d Fixed setting HIP_CLANG_PATH on Windows. 2019-05-28 09:38:17 -04:00