Patel, Jaydeepkumar
dea880f9da
SWDEV-508973 - If total # of threads/block is more than HW capacity, it's invalid config issue and should return invalid config error. ( #25 )
...
[ROCm/clr commit: 8531cd3bbe ]
2025-04-10 15:16:16 +05:30
Betigeri, Sourabh
487ede31a9
SWDEV-523281 - [clr] Implementation of hipLaunchKernelExC and hipDrvLaunchKernelEx API with support for cooperative launch ( #92 )
...
[ROCm/clr commit: 8c6b90996e ]
2025-04-03 20:10:05 +09:00
Saleel Kudchadker
c8f39ec2b0
SWDEV-502365 - Track last used command
...
- This change tries to save extra synchronization packets we may insert
as we didnt track the completion signals for every command. We track
the current enqueued command until it exits the enqueue stage. We also
record the exit scope to know if we flushed the caches
- Handle correct release scopes and store completion signal as HW events
- Use a new finishCommand implementation to only wait for the command
passed as the argument
Change-Id: Ie4350c5dd24f5d48dfa6ccbabd892f0544caadcc
[ROCm/clr commit: e03e4f3b5d ]
2025-03-04 16:05:02 -05:00
Rahul Manocha
75d53e5c22
SWDEV-489106 - Linker API addition to runtime
...
1) Add Linker APIs to runtime to support SPIRV linking
2) Migrate Internal implementations to runtime and share with rtc
3) Add Support to bundled and unbundled SPIRV Code object linking.
Change-Id: Ic1fd4431f842a208a2468e8aec54a65b5fa6b0e3
[ROCm/clr commit: 5930f047bb ]
2025-02-22 13:39:23 -05:00
Ioannis Assiouras
a349b23474
SWDEV-514686 - Fixed hipEventSynchronize/hipStreamWaitEvent for IPC events
...
Resolved an issue where hipEventSynchronize and hipStreamWaitEvent APIs
did not function correctly for events created with the hipEventInterprocess flag.
The bug caused the event to be incorrectly marked as "recorded,"
leading to these APIs failing to wait for the event as expected.
Change-Id: Ic9fdfaab2393beb93d6e0b83661545e902a63499
[ROCm/clr commit: 1cdfbfd270 ]
2025-02-11 18:43:06 -05:00
Vladana Stojiljkovic
4b786b5207
SWDEV-498061 - Add capture support for hipModuleLaunchCooperativeKernel
...
Change-Id: I5ed188e046c680c2785b3952391f59ed1d0c21b8
[ROCm/clr commit: 30cb2d0e67 ]
2025-01-16 10:54:30 -05:00
Marko Arandjelovic
8647bb483b
SWDEV-504084 - Make hipModuleGetFunction use the device the module is loaded on
...
If a module is loaded on one device, hipModuleGetFunction and other similar APIs should be able to run successfully from another device.
Change-Id: I96084cbd6c6dcf2a81019779a6ab1842ef2f35d1
[ROCm/clr commit: c46f843b99 ]
2025-01-16 10:16:42 -05:00
Vladana Stojiljkovic
3e8d5599d4
SWDEV-494612- Add capture support for hipLaunchCooperativeKernel
...
Change-Id: I6b3c6af55c60cffd43ce6f47b75998f750b75703
[ROCm/clr commit: b75b0d9a53 ]
2024-11-29 08:17:41 -05:00
Ioannis Assiouras
eae7d9bdc8
SWDEV-496003 - Add support for dynamic functions in hipFuncSetAttribute
...
Modified hipFuncSetAttribute to handle pointers to dynamic functions
returned by hipModuleGetFunction.
Change-Id: I54b98f9d31a79630dd7edcd363fad81f1d89219b
[ROCm/clr commit: 1a710dabcf ]
2024-11-19 04:50:15 -05:00
Sourabh Betigeri
78d068f153
SWDEV-450052 - Return if numDevices is more than device count on the platform
...
Change-Id: I538106d1b02084df9cd06b41427629207312e76f
[ROCm/clr commit: 64e1b15551 ]
2024-10-24 17:07:11 -04:00
Saleel Kudchadker
5c03a593e7
SWDEV-491375 - Optimize multithreaded dispatches
...
- Fix typo
Change-Id: If4c68455dcfa03fee18cb4720e8b5b438642703c
[ROCm/clr commit: 0f2342bc13 ]
2024-10-17 17:02:23 -04:00
Rahul Manocha
da48c3b185
[SWDEV-467733] - Add Param checking for SetCacheConfig APIs
...
Change-Id: I9e777fa0fae6791ebab539e49346e6956a6ff196
[ROCm/clr commit: 0d20383ef9 ]
2024-09-27 11:32:58 -04:00
Ajay
d7f4f778b3
SWDEV-465215 - hipFuncSetAttribute hipFuncGetAttributes fixes
...
Change-Id: I2151e4470d63918ff6b809a8fdeaae5bea5cc899
[ROCm/clr commit: c9955a1cea ]
2024-09-13 14:05:25 -04:00
Jaydeep Patel
82474ca1db
SWDEV-465220 - Validate stream on which Kernel is planned to be launched.
...
Change-Id: I34c679bd888c275584c11ad3e8346d4d542976f9
[ROCm/clr commit: b0047d690a ]
2024-08-06 00:31:22 -04:00
Marko Arandjelovic
7cd2515908
SWDEV-465204 - Fix hipModuleLaunchKernel data validation
...
Change-Id: I129f265a5eb79d0a13da4f12e78e06ba307b17ee
[ROCm/clr commit: be5f097e8e ]
2024-08-01 05:09:23 -04:00
kjayapra-amd
30a4b9e316
SWDEV-460948 - Remove dflock, since kernel arguments are part of command now.
...
Change-Id: I6b5a229307b41bd24ffa0bc172c64ad1154df474
[ROCm/clr commit: 9c03f85f46 ]
2024-07-22 16:02:01 -04:00
Julia Jiang
3c7ae28776
SWDEV-472710 - Adding gitattributes and remove trailing spaces
...
Change-Id: Ic8ad2071745f0ffe6a2e120bfebb6d90bf270f87
[ROCm/clr commit: dd30e0e893 ]
2024-07-15 12:39:56 -04:00
kjayapra-amd
41cb6dadf9
SWDEV-460948 - Changes to alloc, set, capture under single function.
...
Change-Id: I7b2d40e99e812b97c53535c5e63c41ad64a8f543
[ROCm/clr commit: 892071aeb2 ]
2024-06-06 16:57:53 -04:00
Ajay
5b731168ca
SWDEV-439581 - hip event flags clean up
...
Change-Id: I2197762d912da41a8b53b32b3446f0a958c988a6
[ROCm/clr commit: 6ec5074d74 ]
2024-05-28 06:31:10 +00:00
Tao Sang
5bf67d7da7
Revert "SWDEV-433371 - use comgr to unbundle code objects"
...
This reverts commit c0ee0ffa1c .
Reason for revert: <INSERT REASONING HERE>
New comgr unbundling action leads to perf drop for uncompressed code object. Will create a new patch to use old path for uncompressed , new unbundling api for compressed .
Change-Id: I41ef53b71fc9f7aaa8cf231d4d70945f1117db52
[ROCm/clr commit: a1350fe8c1 ]
2024-05-28 06:31:10 +00:00
taosang2
c0ee0ffa1c
SWDEV-433371 - use comgr to unbundle code objects
...
1.Make runtime use comgr to unbundle code objects
2.Support compressed/uncompressed modes
3.Remove HIP_USE_RUNTIME_UNBUNDLER and
HIPRTC_USE_RUNTIME_UNBUNDLER to simplify logics
4.Add comgr wrapper for
amd_comgr_action_info_set_bundle_entry_ids()
Change-Id: Ic41b1ad1b64cca1e31986437983a5146d52a7329
[ROCm/clr commit: e53df57ffe ]
2024-05-01 16:09:12 -04:00
Rahul Manocha
35ab01f7de
[SWDEV-442583] - Fix hipLaunchCooperativeKernel API error codes
...
Change-Id: Id3cb4b58b9efd3aceec4377d4d1d3a053c50333e
[ROCm/clr commit: 59051ed3af ]
2024-05-01 11:36:59 -04:00
Jaydeep Patel
c4239ed8e8
SWDEV-446992 - Request can be for bytes OR dptr OR both.
...
Change-Id: Ib479c744b90125b74d99cbf18b7f4b8cf765bf1c
[ROCm/clr commit: 09328f45b3 ]
2024-03-26 11:10:24 -04:00
Satyanvesh Dittakavi
15f01694f4
SWDEV-444021 - Implement hipGetFuncBySymbol
...
Change-Id: I7ef13d02c5b5c6ce2386ccb92b5602d005b35988
[ROCm/clr commit: 684fd60c8f ]
2024-03-14 02:56:30 -04:00
Jaydeep Patel
97ad1412ea
SWDEV-445539, SWDEV-445549 - Restore kernel launch prof data.
...
Issue is due to INIT_hipLaunchKernel_CB_ARGS_DATA turns out to be empty when we generate new hip_prof_str.h with since
extra space introduced by https://gerrit-git.amd.com/c/compute/ec/clr/+/846275/77/hipamd/src/hip_module.cpp#667
Change-Id: Id251956c1663483cc7ab11a3722769cb5b0d3664
[ROCm/clr commit: d1b75659f2 ]
2024-02-14 00:05:41 -05:00
Anusha GodavarthySurya
daf22604af
SWDEV-439637 - Updated to compile with clang compiler
...
Change-Id: Ib0a8e1cc007f083fb1d1f4363cf89ba76ad3c4f2
[ROCm/clr commit: a1b2cbe44e ]
2024-02-06 23:57:13 -05:00
Anusha GodavarthySurya
b10799a7e7
SWDEV-351966 - Rename hip::__hipExtModuleLaunchKernel to hip::hipExtModuleLaunchKernel
...
Change-Id: Ie922760f37bf0c9abf2653d36e32705a12ab5a90
[ROCm/clr commit: 9b6cf0f74b ]
2023-12-20 22:50:01 -05:00
Saleel Kudchadker
f969d89aa4
SWDEV-301667 - Logging refactor
...
- Remove newline from logging as log function internally inserts a new
line
Change-Id: I25eb2242a1f1e87cf811bcc373d1d485b2e027a8
[ROCm/clr commit: 058b2702db ]
2023-12-07 12:12:57 -05:00
Anusha GodavarthySurya
3bdedf0cc7
SWDEV-351966 - Dispatch table for hip runtime
...
Change-Id: Ie4a44fa8cf1ff9c152146070bbbf6b0636d4e325
[ROCm/clr commit: 5e21f0c6bd ]
2023-11-22 01:11:19 -05:00
sdashmiz
fffa6e3296
SWDEV-389530 - [ABI Break]Match error with cuda
...
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: Id9de54b4fd1be7b6b887a4ebfcc6a3d9a70c7bc9
[ROCm/clr commit: 2d83abaca6 ]
2023-10-16 07:31:34 -04:00
Ioannis Assiouras
dda3517ead
SWDEV-425129 - Revert "SWDEV-420822 - [ABI Break] Merge hipFunction_attribute into hipFuncAttribute"
...
This reverts commit 1502016756 .
Change-Id: I02d6e77f0874fc37f22de267435917edd4fdede3
[ROCm/clr commit: bf31109241 ]
2023-10-03 11:32:19 +01:00
Ioannis Assiouras
1502016756
SWDEV-420822 - [ABI Break] Merge hipFunction_attribute into hipFuncAttribute
...
Change-Id: I9b9f7979e9b8dd422d9064c17c79a25bf7248d30
[ROCm/clr commit: c469f18e91 ]
2023-10-01 06:52:12 -04:00
pghafari
f088f06be6
SWDEV-369567 - [ABI Break] updating gridY and Z max dimension check
...
Change-Id: If515fda4938d3c5f455a02b4a65adaad76dc0aed
[ROCm/clr commit: 96f41fad07 ]
2023-09-22 04:52:27 -04:00
Ioannis Assiouras
fb17aa5c41
SWDEV-401489 - [ABI Break] Removed hipModuleLaunchKernelExt
...
Change-Id: I0b31d9db755f8a89ead203dbd238a93c18b76855
[ROCm/clr commit: fe2d747bcc ]
2023-09-21 23:50:16 -04:00
Ioannis Assiouras
a0ee7e2784
SWDEV-419996 - Allow both kernelParams and extra arguments to be set to null
...
When kernel function expects no parameters no error should be returned
if both kernelParams and extra arguments are set to null.
Change-Id: I5941bcc400b6fb380e623bdae0233ae3e4f73815
[ROCm/clr commit: 315082e554 ]
2023-09-07 12:57:46 -04:00
Maneesh Gupta
e45838a25c
Revert "SWDEV-389530 - [ABI Break]Match error with cuda"
...
This reverts commit 2b78a9c443 .
Change-Id: I07aac68c76b3bc42b595330fdbbb04646b35a814
[ROCm/clr commit: 76a4bd1d7f ]
2023-07-31 21:41:54 -04:00
sdashmiz
2b78a9c443
SWDEV-389530 - [ABI Break]Match error with cuda
...
- match error for invalid params
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I2faf1191f665d8bd06d6ba315f440e87b1a5b8ab
[ROCm/clr commit: c7d8557eee ]
2023-07-26 20:32:41 -04:00
pghafari
b01ca8b9c7
SWDEV-406821 - use int32 for grid y,z till rocm 6
...
Change-Id: If9eee4dd5553cc81e283cb2211cc69884808d5c1
[ROCm/clr commit: 9e08ecdd16 ]
2023-06-22 09:42:00 -04:00
pghafari
9eda493469
SWDEV-399734, SWDEV-399733 - update maxGridDim for y and z
...
Change-Id: Id5b1dd2491798dd20a0672362f445ab4de164f6d
[ROCm/clr commit: fb82b292c2 ]
2023-05-17 19:03:04 -04:00
pghafari
505bce23be
SWDEV-369567 - dimension check update
...
Change-Id: I31deb5070d4852db7dd6d37f9a514965f387698e
[ROCm/clr commit: 31b362bf6e ]
2023-05-02 08:04:04 -04:00
German Andryeyev
a6f2ecd703
SWDEV-231145 - Add a validation for uniform launch
...
Change-Id: I68d61690c50060d9dcca117b248dddf69204a23f
[ROCm/clr commit: e82eecf33e ]
2023-04-18 12:56:09 -04:00
German Andryeyev
237480711a
SWDEV-382359 - Workaround a non-uniform launch in MIOpen
...
Change-Id: I0abff25fb20143225739e771c4d3bae5c2a054b9
[ROCm/clr commit: 73698479a9 ]
2023-04-18 11:36:10 -04:00
Ioannis Assiouras
bf7e31c1ff
SWDEV-388278 - Fix return HIP_RETURN(x)
...
Change-Id: I940ee3660a2427eade8690a9318966fb04a1fbe8
[ROCm/clr commit: e6520ddf8a ]
2023-03-13 13:32:55 +00:00
Saleel Kudchadker
9fdbbe53dc
SWDEV-364604 - Add support for hipEventDisableSystemFence
...
Change-Id: I1a6451c873fb22729ac61e4e80f8531251e990f0
[ROCm/clr commit: 7fc5ae2226 ]
2023-02-21 23:11:40 -05:00
Ioannis Assiouras
2633e62801
SWDEV-381402 - Derive hip::Stream from amd::HostQueue
...
Change-Id: I6c1aca5eb350c32d974ae4ffcc725705355956d8
[ROCm/clr commit: e3633dc8f4 ]
2023-02-21 18:12:03 -05:00
victzhan
46652f12a2
SWDEV-376995 - Fixed misplaced checking
...
Change-Id: Ia3bddabfa7fc76066541fb81723136ae6cffb0a4
[ROCm/clr commit: d6a08403d8 ]
2023-02-17 13:34:51 -05:00
victzhan
94f9990e27
SWDEV-376995 - Added if statement so that when AQL dispatch failed it returns corresponding hip error instead of hipSuccess
...
Change-Id: I0724fbcf0833c5dd8b2e4d6e443b3e226046dddf
[ROCm/clr commit: 4e324a9c63 ]
2023-02-14 14:30:50 -05:00
Jaydeep Patel
5981bd5c22
SWDEV-379395 - Use getQueue as it handles null stream and flags can be combination.
...
Change-Id: If37854a9fc0fc57acb30e652953a7f283831cad8
[ROCm/clr commit: 01c3299425 ]
2023-02-01 12:03:42 -05:00
pghafari
829bbe4933
SWDEV-369570 - MaxSharedMemoryPerBloc check
...
Change-Id: I74d216a5d9316758bb611eb241ba85222194ce8b
[ROCm/clr commit: 2e60edbe0e ]
2023-01-17 07:52:15 -05:00
Ioannis Assiouras
1974ef22cf
SWDEV-374403 - Added input sanity checks for hipLaunchCooperativeKernelMultiDevice and hipExtLaunchMultiKernelMultiDevice
...
Change-Id: Iebef5ae68439d87549fdf9559de51c6c79c64392
[ROCm/clr commit: 0d2e0d1621 ]
2023-01-13 19:48:42 -05:00