c693890216
Fix for #300 ( #331 )
...
On some versions of numpy/pandas, applying a str map to an empty series doesn't change the type.
As a result, when adding a float to a string, sometimes numpy dies with a uadd error.
We fix this by explicitly casting to a str first
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: d72ef52208
2024-04-01 14:30:21 -05:00
8943f686f5
Fixing visualization for Compute Pipeline SOL. Need to consider 'Pct of Peak' rather than 'Avg'
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 62221383a7
2024-03-18 14:28:14 -05:00
fbb88baa20
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 4fc30eb5c4
2024-03-15 16:40:13 -05:00
19a9e0431c
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: f4070e3654
2024-03-15 14:04:49 -05:00
fa0cc81720
Update roofline distro_map for Ubuntu22.04 ( #319 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 2dcad38028
2024-03-15 12:47:30 -05:00
a8dcdec00f
tweak logger formatter to suppor OMNIPERF_COLOR=2 which includes the
...
loglevel name in output, but without color
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 69de978d35
2024-03-15 09:31:22 -05:00
3a77ecadd3
bug fix for df tracing output - add more function demarcation
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: c29f28e25e
2024-03-15 09:31:22 -05:00
624606771f
enable more function demarcation for analyze tracing
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 76121f20a9
2024-03-15 09:31:22 -05:00
3dbe61f462
logger update: assign color for TRACE level
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 3438bc9d0f
2024-03-14 17:37:30 -05:00
8d6a8e3b06
update logging formatter handling for consistent behavior with error messsages
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 69af2ffc83
2024-03-14 17:37:30 -05:00
ff7751724b
Fix missing argv in console_warning()
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: e7cc326d5a
2024-03-12 16:44:02 -05:00
bd4bc51cd4
change stubbed values to hbm bw ( #302 )
...
* change stubbed values to hbm bw
Signed-off-by: Jose Santos <josantos@amd.com >
* Reformat
Signed-off-by: Jose Santos <josantos@amd.com >
* Update analysis_webui.py
remove print statements
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/omniperf_analyze/analysis_webui.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/omniperf_analyze/analysis_webui.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
---------
Signed-off-by: Jose Santos <josantos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
Co-authored-by: Cole Ramos <colramos@amd.com >
[ROCm/rocprofiler-compute commit: efb8f131ec
2024-03-12 16:08:30 -05:00
513ba356ae
Kernel no overwrite ( #303 )
...
* Removing kernel name shortener from profile
- Kernel name shortener now in analyze
- db import uses pymongo to import
Signed-off-by: Jose Santos <josantos@amd.com >
* collections now added using pymongo
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* kernel_name_shortener shortens dataframes and not a workload
- argparser: --kernel-verbose to connection group
- analysis_cli, profiler_rocprof_v2: remove kernel_name_shortener, so that it doesnt overwrite workload
- db_import: demangle kernel_name dfs
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* fix db name in pymongo command
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* reformat
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* fix typo
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* remove checker for verbose in profiler_base
Signed-off-by: Jose Santos <josantos@amd.com >
* kernel_name_shortener now called in create_df_kerenel_top_stats and
create_df_pmc
Signed-off-by: Jose Santos <josantos@amd.com >
* add kernel_verbose to analysis_webui, remove stubbed values
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* Update src/utils/kernel_name_shortener.py
keep console_debug
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/utils/kernel_name_shortener.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
---------
Signed-off-by: Jose Santos <josantos@amd.com >
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
Co-authored-by: Cole Ramos <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 4424f320ad
2024-03-12 15:54:52 -05:00
4fb2f6e2b4
Update DB module for new sysinfo keys
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 706d3bb9f0
2024-03-12 12:24:49 -05:00
28f027c7bf
move set_locale_encoding() to occur after logging is setup - allows
...
function to use console_error() directly (https://github.com/AMDResearch/omniperf/pull/308#discussion_r1519914083 )
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: e85037fdfb
2024-03-11 14:19:01 -05:00
6b0a36cb27
Update src/utils/utils.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: 5e21dc35fd
2024-03-11 14:19:01 -05:00
d4015bd76b
Update src/utils/db_connector.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: ebc9108da0
2024-03-11 14:19:01 -05:00
ed8d923155
Update src/utils/db_connector.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: 523639a7fd
2024-03-11 14:19:01 -05:00
f287aa0fc8
Update src/utils/utils.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: 8e45cc897f
2024-03-11 14:19:01 -05:00
35a983b85a
allow color formatter via env variable OMNIPERF_COLOR=1
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 34070394eb
2024-03-11 14:19:01 -05:00
9d7dde19b0
refactor setting of local encoding; remove from top-level omniperf
...
wrapper and push into base class via a companion utility function
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 27a57bdafb
2024-03-11 14:19:01 -05:00
2d84322ea1
update print_status() to use console logger; convert some info logs to debug logs
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 15c86ba424
2024-03-11 14:19:01 -05:00
fdbc5565f3
rework of logger.py setup to introduce another setup_file_handler() -
...
this function enables file-based logger output for use with profile
mode
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 505e263279
2024-03-11 14:19:01 -05:00
917b784ead
refactor logging initialization into two steps:
...
(1) setup_logging_handler -> called prior to arg parsing
(2) setup_logging_priority -> called after arg parsing
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: e24e6c35a5
2024-03-11 14:19:01 -05:00
975c2dad8b
add quietmode option to setup_logging function
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: abd3d20cb2
2024-03-11 14:19:01 -05:00
a9cda2ad33
add a exit keyword to console_error function; allows multiple error
...
lines prior to code exit
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 2b24375e8d
2024-03-11 14:19:01 -05:00
7756a5b00b
updates for run_prof() routine:
...
* add a profileMode keyword option, used to indent profiling output
* update logic if forked process is not successful, output is
displayed directly with INFO logging or lower; also dispaly output
in ERROR mode if the process fails
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 377c642ac2
2024-03-11 14:19:01 -05:00
ab3ce5ecb8
remove duplicate process output within run_prof()
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: dcdef37c34
2024-03-11 14:19:01 -05:00
89bc098c59
include ERROR delimiter directly for console_error() messsages
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 61267ee262
2024-03-11 14:19:01 -05:00
a5e23e17fe
add a profileMode option to capture_subprocess_output() - includes
...
indented output with profiler selection when enabled
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: cc7a725ae8
2024-03-11 14:19:01 -05:00
587d55cd9d
minor refactor of print_status()
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 6bb4210d94
2024-03-11 14:19:01 -05:00
b948aa6ebf
add indent support to console_log()
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 63129e4247
2024-03-11 14:19:01 -05:00
16f580b992
update setup_logging function to return loglevel; disable inclusion of
...
loglevel delimiter in output
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: bdfc536ade
2024-03-11 14:19:01 -05:00
91434bcebf
Fix dangling merge conflict
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 6c5a3623b6
2024-03-11 14:19:01 -05:00
98e5e16d0e
Fix python formatting
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: f2aac37178
2024-03-11 14:19:01 -05:00
00c17f423c
Replaced some straggling print statements with log functions
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 771644f5f7
2024-03-11 14:19:01 -05:00
569dff3627
Connect verbosity flag to loglevel
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 5ed9a5c902
2024-03-11 14:19:01 -05:00
a1371462ba
All logging should use call new functions
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 5bf38a4fed
2024-03-11 14:19:01 -05:00
cfdf288cba
Dedicated logging function for each log level
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 233905071c
2024-03-11 14:19:01 -05:00
39a9961060
Remove outdated remove_workload.py module
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 0611ce4582
2024-03-11 14:19:01 -05:00
15aac4690c
Standalone logging module for cleaner omniperf_base.py
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 2e09f0be7e
2024-03-11 14:19:01 -05:00
4585750893
Force encoding before Omniperf execution ( #299 )
...
* Force encoding before Omniperf execution
Signed-off-by: colramos-amd <colramos@amd.com >
* Fix circular dependency in utils module
Signed-off-by: colramos-amd <colramos@amd.com >
---------
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: f4511e7280
2024-03-06 17:01:07 -06:00
af6567ebdb
bump statman-stopwatch to 2.18 ( #220 )
...
* Lock Pandas to version 1.4.3 for tutorial
Signed-off-by: colramos-amd <colramos@amd.com >
* Establish connection between kernel related flags in Analyze Mode (#187 )
Signed-off-by: colramos-amd <colramos@amd.com >
* Fixing bug in kernel/dispatch filter pytest
Signed-off-by: colramos-amd <colramos@amd.com >
* More CI logic errors fixed
Signed-off-by: colramos-amd <colramos@amd.com >
* Update CHANGES
Signed-off-by: Cole Ramos <colramos@amd.com >
* Update CHANGES
Signed-off-by: Cole Ramos <colramos@amd.com >
* Update README.md
Signed-off-by: Cole Ramos <colramos@amd.com >
* bump statman-stopwatch to 2.18
Signed-off-by: Jason Ray <jayray.net@gmail.com >
* Fix merge mistakes
Signed-off-by: colramos-amd <colramos@amd.com >
---------
Signed-off-by: colramos-amd <colramos@amd.com >
Signed-off-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Jason Ray <jayray.net@gmail.com >
Co-authored-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 994aea9f0e
2024-03-05 11:16:23 -06:00
7a8bf7f720
Account for missing GRBM_GUI_ACTIVE in roof-only mode ( #103 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: a44e07d928
2024-03-05 10:43:24 -06:00
654295db20
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: f94da3228d
2024-03-03 15:20:21 -06:00
ee3ba49168
Fix typo, patch issue in kernel filtering in standalone GUI, and error on version mismatch
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: ea9783f105
2024-03-03 14:38:28 -06:00
6d48d79572
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: ca59cbe3a3
2024-03-02 12:28:34 -06:00
038dd3e27f
Fix missing median values
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7b8cf17254
2024-03-01 18:00:17 -06:00
d7685d3412
Add custom decorator to avoid using kw_only
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: cdeb2c7e85
2024-03-01 17:49:22 -06:00
5868974f74
CMake and Python format
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 1dc4553091
2024-03-01 15:50:42 -06:00
Nick Curtis
colramos-amd
Karl W Schulz
JoseSantosAMD
Karl W. Schulz
Jason Ray