Commit graph

5458 Commits

Autor SHA1 Nachricht Datum
Rahul Garg 178d432b90 Fix nested designator warnings (#1768) 2020-01-06 12:33:34 +05:30
Rahul Garg 3fe1695c3a Fix hipcc warning related to hipVersion (#1767)
* Fix hipcc warning related to hipVersion
* Rename hipVersion.h to hip_version.h
* Remove HIP_VERSION splitting
* Update .gitignore
- Ignore generated include/hip/hip_version.h
- Removed some stale entries
- Added executables from samples/1_Utils/*/ for consistency with bin/ entries.
2020-01-06 12:33:23 +05:30
Yaxun (Sam) Liu c80c2bf234 Update HIP-Clang build instruction (#1764) 2020-01-06 12:32:47 +05:30
Yaxun (Sam) Liu 7dcd5f6329 Document FMA settings (#1717) 2020-01-06 12:32:38 +05:30
foreman a941903848 P4 to Git Change 2052191 by skudchad@skudchad_test2_win_opencl on 2020/01/03 15:54:23
SWDEV-213000 - Backout change to notifyCmdQueue as the real issue has been identified

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#53 edit
2020-01-03 16:02:59 -05:00
foreman 955b224ea0 P4 to Git Change 2051060 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/12/30 16:42:07
SWDEV-145570 - Clean up after `hipError_t` unification.

	- Replace deprecated `hipError_t` enums.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#94 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#52 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#27 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#5 edit
2019-12-30 16:46:39 -05:00
Evgeny Mankov ed43699a3a Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)
2019-12-30 19:21:09 +03:00
Sarbojit2019 4fd77f8336 Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.
2019-12-30 12:44:24 +05:30
Aryan Salmanpour 857052be1e [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.
2019-12-30 12:42:17 +05:30
ansurya 651c7a8e27 Fix texture 3D & 2D layered with N components (#1746)
SWDEV-151670: Issue with 3D texture with 4 components
SWDEV-151671: Issue with 2D layered texture with 4 components

Fixed memcpy when memory is allocated with driver API's.

Github issues: #1755
Fixed 3D default case when array type is not set during memory allocation.
2019-12-30 12:41:42 +05:30
foreman 4185d21347 P4 to Git Change 2049729 by skudchad@skudchad_test2_win_opencl on 2019/12/23 12:36:57
SWDEV-203814 - Change the return type of the hiprtcGetTypeName to have compatibility across ABIs

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18392/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#9 edit
2019-12-23 12:42:24 -05:00
Evgeny Mankov 006e6844c1 Merge pull request #1762 from emankov/hipify-clang
[HIPIFY][doc] LLVM 9.0.1 is the latest stable release now
2019-12-23 20:02:32 +03:00
Evgeny Mankov 2d7e766cc7 [HIPIFY][doc] LLVM 9.0.1 is the latest stable release now
+ Tested on Windows and Linux: no changes are needed
2019-12-23 20:00:33 +03:00
Evgeny Mankov 4aaa2336a8 [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle
2019-12-23 17:01:35 +03:00
Yaxun (Sam) Liu 35988729f3 Add macro __HIP_ENABLE_CUDA_WRAPPER_FOR_OPENMP__ (#1761)
This is to allow force enable cuda wrapper for OpenMP for flexibility
2019-12-23 19:24:54 +05:30
saleelk 1ca75e5f6d Fix the return type of demangle function so that its compatible across ABIs (#1744) 2019-12-23 19:11:40 +05:30
Alex Voicu 150e690a3a Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.
2019-12-23 19:11:24 +05:30
Maneesh Gupta 32625638da replace array designator C99 (#1694)
* replace array designator C99

* Update texture_functions.h

Highlight valid and invalid values in texFormatToSize

Co-authored-by: Maneesh Gupta <maneesh.gupta@amd.com>
2019-12-23 19:10:24 +05:30
Alex Voicu cf526f5484 static inline in a header, just like excess sugar in a diet, causes bloat (#1692) 2019-12-23 19:09:38 +05:30
Evgeny Mankov 4d29423705 [HIP] Fix typo 2019-12-23 12:06:44 +03:00
Evgeny Mankov 9ae76609a1 [HIP] Unify hipError_t (Step 2)
Step 2. Make a few hipError codes deprecated
Update hipify-clang, hipify-perl, docs and samples accordingly
2019-12-22 02:05:31 +03:00
Evgeny Mankov 3c6203c814 Merge pull request #1734 from vsytch/win10-hipMemcpy-fixes
Fix OOM issues with hipMemcpy test on Windows
2019-12-21 22:02:34 +03:00
Maneesh Gupta 6c7ce07577 Update texture_functions.h
Highlight valid and invalid values in texFormatToSize
2019-12-21 12:25:36 +05:30
Maneesh Gupta 86e590ad62 bump version to 3.1 (#1756)
* Bump version to 3.1

* [ci] Enable tests on ROCm 3.0
2019-12-20 12:10:25 -08:00
foreman ba3da9b3ec P4 to Git Change 2049240 by lmoriche@lmoriche_opencl_dev2 on 2019/12/20 13:54:17
SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES

	Return an error instead of dereferencing a null pointer. This should address the issue described
	in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#59 edit
2019-12-20 13:02:52 -06:00
Evgeny Mankov 4a8b87a96c Merge pull request #1757 from emankov/master
[HIPIFY][doc] Update Readme.md: versioning
2019-12-20 20:57:48 +03:00
Evgeny Mankov 65dd13c677 [HIPIFY][doc] Update Readme.md: versioning 2019-12-20 20:55:19 +03:00
Sarbojit2019 911d406bf1 Fix for windows dtest build failure (#1742) 2019-12-19 13:10:43 -08:00
foreman 62f9114fd4 P4 to Git Change 2048698 by jujiang@JJ-HIP on 2019/12/19 15:52:21
SWDEV-215536 - [HIP][Windows]Output mismatch with tex2DLayered()

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#93 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#31 edit
2019-12-19 15:57:37 -05:00
mhbliao a0a50ac601 [hip] Add macro guarding the enum conversion for scalar accessor. (#1748)
- That's a high overhead part, which needs enabling ONLY if necessary.
2019-12-19 10:08:37 -08:00
Evgeny Mankov 08f1c8edf3 Merge pull request #1739 from emankov/hipify-clang
[HIP] Unify hipError_t (Step 1)
2019-12-19 07:57:02 +03:00
foreman 75df64737f P4 to Git Change 2047959 by skudchad@skudchad_test2_win_opencl on 2019/12/18 14:40:28
SWDEV-213000 - Add notifyCmdQueue in ihipModuleLaunchKernel. This torques timing and flushes the queue immediately. Investigation pending.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18408/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#51 edit
2019-12-18 14:42:18 -05:00
foreman 8d32b426dd P4 to Git Change 2047424 by lmoriche@lmoriche_opencl_dev2 on 2019/12/17 20:13:01
SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES

	Return an error instead of dereferencing a null pointer. This should address the issue described
	in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#92 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#58 edit
2019-12-17 20:18:36 -05:00
Evgeny Mankov b1aa111446 Merge pull request #1743 from emankov/master
[HIPIFY] Revise HIP runtime
2019-12-16 20:11:19 +03:00
Evgeny Mankov 1108ef06e1 [HIPIFY] Revise HIP runtime
+ hipMemAllocHost is deprecated, use hipHostMalloc instead
+ hipMemAllocManaged -> hipMallocManaged
+ hipFreeHost -> hipHostFree
+ cudaMemset3D(Async) -> hipMemset3D(Async)
+ update docs and hipify-perl accordingly
2019-12-16 20:09:55 +03:00
Vladislav Sytchenko a91bafca40 Add comments explaining choice on the cap for system memory on Windows. 2019-12-13 21:38:27 -05:00
Vladislav Sytchenko 4c21eed68b Add explicit cast when computing the available amount of system memory. 2019-12-13 21:37:30 -05:00
Evgeny Mankov 21b0f64f3a [HIP] Unify hipError_t (Step 1)
Step 1. Set the same values for RT error codes as for analogous Driver's

[Reason] RT's and Driver's error codes unification in CUDA 10.2
2019-12-13 19:40:16 +03:00
Evgeny Mankov 207d7d7475 Merge pull request #1738 from emankov/hipify-clang
[HIPIFY][build] Fix building with LLVM trunk
2019-12-13 15:43:24 +03:00
Evgeny Mankov 1377db639f [HIPIFY][build] Fix building with LLVM trunk 2019-12-13 15:42:27 +03:00
foreman 35e0c1b6c4 P4 to Git Change 2045076 by skudchad@skudchad_test2_win_opencl on 2019/12/12 15:57:20
SWDEV-213031 - Check the functions_ map else interpret as a hip::Function for now. Function may not be a device function and may have been obtaiend via hipModuleGetFunction and thus not in the functions_ map

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18388/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#57 edit
2019-12-12 16:01:14 -05:00
Evgeny Mankov dadbdad99d Merge pull request #1736 from emankov/hipify
[HIPIFY][BLAS] Sync with cuBlas/rocblas/hipBlas
2019-12-12 19:56:08 +03:00
Evgeny Mankov c7bea1f865 [HIPIFY][BLAS] Sync with cuBlas/rocblas/hipBlas 2019-12-12 19:52:18 +03:00
foreman 5fd041aca7 P4 to Git Change 2044900 by skudchad@skudchad_test2_win_opencl on 2019/12/12 11:42:43
SWDEV-203814 - Add cases to handle char* and char** for tracehelper

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18384/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#4 edit
2019-12-12 11:47:12 -05:00
Vladislav Sytchenko 282367ed6d Reduce the amount of free host memory to 40% of what is reported on Windows, otherwise we can run into OOM situations. 2019-12-11 20:21:12 -05:00
foreman 24deabe498 P4 to Git Change 2044310 by cpaquot@cpaquot-ocl-lc-lnx on 2019/12/11 19:20:38
SWDEV-213526 - [hip] OOM issue
	Clean up a bit from Laurent's comments.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#50 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#56 edit
2019-12-11 19:31:20 -05:00
foreman e3448ce6c4 P4 to Git Change 2044309 by cpaquot@cpaquot-ocl-lc-lnx on 2019/12/11 19:19:15
SWDEV-145570 - [hip] special case const char* for logs in case it's a null pointer.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#3 edit
2019-12-11 19:26:50 -05:00
foreman 38d4f7f091 P4 to Git Change 2044223 by jujiang@JJ-HIP on 2019/12/11 16:16:37
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
	-Update hipCreateTextureObject

	http://ocltc.amd.com/reviews/r/18382/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#91 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#30 edit
2019-12-11 16:30:48 -05:00
foreman f5921646e4 P4 to Git Change 2043802 by cpaquot@cpaquot-ocl-lc-lnx on 2019/12/11 03:06:02
SWDEV-213526 - [hip] OOM issue
	Delay any access to device layers till HIP API is called by app.
	This allows the app to fork the process first and then call HIP which is legal.
	Doing hip calls then fork isn't legal nor supported by ROCm.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#49 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#55 edit
2019-12-11 03:11:19 -05:00
mhbliao 539370d308 Only add hipExtLaunchMultiKernelMultiDevice for non-HCC compilers. (#1729) 2019-12-10 10:32:25 -08:00