Commit Graph

5458 Commits

Author SHA1 Message Date
Jenkins b79041c97e Merge 'master' into 'amd-master'
Change-Id: Ieef32efec384d27df2a0fbe262be139b5e734b43
2019-12-10 11:06:12 +00:00
jglaser 280a8ebadf fix linking of vector types with gcc (#1690)
* fix linking of vector types when linking hipcc objects with gcc

* use __atribute__((vector_size)) with both clang and gcc

and reinstate nonaligned n=3 vector type

* use implicit conversion to value and ext_vector_type when available

* Alternate formulation for GCC compatibility

* Built-in arrays don't mix well with placement new

* Fix typo

* Add conversions to enum

* Fix Scalar_accessor assignment.

* Update hip_vector_types.h

* stir up the underlying_type hideous mess

This fixes the HIP build issue "error: only enumeration types have underlying types".
2019-12-10 09:40:15 +05:30
foreman 441c3d0a5b P4 to Git Change 2042612 by eshcherb@evgeny-hip on 2019/12/09 11:11:38
SWDEV-197289 - HIP-VDI tracing
	activity suppressing of type is zero;
	fixing callbacks table recursive mutex;

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#101 edit
2019-12-09 11:22:57 -05:00
Evgeny Mankov 8223a48683 Merge pull request #1725 from emankov/hipify-clang
[HIPIFY] Add cleanupHipifyOptions functionality
2019-12-08 15:15:57 +03:00
Evgeny Mankov 486ec185e7 [HIPIFY] Add cleanupHipifyOptions functionality
Needed for sorting input files to avoid clang errors on unsupported options
2019-12-08 15:13:28 +03:00
Evgeny Mankov 62df9e5732 Merge pull request #1723 from emankov/hipify-clang
[HIPIFY] main source file refactoring
2019-12-07 14:07:23 +03:00
Evgeny Mankov 72b1d16115 [HIPIFY] main source file refactoring 2019-12-07 13:50:13 +03:00
Evgeny Mankov 97537d0818 Merge pull request #1722 from emankov/hipify-clang
[HIPIFY][fix][#1246][#1655] Sort input files based on their dependency graph
2019-12-07 11:23:01 +03:00
Evgeny Mankov ef405daaee [HIPIFY][fix][#1246][#1655] Sort input files based on their dependency graph
+ Implemented by using clang Driver infrastructure

[ToDo] Add tests for in-place hipification of multiple files
2019-12-07 11:20:17 +03:00
foreman 755f35e7d8 P4 to Git Change 2042093 by jujiang@JJ-HIP on 2019/12/06 14:44:16
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
	-Update hipTexRefSetArray

	http://ocltc.amd.com/reviews/r/18356/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#29 edit
2019-12-06 14:53:41 -05:00
mhbliao 209f31525f Fix hipExtLaunchMultiKernelMultiDevice refactoring. (#1714)
- Use the correct condition for HIP VDI runtime.
2019-12-06 09:49:17 -08:00
Jenkins 15aa9de37f Merge 'master' into 'amd-master'
Change-Id: I11a48b1198f902fa74e9c0cf7e234c81fb704968
2019-12-06 10:51:37 +00:00
foreman e20237e406 P4 to Git Change 2041756 by cpaquot@cpaquot-ocl-lc-lnx on 2019/12/06 00:27:07
SWDEV-213526 - [hip] OOM issue
	Restore lazy kernel uploads for 2.10 release.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#54 edit
2019-12-06 00:33:55 -05:00
Rahul Garg a369bd4418 Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.
2019-12-06 09:51:53 +05:30
foreman 6e9e96493f P4 to Git Change 2040890 by skudchad@skudchad_test2_win_opencl on 2019/12/04 14:16:51
SWDEV-203814 - HIPRTC Inprocess runtime changes(part2)

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18342/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#37 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#35 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#50 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#73 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#38 edit
2019-12-04 14:22:03 -05:00
foreman 1cd1b3eae2 P4 to Git Change 2040884 by jujiang@JJ-HIP on 2019/12/04 13:59:15
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
	-Update hipMemcpy3D function
	http://ocltc.amd.com/reviews/r/18346/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#90 edit
2019-12-04 14:06:53 -05:00
foreman 94e4e87b88 P4 to Git Change 2040867 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/12/04 13:32:27
SWDEV-145570 - Adding back the lazy kernel changes because the OOM issue is because of KFD/RocR.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#53 edit
2019-12-04 13:34:03 -05:00
Evgeny Mankov c3076a2a07 Merge pull request #1712 from emankov/hipify
[HIPIFY] CUDA 10.2 (functions only)
2019-12-04 18:39:10 +03:00
Evgeny Mankov 43441eb99c [HIPIFY] CUDA 10.2 (functions only)
+ Both Driver API and RT API are supported and synced with each other
+ Update *.md docs and hipify-perl accordingly
+ Add new conversion type "virtual_memory", introduced in Dirver API
2019-12-04 18:37:31 +03:00
Evgeny Mankov 187f28e26b Merge pull request #1710 from emankov/hipify
[HIPIFY] CUDA 10.2 fp_16 support
2019-12-04 13:28:43 +03:00
Evgeny Mankov 721a8540c0 [HIPIFY] CUDA 10.2 fp_16 support 2019-12-04 13:27:46 +03:00
Maneesh Gupta 59b3bd0048 [packaging] Rename hip packages to conform to debian package renaming rules (#1708) 2019-12-04 15:55:37 +05:30
Evgeny Mankov 89703e4ea9 Merge pull request #1709 from emankov/hipify
[HIPIFY] CUDA 10.2 support (data types only)
2019-12-04 12:26:51 +03:00
Evgeny Mankov 33f81effb1 [HIPIFY] CUDA 10.2 support (data types only)
+ Both Driver API and RT API are supported and synced with each other
+ Update *.md docs and hipify-perl accordingly
2019-12-04 12:25:20 +03:00
Rahul Garg 261a04580f Fix hipMemcpyWithStream (#1707)
* Fix hipMemcpyWithStream
* Add a dtest for the same.
2019-12-04 11:56:23 +05:30
Aryan Salmanpour 8eaea4d114 [hip] refactoring hipExtLaunchMultiKernelMultiDevice API (#1698)
[Background] it was found that if lazy linking used for a library that calls hipExtLaunchMultiKernelMultiDevice API then this API can get the wrong program_state object for looking up device kernels leading to a "No device code available" error in this API.

To fix this issue, the API was refactored to be inline and get and pass the correct program_state to an internal hip API to request a multi-device kernel launch.
2019-12-04 11:50:51 +05:30
foreman 401d75de56 P4 to Git Change 2039536 by jujiang@JJ-HIP on 2019/12/02 14:31:13
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
	-Update ihipBindTexture

	http://ocltc.amd.com/reviews/r/18333/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#89 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#28 edit
2019-12-02 13:37:35 -06:00
Jenkins 3bb63fb84e Merge 'master' into 'amd-master'
Change-Id: I79c383bed37cf6278ddb733ddf3bf3661e3dad35
2019-12-02 01:27:13 -05:00
Maneesh Gupta 38e971b645 Revert "[packaging] Conform to debian package naming rules (#1647)" (#1688)
This reverts commit 5a03482690.
2019-12-01 14:47:43 +05:30
Evgeny Mankov da468e181f Merge pull request #1702 from emankov/hipify
[HIPIFY] Sync cudaError/CUresult between CUDA Driver API/CUDA RT API/HIP
2019-11-29 19:31:28 +03:00
Evgeny Mankov 636108aaa9 [HIPIFY] Sync cudaError/CUresult between CUDA Driver API/CUDA RT API/HIP
+ Update *.md docs and hipify-perl accordingly

[Reason]
Starting with CUDA 10.1 all error codes are merged between Driver and RT APIs

[ToDo]
Do the same merge in HIP API as there is no need in distinguishing return codes by API
2019-11-29 19:29:11 +03:00
foreman 384f95a8be P4 to Git Change 2038688 by jujiang@JJ-HIP on 2019/11/29 10:14:49
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
	- Update function hipMemcpy3D for Texture Array
	- Add  hipArrayCubemap support in hipMalloc3DArray

	http://ocltc.amd.com/reviews/r/18328/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#88 edit
2019-11-29 10:17:28 -05:00
Maneesh Gupta 4c92bd50c4 Revert changes for atomic FADD support when address is in LDS (#1701)
This reverts PR #1591 and follow-on PR #1695
2019-11-29 11:58:12 +05:30
Siu Chi Chan d33975d6e8 add error checking for code object loading 2019-11-28 14:00:48 -05:00
Alex Voicu 17a4780dc6 Uniform is_shared query. (#1695) 2019-11-28 13:39:05 +05:30
foreman d2570e2254 P4 to Git Change 2037147 by kjayapra@1_HIPWS_LNX1_PAL on 2019/11/26 16:58:07
SWDEV-144570 - Adding hipMemcpyWithStream API

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#36 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#34 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#87 edit
2019-11-26 17:03:41 -05:00
Jeff Daily 6df73e1f12 fix hipMempcy precondition, test for zero size first (#1697) 2019-11-25 19:03:03 -08:00
Anusha Godavarthy Surya bc79c5636b replace array designator C99 2019-11-25 16:51:49 +05:30
foreman e7745c6d1e P4 to Git Change 2035631 by cpaquot@cpaquot-ocl-lc-lnx on 2019/11/22 17:52:20
SWDEV-213526 - pytorch tests fail with hipErrorOutofMemory
	There's a bug in ROCr when loading a lot of kernels and not syncing
	So for now, if an allocation fails, sync devices and retry before
	returning hipErrorOutOfMemory error.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#86 edit
2019-11-22 17:56:07 -05:00
foreman db74302fe3 P4 to Git Change 2035286 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/11/22 11:19:57
SWDEV-145570 - Revering CL 2033170

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#52 edit
2019-11-22 11:29:49 -05:00
Alex Voicu 306d50291e Unary operators were too restrictive in the type of their argument. (#1683) 2019-11-22 07:54:53 +05:30
Shyam Saladi 562336e733 [HIPIFY] fix typo (#1681) 2019-11-22 07:54:37 +05:30
ansurya e5fc5aa41c Fix rocBLAS compilation failure (#1677)
SWDEV-212749:
o Recent changes to “add support for extended launch” require hip_runtime.h to be include in hip_ext.h
o Order in which external applications include hip_hcc.h/hip_runtime.h causes compilation failure
2019-11-22 07:54:17 +05:30
Alex Voicu 2ed3a0873c Use native support for atomic FADD when address is in LDS (#1591) 2019-11-22 07:53:48 +05:30
foreman 6cabc4898d P4 to Git Change 2034910 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/11/21 19:28:10
SWDEV-145570 - Revering CL#2033779 for now.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#48 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#49 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#51 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#70 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#36 edit
2019-11-21 19:33:05 -05:00
satyanveshd d4dde7a27d fixed directed tests fail when hcc bumped to 3.0 (#1678)
Handled the HCC version check appropriately as few of the directed tests (SWDEV-212161) were failing when hcc was bumped to 3.0.
2019-11-20 21:37:52 +05:30
Alex Voicu 022ac3cb0a General sync memcpy improvements. Add hipMemcpyWithStream (#1673)
* General sync memcpy improvements. Add `hipMemcpyWithStream`

* Update hip_memory.cpp
2019-11-20 21:36:37 +05:30
Rahul Garg 13c2a31d7e Update error codes for hipGetDevice for doxygen and move up null check (#1668)
* [docs] Update error codes for hipGetDevice

* Move up out ptr check
2019-11-20 21:35:27 +05:30
Paul Fultz II 57b1b03261 Fix helper header when using c++17 (#1666)
This will fix issue #1621. It also adds tests for is_callable with c++11, c++14, and c++17.

The fallback implementation was completely broken so I rewrote it so it pass the tests as well. This should be used instead of PR #1631.
2019-11-20 21:33:42 +05:30
Alex Voicu c383f20691 Extend vector type capabilities and add tests to reflect it. (#1656) 2019-11-20 21:32:32 +05:30