Jonathan R. Madsen
f167317524
Public C++ header files and samples updates ( #819 )
...
* Public C++ header files (source/include/rocprofiler-sdk/cxx)
* Update samples/api_buffered_tracing
- scratch memory and page migration
- README
* Update samples/api_buffered_tracing
- page migration component in sample
* Update tests/page-migration/validate.py
- fix checks for page migration operation names
* Update tests/page-migration/validate.py
- fix get_allocated_pages
* Update scratch memory and page migration validations
* Fix include/rocprofiler-sdk/cxx installation
* Rework include/rocprofiler-sdk/cxx
- Improve name_info to support const char*, string_view, string
* Update samples/api_{buffered,callback}_tracing
* External correlation ID request sample
- includes correlation ID retirement demo
* Update samples/api_buffered_tracing/README.md
* Update lib/rocprofiler-sdk/hsa/queue.cpp
- generate correlation ID for kernel launch if one doesn't exist
* Remove priority check from tool libraries (samples/tests)
- if(priority > 0) return nullptr check in rocprofiler_configure has proliferated beyond its intended use
* Apply suggestions from code review
[ROCm/rocprofiler-sdk commit: de13d2ac5d ]
2024-04-25 20:09:11 -05:00
Jonathan R. Madsen
de13d2ac5d
Public C++ header files and samples updates ( #819 )
...
* Public C++ header files (source/include/rocprofiler-sdk/cxx)
* Update samples/api_buffered_tracing
- scratch memory and page migration
- README
* Update samples/api_buffered_tracing
- page migration component in sample
* Update tests/page-migration/validate.py
- fix checks for page migration operation names
* Update tests/page-migration/validate.py
- fix get_allocated_pages
* Update scratch memory and page migration validations
* Fix include/rocprofiler-sdk/cxx installation
* Rework include/rocprofiler-sdk/cxx
- Improve name_info to support const char*, string_view, string
* Update samples/api_{buffered,callback}_tracing
* External correlation ID request sample
- includes correlation ID retirement demo
* Update samples/api_buffered_tracing/README.md
* Update lib/rocprofiler-sdk/hsa/queue.cpp
- generate correlation ID for kernel launch if one doesn't exist
* Remove priority check from tool libraries (samples/tests)
- if(priority > 0) return nullptr check in rocprofiler_configure has proliferated beyond its intended use
* Apply suggestions from code review
2024-04-25 20:09:11 -05:00
Jonathan R. Madsen
ec3d720303
Fix CPACK_RPM_PACKAGE_LICENSE ( #63 )
...
- move install command for license to rocprofiler_register_config_install.cmake
- CPACK_RPM_PACKAGE_LICENSE should be set to license type (i.e. "MIT"), not the path to the license file
[ROCm/rocprofiler-register commit: 11a4668306 ]
2024-04-25 16:04:09 -05:00
Jonathan R. Madsen
11a4668306
Fix CPACK_RPM_PACKAGE_LICENSE ( #63 )
...
- move install command for license to rocprofiler_register_config_install.cmake
- CPACK_RPM_PACKAGE_LICENSE should be set to license type (i.e. "MIT"), not the path to the license file
2024-04-25 16:04:09 -05:00
raramakr
e4b6a828e4
SWDEV-448381 - CPACK dependency list should be comma separated ( #61 )
...
* SWDEV-448381 - CPACK dependency list should be comma separated
* Remove redundant code and update the dependency list in first place
* Update cmake/rocprofiler_register_config_packaging.cmake
---------
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com >
[ROCm/rocprofiler-register commit: dd231244ee ]
2024-04-25 15:55:14 -05:00
raramakr
dd231244ee
SWDEV-448381 - CPACK dependency list should be comma separated ( #61 )
...
* SWDEV-448381 - CPACK dependency list should be comma separated
* Remove redundant code and update the dependency list in first place
* Update cmake/rocprofiler_register_config_packaging.cmake
---------
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com >
2024-04-25 15:55:14 -05:00
Ioannis Assiouras
32e94ef1cc
SWDEV-457859 - Initialize isWGPMode_ in WorkGroupInfo
...
Change-Id: Ie3f3c0bcea84368c1b0607fd52b4bc7cae41c512
[ROCm/clr commit: cffff4e1cb ]
2024-04-25 16:36:55 -04:00
Ioannis Assiouras
cffff4e1cb
SWDEV-457859 - Initialize isWGPMode_ in WorkGroupInfo
...
Change-Id: Ie3f3c0bcea84368c1b0607fd52b4bc7cae41c512
2024-04-25 16:36:55 -04:00
Ammar ELWazir
9681d0d8de
SWDEV-458196: Fixing PID and TID
...
Perfetto added more restrictions on the types, so "1" is different from 1 alone, which wasn't the case before. Thats why we are seeing this issue recently
Change-Id: I69835c8f61bb9168fdfcdcd0821c1ba35d0369fe
2024-04-25 15:18:48 -05:00
Ammar ELWazir
1541f36388
SWDEV-458196: Fixing PID and TID
...
Perfetto added more restrictions on the types, so "1" is different from 1 alone, which wasn't the case before. Thats why we are seeing this issue recently
Change-Id: I69835c8f61bb9168fdfcdcd0821c1ba35d0369fe
[ROCm/rocprofiler commit: 9681d0d8de ]
2024-04-25 15:18:48 -05:00
Jonathan R. Madsen
9b747eb63c
Correct timestamp skew adjustments for kernel and async copy tracing ( #827 )
...
[ROCm/rocprofiler-sdk commit: e2bce49655 ]
2024-04-25 14:36:11 -05:00
Jonathan R. Madsen
e2bce49655
Correct timestamp skew adjustments for kernel and async copy tracing ( #827 )
2024-04-25 14:36:11 -05:00
Vladimir Indic
d0016ef728
Restructure code object source code ( #826 )
...
* public codeobj info
* Restructure code object source code file layout
* Update get_unloaded_code_objects + add iterate_loaded_code_objects
* Remove get_unloaded_code_objects from visible internal API
- iterate_loaded_code_objects + functor which filters on the hsa_executable_t effectively reproduces this behavior
* Whitespace removal
---------
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
[ROCm/rocprofiler-sdk commit: 733aa8e438 ]
2024-04-25 14:03:04 -05:00
Vladimir Indic
733aa8e438
Restructure code object source code ( #826 )
...
* public codeobj info
* Restructure code object source code file layout
* Update get_unloaded_code_objects + add iterate_loaded_code_objects
* Remove get_unloaded_code_objects from visible internal API
- iterate_loaded_code_objects + functor which filters on the hsa_executable_t effectively reproduces this behavior
* Whitespace removal
---------
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
2024-04-25 14:03:04 -05:00
coleramos425
9a0d5f0663
Replace deprecated roofline warning with logging helper function
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7d34e80567 ]
2024-04-25 18:43:20 +00:00
coleramos425
7d34e80567
Replace deprecated roofline warning with logging helper function
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-25 18:43:20 +00:00
Joseph Macaranas
ac3d2ca8c5
Add support for external CI builds using Azure Pipelines ( #62 )
...
* Add support for external CI builds using Azure Pipelines
* Change token name to match IT-created token
[ROCm/rocprofiler-register commit: 2b777139d3 ]
2024-04-25 13:41:30 -05:00
Joseph Macaranas
2b777139d3
Add support for external CI builds using Azure Pipelines ( #62 )
...
* Add support for external CI builds using Azure Pipelines
* Change token name to match IT-created token
2024-04-25 13:41:30 -05:00
coleramos425
efcf9001d7
Add TCC_TOO_MANY_EA_WRREQS_STALL to gfx940 input configs ( #349 )
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 0fc620ce79 ]
2024-04-25 18:22:00 +00:00
coleramos425
0fc620ce79
Add TCC_TOO_MANY_EA_WRREQS_STALL to gfx940 input configs ( #349 )
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-25 18:22:00 +00:00
coleramos425
3237f685e6
Update names of roofline csv expectation in testing
...
Co-authored-by: Jose Santos <josantos@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 46aa20e014 ]
2024-04-25 18:10:21 +00:00
coleramos425
46aa20e014
Update names of roofline csv expectation in testing
...
Co-authored-by: Jose Santos <josantos@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-25 18:10:21 +00:00
shadi
15b8dc404c
SWDEV-420016 - Add more driver side graph APIs
...
Signed-off-by: shadi <shadi.dashmiz@amd.com >
Change-Id: Iff3ee7dcbcd24836f227fdc9bd5ff4b554ac914f
[ROCm/clr commit: f2b01782ac ]
2024-04-25 12:50:43 -04:00
shadi
f2b01782ac
SWDEV-420016 - Add more driver side graph APIs
...
Signed-off-by: shadi <shadi.dashmiz@amd.com >
Change-Id: Iff3ee7dcbcd24836f227fdc9bd5ff4b554ac914f
2024-04-25 12:50:43 -04:00
amd-jmacaran
587e4287f4
Change token name to match IT-created token
...
Change-Id: Ic9189c012024c59cf5bad9daf25f6c2575a100fd
2024-04-25 12:23:28 -04:00
amd-jmacaran
3fc997dd0f
Change token name to match IT-created token
...
Change-Id: Ic9189c012024c59cf5bad9daf25f6c2575a100fd
[ROCm/ROCR-Runtime commit: 587e4287f4 ]
2024-04-25 12:23:28 -04:00
German Andryeyev
08e7942cf8
SWDEV-447691 - Correct handle type for DX12 semaphore
...
Change-Id: Id23882286cb2a0d0472964ffc501ab27b7dc7f00
[ROCm/clr commit: 9fdddb7c5d ]
2024-04-25 11:24:56 -04:00
German Andryeyev
9fdddb7c5d
SWDEV-447691 - Correct handle type for DX12 semaphore
...
Change-Id: Id23882286cb2a0d0472964ffc501ab27b7dc7f00
2024-04-25 11:24:56 -04:00
German Andryeyev
e61e3918dc
SWDEV-353281 - Correct mempool graph test
...
The new logic requires VM mode
Change-Id: Ia15bb63674880a82a28b75e809c75a04aa16b4ac
[ROCm/hip-tests commit: a2e4b0d3be ]
2024-04-25 11:18:42 -04:00
German Andryeyev
a2e4b0d3be
SWDEV-353281 - Correct mempool graph test
...
The new logic requires VM mode
Change-Id: Ia15bb63674880a82a28b75e809c75a04aa16b4ac
2024-04-25 11:18:42 -04:00
amd-jmacaran
eead75635e
Change token name to match IT-created token
...
Change-Id: Ie08eb15af669d4247c611c122ca0a77eb365f6dd
[ROCm/rocminfo commit: 75803689d1 ]
2024-04-25 03:57:02 -04:00
amd-jmacaran
75803689d1
Change token name to match IT-created token
...
Change-Id: Ie08eb15af669d4247c611c122ca0a77eb365f6dd
2024-04-25 03:57:02 -04:00
Galantsev, Dmitrii
cb87eeeae7
Update kBlockNameMap
...
Change-Id: I096f40f2b953fad7081d4b9bc05c0291c0f8058d
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2024-04-24 23:50:55 -05:00
Galantsev, Dmitrii
f74f1684de
Update kBlockNameMap
...
Change-Id: I096f40f2b953fad7081d4b9bc05c0291c0f8058d
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: cb87eeeae7 ]
2024-04-24 23:50:55 -05:00
Galantsev, Dmitrii
0c8827c4b7
CMAKE - Use ADDRESS_SANITIZER env var
...
Change-Id: I4727120de2f9d7bded8c24033c252ede718831fc
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2024-04-24 23:04:25 -05:00
Galantsev, Dmitrii
b517730e57
CMAKE - Use ADDRESS_SANITIZER env var
...
Change-Id: I4727120de2f9d7bded8c24033c252ede718831fc
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 0c8827c4b7 ]
2024-04-24 23:04:25 -05:00
David Yat Sin
3d999a1adf
Perform HDP flush for SDMA copies gfx10/gfx11
...
Perform HDP flush on gfx10/gfx11 PCIe devices.
Exclude gfx101x devices
Change-Id: Ief76c34634b09b0a7942cb71519d4082ca8b4fad
2024-04-24 18:07:34 -04:00
David Yat Sin
defe5ac509
Perform HDP flush for SDMA copies gfx10/gfx11
...
Perform HDP flush on gfx10/gfx11 PCIe devices.
Exclude gfx101x devices
Change-Id: Ief76c34634b09b0a7942cb71519d4082ca8b4fad
[ROCm/ROCR-Runtime commit: 3d999a1adf ]
2024-04-24 18:07:34 -04:00
David Galiffi
e9df02bb5b
Add ".venv" to gitignore file
...
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
[ROCm/rocprofiler-compute commit: c24baf3610 ]
2024-04-24 17:02:52 -05:00
David Galiffi
c24baf3610
Add ".venv" to gitignore file
...
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
2024-04-24 17:02:52 -05:00
Jonathan R. Madsen
abe00ad1d0
Update CMake config install location + env setup files ( #821 )
...
- install cmake config files to CMAKE_INSTALL_LIBDIR instead of CMAKE_INSTALL_DATAROOTDIR per ROCm standards
- Provide setup-env.sh and modulefiles for rocprofiler-sdk and rocprofiler-sdk-roctx
[ROCm/rocprofiler-sdk commit: 67dbe3f47f ]
2024-04-24 14:43:47 -05:00
Jonathan R. Madsen
67dbe3f47f
Update CMake config install location + env setup files ( #821 )
...
- install cmake config files to CMAKE_INSTALL_LIBDIR instead of CMAKE_INSTALL_DATAROOTDIR per ROCm standards
- Provide setup-env.sh and modulefiles for rocprofiler-sdk and rocprofiler-sdk-roctx
2024-04-24 14:43:47 -05:00
Ioannis Assiouras
b052e90ea8
SWDEV-451099 - Added include for __half type definitions for non-HIP code on windows
...
Change-Id: Id80cef5a36db8707276de052cbaf73b6826d222f
[ROCm/clr commit: 2841aab017 ]
2024-04-24 15:31:31 -04:00
Ioannis Assiouras
2841aab017
SWDEV-451099 - Added include for __half type definitions for non-HIP code on windows
...
Change-Id: Id80cef5a36db8707276de052cbaf73b6826d222f
2024-04-24 15:31:31 -04:00
amd-jmacaran
fa521f727a
Add support for external CI builds using Azure Pipelines
...
Change-Id: I7658fbc8c52bef551dae8c13413825507a0d8c0a
[ROCm/rocminfo commit: 9a91005354 ]
2024-04-24 15:25:10 -04:00
amd-jmacaran
9a91005354
Add support for external CI builds using Azure Pipelines
...
Change-Id: I7658fbc8c52bef551dae8c13413825507a0d8c0a
2024-04-24 15:25:10 -04:00
German Andryeyev
d1507ad475
SWDEV-353281 - Align VA size
...
Lower layer ignores alignment
Change-Id: If16df951ecefddc804a6effe013058afc595d30f
[ROCm/clr commit: 5c23440199 ]
2024-04-24 15:22:20 -04:00
German Andryeyev
5c23440199
SWDEV-353281 - Align VA size
...
Lower layer ignores alignment
Change-Id: If16df951ecefddc804a6effe013058afc595d30f
2024-04-24 15:22:20 -04:00
Jonathan R. Madsen
3b6249bdac
Rework counter collection sample app ( #822 )
...
* Sync more often in counter collection samples
* Update samples/counter_collection/main.cpp
- support command line arguments
- number of iterations
- iterations per sync
- number of devices to use
[ROCm/rocprofiler-sdk commit: 8c985543d9 ]
2024-04-24 14:00:59 -05:00
Jonathan R. Madsen
8c985543d9
Rework counter collection sample app ( #822 )
...
* Sync more often in counter collection samples
* Update samples/counter_collection/main.cpp
- support command line arguments
- number of iterations
- iterations per sync
- number of devices to use
2024-04-24 14:00:59 -05:00