نمودار کامیت

64512 کامیت‌ها

مولف SHA1 پیام تاریخ
David Yat Sin cb5a29955b rocrtst: Speed-up Memory_Max_Mem test
Skip Extended-scope memory pool as allocation is very close to
fine-grain/coarse-grain but with just different PTE flags.

Only test coarse grain on CPU agent other than the first CPU agent.

Stop bisecting the max size once we are withing 5% to total size for
these pool to speed this test on large memory pools.

Change-Id: I77d1b45a1752ef092dda7c7f27723ea0a292a612
2023-12-04 15:03:31 +00:00
David Yat Sin 663b461512 rocrtst: Speed-up Memory_Max_Mem test
Skip Extended-scope memory pool as allocation is very close to
fine-grain/coarse-grain but with just different PTE flags.

Only test coarse grain on CPU agent other than the first CPU agent.

Stop bisecting the max size once we are withing 5% to total size for
these pool to speed this test on large memory pools.

Change-Id: I77d1b45a1752ef092dda7c7f27723ea0a292a612


[ROCm/ROCR-Runtime commit: cb5a29955b]
2023-12-04 15:03:31 +00:00
David Yat Sin 642165b1bc Increase scratch aperture size to 4GB per XCC
Change-Id: Ia02cea45ce8b782527f44fec539b0ab7cc453200
2023-12-04 15:03:31 +00:00
David Yat Sin 0607f3c34d Increase scratch aperture size to 4GB per XCC
Change-Id: Ia02cea45ce8b782527f44fec539b0ab7cc453200


[ROCm/ROCR-Runtime commit: 642165b1bc]
2023-12-04 15:03:31 +00:00
Jonathan Kim 81c64228e0 Increase SDMA copy size
SDMA4.4 and SDMA5.2+ has increased it's available copy size to 2^30 bytes
represented by exponent as bits set in the COUNT field of the
linear copy.

Also note that the full 2^22 byte limit is available from SDMA4 onwards
as it has corrected the 0x3fffe0 HW limitation from SDMA3.

As copy limit has increase, this can change system performance
so provide env var HSA_ENABLE_SDMA_COPY_SIZE_OVERRIDE=0 to fall
back to the original 0x3fffe0 limit for debugging purposes.

Change-Id: I0fb6e5378f68e5b8a00ff559271691a943ee06ee
2023-12-04 15:03:31 +00:00
Jonathan Kim 1931c4f8a4 Increase SDMA copy size
SDMA4.4 and SDMA5.2+ has increased it's available copy size to 2^30 bytes
represented by exponent as bits set in the COUNT field of the
linear copy.

Also note that the full 2^22 byte limit is available from SDMA4 onwards
as it has corrected the 0x3fffe0 HW limitation from SDMA3.

As copy limit has increase, this can change system performance
so provide env var HSA_ENABLE_SDMA_COPY_SIZE_OVERRIDE=0 to fall
back to the original 0x3fffe0 limit for debugging purposes.

Change-Id: I0fb6e5378f68e5b8a00ff559271691a943ee06ee


[ROCm/ROCR-Runtime commit: 81c64228e0]
2023-12-04 15:03:31 +00:00
Youssef Aly ae1da390bd Enabled profiling for CPU agents for memcpy activities
To be able to trace memcpy asynchronously, both dst and src agents need to have profiling enabled and the api for enabling profiling was only enabling for gpu agents. CPU agents didn't have profiling enabled so the signal owner could not be known. hsa_amd_profiling_get_async_copy_time will fail with an HSA status error because it can't read the agent for the given signal.

Change-Id: Ie165e0e39b8fcd6992a55695b9ffcead10a8e812
2023-12-04 15:01:59 +00:00
Youssef Aly 1c1298c1c0 Enabled profiling for CPU agents for memcpy activities
To be able to trace memcpy asynchronously, both dst and src agents need to have profiling enabled and the api for enabling profiling was only enabling for gpu agents. CPU agents didn't have profiling enabled so the signal owner could not be known. hsa_amd_profiling_get_async_copy_time will fail with an HSA status error because it can't read the agent for the given signal.

Change-Id: Ie165e0e39b8fcd6992a55695b9ffcead10a8e812


[ROCm/ROCR-Runtime commit: ae1da390bd]
2023-12-04 15:01:59 +00:00
Jonathan R. Madsen f9cf1852e5 rocprofiler-register support
- Update CMakeLists.txt
  - find_package for rocprofiler-register
    - this is an optional package until rocprofiler-register is added to the CI
  - define HSA_VERSION_{MAJOR,MINOR,PATCH} ppdefs
- Update runtime.cpp
  - include <rocprofiler-register/rocprofiler-register.h>
  - if rocprofiler-register succeeds, do not support v1 unless explicitly requested

Change-Id: I8f48bbf3f6b52fb91ddade2f198491a1256035fe
2023-12-04 15:01:59 +00:00
Jonathan R. Madsen 880ddd4387 rocprofiler-register support
- Update CMakeLists.txt
  - find_package for rocprofiler-register
    - this is an optional package until rocprofiler-register is added to the CI
  - define HSA_VERSION_{MAJOR,MINOR,PATCH} ppdefs
- Update runtime.cpp
  - include <rocprofiler-register/rocprofiler-register.h>
  - if rocprofiler-register succeeds, do not support v1 unless explicitly requested

Change-Id: I8f48bbf3f6b52fb91ddade2f198491a1256035fe


[ROCm/ROCR-Runtime commit: f9cf1852e5]
2023-12-04 15:01:59 +00:00
Jonathan Kim 2f847cf05f Restore default code object version usage for ROCr and ROCr Test
Remove override that forces ROCr image blit source and ROCr test to use
code object version 4 now that mainline has been updated to version 5.

Change-Id: I94681e86835c0e382475306ead4cd4132a2ee78f
2023-12-04 15:01:44 +00:00
Jonathan Kim 73ab40ecd3 Restore default code object version usage for ROCr and ROCr Test
Remove override that forces ROCr image blit source and ROCr test to use
code object version 4 now that mainline has been updated to version 5.

Change-Id: I94681e86835c0e382475306ead4cd4132a2ee78f


[ROCm/ROCR-Runtime commit: 2f847cf05f]
2023-12-04 15:01:44 +00:00
Jatin Chaudhary c9b5c5c657 SWDEV-431399 - add const cast to pointer before casting it to function type.
C++ does not allow const qualifier on function type, even if we add it it will get ignored and clang will fail with failed cast from const void* to func*. const_cast here is necessary to make it work.

Change-Id: I72cec8d9e715bdf9e163cb9b08393dd733dafaf2


[ROCm/clr commit: 5b5213adf5]
2023-12-04 04:34:57 -05:00
Jatin Chaudhary 5b5213adf5 SWDEV-431399 - add const cast to pointer before casting it to function type.
C++ does not allow const qualifier on function type, even if we add it it will get ignored and clang will fail with failed cast from const void* to func*. const_cast here is necessary to make it work.

Change-Id: I72cec8d9e715bdf9e163cb9b08393dd733dafaf2
2023-12-04 04:34:57 -05:00
Ioannis Assiouras ab411c8f34 SWDEV-434702 - get the nullstream in constant time in iHipWaitActiveStreams
Change-Id: Ib92cc4d2ca1b725cf30b24cdd711c873fd513d95


[ROCm/clr commit: 8bdda90071]
2023-12-03 19:05:18 -05:00
Ioannis Assiouras 8bdda90071 SWDEV-434702 - get the nullstream in constant time in iHipWaitActiveStreams
Change-Id: Ib92cc4d2ca1b725cf30b24cdd711c873fd513d95
2023-12-03 19:05:18 -05:00
Karl W Schulz 0f8d5fe131 Merge branch '2.x' into 2.x-dev
[ROCm/rocprofiler-compute commit: bd803a0883]
2023-12-01 14:50:08 -06:00
Karl W Schulz bd803a0883 Merge branch '2.x' into 2.x-dev 2023-12-01 14:50:08 -06:00
colramos-amd c134a12674 Fixing more typos...
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: f822a56b7c]
2023-12-01 13:43:07 -06:00
colramos-amd f822a56b7c Fixing more typos...
Signed-off-by: colramos-amd <colramos@amd.com>
2023-12-01 13:43:07 -06:00
colramos-amd 1279b2afac Small typo corrections in docs
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: bc2d4b3491]
2023-12-01 13:38:53 -06:00
colramos-amd bc2d4b3491 Small typo corrections in docs
Signed-off-by: colramos-amd <colramos@amd.com>
2023-12-01 13:38:53 -06:00
colramos-amd 145eb15289 Update testing collateral to reflect name change of kernel-verbose option
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: c73b49704c]
2023-12-01 13:32:19 -06:00
colramos-amd c73b49704c Update testing collateral to reflect name change of kernel-verbose option
Signed-off-by: colramos-amd <colramos@amd.com>
2023-12-01 13:32:19 -06:00
colramos-amd 94f61de5dd Cache ascii art in source and remove ascii dependency
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 9a66f66ebc]
2023-12-01 13:28:56 -06:00
colramos-amd 9a66f66ebc Cache ascii art in source and remove ascii dependency
Signed-off-by: colramos-amd <colramos@amd.com>
2023-12-01 13:28:56 -06:00
Benjamin Welton 4114b975d5 Documentation Update For Counters (#246)
* Documentation Update

* Minor fixes

* source formatting (clang-format v11) (#265)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: 022d7abc29]
2023-11-30 14:58:54 -08:00
Benjamin Welton 022d7abc29 Documentation Update For Counters (#246)
* Documentation Update

* Minor fixes

* source formatting (clang-format v11) (#265)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
2023-11-30 14:58:54 -08:00
Galantsev, Dmitrii 7fc67c88ce Fix ASAN for tests and log metrics better
Change-Id: Ib495cfc28c48a4d291a89673a3b6fc13313845c7
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: a128867497]
2023-11-30 15:39:05 -05:00
Galantsev, Dmitrii a128867497 Fix ASAN for tests and log metrics better
Change-Id: Ib495cfc28c48a4d291a89673a3b6fc13313845c7
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-11-30 15:39:05 -05:00
JoseSantosAMD 311014ddbd RHEL9 uses RHEL8 roofline binary (#208)
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

[ROCm/rocprofiler-compute commit: f52a1c8df5]
2023-11-30 13:31:20 -06:00
JoseSantosAMD f52a1c8df5 RHEL9 uses RHEL8 roofline binary (#208)
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
2023-11-30 13:31:20 -06:00
Jonathan R. Madsen 10b63beaca Merge pull request #49 from ROCm-Developer-Tools/amd-staging
Support ROCP_TOOL_LIBRARIES env + librocprofiler-sdk.so (#48)

[ROCm/rocprofiler-register commit: c4c4e51e0f]
2023-11-30 13:27:50 -06:00
Jonathan R. Madsen c4c4e51e0f Merge pull request #49 from ROCm-Developer-Tools/amd-staging
Support ROCP_TOOL_LIBRARIES env + librocprofiler-sdk.so (#48)
2023-11-30 13:27:50 -06:00
Maneesh Gupta 38bd0db481 SWDEV-388833 - Fix potential build issues with gcc tests
Change-Id: I53c109ebaed60b085069d862d87ac8a3597331c5


[ROCm/hip-tests commit: da89b3e76e]
2023-11-30 01:19:22 -05:00
Maneesh Gupta da89b3e76e SWDEV-388833 - Fix potential build issues with gcc tests
Change-Id: I53c109ebaed60b085069d862d87ac8a3597331c5
2023-11-30 01:19:22 -05:00
Jonathan R. Madsen 0f8430700d Support ROCP_TOOL_LIBRARIES env + librocprofiler-sdk.so (#48)
* Fix support for version in find_package(rocprofiler-register <version>)

* Update lib/rocprofiler-register/rocprofiler-register.cpp

- change rocprofiler library name to librocprofiler-sdk.so
- add helper function rocp_load_rocprofiler_lib for dlopen of rocprofiler library
- support ROCP_TOOL_LIBRARIES environment variable
- reworked rocprofiler_register_error_string

* Update tests/rocprofiler

- rename library to librocprofiler-sdk
- remove rocprofiler_configure within librocprofiler-sdk.so

* Add tests/generic-tool

- provides implementation of rocprofiler_configure

* Update tests/CMakeLists.txt

- use libgeneric-tool.so
- LD_PRELOAD libgeneric-tool.so instead of librocprofiler
- Add tests which use ROCP_TOOL_LIBRARIES

* Update tests/generic-tool/generic-tool.cpp

- include <cstdint>

[ROCm/rocprofiler-register commit: ab02cb6570]
2023-11-29 20:58:18 -06:00
Jonathan R. Madsen ab02cb6570 Support ROCP_TOOL_LIBRARIES env + librocprofiler-sdk.so (#48)
* Fix support for version in find_package(rocprofiler-register <version>)

* Update lib/rocprofiler-register/rocprofiler-register.cpp

- change rocprofiler library name to librocprofiler-sdk.so
- add helper function rocp_load_rocprofiler_lib for dlopen of rocprofiler library
- support ROCP_TOOL_LIBRARIES environment variable
- reworked rocprofiler_register_error_string

* Update tests/rocprofiler

- rename library to librocprofiler-sdk
- remove rocprofiler_configure within librocprofiler-sdk.so

* Add tests/generic-tool

- provides implementation of rocprofiler_configure

* Update tests/CMakeLists.txt

- use libgeneric-tool.so
- LD_PRELOAD libgeneric-tool.so instead of librocprofiler
- Add tests which use ROCP_TOOL_LIBRARIES

* Update tests/generic-tool/generic-tool.cpp

- include <cstdint>
2023-11-29 20:58:18 -06:00
Jonathan R. Madsen fafab6b713 Use -sdk suffix and reset VERSION to 0.0.0 (#263)
* Fix find_package(rocprofiler) in build tree

* Move include/rocprofiler to include/rocprofiler-sdk

* Update include/CMakeLists.txt

- add_subdirectory(rocprofiler-sdk)

* Move lib/rocprofiler to lib/rocprofiler-sdk

* Move lib/rocprofiler-tool to lib/rocprofiler-sdk-tool

* Update lib/CMakeLists.txt

- add_subdirectory(rocprofiler-sdk)
- add_subdirectory(rocprofiler-sdk-tool)

* Update lib/rocprofiler-sdk/CMakeLists.txt

* Rename rocprofiler-tool to rocprofiler-sdk-tool

* Replace include rocprofiler/ with include rocprofiler-sdk/

* Replace include lib/rocprofiler/ with include lib/rocprofiler-sdk/

* Set VERSION to 0.0.0 and finish install to rocprofiler-sdk

* More fixes for rocprofiler -> rocprofiler-sdk

- fix issue with rocprofiler-sdk-config.cmake.in
- fix counters xml install path

* Fix documentation generation

* Create rocprofiler_LIB_ROCPROFILER_SDK_DIR for build tree

* cmake formatting (cmake-format) (#264)

Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: 9a0c84efa6]
2023-11-29 20:43:18 -06:00
Jonathan R. Madsen 9a0c84efa6 Use -sdk suffix and reset VERSION to 0.0.0 (#263)
* Fix find_package(rocprofiler) in build tree

* Move include/rocprofiler to include/rocprofiler-sdk

* Update include/CMakeLists.txt

- add_subdirectory(rocprofiler-sdk)

* Move lib/rocprofiler to lib/rocprofiler-sdk

* Move lib/rocprofiler-tool to lib/rocprofiler-sdk-tool

* Update lib/CMakeLists.txt

- add_subdirectory(rocprofiler-sdk)
- add_subdirectory(rocprofiler-sdk-tool)

* Update lib/rocprofiler-sdk/CMakeLists.txt

* Rename rocprofiler-tool to rocprofiler-sdk-tool

* Replace include rocprofiler/ with include rocprofiler-sdk/

* Replace include lib/rocprofiler/ with include lib/rocprofiler-sdk/

* Set VERSION to 0.0.0 and finish install to rocprofiler-sdk

* More fixes for rocprofiler -> rocprofiler-sdk

- fix issue with rocprofiler-sdk-config.cmake.in
- fix counters xml install path

* Fix documentation generation

* Create rocprofiler_LIB_ROCPROFILER_SDK_DIR for build tree

* cmake formatting (cmake-format) (#264)

Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-11-29 20:43:18 -06:00
German Andryeyev d60fabacbe SWDEV-434298 - Add destination offset
The end pointer in copy buffer requires destination offset

Change-Id: I01f2967144f741761fd2ce3244fd8d04564d986f


[ROCm/clr commit: 44761fe89b]
2023-11-29 16:33:29 -05:00
German Andryeyev 44761fe89b SWDEV-434298 - Add destination offset
The end pointer in copy buffer requires destination offset

Change-Id: I01f2967144f741761fd2ce3244fd8d04564d986f
2023-11-29 16:33:29 -05:00
Satyanvesh Dittakavi 66b4a403a6 SWDEV-434362 - Replace __HIP_CLANG_ONLY__ as it is not supported on HIPRTC
__HIP_CLANG_ONLY__ is not recognized in HIPRTC, due to which some
math functions like amd_mixed_dot were not included in hiprtc builtins.

Change-Id: I1fe41e1ddc8911f6a5b5b1405dd4730d0170a4f7


[ROCm/clr commit: f0010f4fdb]
2023-11-29 04:22:19 -05:00
Satyanvesh Dittakavi f0010f4fdb SWDEV-434362 - Replace __HIP_CLANG_ONLY__ as it is not supported on HIPRTC
__HIP_CLANG_ONLY__ is not recognized in HIPRTC, due to which some
math functions like amd_mixed_dot were not included in hiprtc builtins.

Change-Id: I1fe41e1ddc8911f6a5b5b1405dd4730d0170a4f7
2023-11-29 04:22:19 -05:00
Galantsev, Dmitrii d734ec5aa6 Add linting via pre-commit and docker
Please see .pre-commit-config.yaml for details

- Add clang-format
- Add cpplint
- Add config for clang-tidy but don't enforce with pre-commit

Change-Id: Ica447c78e6fde94b43bfdc00f5b4efc338363e24
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: 142fbac7ac]
2023-11-28 23:21:36 -05:00
Galantsev, Dmitrii 142fbac7ac Add linting via pre-commit and docker
Please see .pre-commit-config.yaml for details

- Add clang-format
- Add cpplint
- Add config for clang-tidy but don't enforce with pre-commit

Change-Id: Ica447c78e6fde94b43bfdc00f5b4efc338363e24
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-11-28 23:21:36 -05:00
Jonathan R. Madsen d0b69ad2b6 Build System Fixes (#46)
* Update build system

- emsure CMAKE_INSTALL_LIBDIR is always lib
- fix find_package(rocprofiler-register) in build tree
- set rocprofiler-register_VERSION in rocprofiler-register-config.cmake
- samples/library-implementation always uses find_package(rocprofiler-register)

* Update cmake/rocprofiler_register_config_install.cmake

- rocprofiler_register_DIR -> rocprofiler-register_DIR

[ROCm/rocprofiler-register commit: b04c8478f2]
2023-11-28 18:19:20 -06:00
Jonathan R. Madsen b04c8478f2 Build System Fixes (#46)
* Update build system

- emsure CMAKE_INSTALL_LIBDIR is always lib
- fix find_package(rocprofiler-register) in build tree
- set rocprofiler-register_VERSION in rocprofiler-register-config.cmake
- samples/library-implementation always uses find_package(rocprofiler-register)

* Update cmake/rocprofiler_register_config_install.cmake

- rocprofiler_register_DIR -> rocprofiler-register_DIR
2023-11-28 18:19:20 -06:00
Gopesh Bhardwaj 4d08ddcb8d SWDEV-431048 Fixing rocprofiler-register package dependencies (#44)
* SWDEV-431048 Fixing rocprofiler-register package dependencies

* cmake formatting (cmake-format) (#45)

Co-authored-by: bgopesh <bgopesh@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>

[ROCm/rocprofiler-register commit: ed1938479d]
2023-11-28 18:19:20 -06:00
Gopesh Bhardwaj ed1938479d SWDEV-431048 Fixing rocprofiler-register package dependencies (#44)
* SWDEV-431048 Fixing rocprofiler-register package dependencies

* cmake formatting (cmake-format) (#45)

Co-authored-by: bgopesh <bgopesh@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
2023-11-28 18:19:20 -06:00