Commit graph

64512 Commits

Autor SHA1 Nachricht Datum
Giovanni LB c22c7d64cc SWDEV-414768: Fixing multiqueue perfetto
Change-Id: Ie60cdc6bffe8e6748d443482a0dc3816d96b6604
2023-10-10 11:55:42 -04:00
Giovanni LB 562c90fdb0 SWDEV-414768: Fixing multiqueue perfetto
Change-Id: Ie60cdc6bffe8e6748d443482a0dc3816d96b6604


[ROCm/rocprofiler commit: c22c7d64cc]
2023-10-10 11:55:42 -04:00
Charis Poag 3ea6946b31 Add rsmi_dev_power_get
* Updates:
  - [API] Added rsmi_dev_power_get(uint32_t dv_ind,
                                   uint64_t *power,
                                   RSMI_POWER_TYPE
                                   *type)
          provides generic get to average or
          current power & provides backwards
          compatibility
  - Added a utility function to get MonitorTypes
    (monitor_type_string(type)) &
    RSMI_POWER_TYPE (power_type_string(type))
    strings
  - [Tests] Added rsmi_dev_power_get tests and
    provided better verification of return values for
    all power APIs
  - [Tests] Updated power outputs to show correct
    units
  - [example] Now uses avg, current, and generic
    power functions with type output response

Change-Id: I5ca06ca37fd5f61e100f2835b664d6cdd1ca42e6
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/rocm_smi_lib commit: 31a1fcce7d]
2023-10-10 00:34:19 -05:00
Charis Poag 31a1fcce7d Add rsmi_dev_power_get
* Updates:
  - [API] Added rsmi_dev_power_get(uint32_t dv_ind,
                                   uint64_t *power,
                                   RSMI_POWER_TYPE
                                   *type)
          provides generic get to average or
          current power & provides backwards
          compatibility
  - Added a utility function to get MonitorTypes
    (monitor_type_string(type)) &
    RSMI_POWER_TYPE (power_type_string(type))
    strings
  - [Tests] Added rsmi_dev_power_get tests and
    provided better verification of return values for
    all power APIs
  - [Tests] Updated power outputs to show correct
    units
  - [example] Now uses avg, current, and generic
    power functions with type output response

Change-Id: I5ca06ca37fd5f61e100f2835b664d6cdd1ca42e6
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2023-10-10 00:34:19 -05:00
mbhiutra d8a6f2e16e SWDEV-415965 - [catch2][dtest] Added test for Optimize HIPGraph Performance
Change-Id: I46b1f1d5bea884d6cf335f7e4e09cb453f20a3fe


[ROCm/hip-tests commit: 9a802f36ed]
2023-10-10 00:11:46 -04:00
mbhiutra 9a802f36ed SWDEV-415965 - [catch2][dtest] Added test for Optimize HIPGraph Performance
Change-Id: I46b1f1d5bea884d6cf335f7e4e09cb453f20a3fe
2023-10-10 00:11:46 -04:00
guanyu12 a6066a2ede Merge amd-staging into amd-master 20231010
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: Id320e9e80c796a4edb155cdc002de1efdb6b2c3a


[ROCm/rocm_smi_lib commit: 5fddc58624]
2023-10-10 10:48:42 +08:00
guanyu12 5fddc58624 Merge amd-staging into amd-master 20231010
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: Id320e9e80c796a4edb155cdc002de1efdb6b2c3a
2023-10-10 10:48:42 +08:00
Oliveira, Daniel 5e444f87ad rocm_smi_lib: Fix Modernize and refactor gpu_metrics
Adds support for 'gpu_metrics_v1_4' and new counters

Code changes related to the following:
  * rsmi gpu_metrics APIs
  * rsmi gpu_metrics Logs
  * The new gpu_metrics are now part of the Device

Build changes related to the following: None

Change-Id: Ie748e977cd0a01c6a2fb82260014c0699605dbb3
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>


[ROCm/rocm_smi_lib commit: 4e4ebde640]
2023-10-09 21:43:22 -05:00
Oliveira, Daniel 4e4ebde640 rocm_smi_lib: Fix Modernize and refactor gpu_metrics
Adds support for 'gpu_metrics_v1_4' and new counters

Code changes related to the following:
  * rsmi gpu_metrics APIs
  * rsmi gpu_metrics Logs
  * The new gpu_metrics are now part of the Device

Build changes related to the following: None

Change-Id: Ie748e977cd0a01c6a2fb82260014c0699605dbb3
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>
2023-10-09 21:43:22 -05:00
Anusha GodavarthySurya 661b3381da SWDEV-408701 - Avoid adding duplicates when no node is captured in cross stream
Change-Id: Iccbddaf9db73238aa938f8b3e8ec410f4a86d524


[ROCm/clr commit: c7e4e9c2f4]
2023-10-09 13:15:47 -04:00
Anusha GodavarthySurya c7e4e9c2f4 SWDEV-408701 - Avoid adding duplicates when no node is captured in cross stream
Change-Id: Iccbddaf9db73238aa938f8b3e8ec410f4a86d524
2023-10-09 13:15:47 -04:00
Rakesh Roy df0de2458f SWDEV-425460, SWDEV-426132, SWDEV-426133, SWDEV-426137 - Revert "SWDEV-399623 - [ABI Break] Remove 'memoryType' from hipPointerAttribute_t"
This reverts commit 24ad87502d.

Reason for revert: This causes build failure in AMG, UCC & UCX

Change-Id: I9198de12f04fa1790cfbd8b65955723e05700c8a


[ROCm/hip commit: 8ed05a1567]
2023-10-09 12:33:50 -04:00
Rakesh Roy 8ed05a1567 SWDEV-425460, SWDEV-426132, SWDEV-426133, SWDEV-426137 - Revert "SWDEV-399623 - [ABI Break] Remove 'memoryType' from hipPointerAttribute_t"
This reverts commit 99c48bfc6d.

Reason for revert: This causes build failure in AMG, UCC & UCX

Change-Id: I9198de12f04fa1790cfbd8b65955723e05700c8a
2023-10-09 12:33:50 -04:00
Rakesh Roy 81a120a5c5 SWDEV-425967, SWDEV-425968 - Revert "SWDEV-415029 - [ABI Break] Remove hcc symbols"
This reverts commit de3d24df97.

Reason for revert: This causes build failure in hipBLASLt & hipSPARSELt

Change-Id: Ifb1ee519971c6183eb53634d6d8901a9e94cc9cc


[ROCm/hip-tests commit: fe5206e50a]
2023-10-09 06:31:52 -04:00
Rakesh Roy fe5206e50a SWDEV-425967, SWDEV-425968 - Revert "SWDEV-415029 - [ABI Break] Remove hcc symbols"
This reverts commit 403afae98f.

Reason for revert: This causes build failure in hipBLASLt & hipSPARSELt

Change-Id: Ifb1ee519971c6183eb53634d6d8901a9e94cc9cc
2023-10-09 06:31:52 -04:00
Rakesh Roy 34aa551075 SWDEV-425967, SWDEV-425968 - Revert "SWDEV-415029 - [ABI Break] Remove hcc symbols"
This reverts commit 088704abeb.

Reason for revert: This causes build failure in hipBLASLt & hipSPARSELt

Change-Id: I59f6aeb8b82261b77eb978e53407bc56be1d0cf1


[ROCm/clr commit: 2535fac296]
2023-10-09 06:30:19 -04:00
Rakesh Roy 2535fac296 SWDEV-425967, SWDEV-425968 - Revert "SWDEV-415029 - [ABI Break] Remove hcc symbols"
This reverts commit 051e1005f4.

Reason for revert: This causes build failure in hipBLASLt & hipSPARSELt

Change-Id: I59f6aeb8b82261b77eb978e53407bc56be1d0cf1
2023-10-09 06:30:19 -04:00
Rakesh Roy ddad1eeec2 SWDEV-425967, SWDEV-425968 - Revert "SWDEV-415029 - [ABI Break] Remove hcc symbols"
This reverts commit 22a0da6747.

Reason for revert: This causes build failure in hipBLASLt & hipSPARSELt

Change-Id: If4932a630391ddce5cdff247163fbadb9b9d31ef


[ROCm/hip commit: 0bf6186614]
2023-10-09 06:27:39 -04:00
Rakesh Roy 0bf6186614 SWDEV-425967, SWDEV-425968 - Revert "SWDEV-415029 - [ABI Break] Remove hcc symbols"
This reverts commit 5dcfb26c3e.

Reason for revert: This causes build failure in hipBLASLt & hipSPARSELt

Change-Id: If4932a630391ddce5cdff247163fbadb9b9d31ef
2023-10-09 06:27:39 -04:00
Sourabh Betigeri d596ec2073 SWDEV-369792 - Fix to use the roclr context already created when creating hip::Device rather than creating a new context in hip
Change-Id: I6dbccb1a17dee0e9a72ec52cb1a5bb096315fa0f


[ROCm/clr commit: 01aa3557f4]
2023-10-07 14:32:32 -04:00
Sourabh Betigeri 01aa3557f4 SWDEV-369792 - Fix to use the roclr context already created when creating hip::Device rather than creating a new context in hip
Change-Id: I6dbccb1a17dee0e9a72ec52cb1a5bb096315fa0f
2023-10-07 14:32:32 -04:00
German Andryeyev bd63f3f614 SWDEV-424603 - Use OR for CPU wait request
Make sure rocclr doesn't overwrite the client's request
for a wait.

Change-Id: I0addf18ea408b7f4ecaa1e04b2877cc0bbbfcc0d


[ROCm/clr commit: fe7b36f3cb]
2023-10-06 16:51:44 -04:00
German Andryeyev fe7b36f3cb SWDEV-424603 - Use OR for CPU wait request
Make sure rocclr doesn't overwrite the client's request
for a wait.

Change-Id: I0addf18ea408b7f4ecaa1e04b2877cc0bbbfcc0d
2023-10-06 16:51:44 -04:00
Jaydeep Patel 38fec06989 SWDEV-425490 - ptrdiff_t differs on windows and linux.
Change-Id: I5b943e869a6552870aa268be898182e806161b3c


[ROCm/clr commit: 46de4256e0]
2023-10-06 16:04:52 -04:00
Jaydeep Patel 46de4256e0 SWDEV-425490 - ptrdiff_t differs on windows and linux.
Change-Id: I5b943e869a6552870aa268be898182e806161b3c
2023-10-06 16:04:52 -04:00
Alex Xie b444ee5b3b SWDEV-423579 - Move header file to ROCclr
This header file is used by ROCclr and might be used by HIP too.
ROCclr folder is a right place for this header file.

Change-Id: Ie2307331f9bd445f3c295d2ccbfc4924b0fa9510


[ROCm/clr commit: 124de0c519]
2023-10-06 14:54:50 -04:00
Alex Xie 124de0c519 SWDEV-423579 - Move header file to ROCclr
This header file is used by ROCclr and might be used by HIP too.
ROCclr folder is a right place for this header file.

Change-Id: Ie2307331f9bd445f3c295d2ccbfc4924b0fa9510
2023-10-06 14:54:50 -04:00
Charis Poag d57d65a607 Rename NPS -> memory partition + compute partition node fix
* Updates:
        - rocm_smi_lib + CLI:
          Rename all "NPS mode" -> "memory partition"
          related files/functions/API/CLI to align with correct
          technical naming
        - rocm_smi_main: fixed identifying primary card's unique id
          utilize rsmi_dev_unique_id_get to map which
          KFD nodes belong to it
        - rsmi_dev_*_partition*: now have better logging output
        - compute partition tests:
          Added 20 sec delay for workaround until GPU
          busy is confirmed as the issue
        - CPPLint fixes/formatting
        - [Example] Moved all endl to "\n" for efficiency
        - [Example] Added Edge & Junction temperature examples
        - [Example] Added rsmi_minmax_bandwidth_get() example - WIP

Change-Id: Ida6db6fda7e0ac9d696a34cb15b4746e69d58d51
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/rocm_smi_lib commit: b251bb0c9f]
2023-10-06 11:51:09 -04:00
Charis Poag b251bb0c9f Rename NPS -> memory partition + compute partition node fix
* Updates:
        - rocm_smi_lib + CLI:
          Rename all "NPS mode" -> "memory partition"
          related files/functions/API/CLI to align with correct
          technical naming
        - rocm_smi_main: fixed identifying primary card's unique id
          utilize rsmi_dev_unique_id_get to map which
          KFD nodes belong to it
        - rsmi_dev_*_partition*: now have better logging output
        - compute partition tests:
          Added 20 sec delay for workaround until GPU
          busy is confirmed as the issue
        - CPPLint fixes/formatting
        - [Example] Moved all endl to "\n" for efficiency
        - [Example] Added Edge & Junction temperature examples
        - [Example] Added rsmi_minmax_bandwidth_get() example - WIP

Change-Id: Ida6db6fda7e0ac9d696a34cb15b4746e69d58d51
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2023-10-06 11:51:09 -04:00
German Andryeyev d593231137 SWDEV-424603 - Force CPU wait if profiling
Some pytorch tests use a tracer plugin and rely on profiling information
to be reported right after hipDeviceSynchronize()

Change-Id: Ib021a1e7b1a30b3c24de72627c471810f7f7878d


[ROCm/clr commit: 5438b6362e]
2023-10-06 11:33:06 -04:00
German Andryeyev 5438b6362e SWDEV-424603 - Force CPU wait if profiling
Some pytorch tests use a tracer plugin and rely on profiling information
to be reported right after hipDeviceSynchronize()

Change-Id: Ib021a1e7b1a30b3c24de72627c471810f7f7878d
2023-10-06 11:33:06 -04:00
Philip Yang 85a47fa66b libhsakmt: Set CWSR range granularity
Set CWSR svm range granularity to 0xff, then KFD will migrate the entire
CWSR range from VRAM back to system memory when recovering the CPU page
fault if rocgdb access CWSR area, this avoid the partial CWSR range
migration and stall CWSR GPU mapping issue.

This is a temporary workaround, it should be reverted once the KFD is
fixed.

Change-Id: I80a7248244574edba25b13858b7ebcf1c77b8930
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
2023-10-06 10:46:40 -04:00
Philip Yang cf6745a36c libhsakmt: Set CWSR range granularity
Set CWSR svm range granularity to 0xff, then KFD will migrate the entire
CWSR range from VRAM back to system memory when recovering the CPU page
fault if rocgdb access CWSR area, this avoid the partial CWSR range
migration and stall CWSR GPU mapping issue.

This is a temporary workaround, it should be reverted once the KFD is
fixed.

Change-Id: I80a7248244574edba25b13858b7ebcf1c77b8930
Signed-off-by: Philip Yang <Philip.Yang@amd.com>


[ROCm/ROCR-Runtime commit: 85a47fa66b]
2023-10-06 10:46:40 -04:00
Ioannis Assiouras 8df12134a1 SWDEV-425471 - Link hipDispatchLatency sample with pthread library
Change-Id: I379823460ab5759de6019ce48b194d8844b65724


[ROCm/hip-tests commit: a5c353f8f5]
2023-10-06 05:44:05 -04:00
Ioannis Assiouras a5c353f8f5 SWDEV-425471 - Link hipDispatchLatency sample with pthread library
Change-Id: I379823460ab5759de6019ce48b194d8844b65724
2023-10-06 05:44:05 -04:00
Ioannis Assiouras 08c94b9a3d SWDEV-420989 - Initialize tiled_info meta_group_rank and meta_group_size
Change-Id: I6792e928702d0fef81f18e74eaead3ad3a8fbb7b


[ROCm/clr commit: 43126bc19b]
2023-10-06 05:43:04 -04:00
Ioannis Assiouras 43126bc19b SWDEV-420989 - Initialize tiled_info meta_group_rank and meta_group_size
Change-Id: I6792e928702d0fef81f18e74eaead3ad3a8fbb7b
2023-10-06 05:43:04 -04:00
Galantsev, Dmitrii 5b4439086d Merge amd-staging into amd-master 20231005
Change-Id: Ie217f139f63aa10ec5e9ce48797b7cb94864736d
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: 2831a5addc]
2023-10-05 16:22:45 -05:00
Galantsev, Dmitrii 2831a5addc Merge amd-staging into amd-master 20231005
Change-Id: Ie217f139f63aa10ec5e9ce48797b7cb94864736d
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-10-05 16:22:45 -05:00
Satyanvesh Dittakavi 6e2d845def SWDEV-424273 - Address MIGraphX tests staging failure
Change-Id: I5f51b62a0046f567603008974fda029d40d7656b


[ROCm/clr commit: f64ead62be]
2023-10-05 15:55:54 -04:00
Satyanvesh Dittakavi f64ead62be SWDEV-424273 - Address MIGraphX tests staging failure
Change-Id: I5f51b62a0046f567603008974fda029d40d7656b
2023-10-05 15:55:54 -04:00
kjayapra-amd 96580585c3 SWDEV-419688 - Do not run GWS init kernel for targets > gfx12 and MI300.
Change-Id: I8e7441268978be71ab8a5a33e7f8bcf69660e500
(cherry picked from commit 36d37ef614909c0f215512aac0c133408d787080)


[ROCm/clr commit: 6a8bc3c718]
2023-10-05 14:57:56 -04:00
kjayapra-amd 6a8bc3c718 SWDEV-419688 - Do not run GWS init kernel for targets > gfx12 and MI300.
Change-Id: I8e7441268978be71ab8a5a33e7f8bcf69660e500
(cherry picked from commit 36d37ef614909c0f215512aac0c133408d787080)
2023-10-05 14:57:56 -04:00
Galantsev, Dmitrii fce4f5fa08 Update package version
Change-Id: Ie094f75d028a09f862729094815f8a2b6ea8ad78
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: 8244a677db]
2023-10-05 12:49:11 -05:00
Galantsev, Dmitrii 8244a677db Update package version
Change-Id: Ie094f75d028a09f862729094815f8a2b6ea8ad78
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-10-05 12:49:11 -05:00
Sriraksha Nagaraj 04cec04c48 SWDEV-421208:Fixing the CMakelists for core unit test
Change-Id: I0949443e4204a69bb070532e4254d9baecd24dc3
2023-10-05 12:33:30 -04:00
Sriraksha Nagaraj 168afe160e SWDEV-421208:Fixing the CMakelists for core unit test
Change-Id: I0949443e4204a69bb070532e4254d9baecd24dc3


[ROCm/rocprofiler commit: 04cec04c48]
2023-10-05 12:33:30 -04:00
gobhardw 417ceaa47f Fixing missing limts header that causes build failure
Change-Id: I3d1ea3b6701a57a16af8742de446ce4bfea6ded6
2023-10-05 10:58:10 -04:00
gobhardw 31462313b6 Fixing missing limts header that causes build failure
Change-Id: I3d1ea3b6701a57a16af8742de446ce4bfea6ded6


[ROCm/rocprofiler commit: 417ceaa47f]
2023-10-05 10:58:10 -04:00