Commit Graph

64512 Commitit

Tekijä SHA1 Viesti Päivämäärä
Sourabh Betigeri 6375193bb4 SWDEV-417765 - Modifies test to verify dimensions returned by group_dim()
Change-Id: Ie92b9f74f4cc37b55f175cb828a88266c5167e0c


[ROCm/hip-tests commit: 9cef1f0ac5]
2023-10-12 11:51:50 -04:00
Sourabh Betigeri 9cef1f0ac5 SWDEV-417765 - Modifies test to verify dimensions returned by group_dim()
Change-Id: Ie92b9f74f4cc37b55f175cb828a88266c5167e0c
2023-10-12 11:51:50 -04:00
Jatin Chaudhary 63029a9739 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries
- alias hipGetDeviceProperties to hipGetDevicePropertiesR0600
- alias hipDeviceProp_t to hipDeviceProp_tR0600
- remove gcnArch from new device property struct
- add new requested struct members

Change-Id: If3f5dbef3d608487d9f6f419285f4bf577ea9bf0


[ROCm/hipother commit: 0ca6451c91]
2023-10-12 11:16:18 -04:00
Jatin Chaudhary 0ca6451c91 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries
- alias hipGetDeviceProperties to hipGetDevicePropertiesR0600
- alias hipDeviceProp_t to hipDeviceProp_tR0600
- remove gcnArch from new device property struct
- add new requested struct members

Change-Id: If3f5dbef3d608487d9f6f419285f4bf577ea9bf0
2023-10-12 11:16:18 -04:00
Jatin Chaudhary 15b062b9b4 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries
- alias hipGetDeviceProperties to hipGetDevicePropertiesR0600
- alias hipDeviceProp_t to hipDeviceProp_tR0600
- remove gcnArch from new device property struct
- add new requested struct members

Change-Id: If3f5dbef3d608487d9f6f419285f4bf577ea9bf0


[ROCm/clr commit: 2989840511]
2023-10-12 11:16:18 -04:00
Jatin Chaudhary 2989840511 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries
- alias hipGetDeviceProperties to hipGetDevicePropertiesR0600
- alias hipDeviceProp_t to hipDeviceProp_tR0600
- remove gcnArch from new device property struct
- add new requested struct members

Change-Id: If3f5dbef3d608487d9f6f419285f4bf577ea9bf0
2023-10-12 11:16:18 -04:00
Jatin Chaudhary f6a1ad4ca1 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries
- Remove directed test which use gcnArch because they have been ported
  to catch.

Change-Id: Ie4062b58572962a841c72831453e65685c3193ac


[ROCm/hip commit: 7156532286]
2023-10-12 10:37:18 -04:00
Jatin Chaudhary 7156532286 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries
- Remove directed test which use gcnArch because they have been ported
  to catch.

Change-Id: Ie4062b58572962a841c72831453e65685c3193ac
2023-10-12 10:37:18 -04:00
Satyanvesh Dittakavi 64215d55e7 SWDEV-420738 - Fix Unit_hipTextureObj3DCheckModes issue due to hipGetLastError change
Change-Id: I3f6efe6f995a2cf041a6f74000fec236298c34a7


[ROCm/hip-tests commit: d517f0175c]
2023-10-12 10:21:10 -04:00
Satyanvesh Dittakavi d517f0175c SWDEV-420738 - Fix Unit_hipTextureObj3DCheckModes issue due to hipGetLastError change
Change-Id: I3f6efe6f995a2cf041a6f74000fec236298c34a7
2023-10-12 10:21:10 -04:00
mbhiutra 350b05a9e3 SWDEV-306122 - [catch2][dtest] Added test for hipGraphMemAllocNodeGetParams, hipGraphMemFreeNodeGetParams APIs
Change-Id: I0b68b6d26e91911acb8c14bd95bb62d6d9688ef4


[ROCm/hip-tests commit: 1ef4b7f4ea]
2023-10-12 10:16:52 -04:00
mbhiutra 1ef4b7f4ea SWDEV-306122 - [catch2][dtest] Added test for hipGraphMemAllocNodeGetParams, hipGraphMemFreeNodeGetParams APIs
Change-Id: I0b68b6d26e91911acb8c14bd95bb62d6d9688ef4
2023-10-12 10:16:52 -04:00
mbhiutra 3cbc2d6553 SWDEV-389401 - [catch2][dtest] hipGetLastError API test
Change-Id: I7c264307269593c2b6d2529a76c04b4b08f752f5


[ROCm/hip-tests commit: 896ffb454b]
2023-10-12 10:09:40 -04:00
mbhiutra 896ffb454b SWDEV-389401 - [catch2][dtest] hipGetLastError API test
Change-Id: I7c264307269593c2b6d2529a76c04b4b08f752f5
2023-10-12 10:09:40 -04:00
Giovanni LB e0962d9d63 SWDEV-423947: Added ATT header option
Change-Id: I6e9ad213b578d752c865c9f9af4ee0b79d447e1b
2023-10-12 10:02:30 -04:00
Giovanni LB 769f6303d8 SWDEV-423947: Added ATT header option
Change-Id: I6e9ad213b578d752c865c9f9af4ee0b79d447e1b


[ROCm/rocprofiler commit: e0962d9d63]
2023-10-12 10:02:30 -04:00
guanyu12 8022953433 Merge amd-staging into amd-master 20231012
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: I02018dfe5cd2aafe3fb754111242a168fe1b9a60


[ROCm/rocm_smi_lib commit: 2cedb90290]
2023-10-12 15:57:48 +08:00
guanyu12 2cedb90290 Merge amd-staging into amd-master 20231012
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: I02018dfe5cd2aafe3fb754111242a168fe1b9a60
2023-10-12 15:57:48 +08:00
Tomasz Kłoczko a226542fc3 install .pc files in libdir
Provided pkgconfig file contains interface description which is arch
dependent. In such cases .pc files should be installed in libdir.

Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Change-Id: Ibbc85ad4aee1ef014c409dfa63313873b590464b
2023-10-11 15:50:38 -04:00
Tomasz Kłoczko 3c5a5397fe install .pc files in libdir
Provided pkgconfig file contains interface description which is arch
dependent. In such cases .pc files should be installed in libdir.

Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Change-Id: Ibbc85ad4aee1ef014c409dfa63313873b590464b


[ROCm/ROCR-Runtime commit: a226542fc3]
2023-10-11 15:50:38 -04:00
Torsten Keßler b44cca813d Mark new symbols in ROCm 5.7.0 as global
Change-Id: Ia0391cac7f432f019dea94f98a145dbf8120817d
2023-10-11 15:50:27 -04:00
Torsten Keßler 7d30e82f41 Mark new symbols in ROCm 5.7.0 as global
Change-Id: Ia0391cac7f432f019dea94f98a145dbf8120817d


[ROCm/ROCR-Runtime commit: b44cca813d]
2023-10-11 15:50:27 -04:00
sdashmiz 8a1939c80f SWDEV-421021 - add hipDrvGraphAddMemsetNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id3fbfc0d9b663f74ed1b76f5aa32dea904b1eec6


[ROCm/hip commit: ffefac3a8d]
2023-10-11 15:27:18 -04:00
sdashmiz ffefac3a8d SWDEV-421021 - add hipDrvGraphAddMemsetNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id3fbfc0d9b663f74ed1b76f5aa32dea904b1eec6
2023-10-11 15:27:18 -04:00
Giovanni LB fdd4af4023 SWDEV-421283: ATT readme updates
Change-Id: I282a53ba6a6349b10c5976ab4232f451f51d82f6
2023-10-11 14:22:53 -04:00
Giovanni LB 5d443a4821 SWDEV-421283: ATT readme updates
Change-Id: I282a53ba6a6349b10c5976ab4232f451f51d82f6


[ROCm/rocprofiler commit: fdd4af4023]
2023-10-11 14:22:53 -04:00
Giovanni LB 865d2782e8 SWDEV-416889: Changing rocminfo location from ROCM_PATH to CPACK_INSTALL_PATH
Change-Id: I7a488a05fc3903fcfcbeac6a76fe2d31f3a23bad
2023-10-11 14:18:31 -04:00
Giovanni LB e52fb98671 SWDEV-416889: Changing rocminfo location from ROCM_PATH to CPACK_INSTALL_PATH
Change-Id: I7a488a05fc3903fcfcbeac6a76fe2d31f3a23bad


[ROCm/rocprofiler commit: 865d2782e8]
2023-10-11 14:18:31 -04:00
jiabaxie 4cef95d286 SWDEV-418999 - python script to support profiler with hip versioning
Change-Id: I8f5ad81162581bf3792c2606ba8c6c3a8e0b4bf2


[ROCm/clr commit: 813907c29d]
2023-10-11 13:46:45 -04:00
jiabaxie 813907c29d SWDEV-418999 - python script to support profiler with hip versioning
Change-Id: I8f5ad81162581bf3792c2606ba8c6c3a8e0b4bf2
2023-10-11 13:46:45 -04:00
Galantsev, Dmitrii 02c4b477d1 Fix rocm_smi.cc
Change-Id: Ib074dd542d8d37a6a618e10bd3bd389ad0cef108
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: 3f0071599d]
2023-10-11 11:46:49 -05:00
Galantsev, Dmitrii 3f0071599d Fix rocm_smi.cc
Change-Id: Ib074dd542d8d37a6a618e10bd3bd389ad0cef108
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-10-11 11:46:49 -05:00
Giovanni LB 11a15ef9b0 SWDEV-423947: Moving to new aqllib
Change-Id: I2f99d88f9bda752fa0533f9c4416c805b68724d7
2023-10-11 10:59:30 -04:00
Giovanni LB 26f0300db7 SWDEV-423947: Moving to new aqllib
Change-Id: I2f99d88f9bda752fa0533f9c4416c805b68724d7


[ROCm/rocprofiler commit: 11a15ef9b0]
2023-10-11 10:59:30 -04:00
Rakesh Roy e2e169f47c SWDEV-421667 - Print shared library name which doesn't contain CO for current device
- ML Frameworks link many ROCm component libraries
- It becomes a tedious task to figure out which library HIP is complaining about
- To improve debuggability print out the shared library name

Change-Id: I53c4d66393670356b8cafd3e48075e430f0a45ce


[ROCm/clr commit: 52001adf43]
2023-10-11 10:43:03 -04:00
Rakesh Roy 52001adf43 SWDEV-421667 - Print shared library name which doesn't contain CO for current device
- ML Frameworks link many ROCm component libraries
- It becomes a tedious task to figure out which library HIP is complaining about
- To improve debuggability print out the shared library name

Change-Id: I53c4d66393670356b8cafd3e48075e430f0a45ce
2023-10-11 10:43:03 -04:00
guanyu12 8a41eaf10f Merge amd-staging into amd-master 20231011
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: I5bba3ad4723cdaf9dc3fff1e80fc106ca2a59e22


[ROCm/rocm_smi_lib commit: 7b6012939e]
2023-10-11 17:24:11 +08:00
guanyu12 7b6012939e Merge amd-staging into amd-master 20231011
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: I5bba3ad4723cdaf9dc3fff1e80fc106ca2a59e22
2023-10-11 17:24:11 +08:00
jiabaxie f25e5e01f3 SWDEV-405983 - adding in HIP_LAUNCH_BLOCKING
Change-Id: I3f9c8a745099aab05155ebe910e727693961a02f


[ROCm/clr commit: 28f0daa34f]
2023-10-10 21:11:13 -04:00
jiabaxie 28f0daa34f SWDEV-405983 - adding in HIP_LAUNCH_BLOCKING
Change-Id: I3f9c8a745099aab05155ebe910e727693961a02f
2023-10-10 21:11:13 -04:00
Jonathan R. Madsen 1bf4cb0893 Agent information w/o using hsa-runtime (#100)
* Agent information w/o using hsa-runtime

- remove lib/rocprofiler/hsa/agent.{hpp,cpp}
- update include/rocprofiler/agent.h
  - basically all possible info from /sys/class/kfd/kfd/topology/nodes/*

* Print topology in rocprofiler_lib.agent test

- hack to help diagnose errors

* Update lib/rocprofiler/tests/details/agent.cpp

- use LOG_IF(WARNING, ...) instead of LOG_IF(FATAL, ...)

* Update lib/rocprofiler/tests/agent.cpp

- print rocminfo at beginning of test
- fix comparison of agent handle
- misc other checks

* Updte lib/rocprofiler/agent.cpp

- handle unreadable /sys/class/kfd/kfd/topology/nodes/<N>/properties file

* Update lib/tests/buffering/CMakeLists.txt

- increase timeout to 120
  - buffering.parallel will timeout when thread sanitizing is enabled

* Update cmake: rocprofiler-drm

- find drm headers and libraries

* Update include/rocprofiler/agent.h

- add family_id field

* Update lib/rocprofiler/agent.cpp

- parse /proc/cpuinfo for name, family, apicid, etc.
- read_topology uses unique pointers to cleanup memory allocations
- implement name and gfxip

* Update lib/rocprofiler/tests/agent.cpp

- improved failure message
- check name/gfxip
- remove check against hsa_agent_t.handle
  - this value is dependent on the address of C++ class

* Update lib/rocprofiler/tests/details/agent.cpp

- tweak gfxip_ variable which is broken for CPU

* Update lib/rocprofiler/agent.cpp

- update string handling for name and gfxip

* Update lib/rocprofiler/tests/agent.cpp

- minor output tweak

* Update lib/rocprofiler/registration.{hpp,cpp}

- registration::init_logging() function

* Update lib/rocprofiler/agent.cpp

- fix hex handling of GFX step version

* Update lib/rocprofiler/tests/details/agent.cpp

- fix format string when nearest CPUs not found

* Update lib/rocprofiler/tests/CMakeLists.txt

- exclude details/agent.cpp from being parsed for gtest tests

* Update include/rocprofiler/fwd.h

- add ROCPROFILER_STATUS_ERROR_INCOMPATIBLE_ABI status

* Update lib/rocprofiler/tests/details/agent.{hpp,cpp}

- replace with slightly modified implementation of rocminfo
  - primary change was not printing

* Update lib/rocprofiler/tests/agent.cpp

- update test to use rocminfo data

* Update lib/rocprofiler/agent.cpp

- add pc_sampling_configs
- return error on incompatible ABI

* Update counters and counters tests

- rename test names for consistency
- fixed incorrect spelling of derived

* Add lib/rocprofiler/tests/{timestamp,version}.cpp

- add timestamp and version tests for rocprofiler_get_timestamp and rocprofiler_get_version, respectively

* Update lib/rocprofiler/tests/agent

- fix double free of name_str from isa_info_t

* Update include/rocprofiler/agent.h

- comments for rocprofiler_agent_mem_bank_t
- add rocprofiler_dim3_t
- comments for rocprofiler_agent_t
- add new fields to rocprofiler_agent_t
    - cu_count
    - workgroup_max_size
    - workgroup_max_dim
    - grid_max_size
    - grid_max_dim
    - vendor_name
    - product_name
- change prototype of rocprofiler_available_agents_cb_t to be const agent**

* Update lib/rocprofiler/agent.cpp

- set size field
- implement:
  - product_name
  - vendor_name
  - workgroup_max_size
  - workgroup_max_dim
  - grid_max_size
  - grid_max_dim
  - cu_count

* Update lib/rocprofiler/tests/agent.cpp

- changes for const agent*

* Update samples/pc_sampling

- updates for const agent*

* Update lib/rocprofiler/agent.cpp

- fix ABI compatibility check
  - return incompatible if tool agent is larger than our agent

* Update include/rocprofiler/agent.h

- doxygen comments
- make size field of rocprofiler_agent_t uint64_t for consistency
- add gpu_id via /sys/class/kfd/kfd/.../<idx>/gpu_id
- add model_name via /sys/class/kfd/kfd/.../<idx>/name

* Update lib/rocprofiler/agent.cpp

- add read_file function (vector of strings)
- support enum in read_property
- assign model_name and gpu_id fields
- remove unique_id

* Update lib/rocprofiler/tests/details/agent.*

- support family id, ucode_version, sdma_ucode_version

* Update lib/rocprofiler/tests/agent.cpp

- Add rocprofiler_lib.agent_abi test
- Verify family_id, ucode_version, sdma_ucode_version

[ROCm/rocprofiler-sdk commit: a798a26227]
2023-10-10 18:10:23 -05:00
Jonathan R. Madsen a798a26227 Agent information w/o using hsa-runtime (#100)
* Agent information w/o using hsa-runtime

- remove lib/rocprofiler/hsa/agent.{hpp,cpp}
- update include/rocprofiler/agent.h
  - basically all possible info from /sys/class/kfd/kfd/topology/nodes/*

* Print topology in rocprofiler_lib.agent test

- hack to help diagnose errors

* Update lib/rocprofiler/tests/details/agent.cpp

- use LOG_IF(WARNING, ...) instead of LOG_IF(FATAL, ...)

* Update lib/rocprofiler/tests/agent.cpp

- print rocminfo at beginning of test
- fix comparison of agent handle
- misc other checks

* Updte lib/rocprofiler/agent.cpp

- handle unreadable /sys/class/kfd/kfd/topology/nodes/<N>/properties file

* Update lib/tests/buffering/CMakeLists.txt

- increase timeout to 120
  - buffering.parallel will timeout when thread sanitizing is enabled

* Update cmake: rocprofiler-drm

- find drm headers and libraries

* Update include/rocprofiler/agent.h

- add family_id field

* Update lib/rocprofiler/agent.cpp

- parse /proc/cpuinfo for name, family, apicid, etc.
- read_topology uses unique pointers to cleanup memory allocations
- implement name and gfxip

* Update lib/rocprofiler/tests/agent.cpp

- improved failure message
- check name/gfxip
- remove check against hsa_agent_t.handle
  - this value is dependent on the address of C++ class

* Update lib/rocprofiler/tests/details/agent.cpp

- tweak gfxip_ variable which is broken for CPU

* Update lib/rocprofiler/agent.cpp

- update string handling for name and gfxip

* Update lib/rocprofiler/tests/agent.cpp

- minor output tweak

* Update lib/rocprofiler/registration.{hpp,cpp}

- registration::init_logging() function

* Update lib/rocprofiler/agent.cpp

- fix hex handling of GFX step version

* Update lib/rocprofiler/tests/details/agent.cpp

- fix format string when nearest CPUs not found

* Update lib/rocprofiler/tests/CMakeLists.txt

- exclude details/agent.cpp from being parsed for gtest tests

* Update include/rocprofiler/fwd.h

- add ROCPROFILER_STATUS_ERROR_INCOMPATIBLE_ABI status

* Update lib/rocprofiler/tests/details/agent.{hpp,cpp}

- replace with slightly modified implementation of rocminfo
  - primary change was not printing

* Update lib/rocprofiler/tests/agent.cpp

- update test to use rocminfo data

* Update lib/rocprofiler/agent.cpp

- add pc_sampling_configs
- return error on incompatible ABI

* Update counters and counters tests

- rename test names for consistency
- fixed incorrect spelling of derived

* Add lib/rocprofiler/tests/{timestamp,version}.cpp

- add timestamp and version tests for rocprofiler_get_timestamp and rocprofiler_get_version, respectively

* Update lib/rocprofiler/tests/agent

- fix double free of name_str from isa_info_t

* Update include/rocprofiler/agent.h

- comments for rocprofiler_agent_mem_bank_t
- add rocprofiler_dim3_t
- comments for rocprofiler_agent_t
- add new fields to rocprofiler_agent_t
    - cu_count
    - workgroup_max_size
    - workgroup_max_dim
    - grid_max_size
    - grid_max_dim
    - vendor_name
    - product_name
- change prototype of rocprofiler_available_agents_cb_t to be const agent**

* Update lib/rocprofiler/agent.cpp

- set size field
- implement:
  - product_name
  - vendor_name
  - workgroup_max_size
  - workgroup_max_dim
  - grid_max_size
  - grid_max_dim
  - cu_count

* Update lib/rocprofiler/tests/agent.cpp

- changes for const agent*

* Update samples/pc_sampling

- updates for const agent*

* Update lib/rocprofiler/agent.cpp

- fix ABI compatibility check
  - return incompatible if tool agent is larger than our agent

* Update include/rocprofiler/agent.h

- doxygen comments
- make size field of rocprofiler_agent_t uint64_t for consistency
- add gpu_id via /sys/class/kfd/kfd/.../<idx>/gpu_id
- add model_name via /sys/class/kfd/kfd/.../<idx>/name

* Update lib/rocprofiler/agent.cpp

- add read_file function (vector of strings)
- support enum in read_property
- assign model_name and gpu_id fields
- remove unique_id

* Update lib/rocprofiler/tests/details/agent.*

- support family id, ucode_version, sdma_ucode_version

* Update lib/rocprofiler/tests/agent.cpp

- Add rocprofiler_lib.agent_abi test
- Verify family_id, ucode_version, sdma_ucode_version
2023-10-10 18:10:23 -05:00
colramos-amd ef5c3cf780 Fixed baseline compare pct change issue occuring with small values
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: ef2e460952]
2023-10-10 14:01:50 -05:00
colramos-amd ef2e460952 Fixed baseline compare pct change issue occuring with small values
Signed-off-by: colramos-amd <colramos@amd.com>
2023-10-10 14:01:50 -05:00
Nirmal Unnikrishnan 2a45d0e378 SWDEV-310152 : Adding script to convert RUNPATH to RPATH in libs/bins
Change-Id: Ic6c49544cb7450384592b4f5609fb394f1f12f02


[ROCm/rocm-core commit: 478270cb11]
2023-10-10 13:30:09 -05:00
Nirmal Unnikrishnan 478270cb11 SWDEV-310152 : Adding script to convert RUNPATH to RPATH in libs/bins
Change-Id: Ic6c49544cb7450384592b4f5609fb394f1f12f02
2023-10-10 13:30:09 -05:00
Saleel Kudchadker 0ec2d8847d SWDEV-301667 - Track last used SDMA engine per queue
- Track last SDMA engine per queue, this results in better scheduling
- Reset last SDMA engine upon batch completion. That ensures we dont get
blocked if the same engine is used by another concurrent copy

Change-Id: Id53111980da7ee41d5c932fb44e4aab5b1e065a3


[ROCm/clr commit: bf8baeecb3]
2023-10-10 12:13:11 -04:00
Saleel Kudchadker bf8baeecb3 SWDEV-301667 - Track last used SDMA engine per queue
- Track last SDMA engine per queue, this results in better scheduling
- Reset last SDMA engine upon batch completion. That ensures we dont get
blocked if the same engine is used by another concurrent copy

Change-Id: Id53111980da7ee41d5c932fb44e4aab5b1e065a3
2023-10-10 12:13:11 -04:00
Giovanni LB 9efd1865c0 Fixing GL2C counter instances
Change-Id: I37edbdaebe349149e369b21a9e48c302e170941e
2023-10-10 12:09:49 -04:00
Giovanni LB 92ec86f2d4 Fixing GL2C counter instances
Change-Id: I37edbdaebe349149e369b21a9e48c302e170941e


[ROCm/rocprofiler commit: 9efd1865c0]
2023-10-10 12:09:49 -04:00