Commit Graph
64512 Commits
Author SHA1 Message Date
Ajay 89e67da3a1 SWDEV-313680 - hipGraphAddKernelNode invalid cases
Change-Id: I4c87c5dd80cd3f78f5c38b2d3447b03b91ffa656


[ROCm/clr commit: ef71f0ded1]
2022-03-03 20:43:02 -05:00
Ajay ef71f0ded1 SWDEV-313680 - hipGraphAddKernelNode invalid cases
Change-Id: I4c87c5dd80cd3f78f5c38b2d3447b03b91ffa656
2022-03-03 20:43:02 -05:00
Ranjith Ramakrishnan f391b5d739 File reorganization with backward compatibility
Wrapper header files
Soft link to libraries and binaries
rocm_smi.py and rsmiBindings.py installed in libexec/rocm_smi
Binaries, libraries and header files installed as per File Reorg folder structure

Change-Id: I3166ab67f89c2ae4aafbc87bb00c9a5233221ade


[ROCm/rocm_smi_lib commit: f1da5591b5]
2022-03-03 18:48:52 -05:00
Ranjith Ramakrishnan f1da5591b5 File reorganization with backward compatibility
Wrapper header files
Soft link to libraries and binaries
rocm_smi.py and rsmiBindings.py installed in libexec/rocm_smi
Binaries, libraries and header files installed as per File Reorg folder structure

Change-Id: I3166ab67f89c2ae4aafbc87bb00c9a5233221ade
2022-03-03 18:48:52 -05:00
Bill(Shuzhou) Liu 2a46ee2ab2 Enable the support to grpc v1.44.0
grpc v1.44.0 needs to link to library absl_synchronization. The
CMakeLists.txt is changed to link to that library if available.

Change-Id: I92f7247473a70e7a83416b9744e788e45d104565
2022-03-03 16:11:09 -05:00
Bill(Shuzhou) Liu a408ccb983 Enable the support to grpc v1.44.0
grpc v1.44.0 needs to link to library absl_synchronization. The
CMakeLists.txt is changed to link to that library if available.

Change-Id: I92f7247473a70e7a83416b9744e788e45d104565


[ROCm/rdc commit: 2a46ee2ab2]
2022-03-03 16:11:09 -05:00
Bill(Shuzhou) Liu 9b2017de0c Prevent stack buffer overflow
readlink() does not append a null byte to buffer. Initialize the
tpath to prevent stack buffer overflow.

Change-Id: I17895dc3576b080a0c35bd0528a5b83223ec1c1b


[ROCm/rocm_smi_lib commit: 4b65b0307f]
2022-03-03 15:43:53 -05:00
Bill(Shuzhou) Liu 4b65b0307f Prevent stack buffer overflow
readlink() does not append a null byte to buffer. Initialize the
tpath to prevent stack buffer overflow.

Change-Id: I17895dc3576b080a0c35bd0528a5b83223ec1c1b
2022-03-03 15:43:53 -05:00
Ajay 2adc7d9113 SWDEV-325545 - hipGraphGetEdges when both from/to are null
Change-Id: Id69d87537a8a7fb7df447cee586137ff1342ce26


[ROCm/clr commit: f2254e0c34]
2022-03-03 13:23:48 -05:00
Ajay f2254e0c34 SWDEV-325545 - hipGraphGetEdges when both from/to are null
Change-Id: Id69d87537a8a7fb7df447cee586137ff1342ce26
2022-03-03 13:23:48 -05:00
Maneesh Gupta ff659975f4 SWDEV-325869 - Update ASAN linker options
Change-Id: I9ef513ab647ec0866cdf0f70f759ab95d80081b9


[ROCm/clr commit: 94ed5262c6]
2022-03-03 11:45:06 +00:00
Maneesh Gupta 94ed5262c6 SWDEV-325869 - Update ASAN linker options
Change-Id: I9ef513ab647ec0866cdf0f70f759ab95d80081b9
2022-03-03 11:45:06 +00:00
Hao Zhou 300b9479c3 Merge amd-staging into amd-master 20220303
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I3b870b9944df71ab11b2c9de176c74351f89068a


[ROCm/rocm_smi_lib commit: f02fe43b55]
2022-03-03 17:18:52 +08:00
Hao Zhou f02fe43b55 Merge amd-staging into amd-master 20220303
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I3b870b9944df71ab11b2c9de176c74351f89068a
2022-03-03 17:18:52 +08:00
Saleel Kudchadker 952c9c89e7 SWDEV-301667 - Treat build warnings as errors for GCC
Change-Id: I5f9633a94d064969103af7c946c879cacd33efde


[ROCm/clr commit: 65cb94a720]
2022-03-03 03:04:52 -05:00
Saleel Kudchadker 65cb94a720 SWDEV-301667 - Treat build warnings as errors for GCC
Change-Id: I5f9633a94d064969103af7c946c879cacd33efde
2022-03-03 03:04:52 -05:00
cjatin added78cbc SWDEV-308763 - Make hiprtc a separate lib and rewrite it using comgr
Change-Id: I28ac50ec897accb2a2b4590d3c25965d907426fb


[ROCm/clr commit: e6c0086d1c]
2022-03-03 02:34:02 -05:00
cjatin e6c0086d1c SWDEV-308763 - Make hiprtc a separate lib and rewrite it using comgr
Change-Id: I28ac50ec897accb2a2b4590d3c25965d907426fb
2022-03-03 02:34:02 -05:00
Sean Keely 8a6954c63c Do not allow occupancy restriction on cooperative groups.
Excessive scratch allocations can normally trigger occupancy
reduction.  This breaks cooperative groups so if occupancy
reduction is required on a cooperative dispatch fail with OOM.

Change-Id: I64612a2e38bf1286f3b74c1c2a68ab0c85452771
2022-03-02 19:59:30 -06:00
Sean Keely 47e1632188 Do not allow occupancy restriction on cooperative groups.
Excessive scratch allocations can normally trigger occupancy
reduction.  This breaks cooperative groups so if occupancy
reduction is required on a cooperative dispatch fail with OOM.

Change-Id: I64612a2e38bf1286f3b74c1c2a68ab0c85452771


[ROCm/ROCR-Runtime commit: 8a6954c63c]
2022-03-02 19:59:30 -06:00
Sean Keely 552dcead93 Correct scratch allocation logic to account for asymmetric harvest.
With asym. harvest hw does not issue groups equally to each SE,
occasionally hw will skip an SE so that the distribution reflects
each SE's CU count.  Scratch resources must be allocated to reflect
this asymmetric distribution of groups.

Change-Id: I65e26206500483ea18e6e8796e65ecba5354b029
2022-03-02 19:59:30 -06:00
Sean Keely c58913a8c8 Correct scratch allocation logic to account for asymmetric harvest.
With asym. harvest hw does not issue groups equally to each SE,
occasionally hw will skip an SE so that the distribution reflects
each SE's CU count.  Scratch resources must be allocated to reflect
this asymmetric distribution of groups.

Change-Id: I65e26206500483ea18e6e8796e65ecba5354b029


[ROCm/ROCR-Runtime commit: 552dcead93]
2022-03-02 19:59:30 -06:00
Saleel Kudchadker 8139cc4683 SWDEV-301667 - Fix build warnings
Change-Id: Ice23b3d1a19a7958ca5c3caff34db2934b361a98


[ROCm/clr commit: 086aee0fcb]
2022-03-02 20:49:18 -05:00
Saleel Kudchadker 086aee0fcb SWDEV-301667 - Fix build warnings
Change-Id: Ice23b3d1a19a7958ca5c3caff34db2934b361a98
2022-03-02 20:49:18 -05:00
Sean Keely cedc3e80a8 Do not bump up total scratch size for large cached allocations.
HW does not ignore low bits of the scratch wave count and will
stride beyond the end of the allocation if the wave count is
ever indivisible by SE count.  Rather than returning the allocation
size for cached large scratch allocations, use the requested
scratch size in scratch setup.  Scratch cache will retain the
cached allocation's size.

Change-Id: I0129ddc99a8940d01d8fbcd0b02d5061f31f456d
2022-03-02 20:48:19 -05:00
Sean Keely c196acd677 Do not bump up total scratch size for large cached allocations.
HW does not ignore low bits of the scratch wave count and will
stride beyond the end of the allocation if the wave count is
ever indivisible by SE count.  Rather than returning the allocation
size for cached large scratch allocations, use the requested
scratch size in scratch setup.  Scratch cache will retain the
cached allocation's size.

Change-Id: I0129ddc99a8940d01d8fbcd0b02d5061f31f456d


[ROCm/ROCR-Runtime commit: cedc3e80a8]
2022-03-02 20:48:19 -05:00
Sourabh Betigeri eca06b35b9 SWDEV-273026 - Fixes a bug that skipped looping through all devices to book keep its corresponding memory in roclr
Change-Id: I404f6d2bcd0c0e31b9b0237903f26f0af19bc735


[ROCm/clr commit: 545cfaf428]
2022-03-02 20:26:28 -05:00
Sourabh Betigeri 545cfaf428 SWDEV-273026 - Fixes a bug that skipped looping through all devices to book keep its corresponding memory in roclr
Change-Id: I404f6d2bcd0c0e31b9b0237903f26f0af19bc735
2022-03-02 20:26:28 -05:00
Julia Jiang f8cac285e5 SWDEV-324824 - Update install instrction to define repository branch variable
Change-Id: I6080aabb5a9b6d4a89bc1f2a26c4ed3a4e77aa9f


[ROCm/clr commit: ab16be4b8f]
2022-03-02 19:56:37 -05:00
Julia Jiang ab16be4b8f SWDEV-324824 - Update install instrction to define repository branch variable
Change-Id: I6080aabb5a9b6d4a89bc1f2a26c4ed3a4e77aa9f
2022-03-02 19:56:37 -05:00
ROCm CI Service Account 146d638001 SWDEV-301947 - Rename query (#2530)
Rename hipDeviceAttributeMultiprocessorBoostCount to
hipDeviceAttributePhysicalMultiProcessorCount

Change-Id: I9f4a7d22bfeef7502c6e8060dcd671e012772d98


[ROCm/hip commit: cc28cc271e]
2022-03-02 16:04:09 -08:00
ROCm CI Service Account cc28cc271e SWDEV-301947 - Rename query (#2530)
Rename hipDeviceAttributeMultiprocessorBoostCount to
hipDeviceAttributePhysicalMultiProcessorCount

Change-Id: I9f4a7d22bfeef7502c6e8060dcd671e012772d98
2022-03-02 16:04:09 -08:00
Saleel Kudchadker 49a1d54a5d SWDEV-321723 - Refactor hipHostMalloc flags
Always choose fing grain memory pool for hipHostMalloc
Choose coarse grain only if hipHostMallocNonCoherent is passed.

Change-Id: I9a67ba77335d4f373d32fea4ecd7848c77f9c190


[ROCm/clr commit: 0da908ec79]
2022-03-02 16:24:40 -05:00
Saleel Kudchadker 0da908ec79 SWDEV-321723 - Refactor hipHostMalloc flags
Always choose fing grain memory pool for hipHostMalloc
Choose coarse grain only if hipHostMallocNonCoherent is passed.

Change-Id: I9a67ba77335d4f373d32fea4ecd7848c77f9c190
2022-03-02 16:24:40 -05:00
Mukul Joshi b8dc875b3c libhsakmt: Update context save area size calculations
Currently, context save area size passed to KFD includes the
size of the debug area. Change this to report the actual size
of the context save area to KFD.

Signed-off-by: Mukul Joshi <mukul.joshi@amd.com>
Change-Id: I5d440ae802255a97ade046775f6a000bae79d5d5
2022-03-02 15:28:38 -05:00
Mukul Joshi a01f9f6a61 libhsakmt: Update context save area size calculations
Currently, context save area size passed to KFD includes the
size of the debug area. Change this to report the actual size
of the context save area to KFD.

Signed-off-by: Mukul Joshi <mukul.joshi@amd.com>
Change-Id: I5d440ae802255a97ade046775f6a000bae79d5d5


[ROCm/ROCR-Runtime commit: b8dc875b3c]
2022-03-02 15:28:38 -05:00
Chauncey Hui 8fd4a43f3e SWDEV-2 - Change OpenCL version number from 3427 to 3428
[ROCm/clr commit: a6bcb4435a]
2022-03-02 03:00:06 -05:00
Chauncey Hui a6bcb4435a SWDEV-2 - Change OpenCL version number from 3427 to 3428 2022-03-02 03:00:06 -05:00
Ajay b4f68b52d3 SWDEV-315443 - hipGraph and Node issues
Change-Id: I9fefd1a12d83bfa89d6704ee236c1409618ab02a


[ROCm/clr commit: 944c18c754]
2022-03-02 00:40:05 +00:00
Ajay 944c18c754 SWDEV-315443 - hipGraph and Node issues
Change-Id: I9fefd1a12d83bfa89d6704ee236c1409618ab02a
2022-03-02 00:40:05 +00:00
Mark Laws a11ac0a632 SWDEV-283957 : Emit correct group name for rocprof split metrics
Change-Id: Id096edd03bb5be9c8082296fdb659845f2b9c7a6
2022-03-01 11:16:00 -06:00
Mark Laws 5c00c7f844 SWDEV-283957 : Emit correct group name for rocprof split metrics
Change-Id: Id096edd03bb5be9c8082296fdb659845f2b9c7a6


[ROCm/rocprofiler commit: a11ac0a632]
2022-03-01 11:16:00 -06:00
haoyuan2 133f476d2e SWDEV-298331 - Fix FreeLibrary throw exception issue on Windows
release HIP resource at DLL_PROCESS_DETACH point

Change-Id: I884ab028eeec1aaa2f655746f7eeae130fd009e4


[ROCm/clr commit: 58e1867079]
2022-03-01 12:06:05 -05:00
haoyuan2 58e1867079 SWDEV-298331 - Fix FreeLibrary throw exception issue on Windows
release HIP resource at DLL_PROCESS_DETACH point

Change-Id: I884ab028eeec1aaa2f655746f7eeae130fd009e4
2022-03-01 12:06:05 -05:00
Jenkins 13388cf479 SWDEV-299127 - Merge 'develop' into 'amd-staging'
Change-Id: If8efa59b48c1b4c0f34024ada6f42c19c82686d6


[ROCm/hip commit: 77fd73caf2]
2022-03-01 07:11:34 -05:00
Jenkins 77fd73caf2 SWDEV-299127 - Merge 'develop' into 'amd-staging'
Change-Id: If8efa59b48c1b4c0f34024ada6f42c19c82686d6
2022-03-01 07:11:34 -05:00
Chauncey Hui 8ce52aba5b SWDEV-2 - Change OpenCL version number from 3426 to 3427
[ROCm/clr commit: ba8172b4ad]
2022-03-01 03:00:07 -05:00
Chauncey Hui ba8172b4ad SWDEV-2 - Change OpenCL version number from 3426 to 3427 2022-03-01 03:00:07 -05:00
agunashe 1828535524 SWDEV-1 - hip tests: Moving ctest file generation to execution phase (#2522)
Earlier ctest file creation was taking place during build time.
Due to cmake framework issue the file creation had issues,
which in turn failed the test build.
This change moves this logic to the execution phase
and gets rid of the unwanted dependency during build time

Change-Id: Ifbf7e325f1b15a8be12e76560a6d339bc76705ee

[ROCm/hip-tests commit: 4872e70674]
2022-02-28 09:26:33 -08:00
agunashe 4872e70674 SWDEV-1 - hip tests: Moving ctest file generation to execution phase (#2522)
Earlier ctest file creation was taking place during build time.
Due to cmake framework issue the file creation had issues,
which in turn failed the test build.
This change moves this logic to the execution phase
and gets rid of the unwanted dependency during build time

Change-Id: Ifbf7e325f1b15a8be12e76560a6d339bc76705ee
2022-02-28 09:26:33 -08:00