Commit Graph

1263 Commits

Author SHA1 Message Date
vedithal-amd bb44e90b2d Unified configuration for metrics (#726)
* Show description of metrics during analysis
    * Use --include-cols Description show the Description column in analyze mode (this is hidden by default)
    * Remove tips field from analysis config

* Align metric names in analysis config and documentation

* Add unified config utils/unified_config.yaml

* Add python script utils/split_config.py to auto generate analysis configuration and documentation metrics description
   * Add test case to ensure unified config is older than auto-generated config
   * Auto generate analysis config and documentation metrics description

* Update CONTRIBUTING.md to add instructions to build documentation assets
    * Add docker image and compose file to build documentation

* Update CHANGELOG and Documentation

* Use jinja template instead of hardcoding metric tables in documentation
2025-07-25 14:01:34 -04:00
xuchen-amd 99a6e67bcc Improve --time-unit arg (#807) 2025-07-24 12:15:52 -04:00
vedithal-amd dbcaccb9de Fix rocprofv3 supported counters not being detected (#832)
* Fix rocprofv3 supported counters not being detected

* Fix rocprof interface deprecation warning appearing twice
2025-07-24 11:50:07 -04:00
vedithal-amd d4c316a730 Improve baseline comparison (#817)
* Do not force unsupported metrics to be specified in older gpu
  architectures as None

* Remove metrics which are explicitly set to None

* Update CHANGELOG

* Fix analysis configuration to fix baseline comparisons across all gpu
  architectures
    * Add missing 1812 section for gfx908
    * Add missing 1812 section for gfx90a

* Baseline comparision will only show common metrics
   * First workload will be used to set Metric ID index column
2025-07-24 11:49:02 -04:00
Fei Zheng 137f35e700 Fix L2 read/write/atomic bandwidths on MI350 (#831) 2025-07-23 15:46:19 -06:00
vedithal-amd a70ae40ddc Improve block filtering to accept metric ids (#821)
* Fix tests
* Update CHANGELOG and documentation
2025-07-23 16:16:29 -04:00
cfallows-amd 2a7bbc4cc2 Update standalone roofline intro (#830) 2025-07-23 15:17:00 -04:00
vedithal-amd 068e5aaef4 Fix tests and formatting (#826) 2025-07-22 17:49:16 -04:00
vedithal-amd e132b047cd Standalone GUI bugfix (#825)
* Fix barchart elements table ids

* Add HBM bandwidth section to L2 cache report for gfx950

* bugfix for standlone GUI

Co-authored-by: Felix Marty <Felix.Marty@amd.com>
2025-07-22 15:31:54 -04:00
vedithal-amd 0fdd186dd5 Fix memory clock detection with amd-smi (#824) 2025-07-22 13:46:06 -04:00
vedithal-amd c4d129def5 fix build (#823) 2025-07-22 13:02:14 -04:00
vedithal-amd 98bb0f4237 Remove hardware IP block based filtering (#820)
* Analysis report block based filtering is the default now

* Update documentation

* Update CHANGELOG

* Fix tests
    * Replace hardware block based filtering tests with report block
      based filtering tests
2025-07-21 09:37:35 -04:00
vedithal-amd 537a269e95 Remove MI50/MI60 gfx906 support per documentation (#819) 2025-07-18 09:57:33 -04:00
vstojilj d2cec00116 Add missing <cassert> include (#800)
Co-authored-by: Anusha GodavarthySurya <Anusha.GodavarthySurya@amd.com>
2025-07-16 13:54:39 -04:00
Pratik Basyal 24c27462d7 Minor editorial changes data type selection feature (#816) 2025-07-16 12:39:24 -04:00
Pratik Basyal 8099fd352e Architecture data support and diagrams added (#814)
* Architeture data support and diagrams added

* Architecture image added

* CDNA4 Image updated

* Review feedback incorporated

* CDNA 4 partition mode added

* Fei review feedback incorporated
2025-07-16 10:40:11 -04:00
vedithal-amd ccb34e8a91 Fix docker testing instructions (#813) 2025-07-15 17:06:22 -04:00
cfallows-amd 10c696521d Update workflows for building (#812)
* Update workflows for building testing in pipeline: rhel8 now tests rhel8 and 9, and for both rhel and ubuntu files we are using the same image as rocprofiler-systems which is consistently updated on docker hub.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-15 15:12:21 -04:00
cfallows-amd 1d834f4190 Fix roofline block print during CLI output (#811)
Fix roofline panel in CLI analyze stage when using --block option. Improve roofline CLI output checks and logs.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-15 12:42:27 -04:00
xuchen-amd bfb2dc0795 Update TUI docs. (#796) 2025-07-15 11:13:24 -04:00
Fei Zheng e1da9355c2 Update peak flops for MI350 (#810) 2025-07-15 08:46:13 -06:00
xuchen-amd b4b50502e3 Remove rocm-smi for ROCm 7.1 (#809) 2025-07-15 10:28:53 -04:00
Fei Zheng 5b8d12fde2 Update cli doc description (#804) 2025-07-14 13:05:01 -06:00
Fei Zheng 78c1898ba0 Update PC sampling doc (#798) 2025-07-14 13:04:14 -06:00
xuchen-amd a3dc98e251 rocm-smi deprecation warning (#806) 2025-07-14 13:35:47 -04:00
Pratik Basyal 81d95d8e4a roofline footnote updated (#808) 2025-07-14 13:27:43 -04:00
xuchen-amd 23664c72f7 tui user experience improvement (#805) 2025-07-11 16:51:55 -04:00
vedithal-amd 000fd4f5b2 Fix roofline and TUI bugs (#803)
* Fix roofline rocm version bug
* Fix utils bug
* Remove unnecessary tests
* Do not check textual-fspicker package in cmake build
* Use rocprofv3 to test MI 100 and fix tests
2025-07-09 19:15:46 -04:00
xuchen-amd 8585cd8e8f Generalize config path. (#802)
* Generalize config path.

* Fix format.

* Fix typo.
2025-07-09 18:57:21 -04:00
vedithal-amd c51b9d16c3 Fix util tests (#797)
* Fix profile tests
* Update known issue for corrupted memory chart
2025-07-08 17:15:09 -04:00
cfallows-amd 3df0d1dded Update roofline bins for rocm7 changes (#755)
* Update current bins to have rocm6 suffix. Add new rocm7 bins, built on rocm7.0 latest due to hip updates.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Re-add rocm version check for roof bins.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Rebuild roofline binaries on top of latest rocm7 (#16379) after recent mainline promotions.
Adjusting version and distro combinations of bins following rocm6 vs rocm 7 supported OS.
*rhel8 not supported on rocm7, also not built anymore
*sles15 not supported on rocm7 but is still being built
*ubuntu stays as 22.04 and above for rocm7

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Minor fixes after testing.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Fixed bad copy after finding it in testing ctest.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Remove runpath from new bin

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Rework target_binary map return in detect_roofline- we should not be returning maps of different sizes or with different keys for the same method. Expected output should be consistent in case we run into bad position, or for testing purposes. Manually tested all possible roofline bin expected cases to comfirm functionality and expected user output.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Update changelog with new roofline distro minimums

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-08 16:51:50 -04:00
xuchen-amd 60a50e681b Add tui cmake install. (#794) 2025-07-08 11:18:26 -04:00
Fei Zheng 1b7445faa4 PC Sampling: fix potential_end_offset (#792)
* fix potential_end_offset

* format code: unrelated
2025-07-08 08:52:01 -04:00
Fei Zheng 239e6550f4 format with isort (#793) 2025-07-08 08:51:20 -04:00
fxmarty-amd c58ee9e73b fix normalization (#789) 2025-07-08 08:50:41 -04:00
cfallows-amd 61a9381edf Adjust csv output list for test_block_SPI for MI350 (#785)
Adjusting expected output list for test_block_SPI for MI350 series products.
Run formatter.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-03 01:58:11 -04:00
jamessiddeley-amd a6463f5e98 additional-code-coverage-compute (#763)
* added additional functions to test_utils.py

* added code coverage for db_connector.py

* Update test_profile_general.py

Added additional roofline test cases

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* updated coverage mi_gpu_spec.py 73% -> 94%

* added parser.py coverage

* removed redundant comments

* added test_utils and test_db_connector

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
2025-07-02 13:29:10 -04:00
cfallows-amd a59b1ea6e6 Fix method return for python version compatibility (#784)
Support for python3.8 and above means union defined in one of the methods was throwing errors for anything less than python3.10. Swapping out | operand for Optional[] resolves errors on systems using <3.10. No functional changes.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-02 10:36:37 -04:00
vedithal-amd 894046f283 Fix rocprofiler sdk list counters (#765) 2025-07-02 09:41:51 -04:00
xuchen-amd 222dbdc6bd Remove cell backgrouund colors. (#778) 2025-06-28 10:38:28 -04:00
jamessiddeley-amd 1bb7bf4dd4 added 0400 analysis config yaml files (#779) 2025-06-27 16:21:19 -04:00
vedithal-amd 6e1bbb5efb Fix SPI block counter limit (#780)
* Fix SPI counter collection limit

* Update counter collection limits from aqlprofile

* Remove special handling for MI 350 SPI pipe counters
2025-06-27 14:07:56 -04:00
Fei Zheng f5bc717fe1 Documentation update for FP8 on MI300 (#766) 2025-06-26 13:35:36 -06:00
vedithal-amd a95a45d69a Add support for MI 100 with rocprofiler-sdk (#768)
* Add custom rocprofiler-sdk counter definitions file for MI 100

* Update CHANGELOG to mention that accumulation counters will not be
  collected when profiling on MI 100 using rocprofiler-sdk/rocprofv3

* Migrate accum_counters.yaml to code
2025-06-26 09:03:18 -04:00
David Galiffi 1903e8e748 Provide a version for RPM Obsoletes attribute (#670)
Fix RPM generation warning
2025-06-25 12:36:47 -04:00
Kunal Malviya 661de1d483 Adding verbose and changing threads (#771)
Co-authored-by: rocm <rocm@rocm-System-Kunal.amd.com>
2025-06-25 18:49:46 +05:30
cfallows-amd 630bc149ff Add roofline PDF output to general profiling runs (#774)
Change when Roofline PDFs are generated- during general profiling and --roof-only profiling (skip only when --no-roof option is present)

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-06-25 01:19:28 -04:00
dependabot[bot] 181e4f44c7 Bump rocm-docs-core from 1.18.2 to 1.21.1 in /docs/sphinx (#775)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.18.2 to 1.21.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.2...v1.21.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-version: 1.21.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-24 21:04:16 -04:00
xuchen-amd 74e9853f8e Fix system sol units, remove units if None value. (#773)
* Fix system sol units.
2025-06-24 16:37:55 -04:00
xuchen-amd 92ce4732bc GUI: prevent big number overflow (#772)
* Prevent number overflow by formatting values.

* Improve value formatting logic based on comments.
2025-06-24 16:27:06 -04:00