5a3556ca85
update copyright years to 2025
...
revert shared_mutex.h
[ROCm/rocm_smi_lib commit: a156bfa4ae
2025-06-03 17:16:54 -05:00
a156bfa4ae
update copyright years to 2025
...
revert shared_mutex.h
2025-06-03 17:16:54 -05:00
148400af45
update license year to 2025
...
[ROCm/rocm_smi_lib commit: b0831d79cf
2025-06-03 17:16:54 -05:00
b0831d79cf
update license year to 2025
2025-06-03 17:16:54 -05:00
f62fdb7380
SWDEV-526022-[catch2][dtest]-Functional and Negative tests for hipLaunchKernelExC, hipLaunchKernelEx and hipDrvLaunchKernelEx APIs ( #156 )
...
* Fntl tests of hipLaunchKernelExC, hipLaunchKernelEx and hipDrvLaunchKernelEx APIs
* Fixed the test failures on windows
[ROCm/hip-tests commit: 60b3aae3c0
2025-06-03 14:37:25 +05:30
60b3aae3c0
SWDEV-526022-[catch2][dtest]-Functional and Negative tests for hipLaunchKernelExC, hipLaunchKernelEx and hipDrvLaunchKernelEx APIs ( #156 )
...
* Fntl tests of hipLaunchKernelExC, hipLaunchKernelEx and hipDrvLaunchKernelEx APIs
* Fixed the test failures on windows
2025-06-03 14:37:25 +05:30
415ba0773b
Add HIP_vector_base constructor ( #456 )
...
Change-Id: I57571f6bf9876d3a9ff312b952858527ec6abc7b
[ROCm/clr commit: c2f6c98006
2025-06-03 12:23:38 +05:30
c2f6c98006
Add HIP_vector_base constructor ( #456 )
...
Change-Id: I57571f6bf9876d3a9ff312b952858527ec6abc7b
2025-06-03 12:23:38 +05:30
1586e74e76
SWDEV-123456 - handle checkboxes with spaces ( #464 )
...
[ROCm/clr commit: de27ba3f02
2025-06-03 08:38:54 +02:00
de27ba3f02
SWDEV-123456 - handle checkboxes with spaces ( #464 )
2025-06-03 08:38:54 +02:00
cc7ccf507a
[SWDEV-535739] Align RDC with amdsmi 26.0 ( #191 )
...
* Align RDC with amdsmi 26.0.0
* Remove RDCI_IOLINK_TYPE_NUMIOLINKTYPES
---------
Signed-off-by: adapryor <Adam.pryor@amd.com >
Change-Id: Ib7f2a22bd9544e0bf74afb1ed8d8f8b79b129b1a
2025-06-02 18:27:19 -05:00
151b0301f1
[SWDEV-535739] Align RDC with amdsmi 26.0 ( #191 )
...
* Align RDC with amdsmi 26.0.0
* Remove RDCI_IOLINK_TYPE_NUMIOLINKTYPES
---------
Signed-off-by: adapryor <Adam.pryor@amd.com >
Change-Id: Ib7f2a22bd9544e0bf74afb1ed8d8f8b79b129b1a
[ROCm/rdc commit: cc7ccf507a
2025-06-02 18:27:19 -05:00
16e31aae65
Bump AMD-SMI Version
...
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com >
Change-Id: I2707585cbe49f8b14f18c679080293bc05a151bd
2025-06-02 18:23:43 -05:00
5bf0d39a23
Bump AMD-SMI Version
...
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com >
Change-Id: I2707585cbe49f8b14f18c679080293bc05a151bd
[ROCm/rdc commit: 16e31aae65
2025-06-02 18:23:43 -05:00
a4208bbd94
Fix compilation failure in amd-smi 26.0.0 ( #223 )
...
- The parameter "year" was removed from amdsmi_version_t.
- For SWDEV-535858, SWDEV-535870
[ROCm/rocprofiler-systems commit: 650827c5ea
2025-06-02 18:22:13 -04:00
650827c5ea
Fix compilation failure in amd-smi 26.0.0 ( #223 )
...
- The parameter "year" was removed from amdsmi_version_t.
- For SWDEV-535858, SWDEV-535870
2025-06-02 18:22:13 -04:00
0e9c3b2c4f
[SWDEV-243250] RDC Process Start/Stop integration ( #189 )
...
Change-Id: I3d2be33b5d23cd259b3d06fb572f81d19e6c3798
Signed-off-by: adapryor <Adam.pryor@amd.com >
2025-06-02 14:42:21 -05:00
ec661d5d17
[SWDEV-243250] RDC Process Start/Stop integration ( #189 )
...
Change-Id: I3d2be33b5d23cd259b3d06fb572f81d19e6c3798
Signed-off-by: adapryor <Adam.pryor@amd.com >
[ROCm/rdc commit: 0e9c3b2c4f
2025-06-02 14:42:21 -05:00
ae6b1aa6e6
Bump rocm-docs-core[api-reference] from 1.18.1 to 1.20.0 in /docs/sphinx
...
Bumps [rocm-docs-core[api-reference]](https://github.com/ROCm/rocm-docs-core ) from 1.18.1 to 1.20.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases )
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.1...v1.20.0 )
---
updated-dependencies:
- dependency-name: rocm-docs-core[api-reference]
dependency-version: 1.20.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-06-02 13:33:21 -05:00
30397e77f3
Bump rocm-docs-core[api-reference] from 1.18.1 to 1.20.0 in /docs/sphinx
...
Bumps [rocm-docs-core[api-reference]](https://github.com/ROCm/rocm-docs-core ) from 1.18.1 to 1.20.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases )
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.1...v1.20.0 )
---
updated-dependencies:
- dependency-name: rocm-docs-core[api-reference]
dependency-version: 1.20.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
[ROCm/rdc commit: ae6b1aa6e6
2025-06-02 13:33:21 -05:00
44827ba976
"How-to" document describing VCN and JPEG metrics and tracing ( #186 )
...
- Create a document to describe enabling VCN and JPEG related metrics
and tracing
- Upload images and modify indexes.
[ROCm/rocprofiler-systems commit: 13f315a65d
2025-06-02 13:31:18 -04:00
13f315a65d
"How-to" document describing VCN and JPEG metrics and tracing ( #186 )
...
- Create a document to describe enabling VCN and JPEG related metrics
and tracing
- Upload images and modify indexes.
2025-06-02 13:31:18 -04:00
1539c16ee8
SWDEV-535184 - Fix to switch HIP_RUNTIME_API_TABLE_STEP_VERSION 9 and 10 ( #448 )
...
[ROCm/clr commit: 54a2e943d7
2025-06-02 21:24:40 +05:30
54a2e943d7
SWDEV-535184 - Fix to switch HIP_RUNTIME_API_TABLE_STEP_VERSION 9 and 10 ( #448 )
2025-06-02 21:24:40 +05:30
f6c8cbd293
rocr: Fix inefficient copy operations
...
Refactor variable assignments to use std::move() where appropriate.
Updat function headers to accept parameters by const& where appropriate.
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com >
2025-06-02 11:18:36 -04:00
6de1c81b71
rocr: Fix inefficient copy operations
...
Refactor variable assignments to use std::move() where appropriate.
Updat function headers to accept parameters by const& where appropriate.
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com >
[ROCm/ROCR-Runtime commit: f6c8cbd293
2025-06-02 11:18:36 -04:00
ae6851dbb4
rocr: Fixed inefficient copy operations
...
Changed variable assignments to use std::move() where appropriate.
Changed function headers to pass string arguments by reference where appropriate.
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com >
2025-06-02 11:18:36 -04:00
65f5ce6f0a
rocr: Fixed inefficient copy operations
...
Changed variable assignments to use std::move() where appropriate.
Changed function headers to pass string arguments by reference where appropriate.
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com >
[ROCm/ROCR-Runtime commit: ae6851dbb4
2025-06-02 11:18:36 -04:00
a945b5d493
rocr: Fixed inefficient copy operations
...
Changed variable assignments to use std::move() where appropriate.
Revert change in amd_kfd_driver.cpp.
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com >
2025-06-02 11:18:36 -04:00
b97f9ba6d5
rocr: Fixed inefficient copy operations
...
Changed variable assignments to use std::move() where appropriate.
Revert change in amd_kfd_driver.cpp.
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com >
[ROCm/ROCR-Runtime commit: a945b5d493
2025-06-02 11:18:36 -04:00
369d89ade3
rocr: Fixed inefficient copy operations
...
Changed variable assignments to use std::move() where appropriate
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com >
2025-06-02 11:18:36 -04:00
88dd451c64
rocr: Fixed inefficient copy operations
...
Changed variable assignments to use std::move() where appropriate
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com >
[ROCm/ROCR-Runtime commit: 369d89ade3
2025-06-02 11:18:36 -04:00
ed5a6441a9
Update docs 2025 04 14 ( #54 )
...
* Update docs 2025 03 31
- Docs: remove virtual_rocr.rst
- Fix documentation warnings
- Reformat HIP RTC
- Docs: Refactor HIP porting guide
- Docs: Expand HIP porting guide and CUDA driver porting guide
- Minor fix
- Docs: Update environment variables file
- Bump rocm-docs-core[api_reference] from 1.15.0 to 1.17.0 in /docs/sphinx
- Docs: Update FP8 page to show both FP8 and FP16 types
- Bump sphinxcontrib-doxylink from 1.12.4 to 1.13.0 in /docs/sphinx
- Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core ) from 1.17.0 to 1.17.1.
- Remove external link
- Update programming model
- Bump rocm-docs-core[api_reference] from 1.17.1 to 1.18.1 in /docs/sphinx
- Docs: Add page for Complex Math API
- Docs: Add page about HIP error codes
- Update docs: the compilation cache is enabled by default
- Fix fns32 function mask type in doc
* Bump rocm-docs-core[api_reference] from 1.18.1 to 1.18.2 in /docs/sphinx
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core ) from 1.18.1 to 1.18.2.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases )
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.1...v1.18.2 )
---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
dependency-version: 1.18.2
dependency-type: direct:production
update-type: version-update:semver-patch
* Fix readme link
* Docs: Fix verbose paths generated by doxygen
* Handle git ssh in docs conf.py
[ROCm/hip commit: d0cf32a63a
2025-06-02 20:40:41 +05:30
d0cf32a63a
Update docs 2025 04 14 ( #54 )
...
* Update docs 2025 03 31
- Docs: remove virtual_rocr.rst
- Fix documentation warnings
- Reformat HIP RTC
- Docs: Refactor HIP porting guide
- Docs: Expand HIP porting guide and CUDA driver porting guide
- Minor fix
- Docs: Update environment variables file
- Bump rocm-docs-core[api_reference] from 1.15.0 to 1.17.0 in /docs/sphinx
- Docs: Update FP8 page to show both FP8 and FP16 types
- Bump sphinxcontrib-doxylink from 1.12.4 to 1.13.0 in /docs/sphinx
- Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core ) from 1.17.0 to 1.17.1.
- Remove external link
- Update programming model
- Bump rocm-docs-core[api_reference] from 1.17.1 to 1.18.1 in /docs/sphinx
- Docs: Add page for Complex Math API
- Docs: Add page about HIP error codes
- Update docs: the compilation cache is enabled by default
- Fix fns32 function mask type in doc
* Bump rocm-docs-core[api_reference] from 1.18.1 to 1.18.2 in /docs/sphinx
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core ) from 1.18.1 to 1.18.2.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases )
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.1...v1.18.2 )
---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
dependency-version: 1.18.2
dependency-type: direct:production
update-type: version-update:semver-patch
* Fix readme link
* Docs: Fix verbose paths generated by doxygen
* Handle git ssh in docs conf.py
2025-06-02 20:40:41 +05:30
cb73b09ce1
SWDEV-535738 - Use __hip_internal instead of std namespace for device code. ( #455 )
...
[ROCm/clr commit: a018d4278a
2025-06-02 20:09:17 +05:30
a018d4278a
SWDEV-535738 - Use __hip_internal instead of std namespace for device code. ( #455 )
2025-06-02 20:09:17 +05:30
3c64dc9c22
Bump rocm-docs-core[api_reference] from 1.19.1 to 1.20.0 in /docs/sphinx ( #222 )
...
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core ) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases )
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.19.1...v1.20.0 )
---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
dependency-version: 1.20.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[ROCm/rocprofiler-systems commit: 7ff2de2591
2025-06-02 09:47:38 -04:00
7ff2de2591
Bump rocm-docs-core[api_reference] from 1.19.1 to 1.20.0 in /docs/sphinx ( #222 )
...
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core ) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases )
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.19.1...v1.20.0 )
---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
dependency-version: 1.20.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-02 09:47:38 -04:00
701bbf5126
Lintian Warnings Fixes, Enhancements ( #25 )
...
* Add Lintian Warnings Fixes
* Update Review Comments, Warning Fixes
[ROCm/rocm-core commit: f774bf6276
2025-06-01 18:48:30 -04:00
f774bf6276
Lintian Warnings Fixes, Enhancements ( #25 )
...
* Add Lintian Warnings Fixes
* Update Review Comments, Warning Fixes
2025-06-01 18:48:30 -04:00
bb80373649
[CI] Adding Navi4 & Mi300X ( #361 )
...
* Adding Navi4 & Mi300X
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
[ROCm/rocprofiler-sdk commit: c71d20750e
2025-05-30 17:18:07 -05:00
c71d20750e
[CI] Adding Navi4 & Mi300X ( #361 )
...
* Adding Navi4 & Mi300X
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
* Update continuous_integration.yml
2025-05-30 17:18:07 -05:00
a85fb8f456
add binary link ( #427 )
...
* add binary link
* Update source/docs/how-to/using-thread-trace.rst
---------
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
[ROCm/rocprofiler-sdk commit: 7411640761
2025-05-30 11:52:31 -05:00
7411640761
add binary link ( #427 )
...
* add binary link
* Update source/docs/how-to/using-thread-trace.rst
---------
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
2025-05-30 11:52:31 -05:00
af98f5163b
Adding Thread Trace API reference ( #417 )
...
* Adding Thread Trace API reference
* Doc fixes
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/_toc.yml.in
Co-authored-by: Baraldi, Giovanni <Giovanni.Baraldi@amd.com >
* Apply suggestions from code review
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
* Update source/docs/index.rst
* Apply suggestions from code review
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
* Apply suggestions from code review
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
* Apply suggestions from code review
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
* Update source/docs/api-reference/thread_trace.rst
* Apply suggestions from code review
Co-authored-by: Paoletti, Leo <Leo.Paoletti@amd.com >
* Update source/docs/_toc.yml.in
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
---------
Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com >
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
Co-authored-by: Paoletti, Leo <Leo.Paoletti@amd.com >
Co-authored-by: Xu, Alex <Alex.Xu@amd.com >
[ROCm/rocprofiler-sdk commit: eedfecd905
2025-05-30 11:51:46 -05:00
eedfecd905
Adding Thread Trace API reference ( #417 )
...
* Adding Thread Trace API reference
* Doc fixes
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/_toc.yml.in
Co-authored-by: Baraldi, Giovanni <Giovanni.Baraldi@amd.com >
* Apply suggestions from code review
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
* Update source/docs/index.rst
* Apply suggestions from code review
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
* Apply suggestions from code review
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
* Apply suggestions from code review
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
* Update source/docs/api-reference/thread_trace.rst
* Apply suggestions from code review
Co-authored-by: Paoletti, Leo <Leo.Paoletti@amd.com >
* Update source/docs/_toc.yml.in
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
* Update source/docs/api-reference/thread_trace.rst
---------
Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com >
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com >
Co-authored-by: Paoletti, Leo <Leo.Paoletti@amd.com >
Co-authored-by: Xu, Alex <Alex.Xu@amd.com >
2025-05-30 11:51:46 -05:00
b97d17942b
Bump rocm-docs-core[api_reference] from 1.19.0 to 1.19.1 in /docs/sphinx ( #219 )
...
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core ) from 1.19.0 to 1.19.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases )
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.19.0...v1.19.1 )
---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
dependency-version: 1.19.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[ROCm/rocprofiler-systems commit: 2afe8b68ea
2025-05-30 09:32:01 -04:00
2afe8b68ea
Bump rocm-docs-core[api_reference] from 1.19.0 to 1.19.1 in /docs/sphinx ( #219 )
...
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core ) from 1.19.0 to 1.19.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases )
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.19.0...v1.19.1 )
---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
dependency-version: 1.19.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-30 09:32:01 -04:00
293092f32f
rocr: Fix Resource Leak
...
allocated memory was previously not freed in the event of an error
with rwlock initialization.
Signed-off-by: Sunday Clement <Sunday.Clement@amd.com >
2025-05-30 09:16:26 -04:00
3d3cca8083
rocr: Fix Resource Leak
...
allocated memory was previously not freed in the event of an error
with rwlock initialization.
Signed-off-by: Sunday Clement <Sunday.Clement@amd.com >
[ROCm/ROCR-Runtime commit: 293092f32f
2025-05-30 09:16:26 -04:00
Peter Park
Gollamandala, Srinivasarao
Belton-Schure, Aidan
Lytovchenko, Danylo
Pryor, Adam
Maisam Arif
David Galiffi
dependabot[bot]
Sajina PK
Xie, Jiabao(Jimbo)
Alysa Liu
Kiss, Istvan
Patel, Jaydeepkumar
Cheruvally, Aravindan
Elwazir, Ammar
Kumar, Amit
Baraldi, Giovanni
Sunday Clement