Commit Graph

1791 Commits

Author SHA1 Message Date
Saleel Kudchadker 60b9dc4a45 SWDEV-301667 - Better log
Change-Id: I3b5b3593cb0144e56a4ddea2fa29028544a73203


[ROCm/clr commit: b2240bcda5]
2023-06-20 14:26:44 -04:00
Jaydeep Patel de6662f1b7 SWDEV-403768 - Check mem type is managed and result mem addresses are not null.
Change-Id: Ib40c468a981e0dd42b2da65aeb7543b11af4bc90


[ROCm/clr commit: a6e72de83d]
2023-06-16 08:49:21 -04:00
Jaydeep Patel 600ad0e9dc SWDEV-403770 - Add validations.
Change-Id: If36202ba9777d2a0d6f8ee92982dbff92bafe81a


[ROCm/clr commit: 0a20da39cd]
2023-06-16 02:37:25 -04:00
sdashmiz 2216908962 SWDEV-403638 - Fix warnings
- disable deprecated function use warning
- disalbe size_t to .type' warning
- disable conversion from 'type1' to 'type2' warning

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I64161fd37cf56de3d132102103267ae8da40193a


[ROCm/clr commit: 38a67df312]
2023-06-15 12:17:22 -04:00
sdashmiz 2e960fae8f SWDEV-403063 - Clean up hip graph
- Replace dynamic allocation with embedded struct in hip graph

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Idfe3f7393fa50d6e510d4c88f779408f96d3accb


[ROCm/clr commit: cc85289739]
2023-06-15 12:17:09 -04:00
German af5944dc71 SWDEV-311270 - Add IPC support for memory pools
Initial implementation for hipMemPoolExportToShareableHandle,
hipMemPoolImportFromShareableHandle,
hipMemPoolExportPointer and hipMemPoolImportPointer

Change-Id: I0ebdc48e9163b394ded560adca6c38bbc5aee7d1


[ROCm/clr commit: 1a0c3e4dc4]
2023-06-15 11:36:52 -04:00
Maneesh Gupta 0be27c38f8 SWDEV-397358 - Revert "Return hipErrorNotSupported for unsupported APIs"
This reverts commit 32a73102ea.

Change-Id: Idb18e1ce6bcfc1da144fabf1ba01329f4f6604a5
(cherry picked from commit 5c38999efe11243dcdd8cc5244172e6840c47492)


[ROCm/clr commit: 68238c99d2]
2023-06-05 04:55:33 -04:00
Jaydeep Patel 911002f262 SWDEV-403762 - Fill pciBusId even if len <=12.
Change-Id: Iaf1b3314f4ae5597d42d54eb4c977667ecbb9cfb


[ROCm/clr commit: 0064fac887]
2023-06-02 10:47:21 +00:00
Anusha GodavarthySurya 729779a3b3 SWDEV-399098 - Change hip_init lock to use std::call_once
Updating hip_init lock to use std::call_once fixed Performance
drops in TF benchmarks for FP16

Change-Id: Ib1125ac66806b232057ba183e296ea4d0642d08d


[ROCm/clr commit: 2f83719d12]
2023-06-01 02:04:29 -04:00
Jacob Lambert 911dbabdff SWDEV-380857 - Remove space in "Linker Program" used to set Comgr object name
Not a required change, but it does make dealing with temporary files generated
by Comgr easier.

Change-Id: I9c43138dd2a6c4fea965b57fbce7a087ab2bbd28


[ROCm/clr commit: 1171518b97]
2023-05-30 13:47:26 -04:00
sdashmiz 9a3d3aef8c SWDEV-360031 - Event record clean up
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ic7b5edd501c5f61b2bce87252ac040cbc4083006


[ROCm/clr commit: 1e9dfdfe99]
2023-05-29 11:42:16 -04:00
Jacob Lambert 2d9db8a102 SWDEV-371628 - Remove now-redundant Comgr devlib call from hipRTC
Because hipRTC is now using the newer
AMD_COMGR_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC, and now that this
action has been fixed for HIP compilations in Comgr, hipRTC no
longer needs separate Comgr call to link in the device libs.

Change-Id: Ibf9024cbaaab825584566e8d0b5fce60d7063dd8


[ROCm/clr commit: 283dd8352d]
2023-05-23 18:34:59 -04:00
Jaydeep Patel 0a6fe33ab7 SWDEV-401231 - getMemoryObject returns nullptr for host system memory as arena is disabled for XNACK.
Change-Id: I84348e0ba2debf69f65c0e85179dad7827d30806


[ROCm/clr commit: b07a44c253]
2023-05-23 09:51:08 -04:00
Ioannis Assiouras fce1d56110 SWDEV-401495 - Removed hip_hcc.def.in
Change-Id: Ia84503f0b9582f32de819f4ff95630fb024cd613


[ROCm/clr commit: 9d06e8c2d3]
2023-05-19 11:47:07 +01:00
sdashmiz a88c64f86d SWDEV-367877 - Detect cycle in graph
- detect cycle when graph is instantiated

- remove level calculation from add/remove node

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I3f7432f91f70aec8e4fd866b2766256f8a9a0cfe

graph-cycle-corrections

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I8a3cec9a5a503aac6ea1e85ff3dd2b972790fb1d


[ROCm/clr commit: 8578da8a3d]
2023-05-18 09:44:39 -04:00
Jaydeep Patel f7c3760996 SWDEV-389199 - Add GL Memory object to memory map so that it is acknowledged by getMemoryObject.
Change-Id: Ia58bc30ba8be016c1f004f6af01dd767f45f7905


[ROCm/clr commit: 97dc73f581]
2023-05-18 01:10:33 -04:00
pghafari 9eda493469 SWDEV-399734, SWDEV-399733 - update maxGridDim for y and z
Change-Id: Id5b1dd2491798dd20a0672362f445ab4de164f6d


[ROCm/clr commit: fb82b292c2]
2023-05-17 19:03:04 -04:00
Satyanvesh Dittakavi 82e044cb6a SWDEV-399851 - Add template overload for ToString in HIPRTC
HIPRTC_INIT_API can have nullptr in the arguments and ClPrint
can crash while printing

Change-Id: Iecade5c3867196509c8cc0647b9aa24be0960a02


[ROCm/clr commit: c98fad1edc]
2023-05-16 14:21:19 +00:00
Jatin Chaudhary 9e5b96d567 SWDEV-384013 - Print link options being passed to compiler with AMD_LOG_LEVEL
Change-Id: I556ed434587cff07a634796da51dcbb9ae78ef21


[ROCm/clr commit: 8753db5446]
2023-05-15 15:52:04 -04:00
Jaydeep Patel cb3642e26e SWDEV-398047 - Disable arena for XNACK.
Change-Id: If6c98490bd5b8146a357f45ed132f687def0877f


[ROCm/clr commit: ffa1deef27]
2023-05-10 23:28:05 -04:00
Jacob Lambert c22413efba SWDEV-380857 - Fix bug when reading bitcode file into vector<char> buffer
The previous implementation using std::copy() resulted in
differences between the in-memory and on-disk representations.
With the updated implementation, we get the same contents.

Change-Id: Iadfae3cd7f7ba99538da2ac4f11f30f5a78260d8


[ROCm/clr commit: b17056cb93]
2023-05-08 16:25:01 -04:00
German 8d97827417 SWDEV-353281 - VM support in mempool for graphs
The change enables VM support in graphs on Windows. That allows
to avoid caching of all allocations at the cost of map/unmap
overhead during memory create/destroy.

Change-Id: I792be00fba099e5e5d3cd44a963e1dfd6976a86d


[ROCm/clr commit: 04b696abee]
2023-05-05 15:31:26 -04:00
kjayapra-amd 23584feba4 SWDEV-393910 - Port gfx94x changes to mainline.
Change-Id: Ibf727223bbe5230b132b47c39e0fc1d87cbd3b9c


[ROCm/clr commit: f14e8a2dba]
2023-05-05 15:16:23 -04:00
Ioannis Assiouras 7adb0089c6 SWDEV-397356: Move HIP_API_PRINT after HIP_INIT so that the begin function call gets printed
Change-Id: I99b655596741c19bc483647794ae8b4f6e6f2843


[ROCm/clr commit: d88f0358b0]
2023-05-04 18:46:21 -04:00
Ioannis Assiouras 145506e067 SWDEV-398511 - Removed hiprtc_internal.hpp
Change-Id: Ic0751dfeb4936b3e233b44e34d16e0a1605874d7


[ROCm/clr commit: 29e0d2f335]
2023-05-04 16:50:18 +01:00
kjayapra-amd 69406243e2 SWDEV-378006 - Adding a new guarantee macro to support printing args.
Change-Id: I2083ddaf8058759bdace7d3bb1e8e3670cbeddd2


[ROCm/clr commit: 7f41a96ffb]
2023-05-03 12:43:16 -04:00
pghafari 505bce23be SWDEV-369567 - dimension check update
Change-Id: I31deb5070d4852db7dd6d37f9a514965f387698e


[ROCm/clr commit: 31b362bf6e]
2023-05-02 08:04:04 -04:00
Jatin Chaudhary 646af29dc5 SWDEV-1 - Fix incorrect SGPR usage in VGPR calculation. Pointed out by #58 issue on hipamd public repo
Change-Id: I8c27c0da254521714c92369990aa10f6fc09c246


[ROCm/clr commit: 54f73e430b]
2023-05-02 03:53:18 -04:00
sdashmiz ebcab6e910 SWDEV-360031 - Correct APIs behaviour
- correct error for hipStreamWaitEvent when event recorded before
  capture
- correct hipEventSync when event is synced during capture

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I7ecbed5621eaf323846d4ccb20ec112aaa8a5757


[ROCm/clr commit: 544318fffe]
2023-05-01 13:38:59 -04:00
Ajay 858a32a24a SWDEV-374386 - hipGraphAddMemcpyNode negative cases
validate 3d memcpy params -
pitch, extend - height/width/depth, src/dst offsets and total size

Change-Id: I629fc242264ebbc3e9dbfd9233da8d3a127500b4


[ROCm/clr commit: 22eae6ac9e]
2023-04-28 12:11:24 -04:00
German Andryeyev b2525dfb82 SWDEV-381627 - Move cl_vk_amd.hpp into rocclr
Rename VK interop to ExternalMemory object, since it should handle
DX interops also

Change-Id: I536ec46d3e53ece35234a2e29030393ad411b96d


[ROCm/clr commit: 3e5803c4c0]
2023-04-26 15:25:01 -04:00
Sourabh Betigeri 898340aaa9 SWDEV-392367 - Fixes hipMemGetAddressRange returning device buffer size as 0
Change-Id: I6b5640b544390b2dfc53fad271acc7f30240e274


[ROCm/clr commit: 7aba1cf4cd]
2023-04-25 13:46:52 -04:00
Jaydeep Patel 6b364523bd SWDEV-389647 - SWDEV-388950 - Check device id same while set params.
GraphMemcpyNodeSetParamsFrom/ToSymbol APIs neew to check device id for
original src/dst is same as what is passed in while set.

Change-Id: If0b610808223dce9115562bb5e9b31c8eaa2df22


[ROCm/clr commit: b6aa27d4a3]
2023-04-25 13:24:26 -04:00
German ca2d9bfbff SWDEV-353281 - Don't add the same stream into the list
Change-Id: I7f41de68b669dc759bdb11657dd897ad57e368fc


[ROCm/clr commit: 31697779bb]
2023-04-25 10:21:55 -04:00
pghafari 0ddd82a5f7 SWDEV-367145 - adding support for timeline semaphore
Change-Id: I654359b48abe8bbaac2def5118d3ad0bb05d9492


[ROCm/clr commit: afa15ddb89]
2023-04-25 10:02:43 -04:00
sdashmiz 8e2c75defb SWDEV-387508 - do not treat uuid as string
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I4de88330650eba4e4259686cdb5fb089b17aa8e4


[ROCm/clr commit: 261ce9837c]
2023-04-25 09:52:12 -04:00
Jaydeep Patel b373c0d221 SWDEV-390597 - Return No Device error for hipSetDevice and hipSetDeviceFlags.
Change-Id: I457b1197a8f1b71a8bbbdf09f193f643c61700b6


[ROCm/clr commit: 3dfe48b582]
2023-04-24 03:50:33 -04:00
Jaydeep Patel e404ad7bd8 SWDEV-389648 - Find node and then erase.
Change-Id: Iecf78fe6b0645e58b4de6658b59ad1285946b698


[ROCm/clr commit: 3c5888922e]
2023-04-19 01:05:58 -04:00
Jaydeep Patel 3bab75e327 SWDEV-389477 - Check D2D is intra device.
Change-Id: Ibef2a6de82a18357ef35bcd70298478de6b0e380


[ROCm/clr commit: 415fb15c76]
2023-04-19 01:01:12 -04:00
Jaydeep Patel 2536d245f6 SWDEV-388943,SWDEV-388954 - Corrected validations for memcpy kind.
Change-Id: I8338111ac46e4eba279d53969d12df3a23552049


[ROCm/clr commit: 2576153acd]
2023-04-19 01:00:50 -04:00
Jaydeep Patel e257db8ba7 SWDEV-388958 - SWDEV-388929 - Kind can be hipMemcpyDefault for H2D and D2D and srcMemory can be allocated using hipHostMalloc for H2D.
Change-Id: I187ff850ebb890b357ee03500105b71468508ea2


[ROCm/clr commit: 7215451db9]
2023-04-19 01:00:28 -04:00
Jaydeep Patel 97726d4215 SWDEV-391731 - Check thread local list too.
With global flag, In addition to global vector, we need to check
thread local vector too. If both of them are empty then only
return false.

Change-Id: I3a24d16a35c702b34b9a8867dc410ebd80108f25


[ROCm/clr commit: 09a081235c]
2023-04-19 01:00:09 -04:00
Jaydeep Patel 06bc6d9980 SWDEV-391178 - Extern monitor to avoid copy in multithreading.
Defining monitor in header cause copy and hence it's moved to cpp.

Change-Id: Ib07bbde2808d9cb2af9349076f777e8a5b28d210


[ROCm/clr commit: e8eb1772f2]
2023-04-19 00:58:49 -04:00
pghafari 82219d2fb1 SWDEV-366992 - adding handle type for vk interop
Change-Id: I79ee0d89b948c21b96709e9e607abe7901621a97


[ROCm/clr commit: 78de2ae692]
2023-04-18 16:59:25 -04:00
German Andryeyev a6f2ecd703 SWDEV-231145 - Add a validation for uniform launch
Change-Id: I68d61690c50060d9dcca117b248dddf69204a23f


[ROCm/clr commit: e82eecf33e]
2023-04-18 12:56:09 -04:00
German Andryeyev 237480711a SWDEV-382359 - Workaround a non-uniform launch in MIOpen
Change-Id: I0abff25fb20143225739e771c4d3bae5c2a054b9


[ROCm/clr commit: 73698479a9]
2023-04-18 11:36:10 -04:00
Satyanvesh Dittakavi 53dcdf2b46 SWDEV-393060 - Address directed tests build failures with CLR
Change-Id: I76b93ee073d21ec5fae0db5a129ada89f750855d


[ROCm/clr commit: a3104c60e1]
2023-04-14 03:53:51 -04:00
taosang2 769f1e166e SWDEV-390626 - Support surface Apis
Change-Id: I1691b82d597bfd722d562778f919ebf8ca530e90


[ROCm/clr commit: 53742adc08]
2023-04-05 16:38:04 +00:00
German 56dedad98b SWDEV-380703 - sync all streams individually
Avoid syncing blocking streams with the default stream,
since that introduces extra command dependencies and
doesn't allow to destroy memory after last submission

Change-Id: I618e9bd2091c4cf9157125612d8c4759030c5a80


[ROCm/clr commit: 1e88d2c52f]
2023-04-05 16:37:49 +00:00
Jaydeep Patel 235eb22491 SWDEV-390439 - SWDEV-387997 - Delete array.
Change-Id: Ica20b005f5db7f4ed65c5ebc51959392671fe320


[ROCm/clr commit: 0f975e6e93]
2023-04-05 16:37:39 +00:00