Commit Graph

4586 Commits

Author SHA1 Message Date
Sameer Sahasrabuddhe 3e7d08f5ee enable HCC printf when using hip-clang
This is cherry-picked from PR#1947 that was committed to the
github repo. It allows printf to work with hip-clang and HCC
runtime.

Change-Id: I754753250ea1e694cf3441722e2d4c9d25fa75bc


[ROCm/hip commit: 9a0c5d0653]
2020-03-28 00:18:21 -04:00
Saleel Kudchadker 35e9fa08be Merge "Check event status before notify" into amd-master-next
[ROCm/hip commit: 5a8add03a5]
2020-03-27 20:19:40 -04:00
Vladislav Sytchenko 511f2d03a2 (SWDEV-228794)
Adjust the origin of the copy if the user passes a pointer that wasn't allocated by the runtime.

Change-Id: I0aeb20195ed730857a461a53f537626ec2573fd1


[ROCm/hip commit: 6ed73f50f7]
2020-03-27 16:33:16 -04:00
Vladislav Sytchenko d3b9203359 (SWDEV-228794)
Add hipMallocHost()

Change-Id: Ia3c7c5ca94b39fe30f3a51d1b60782d3472259ff


[ROCm/hip commit: fd7a8f0367]
2020-03-27 15:57:48 -04:00
Vladislav Sytchenko 7a867cd98f (SWDEV-228782)
The only requirment from hipMallocPitch() is that the returned pitch is aligned to the HW image pitch alignment. There is no restriction on the size of the allocation, since the memory might not be used for images.

Change-Id: I97438e5fe4012ca4721b14b85f514dbac803c17c


[ROCm/hip commit: a91b82f00e]
2020-03-27 15:52:17 -04:00
Tao Sang aa94d9c654 Merge "Support hipFuncGetAttributes with hip-clang+Hcc RT" into amd-master-next
[ROCm/hip commit: af7d131749]
2020-03-27 14:36:41 -04:00
Saleel Kudchadker 573d676ef0 Check event status before notify
Change-Id: I68f6bbbf236e49b859be2d5afbe0c8282fe15dd3


[ROCm/hip commit: 178fc17846]
2020-03-27 11:32:46 -07:00
satyanveshd 3eea799a53 [dtests] Added few Negative tests (#1735)
[ROCm/hip commit: 351d39e6aa]
2020-03-27 14:10:12 +05:30
Siu Chi Chan e58a0d06f7 don't expose symbols from code_object_bundle (#1971)
Change-Id: I56479485aad42c3d517fe6d9055be1cd846eeb00

[ROCm/hip commit: 43abf84f54]
2020-03-27 14:09:07 +05:30
Sarbojit2019 1909e436cf Fix few memory leaks in HIP (#1969)
[ROCm/hip commit: f1b028b93e]
2020-03-27 14:08:30 +05:30
Jatin Chaudhary 32a9b2f2bb Packaging changes to bring them to sync with generated ones (#1918)
[ROCm/hip commit: 3805d7c5f2]
2020-03-27 14:08:12 +05:30
Tao Sang c20e13d1f0 Support hipFuncGetAttributes with hip-clang+Hcc RT
Fix issues of missing kernel function symbols and missing argument list via
using __hipRegister* functions.
Then the following tests can pass,
directed_tests/runtimeApi/module/hipFuncGetAttributes
directed_tests/runtimeApi/module/hipExtLaunchMultiKernelMultiDevice
directed_tests/gcc/LaunchKernel

Change-Id: I52135b61e8283eb4f9f10f77895151e4e55418d9


[ROCm/hip commit: d967be8eeb]
2020-03-26 23:28:35 -04:00
Saleel Kudchadker 89295ceafa OpenCL2.2 Header changes
Change-Id: I3285a8ffc7e34333feb68e925ebd460831c8e3d4


[ROCm/hip commit: a5fb06f4db]
2020-03-26 17:35:09 -07:00
Vladislav Sytchenko ec09381120 Add support for formating hipExtent objects
Change-Id: Iea54a510e81a856c0c450305b3e5a7179ee48295


[ROCm/hip commit: 2a2b9e47a0]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko 99b2084641 Enable initial sRGB support
Instead of using the sampler field force_degamma to perform sRGB->linear conversion during pixel sampling, we use an appropriate image format instead. The overhead of this is having to create an image view when creating a texture object from an array.

Change-Id: I1ca368c312c1fd4b6f784a3a1b35b5eeb28070ff


[ROCm/hip commit: 8ddeeb4551]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko c1b7b2276e Add initial entry points for mipmapped array API
Change-Id: Icd59cc7323ddcb6773da6105260415a1e6f4cdcb


[ROCm/hip commit: e0187ba405]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko b48bf1dc8c Handle offsets for dptr <-> image copies
Change-Id: I7a4a56ee07a26a741d2aac35502446d248f720ad


[ROCm/hip commit: faf3b83594]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko e149397f73 Replace hip::TextureObject with __hip_texture
This avoids the use of extra casts when obtaining a texture object handle.

Change-Id: I42df22bdad0ab9ac6c33cb8b282dee65fe7cfd6e


[ROCm/hip commit: c1475f948e]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko cbeaeeb249 Correctly format hipResourceDesc objects
The struct consists of a union - only the active object should be read.

Change-Id: I1c40965b61518acd91a2dcbae92a015ac9be346a


[ROCm/hip commit: fbe30090a2]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko 1ff602f312 Headers need to export C symbols for texture API
This also adds declarations of all the missing texture APIs.

hipTexRefSet*() functions need to take a textureReference as a ptr for type erasure to work. Runtime has been modified to accomodate this.

This change only applies to VDI.

Change-Id: Icf43cc5bd44dfc2c39084b7fe56d5a793bf7319f


[ROCm/hip commit: 2028b6eb29]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko ab94b954f9 Set textureObject to nullptr
This avoids dangling pointers for newly initiazlied textures

Change-Id: Ia444b91fe17fd756ed583ec595ae1febbdfbd034


[ROCm/hip commit: ced0582a52]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko fca3ce3008 Modify formatting for textureReferences
We don't program the numChannels and format members (these are HCC specific), so printing these will only display garbage.

Change-Id: I83dc8be9a3cae2659c64f4594d07c05330d2dd14


[ROCm/hip commit: 39558dc1b9]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko 462dcfe244 Correct typos in texture function declarations
Change-Id: I492995e984eda2e8a5e806c5d4c9c78da09ac483


[ROCm/hip commit: b09fe1280e]
2020-03-26 12:43:17 -04:00
Vladislav Sytchenko f8d11f2f30 Allow creating texture from unaligned user ptr
All we have to do is align the ptr to HW requirments an if it's not zero, then return the offset to the user.

We currently don't have anywhere to store this offset, so hipGetTextureAlignmentOffset() will still always return 0.

Change-Id: If31998127d99a2a3222a026d88249519d6102505


[ROCm/hip commit: ea701777d8]
2020-03-26 12:43:17 -04:00
Aryan Salmanpour b5f7402c62 [hip] fix a build error when building hip with latest hcc (#1977)
there is a build error when building HIP with latest HCC from GitHub after PR#1935 merged into HIP master branch. this PR changed blockDimX to blockDim and two lines missed this change where added in the current PR.

[ROCm/hip commit: c8ca2355ae]
2020-03-26 17:10:42 +05:30
Nick Curtis c06bdfca62 Update hip_debugging.md (#1973)
Fix link formatting

[ROCm/hip commit: bb72abca20]
2020-03-26 17:09:56 +05:30
Sarbojit2019 59cf17fb32 Fix for __usad issue (#1972)
Fixes #1930

[ROCm/hip commit: 5024f9057a]
2020-03-26 17:09:44 +05:30
Benjamin Sherman d9d1017168 Add const qualifiers to HIP_vector_type unary arithmetic operators (#1965)
Resolves issue #1960

[ROCm/hip commit: 3d38135ae2]
2020-03-26 17:09:00 +05:30
Siu Chi Chan 9e5f7e3a3c Initialize all undef symbols with a magic poison (#1962)
[ROCm/hip commit: 8fefda2bb9]
2020-03-26 17:06:09 +05:30
Sarbojit2019 9e98e69b7a Fix for segfault seen if invalid kind is passed to hipMemcpy (#1937)
Fixes SWDEV-224941

[ROCm/hip commit: 3e363047d5]
2020-03-26 17:04:43 +05:30
Jatin Chaudhary 26b7d3e2ee [dtest] Adding VectorTest (#1732)
Adding unit test for operations of device vector types

[ROCm/hip commit: ee5fa8977c]
2020-03-26 17:03:43 +05:30
Evgeny Mankov ecd7d5798c [HIPIFY][doc] Update README.md: LLVM 10.0.0 Release is supported
[ROCm/hip commit: 37873d1204]
2020-03-26 11:07:43 +03:00
Payam Ghafari 3a9576f1e2 Merge "updated cmake to create libamdhip64 static file as well" into amd-master-next
[ROCm/hip commit: 8e8b372726]
2020-03-26 01:10:12 -04:00
Paul Fultz II bbc1550bbb Fix path for hip-clang when using hipcc (#1961)
* Fix path for hip-clang when using hipcc

* Fix typo

* Update regex

[ROCm/hip commit: 855209abed]
2020-03-25 14:42:48 -07:00
Yaxun (Sam) Liu 069cca494a Add option --hipcc-func-supp for function support (#1957)
By default hipcc passes -mllvm options to let HIP-Clang inline all device functions.

--hipcc-func-supp enables function support and disables inline all.

--hipcc-no-func-supp disable function support and enables inline all.

This is a temporary solution to match HCC behavior for performance.

This option is mainly for debugging purpose.

Change-Id: I0c44ac1812bb3cea5c3e5b6e14ebaa45919236f6

[ROCm/hip commit: 3bef4e60ad]
2020-03-25 14:41:27 -07:00
Joseph Greathouse cb69c6037c Fix cooperative launch APIs to set hipGetLastError (#1935)
* Fix cooperative launch APIs to set hipGetLastError

Previously, the cooperative launch APIs did not properly log their
errors in the global hipGetLastError variable before returning back
to the user. As such, the APIs would leave hipSuccess in the
last error, which would break some use cases.

This fixes that problem by making a trampoline function that does
the HIP_INIT_API and ihipLogStatus.

* Add missing flag to the log of multi-GPU launch

[ROCm/hip commit: f61b79d9a3]
2020-03-25 14:39:24 -07:00
jujiang 910a8a5d1e SWDEV-226708-hipMemcpyPeerAsync failed-->Update test app to create stream on proper device
Change-Id: Ia9f51435ffb5a8fbbff39e363acecabb338bf34c


[ROCm/hip commit: 3774a1b106]
2020-03-25 17:22:56 -04:00
Payam 1eb9cea01e updated cmake to create libamdhip64 static file as well
Change-Id: I2054b9501cefa232abbf398524ab62450ab6805d


[ROCm/hip commit: 76703acb1d]
2020-03-25 16:37:57 -04:00
Vladislav Sytchenko a48ad08f24 Disable failing tests for VDI
The hipExtModuleLaunchKernel and hipModuleLoadDataMultiThreaded tests keeps randomly failing on Jenkins.

Change-Id: I87e5d54fb7429c14ff1dcecb20e03a7816670fae


[ROCm/hip commit: e7d91b8230]
2020-03-23 17:09:57 -04:00
Christophe Paquot 58ea10b083 Merge "Enable VDI Occupancy test" into amd-master-next
[ROCm/hip commit: 3dce22538c]
2020-03-23 13:38:57 -04:00
Nick Curtis 15ea4194c4 Update hip_runtime_api.h (#1966)
Correct URL for deprecated api list

[ROCm/hip commit: b4c69a2e4a]
2020-03-23 10:16:24 -07:00
Saleel Kudchadker 09bd0d2138 Merge "Sync streams when freeing or destroying mem" into amd-master-next
[ROCm/hip commit: 91069c0de4]
2020-03-21 13:33:41 -04:00
Christophe Paquot 3c623309cd hipStreamAddCallback test seg faults
Change-Id: If419d2fad490d0ed50eb1315af809fc1deda1ce3
SWDEV-227875: Add a lock in streams to lock when the callback is call so we make sure things aren't moving forward in the stream


[ROCm/hip commit: 653277bd3f]
2020-03-20 13:07:34 -07:00
Saleel Kudchadker 1b4bbfcb53 Sync streams when freeing or destroying mem
Change-Id: I6932f225a8b932bb2adbd5e37880f7e604496809


[ROCm/hip commit: 8b39e0b74e]
2020-03-20 10:53:23 -07:00
Christophe Paquot 7a418b2fce Merge "hipStreamAddCallback test seg faults" into amd-master-next
[ROCm/hip commit: d98879a250]
2020-03-20 12:05:37 -04:00
kjayapra-amd 64677e52e2 SWDEV-216213 - Lookup module functions from PlatformState::functions_.
Change-Id: I91dfe327f2ebdcf4c9b39ddd14d60aa0ce2fa9f4


[ROCm/hip commit: cd92bd7fee]
2020-03-20 11:52:28 -04:00
Christophe Paquot 0d5638f513 hipStreamAddCallback test seg faults
Change-Id: I1f107fc8a5c586cd571f0280ed8716c5f89d25b7
SWDEV-227875: Need to add a dummy marker in case the stream is empty.


[ROCm/hip commit: 3dfbfc408b]
2020-03-19 11:11:59 -07:00
Yaxun (Sam) Liu 89cf7e2c4d Let hipcc treat .c program as C program (#1945)
nvcc treats .c program as C program and .cpp program as C++ program.

Currently hipcc treats .c and .cpp programs as HIP programs.

It is desirable to let hipcc behave like nvcc.

Currently it is not feasible to let hipcc treat .cpp programs as C++ program
since there are too many HIP applications use .cpp as extension for HIP programs.
However we should be able let hipcc treat .c program C program since there
are few applications use .c as extensioin for HIP programs.

[ROCm/hip commit: 28db1e4383]
2020-03-19 16:16:31 +05:30
Jeff Daily a2915ae475 fix hipStreamAddCallback, block future work on stream (#1934)
[ROCm/hip commit: 01d661b159]
2020-03-19 16:16:04 +05:30
nelsonc-amd d6d60529ce packaging: change Provides to use dash instead of underscore (#1913)
Addresses an installation problem for several HIP packages.
Packages builds have been tested locally, validation in progress.

[ROCm/hip commit: b757c2a891]
2020-03-19 16:15:09 +05:30