Граф коммитов

53 Коммитов

Автор SHA1 Сообщение Дата
Manocha, Rahul 3f6f9d6081 SWDEV-539710 - Defer allocation of managed variable (#652)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-07-31 08:30:23 -07:00
Sang, Tao b15c1657b8 SWDEV-502579 - Remove duplicated symbols (#21)
Remove duplicated compiler symbols from hip-rt. hip-rt should use symbols such as EF_AMDGPU_MACH_AMDGCN_XXX and
ELFABIVERSION_AMDGPU_HSA_VX defined in compiler header.
2025-07-22 10:41:01 +05:30
Belton-Schure, Aidan 81238db679 SWDEV-515426 - Remove HIP_USE_RUNTIME_UNBUNDLER (#205)
* remove HIP_USE_RUNTIME_UNBUNDLER
* clang-format
* Generic to use comgr
* Remove HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION flag
* Removes runtime unbundling unused and debug Code
* Removes stale functions
2025-07-08 21:45:31 +05:30
Assiouras, Ioannis 1099e0a131 SWDEV-526188 - Fix race condition in StatCO::getStatFunc()
Make sure that a newly created FatBinaryInfo is assigned to modules only after extractFatBinary has been called for the object.
2025-04-27 21:14:01 +01:00
Xie, Pengda e92ea151b2 SWDEV-518317 - Remove Redundant Error Message in removeFatBinary (#164) 2025-04-15 09:00:39 -07:00
Sang, Tao 8d90b44a1b SWDEV-508863 - Support generic target in compressed fatbin (#44) 2025-03-27 20:13:51 +05:30
Pengda Xie ae3b053ddf SWDEV-518317 - Don't attempt to remove managedVars when map is empty
Change-Id: I25c33487dc08f96c087b6acc1abe42a4a666a609
2025-03-05 11:53:18 -05:00
Branislav Brzak c2d1776ebd SWDEV-516564 - SWDEV-512817 - Remove mentions of gfx940 and gfx941
Change-Id: Ia069fcb9c6948c3fc9a00961593c9dcc59609375
2025-03-05 04:26:07 -05:00
German Andryeyev cece301fd4 SWDEV-518474 - Add comgr debug mask
Move prints from CO processing under COMGR debug mask.

Change-Id: I2a417e42a1f4e2922a34eb104c69e4db10b5f1c6
2025-03-04 14:37:08 -05:00
taosang2 29cc394510 SWDEV-513458 - Add gfx950 target ID
Add gfx950 target ID

Cherry-picked
https://gerrit-git.amd.com/c/compute/ec/clr/+/997678
https://gerrit-git.amd.com/c/compute/ec/clr/+/1063519

Change-Id: I0228c5e87ceec366983fd4afb1c25e7f8161c2c2
2025-02-04 18:30:23 -05:00
Saleel Kudchadker 08af3eb484 SWDEV-508225 - Improve fat binary handling
Change-Id: I78a9951f2f4c4c743c1205b1e40aac215054e27d
2025-01-28 14:38:21 -05:00
Marko Arandjelovic c46f843b99 SWDEV-504084 - Make hipModuleGetFunction use the device the module is loaded on
If a module is loaded on one device, hipModuleGetFunction and other similar APIs should be able to run successfully from another device.

Change-Id: I96084cbd6c6dcf2a81019779a6ab1842ef2f35d1
2025-01-16 10:16:42 -05:00
German Andryeyev 0640d36019 SWDEV-504658 - Reduce the lock scope for kernel look-up
The vector with all kernels is preallocated on the executable init.
Thus, reduce the scope  of global lock to the binary creation only.

Change-Id: I73035013a6562175069137e895bba815f466ee35
2024-12-18 17:04:51 -05:00
Tao Sang 3ad8f1b811 SWDEV-496667 - Support gfx9-4-generic target
Support gfx9-4-generic target to cover mi3XX.
Support features sramecc and xnack in generic target.
Improve some code formats.
Add more log on compiler.

Change-Id: I6b3c6af55c60cffd43ce6f17b75998f751b75713
2024-12-12 14:43:39 -05:00
taosang2 f1f4f40c5b SWDEV-447973 - Support generic targets
Change-Id: I32db83843e45e0f013591493aafd7a532c881e16
2024-11-29 10:12:10 -05:00
Sebastian Luzynski 019abdc3bd SWDEV-465085 - replace asserts inside API calls
This change replaces some asserts, that were only available in debug
mode, with standard error handling.

Signed-off-by: Sebastian Luzynski <Sebastian.Luzynski@amd.com>
Change-Id: I112f9e56f921abd72daf0d11e4ecdcb7b1a9f9e6
2024-11-29 04:11:39 -05:00
Rahul Manocha a2d8199402 SWDEV-494409 - Fix destructor path for Static and Dynamic CO
1) For Dynamic CO variables, free the device pointer in
   DynCO destructor instead of DeviceVar destructor.
2) For Static CO Remove Fatbinary,
   only call hipFree for valid device Vars instead of all devices.

Change-Id: I84291f5371b2c05d1d0bcdb4f9c6bd122e7c9b21
2024-11-19 13:04:44 -05:00
Ioannis Assiouras 1a710dabcf SWDEV-496003 - Add support for dynamic functions in hipFuncSetAttribute
Modified hipFuncSetAttribute to handle pointers to dynamic functions
returned by hipModuleGetFunction.

Change-Id: I54b98f9d31a79630dd7edcd363fad81f1d89219b
2024-11-19 04:50:15 -05:00
kjayapra-amd e7c0e06b5e SWDEV-486510 - Delete hip::Function object, in case compiler passes duplicate hostFunction ptr.
Change-Id: Ic8714eb9022a0f2150b2ea5dc008cecd7a9fae27
2024-10-10 12:45:58 -04:00
Jaydeep Patel 614b00c20b SWDEV-487905 - Managed vars are registered in __hipRegisterManagedVar however not freed.
Change-Id: Ic5a72ac4d64a9f7f5a3a7a88e1ed813e6dcc1f57
2024-09-30 11:54:31 -04:00
Tao Sang d0050ce309 SWDEV-433371 - Support new comgr unbundling action
Support new comgr unbundling action api to extract codebjects
in compressed and uncompressed modes.

Create HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION ENV to
toggle new path and old path.
If HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION=false(default),
   uncompressed codeobject will go old path for better perf,
   compressed   codeobject will go new path.
If HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION=true,
   both uncompressed and compressed codeobjects will go new
   path.

Add comgr wrapper for
   amd_comgr_action_info_set_bundle_entry_ids()

Change-Id: I79952f132fe21249296685ee12cae05a4f9aec32
2024-05-28 06:31:10 +00:00
Tao Sang a1350fe8c1 Revert "SWDEV-433371 - use comgr to unbundle code objects"
This reverts commit e53df57ffe.

Reason for revert: <INSERT REASONING HERE>
New comgr unbundling action leads to perf drop for uncompressed code object.   Will create a new patch to use old path for uncompressed , new unbundling api for compressed . 

Change-Id: I41ef53b71fc9f7aaa8cf231d4d70945f1117db52
2024-05-28 06:31:10 +00:00
kjayapra-amd 68ddd8f3a0 SWDEV-460091 - Handle cases where inline variables are included in multiple translation unit.
Change-Id: I92179ad198abbdaf5aec9c3c4ba76eeb6b0cc761
2024-05-03 15:52:28 -04:00
taosang2 e53df57ffe SWDEV-433371 - use comgr to unbundle code objects
1.Make runtime use comgr to unbundle code objects
2.Support compressed/uncompressed modes
3.Remove HIP_USE_RUNTIME_UNBUNDLER and
  HIPRTC_USE_RUNTIME_UNBUNDLER to simplify logics
4.Add comgr wrapper for
  amd_comgr_action_info_set_bundle_entry_ids()

Change-Id: Ic41b1ad1b64cca1e31986437983a5146d52a7329
2024-05-01 16:09:12 -04:00
jiabaxie f80985f6a1 SWDEV-435477 - correct MACH IDs and add strx1/halo and krackan support for hip
Change-Id: I5b7ed449f4755d69f10677b90ab2b0ceae050b3d
2023-12-14 13:07:03 -05:00
Saleel Kudchadker 058b2702db SWDEV-301667 - Logging refactor
- Remove newline from logging as log function internally inserts a new
line

Change-Id: I25eb2242a1f1e87cf811bcc373d1d485b2e027a8
2023-12-07 12:12:57 -05:00
Anusha GodavarthySurya 5e21f0c6bd SWDEV-351966 - Dispatch table for hip runtime
Change-Id: Ie4a44fa8cf1ff9c152146070bbbf6b0636d4e325
2023-11-22 01:11:19 -05:00
Jatin Chaudhary ce27581465 SWDEV-431399 - fix first set of memory leaks in clr, found in rtc tests
change constexpr variable names to match the C++ style we follow.

Change-Id: Ibc59a65d8ff2ca765da7bf5e653c0650fb3714c4
2023-11-14 20:39:45 -05:00
Saleel Kudchadker f06368fd04 SWDEV-301667 - Add error logging
Change-Id: I814399dc0e7083bb7fb0ed8bf46dd96bdf664965
2023-11-10 11:55:54 -05:00
Ajay 2bae1b1387 SWDEV-421102 - make clr compatible with c++20
Change-Id: Ia692817232caa3ee97dc0b2139645a0474b582e1
2023-09-18 11:28:29 -04:00
kjayapra-amd f14e8a2dba SWDEV-393910 - Port gfx94x changes to mainline.
Change-Id: Ibf727223bbe5230b132b47c39e0fc1d87cbd3b9c
2023-05-05 15:16:23 -04:00
kjayapra-amd 7f41a96ffb SWDEV-378006 - Adding a new guarantee macro to support printing args.
Change-Id: I2083ddaf8058759bdace7d3bb1e8e3670cbeddd2
2023-05-03 12:43:16 -04:00
Anusha GodavarthySurya 9b84e05427 SWDEV-386102 - Handle code object v5
Change-Id: I47b840f484d90ca7815fb9c8af959ceaac62cf70
2023-03-09 00:19:25 -05:00
Jaydeep Patel 57fa5938fe SWDEV-383056 - Don't sync with dst device for hipMemcpyAsync.
Change-Id: I28530e6bd870d617507592576295fc9e7eed1475
2023-02-28 23:21:01 -05:00
Ioannis Assiouras e3633dc8f4 SWDEV-381402 - Derive hip::Stream from amd::HostQueue
Change-Id: I6c1aca5eb350c32d974ae4ffcc725705355956d8
2023-02-21 18:12:03 -05:00
Konstantin Zhuravlyov caf7551dd7 SWDEV-1 - Add missing gpu cases in getProcName
Change-Id: I16103ab213cc70f388690df85e6a03e7a408384d
2023-02-17 15:55:09 -05:00
kjayapra-amd 5e4f430e03 SWDEV-241902 - Using COMGR APIs for extracting Code object.
Change-Id: I2dd662babf805d2de6e037bf41f7306e523da7d5
2022-12-06 12:17:12 -08:00
Rakesh Roy 4f5d180ca7 SWDEV-368881 - Revert enable hipLaunchCooperativeKernel for hipRTC compiled function
This reverts commit b4d8586a11.

Reason for revert: Doesn't match with CUDA behavior

Change-Id: I413f3d241f864c1e7c21681c5fff8f216ef54306
2022-11-30 03:58:29 -05:00
Rakesh Roy b4d8586a11 SWDEV-368881 - Enable hipLaunchCooperativeKernel for hipRTC compiled function
- Add helper function to validate whether a dynamic function is present or not
- If getStatFunc fails, then check whether the function passed is a valid dynamic function

Change-Id: I4141172f42dce7ff689709560c483e602b5dad4b
2022-11-29 00:35:43 -05:00
pghafari 9f37acc55f SWDEV-341326 - removing sigabrt for NoBinaryForGpu
Change-Id: Ia30fb3efec7f71b870e6a35d5ce51a4aa61fad28
2022-08-31 09:39:59 -04:00
Laurent Morichetti a682934251 SWDEV-351980 - Acquire the code object lock in StatCO::getStatFuncName
Change-Id: I52ce2530d12fbe47e575feb2aab39bbfdfebd201
2022-08-16 19:43:15 -04:00
Ajay b380a95597 SWDEV-348678 - hipManagedVar to initialize on all devices
Change-Id: Id714b56e89e4930ee067f3a7472a0029057d2711
2022-08-10 16:54:19 +00:00
Ajay 789e718549 SWDEV-342009 SWDEV-340506 - assertion failures in managed variables
Change-Id: Iac884f2e3cece96e605e353a8851274ba578e8be
2022-07-22 11:48:34 -04:00
Ammar ELWazir fb8690f812 SWDEV-345650 - Solving hipKernelNameRefByPtr Stream Issue
Stream is not important to get the kernel
name from Function that can be found in
the functions_ map.

Change-Id: I164bc3ebcc5552359856e76204d8b124ba0d2f34
2022-07-15 15:38:39 -04:00
kjayapra-amd 84f94fd134 SWDEV-290384 - Add Linker API support in hiprtc
Change-Id: I4621a033a22e4da0201c3804e2b357470a681ab0
2022-05-24 09:16:14 -04:00
Saleel Kudchadker 086aee0fcb SWDEV-301667 - Fix build warnings
Change-Id: Ice23b3d1a19a7958ca5c3caff34db2934b361a98
2022-03-02 20:49:18 -05:00
Satyanvesh Dittakavi 6e562f4d83 SWDEV-306940 - Fix hipamd errors/warnings found by CppCheck
Change-Id: Ia93d4f5262ea4269d8031edbfd27033b887e5300
2022-02-05 08:42:47 -05:00
Satyanvesh Dittakavi a6b2294b93 Revert "SWDEV-304151 - Reset file descriptor after Module Load"
This reverts commit 3b157b3d5f.

Reason for revert: To address SWDEV-316216

Change-Id: Ib8e6ac4b87c5e52757cd8f45958f39f012823c60
2021-12-23 06:11:43 +00:00
Satyanvesh Dittakavi 3b157b3d5f SWDEV-304151 - Reset file descriptor after Module Load
File descriptors opened during hipModuleLoad are not closed
until hipModuleUnLoad. In large models, this exceeds the ulimit
for no. of open file descriptors causing out of resource issues.
Hence, close the file descriptors once the required data is read
from the file, and not wait until unload.

Change-Id: Ic50d424e5ca388715b1e6309a0de72a480321582
2021-11-19 12:25:59 -05:00
Julia Jiang 8835b897d5 SWDEV-286322 - Remove execution permission
Change-Id: I96e603fc8d407c3a76fa1053bad81e45744b59ad
2021-08-05 14:04:06 -04:00