Commit Graph

64521 Commits

Author SHA1 Message Date
Gopesh Bhardwaj 8ab1ed78d8 Adding Node-id for debugging with log level trace (#1090) 2024-10-10 11:00:28 +05:30
Jaydeep Patel 7983801b0c SWDEV-485866 - Return OOM if stream creation fails due to insufficient memory.
Change-Id: I4e57ecc81921bde274bb6a4e0890f0fc6a17955a


[ROCm/clr commit: 5ccc140e1b]
2024-10-10 00:44:54 -04:00
Jaydeep Patel 5ccc140e1b SWDEV-485866 - Return OOM if stream creation fails due to insufficient memory.
Change-Id: I4e57ecc81921bde274bb6a4e0890f0fc6a17955a
2024-10-10 00:44:54 -04:00
adapryor e20bc58b1c Add XGMI read/write sum metrics
Change-Id: I898b779ea7f5336edf0d047fb1e5d3ec40085baa
2024-10-09 17:02:55 -05:00
adapryor c283aebd1c Add XGMI read/write sum metrics
Change-Id: I898b779ea7f5336edf0d047fb1e5d3ec40085baa


[ROCm/rdc commit: e20bc58b1c]
2024-10-09 17:02:55 -05:00
Jatin Chaudhary da59165313 SWDEV-486137 - match behavior of int variants of hadd/uhadd/rhadd/urhadd
Match cases and handle cases where it can overflow.

Change-Id: I3d6f802686af230a622ef9891a844135ad3d1ae5


[ROCm/clr commit: b977101893]
2024-10-09 13:47:33 -04:00
Jatin Chaudhary b977101893 SWDEV-486137 - match behavior of int variants of hadd/uhadd/rhadd/urhadd
Match cases and handle cases where it can overflow.

Change-Id: I3d6f802686af230a622ef9891a844135ad3d1ae5
2024-10-09 13:47:33 -04:00
taosang2 4b0437de28 SWDEV-482059 SWDEV-476745 - Add image support check
Add image support check before hipMallocArray().

Change-Id: I9efed88d791ee1b2b4465286b3341b821f7bf628


[ROCm/hip-tests commit: b4694a6bab]
2024-10-09 11:29:28 -04:00
taosang2 b4694a6bab SWDEV-482059 SWDEV-476745 - Add image support check
Add image support check before hipMallocArray().

Change-Id: I9efed88d791ee1b2b4465286b3341b821f7bf628
2024-10-09 11:29:28 -04:00
kjayapra-amd 3a2d835272 SWDEV-486573 - Check the return type of commit memory.
Change-Id: Id158cd7a0dff37b382b858cf7113aa4cf326300a


[ROCm/clr commit: 74ebbe17e9]
2024-10-09 05:10:03 -04:00
kjayapra-amd 74ebbe17e9 SWDEV-486573 - Check the return type of commit memory.
Change-Id: Id158cd7a0dff37b382b858cf7113aa4cf326300a
2024-10-09 05:10:03 -04:00
Julia Jiang 5d7b767788 SWDEV-479940 - Correct changelog in staging for 6.2.1
Change-Id: I3f35a85b9834841d27fa35abc52b9838d6f1c9e7


[ROCm/clr commit: d6bcabdc2c]
2024-10-08 17:04:43 -04:00
Julia Jiang d6bcabdc2c SWDEV-479940 - Correct changelog in staging for 6.2.1
Change-Id: I3f35a85b9834841d27fa35abc52b9838d6f1c9e7
2024-10-08 17:04:43 -04:00
Ioannis Assiouras d452c4ad28 SWDEV-483134 - Deprecate hipHostMalloc and hipHostFree APIs
Change-Id: I230ab2de2e4bdfdd9bfb0a3e59c6130a25b8b0cd


[ROCm/clr commit: 80043d38f4]
2024-10-08 15:58:25 -04:00
Ioannis Assiouras 80043d38f4 SWDEV-483134 - Deprecate hipHostMalloc and hipHostFree APIs
Change-Id: I230ab2de2e4bdfdd9bfb0a3e59c6130a25b8b0cd
2024-10-08 15:58:25 -04:00
Kent Russell ccd80d19ba kfdtest: Fix in-tree scriptless build
If you build thunk following the instructions in the thunk's README,
there is no /lib folder in the build folder. Adjust the include path,
and clean up the docs to reflect that. The header include is already
defined in the CMake file as ../../include, so we don't use
LIBHSAKMT_PATH for that linking, just the lib location

Change-Id: I73435d59adb9d01f527a28b1935086260e9d3d70
Signed-off-by: Kent Russell <kent.russell@amd.com>
2024-10-08 14:42:33 -04:00
Kent Russell 9f4a01e8a9 kfdtest: Fix in-tree scriptless build
If you build thunk following the instructions in the thunk's README,
there is no /lib folder in the build folder. Adjust the include path,
and clean up the docs to reflect that. The header include is already
defined in the CMake file as ../../include, so we don't use
LIBHSAKMT_PATH for that linking, just the lib location

Change-Id: I73435d59adb9d01f527a28b1935086260e9d3d70
Signed-off-by: Kent Russell <kent.russell@amd.com>


[ROCm/ROCR-Runtime commit: ccd80d19ba]
2024-10-08 14:42:33 -04:00
Satyanvesh Dittakavi 815b9ffc36 SWDEV-489280 - Add missing hipGraphNodeSetParams API in dispatch table
Change-Id: I41dfd045fa4e29b49e605b8d583ec9f51dd6a6cc


[ROCm/clr commit: 15ecf834a1]
2024-10-08 13:56:02 -04:00
Satyanvesh Dittakavi 15ecf834a1 SWDEV-489280 - Add missing hipGraphNodeSetParams API in dispatch table
Change-Id: I41dfd045fa4e29b49e605b8d583ec9f51dd6a6cc
2024-10-08 13:56:02 -04:00
Gopesh Bhardwaj b426c65c43 mem copy direction field update (#1124)
[ROCm/rocprofiler-sdk commit: 81e93a6ddb]
2024-10-08 15:15:48 +05:30
Gopesh Bhardwaj 81e93a6ddb mem copy direction field update (#1124) 2024-10-08 15:15:48 +05:30
Jaydeep Patel 566984676e SWDEV-487988 - Reserve event flag in hip::Event.
Don't create new hip:Function if it is already registered.

Change-Id: I3ecd5d61146659be6ba434717b0f21d3fc04cfc9


[ROCm/clr commit: a6c5c6a95a]
2024-10-08 05:29:32 -04:00
Jaydeep Patel a6c5c6a95a SWDEV-487988 - Reserve event flag in hip::Event.
Don't create new hip:Function if it is already registered.

Change-Id: I3ecd5d61146659be6ba434717b0f21d3fc04cfc9
2024-10-08 05:29:32 -04:00
Jaydeep Patel b31bf885a3 SWDEV-482692, SWDEV-485802, SWDEV-485489 - Handle refcounts owned by graph for user objects.
Change-Id: Ic739ab1ec5d3dc3143e3ae70f9591922bc0e3d9f


[ROCm/clr commit: e74ac6f580]
2024-10-08 03:44:44 -04:00
Jaydeep Patel e74ac6f580 SWDEV-482692, SWDEV-485802, SWDEV-485489 - Handle refcounts owned by graph for user objects.
Change-Id: Ic739ab1ec5d3dc3143e3ae70f9591922bc0e3d9f
2024-10-08 03:44:44 -04:00
Jaydeep Patel 3130b4639f SWDEV-487905 - device_ptr_ is being removed and its amd:Memory obj is being deleted during ihipFree in hip::StatCO::removeFatBinary.
Change-Id: I89d9fdeb53dc4ce0699f1f445a28486917a36e72


[ROCm/clr commit: 164cbcc531]
2024-10-08 03:38:15 -04:00
Jaydeep Patel 164cbcc531 SWDEV-487905 - device_ptr_ is being removed and its amd:Memory obj is being deleted during ihipFree in hip::StatCO::removeFatBinary.
Change-Id: I89d9fdeb53dc4ce0699f1f445a28486917a36e72
2024-10-08 03:38:15 -04:00
Branislav Brzak 491d3828dd SWDEV-482130 - Fix release of virtual mem obj
Change-Id: I893a8353aa1a25d00e36c8e601caf31cc0fc1f22


[ROCm/clr commit: 43fcac1739]
2024-10-08 01:37:39 -04:00
Branislav Brzak 43fcac1739 SWDEV-482130 - Fix release of virtual mem obj
Change-Id: I893a8353aa1a25d00e36c8e601caf31cc0fc1f22
2024-10-08 01:37:39 -04:00
Benjamin Welton c69cb447ee clang-18 build fix for RCCL (#1123)
Removes ambiguity on const usage, which clang-18 complains about
(preventing build with warn error).

[ROCm/rocprofiler-sdk commit: b46966e96b]
2024-10-07 15:58:41 -07:00
Benjamin Welton b46966e96b clang-18 build fix for RCCL (#1123)
Removes ambiguity on const usage, which clang-18 complains about
(preventing build with warn error).
2024-10-07 15:58:41 -07:00
Mythreya cbf61d5a66 Fix PSDB change (#1120)
Reverts change to `source/include/rocprofiler-sdk/callback_tracing.h`
from commit c77e4d3b80

[ROCm/rocprofiler-sdk commit: a3b41d04fc]
2024-10-07 17:37:19 -05:00
Mythreya a3b41d04fc Fix PSDB change (#1120)
Reverts change to `source/include/rocprofiler-sdk/callback_tracing.h`
from commit 9b2ece76c3
2024-10-07 17:37:19 -05:00
Giovanni Lenzi Baraldi 6361ff50a5 SWDEV-487621: Fixes for metric definitions (#1118)
* Fixes for metric definitions

* Removing gfx8

* Update changelog

* Fixing unit tests

* Small fixes

* Fix for write size

[ROCm/rocprofiler-sdk commit: 9652a6e738]
2024-10-08 02:44:31 +05:30
Giovanni Lenzi Baraldi 9652a6e738 SWDEV-487621: Fixes for metric definitions (#1118)
* Fixes for metric definitions

* Removing gfx8

* Update changelog

* Fixing unit tests

* Small fixes

* Fix for write size
2024-10-08 02:44:31 +05:30
Giovanni Lenzi Baraldi 43684c07c6 SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests. (#1112)
* SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests.

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Adding backlog for codeobj changes

* Formatting

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

---------

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: a6be3f9660]
2024-10-07 20:00:59 +00:00
Giovanni Lenzi Baraldi a6be3f9660 SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests. (#1112)
* SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests.

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Adding backlog for codeobj changes

* Formatting

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

---------

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>
2024-10-07 20:00:59 +00:00
vstempen a83747166a Documented Docker container OpenSSL abilities being affected by Host network proxy services (#440)
* Documented Docker container OpenSSL abilities being affected by host
network proxy services, causing network certificates verification
problem during Docker container build stage of Grafana server setup.

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>

* Update docs/install/grafana-setup.rst

Co-authored-by: Peter Park <peter.park@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>

---------

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>
Co-authored-by: Peter Park <peter.park@amd.com>

[ROCm/rocprofiler-compute commit: ba94cb8370]
2024-10-07 15:53:48 -04:00
vstempen ba94cb8370 Documented Docker container OpenSSL abilities being affected by Host network proxy services (#440)
* Documented Docker container OpenSSL abilities being affected by host
network proxy services, causing network certificates verification
problem during Docker container build stage of Grafana server setup.

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>

* Update docs/install/grafana-setup.rst

Co-authored-by: Peter Park <peter.park@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>

---------

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>
Co-authored-by: Peter Park <peter.park@amd.com>
2024-10-07 15:53:48 -04:00
Giovanni LB bddd5b51dd SWDEV-487621: Fixing BW measurement in MI300
Change-Id: Ib513009616214a1f3f3568571e58d79259692cfc
2024-10-07 16:29:09 -03:00
Giovanni LB 8b22cf86a7 SWDEV-487621: Fixing BW measurement in MI300
Change-Id: Ib513009616214a1f3f3568571e58d79259692cfc


[ROCm/rocprofiler commit: bddd5b51dd]
2024-10-07 16:29:09 -03:00
Shweta Khatri 8bc4efc8ca hsakmt: pmc_table.c: Fix Coverity reported warnings
Eliminate out-of-bounds access in get_block_properties

Change-Id: I3abee1e36fafdda053d4bc4a611698d676b01d5c
2024-10-07 14:15:26 -04:00
Shweta Khatri 6506a664e7 hsakmt: pmc_table.c: Fix Coverity reported warnings
Eliminate out-of-bounds access in get_block_properties

Change-Id: I3abee1e36fafdda053d4bc4a611698d676b01d5c


[ROCm/ROCR-Runtime commit: 8bc4efc8ca]
2024-10-07 14:15:26 -04:00
Shweta Khatri 52e7fd1480 hsakmt: debug.c: Fix Coverity reported warnings
Fix potential  memory leak reported by Coverity warnings

Change-Id: Iacbaa99be3f4fe7fae5fb6a10bd41dfc34b96059
2024-10-07 14:14:26 -04:00
Shweta Khatri f2bd877365 hsakmt: debug.c: Fix Coverity reported warnings
Fix potential  memory leak reported by Coverity warnings

Change-Id: Iacbaa99be3f4fe7fae5fb6a10bd41dfc34b96059


[ROCm/ROCR-Runtime commit: 52e7fd1480]
2024-10-07 14:14:26 -04:00
Shweta Khatri c9454794b6 hsakmt: fmm.c: Fix Coverity reported warnings
Fixed multiple issues related to memory management, atomicity,
and error handling across various functions: handle null checks,
use-after-free, unchecked returns, and memory leaks.

Change-Id: Ia7c76320cc20e24001052fbba2dd0600bd412140
2024-10-07 13:54:03 -04:00
Shweta Khatri 42043a59ea hsakmt: fmm.c: Fix Coverity reported warnings
Fixed multiple issues related to memory management, atomicity,
and error handling across various functions: handle null checks,
use-after-free, unchecked returns, and memory leaks.

Change-Id: Ia7c76320cc20e24001052fbba2dd0600bd412140


[ROCm/ROCR-Runtime commit: c9454794b6]
2024-10-07 13:54:03 -04:00
Giovanni LB dfa81b0cab Fix for s_delay_alu followed by s_waitcnt on gfx11
Change-Id: I3254ee80a0a5542467da5c61cf60f9e27aab9a36
2024-10-07 14:11:24 -03:00
Giovanni LB 6f37da626f Fix for s_delay_alu followed by s_waitcnt on gfx11
Change-Id: I3254ee80a0a5542467da5c61cf60f9e27aab9a36


[ROCm/rocprofiler commit: dfa81b0cab]
2024-10-07 14:11:24 -03:00
Gopesh Bhardwaj c77e4d3b80 Fixing installed pacakge tests in CI (#1119)
* Fixing installed pacakge tests in CI

* Formatted rocprofv3.py with black formatter

[ROCm/rocprofiler-sdk commit: 9b2ece76c3]
2024-10-07 20:55:35 +05:30