Commit Graph

64521 Commits

Author SHA1 Message Date
Ioannis Assiouras 8e62770f50 SWDEV-478295 - Set CXX as the project language in 23_cmake_hiprtc
Change-Id: I40c01191e9de1790bbdd42896bdf70c046a70e34
2024-10-01 10:57:16 -04:00
Tim 7b27294298 Fix Issue [SWDEV-485618]: README Outdated: Include File
Changes to the README.md:
-Fixed the dead links in the examples.
-Updated the example to point to the ones in roctracer_spec.md instead of tests.

Changes to the roctracer_spec.md:
-Changed #include from #include <*.h> to #include <roctracer/*.h> to
reflect the latest code structure.

Change-Id: Iab44fc327821c1a01f0b949d3c9a3c20ca587599


[ROCm/roctracer commit: 725d289a2b]
2024-10-01 09:52:09 -04:00
Tim 725d289a2b Fix Issue [SWDEV-485618]: README Outdated: Include File
Changes to the README.md:
-Fixed the dead links in the examples.
-Updated the example to point to the ones in roctracer_spec.md instead of tests.

Changes to the roctracer_spec.md:
-Changed #include from #include <*.h> to #include <roctracer/*.h> to
reflect the latest code structure.

Change-Id: Iab44fc327821c1a01f0b949d3c9a3c20ca587599
2024-10-01 09:52:09 -04:00
Satyanvesh Dittakavi b758610a55 SWDEV-478708 - Remove forced wait of 10us in hipEventQuery
Change-Id: I868aae14311c3cdfc09aa03252ac324c4b79b864


[ROCm/clr commit: ade1954015]
2024-10-01 06:27:42 -04:00
Satyanvesh Dittakavi ade1954015 SWDEV-478708 - Remove forced wait of 10us in hipEventQuery
Change-Id: I868aae14311c3cdfc09aa03252ac324c4b79b864
2024-10-01 06:27:42 -04:00
Ioannis Assiouras 573305e5af SWDEV-478472 - Disabled Unit_hipMallocArray_Negative_8bitFloat
Change-Id: I2d7f8ae8b2cae655904522d3acc20aa939080d1b


[ROCm/hip-tests commit: cf29cda0bd]
2024-10-01 09:54:14 +01:00
Ioannis Assiouras cf29cda0bd SWDEV-478472 - Disabled Unit_hipMallocArray_Negative_8bitFloat
Change-Id: I2d7f8ae8b2cae655904522d3acc20aa939080d1b
2024-10-01 09:54:14 +01:00
Shweta Khatri 9f43c9fd51 hsakmt: spm.c: Fix Coverity reported warnings
Fix unused ret value and initialize gpu_id

Change-Id: Ib3acc7db4bbab519318d0970786a5dc641dcc9eb
2024-09-30 19:46:51 -04:00
Shweta Khatri b4ebbe7448 hsakmt: spm.c: Fix Coverity reported warnings
Fix unused ret value and initialize gpu_id

Change-Id: Ib3acc7db4bbab519318d0970786a5dc641dcc9eb


[ROCm/ROCR-Runtime commit: 9f43c9fd51]
2024-09-30 19:46:51 -04:00
David Yat Sin 73f6bfa747 rocr/vmm: Only modify permisions for specified agents
When hsa_amd_vmem_set_access is called, do not remove permissions for
unspecified agents. Also updating documentation in header to clarify
this.

Change-Id: I3bb4cf08ba399f85cc67b17fd13a4a40d862415f
2024-09-30 17:41:58 -04:00
David Yat Sin 298ec3d840 rocr/vmm: Only modify permisions for specified agents
When hsa_amd_vmem_set_access is called, do not remove permissions for
unspecified agents. Also updating documentation in header to clarify
this.

Change-Id: I3bb4cf08ba399f85cc67b17fd13a4a40d862415f


[ROCm/ROCR-Runtime commit: 73f6bfa747]
2024-09-30 17:41:58 -04:00
Rahul Manocha 9f10e89d97 SWDEV-487903 - Fix for Empty Kernel Segfault in PAL
Change-Id: Ia1c19cf4ea24188cdb2d374b07f975f794e02dba


[ROCm/clr commit: 9da90fe848]
2024-09-30 13:00:15 -04:00
Rahul Manocha 9da90fe848 SWDEV-487903 - Fix for Empty Kernel Segfault in PAL
Change-Id: Ia1c19cf4ea24188cdb2d374b07f975f794e02dba
2024-09-30 13:00:15 -04:00
coleramos425 b7d4dd023d Update issue template
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: faaf5bdcfe]
2024-09-30 16:45:42 +00:00
coleramos425 faaf5bdcfe Update issue template
Signed-off-by: coleramos425 <colramos@amd.com>
2024-09-30 16:45:42 +00:00
Jaydeep Patel bc3f3b09df SWDEV-487905 - Managed vars are registered in __hipRegisterManagedVar however not freed.
Change-Id: Ic5a72ac4d64a9f7f5a3a7a88e1ed813e6dcc1f57


[ROCm/clr commit: 614b00c20b]
2024-09-30 11:54:31 -04:00
Jaydeep Patel 614b00c20b SWDEV-487905 - Managed vars are registered in __hipRegisterManagedVar however not freed.
Change-Id: Ic5a72ac4d64a9f7f5a3a7a88e1ed813e6dcc1f57
2024-09-30 11:54:31 -04:00
Branislav Brzak 2896b2c2d9 SWDEV-483315 - Add hipGraphNodeGetDependentNodes_v2
Change-Id: I418d0c2a5a77b07603e4e481fd9547cf43b03a20


[ROCm/hipother commit: e22853eb4d]
2024-09-30 11:51:11 -04:00
Branislav Brzak e22853eb4d SWDEV-483315 - Add hipGraphNodeGetDependentNodes_v2
Change-Id: I418d0c2a5a77b07603e4e481fd9547cf43b03a20
2024-09-30 11:51:11 -04:00
Mukul Joshi b81e45f03c kfdtest: Update KFDPerformanceTest.P2PBandWidthTest for CPX mode
Currently, KFDPerformanceTest.P2PBandWidthTest cannot work if there are
more than 16 KFD nodes in the system. This limit was put in to match the
number of SDMA queues supported on a single node.
This patch updates the test to make it run on systems with more than
16 KFD nodes.

Signed-off-by: Mukul Joshi <mukul.joshi@amd.com>
Change-Id: I561d0cdef664cae84fb9c13a801052e2001256e5
2024-09-30 11:28:33 -04:00
Mukul Joshi e1ffd97abd kfdtest: Update KFDPerformanceTest.P2PBandWidthTest for CPX mode
Currently, KFDPerformanceTest.P2PBandWidthTest cannot work if there are
more than 16 KFD nodes in the system. This limit was put in to match the
number of SDMA queues supported on a single node.
This patch updates the test to make it run on systems with more than
16 KFD nodes.

Signed-off-by: Mukul Joshi <mukul.joshi@amd.com>
Change-Id: I561d0cdef664cae84fb9c13a801052e2001256e5


[ROCm/ROCR-Runtime commit: b81e45f03c]
2024-09-30 11:28:33 -04:00
Julia Jiang 493e9c7884 SWDEV-412099 - Fix CTS clFillImage sub-tests failures
Change-Id: I082476837c539e6ccf93cba6b1e97aae2509e65c


[ROCm/clr commit: 17c8b9f855]
2024-09-30 11:13:52 -04:00
Julia Jiang 17c8b9f855 SWDEV-412099 - Fix CTS clFillImage sub-tests failures
Change-Id: I082476837c539e6ccf93cba6b1e97aae2509e65c
2024-09-30 11:13:52 -04:00
Charis Poag 986c8e09ef Merge amd-staging into amd-master 20240930
Change-Id: I814a16d5e1f9371e00dbbb3623dc975ab2359f44
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/rocm_smi_lib commit: 28c2cc3298]
2024-09-30 10:56:18 -04:00
Charis Poag 28c2cc3298 Merge amd-staging into amd-master 20240930
Change-Id: I814a16d5e1f9371e00dbbb3623dc975ab2359f44
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2024-09-30 10:56:18 -04:00
Branislav Brzak 6a9b977def SWDEV-478034 - Unable to link to hipGraphExecNodeSetParams
Change-Id: I0b6b8d1a4281ecda3c1789d8829ade9771aed741


[ROCm/clr commit: 939c788779]
2024-09-30 02:13:43 -04:00
Branislav Brzak 939c788779 SWDEV-478034 - Unable to link to hipGraphExecNodeSetParams
Change-Id: I0b6b8d1a4281ecda3c1789d8829ade9771aed741
2024-09-30 02:13:43 -04:00
Anusha GodavarthySurya c0ceb1cf12 SWDEV-477324 - Capture Memcpy1D pinned H2D D2H
Change-Id: I1f4744f20a9caeed005ec68da44e5fde737e09f7


[ROCm/clr commit: 742b0210d3]
2024-09-30 01:01:30 -04:00
Anusha GodavarthySurya 742b0210d3 SWDEV-477324 - Capture Memcpy1D pinned H2D D2H
Change-Id: I1f4744f20a9caeed005ec68da44e5fde737e09f7
2024-09-30 01:01:30 -04:00
Vladana Stojiljkovic 887b11894b SWDEV-482086 - Fix hipGraphInstantiate leak
* In a scenario where kernel is launched with hipExtLaunchKernelGGL and stop event is used, hipGraphInstantiate leaks. Since stop event is used, profiling is enabled and Timestamp (ReferencedCountedObject) is created, but it doesn't get released.
* The idea behind this solution is that profiling should be disabled when command is captured, hence the timestamp should not be created. Because information about capturing isn't available when kernel command is created, packet capturing state is used to determine whether to create a timestamp or not.

Change-Id: Ia23adac4592ded4fb5e236acf99e12e729f63692


[ROCm/clr commit: da5f1a6146]
2024-09-29 11:36:53 -04:00
Vladana Stojiljkovic da5f1a6146 SWDEV-482086 - Fix hipGraphInstantiate leak
* In a scenario where kernel is launched with hipExtLaunchKernelGGL and stop event is used, hipGraphInstantiate leaks. Since stop event is used, profiling is enabled and Timestamp (ReferencedCountedObject) is created, but it doesn't get released.
* The idea behind this solution is that profiling should be disabled when command is captured, hence the timestamp should not be created. Because information about capturing isn't available when kernel command is created, packet capturing state is used to determine whether to create a timestamp or not.

Change-Id: Ia23adac4592ded4fb5e236acf99e12e729f63692
2024-09-29 11:36:53 -04:00
Jaydeep Patel 98539759f1 SWDEV-483436 - User spt stream as def with -fgpu-default-stream=per-thread for hipMemsetAsync.
Change-Id: Ia85c2b4c40fc9250754d3b64fb9fd1c615362572


[ROCm/clr commit: d6193a2f23]
2024-09-29 01:42:33 -04:00
Jaydeep Patel d6193a2f23 SWDEV-483436 - User spt stream as def with -fgpu-default-stream=per-thread for hipMemsetAsync.
Change-Id: Ia85c2b4c40fc9250754d3b64fb9fd1c615362572
2024-09-29 01:42:33 -04:00
Jeffrey Novotny c470fd1cc4 Correct link to rocprofiler-sdk GitHub (#1097)
[ROCm/rocprofiler-sdk commit: 78fe20320f]
2024-09-27 21:03:49 -06:00
Jeffrey Novotny 78fe20320f Correct link to rocprofiler-sdk GitHub (#1097) 2024-09-27 21:03:49 -06:00
Benjamin Welton d01b3e1a33 [rocprofv3] Do not fetch metrics for CPU agents (#1101)
Skip CPU agents when fetching metrics. Only fetch metrics for GPU
agents.

Co-authored-by: Benjamin Welton <ben@amd.com>

[ROCm/rocprofiler-sdk commit: 0c4a583e23]
2024-09-27 21:03:18 -06:00
Benjamin Welton 0c4a583e23 [rocprofv3] Do not fetch metrics for CPU agents (#1101)
Skip CPU agents when fetching metrics. Only fetch metrics for GPU
agents.

Co-authored-by: Benjamin Welton <ben@amd.com>
2024-09-27 21:03:18 -06:00
itrowbri acb3a65007 Updated validation of aborted-app test to use hipExtHostAlloc (#1103)
* Updated validation of aborted-app test to use hipExtHostAlloc now that tracing for this command is supported

* Updated CHANGELOG

[ROCm/rocprofiler-sdk commit: 5dd2f94f74]
2024-09-27 21:02:00 -06:00
itrowbri 5dd2f94f74 Updated validation of aborted-app test to use hipExtHostAlloc (#1103)
* Updated validation of aborted-app test to use hipExtHostAlloc now that tracing for this command is supported

* Updated CHANGELOG
2024-09-27 21:02:00 -06:00
David Galiffi df9f80e145 Rename to ROCm Systems Profiler (rocprof-sys) (#1)
Rename to ROCm Systems Profiler (rocprof-sys)

[ROCm/rocprofiler-systems commit: f3c699ea61]
2024-09-27 17:18:21 -04:00
David Galiffi f3c699ea61 Rename to ROCm Systems Profiler (rocprof-sys) (#1)
Rename to ROCm Systems Profiler (rocprof-sys)
2024-09-27 17:18:21 -04:00
coleramos425 0c079e3068 Remove unrelease prefix from CHANGELOG
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: e497928dee]
2024-09-27 16:16:21 -05:00
coleramos425 e497928dee Remove unrelease prefix from CHANGELOG
Signed-off-by: coleramos425 <colramos@amd.com>
2024-09-27 16:16:21 -05:00
cfallows-amd bd8e22adc4 Update VERSION, CHANGELOG, and README citation for next release (#433)
Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>

[ROCm/rocprofiler-compute commit: cf1b699ba7]
2024-09-27 16:16:21 -05:00
cfallows-amd cf1b699ba7 Update VERSION, CHANGELOG, and README citation for next release (#433)
Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>
2024-09-27 16:16:21 -05:00
Cole Ramos 29d8243d04 Tarball on rocm tags and MAINTAINERS guide (#402)
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure

Signed-off-by: coleramos425 <colramos@amd.com>

* Apply linting feedback

Signed-off-by: coleramos425 <colramos@amd.com>

* Update links in MAINTAINERS for new branches

Signed-off-by: coleramos425 <colramos@amd.com>

* Update MAINTAINERS.md for changelog formatting

Signed-off-by: coleramos425 <colramos@amd.com>

* Update Omniperf ver checker to allow tags with rocm- prefix

Signed-off-by: coleramos425 <colramos@amd.com>

* Add step to packaging workflow to upload release tarball to release

Signed-off-by: coleramos425 <colramos@amd.com>

* Synax change for release name in packaging action

Signed-off-by: coleramos425 <colramos@amd.com>

* Update MAINTAINERS for instuctions on ROCm releases

Signed-off-by: coleramos425 <colramos@amd.com>

* Update softprops pluvin to v2 and remove release name

Removing the release name enables us to modify an existing release with the matching tag

Signed-off-by: coleramos425 <colramos@amd.com>

* Remove draft option on softprops plugin

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: d2e806d1aa]
2024-09-27 16:16:21 -05:00
Cole Ramos d2e806d1aa Tarball on rocm tags and MAINTAINERS guide (#402)
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure

Signed-off-by: coleramos425 <colramos@amd.com>

* Apply linting feedback

Signed-off-by: coleramos425 <colramos@amd.com>

* Update links in MAINTAINERS for new branches

Signed-off-by: coleramos425 <colramos@amd.com>

* Update MAINTAINERS.md for changelog formatting

Signed-off-by: coleramos425 <colramos@amd.com>

* Update Omniperf ver checker to allow tags with rocm- prefix

Signed-off-by: coleramos425 <colramos@amd.com>

* Add step to packaging workflow to upload release tarball to release

Signed-off-by: coleramos425 <colramos@amd.com>

* Synax change for release name in packaging action

Signed-off-by: coleramos425 <colramos@amd.com>

* Update MAINTAINERS for instuctions on ROCm releases

Signed-off-by: coleramos425 <colramos@amd.com>

* Update softprops pluvin to v2 and remove release name

Removing the release name enables us to modify an existing release with the matching tag

Signed-off-by: coleramos425 <colramos@amd.com>

* Remove draft option on softprops plugin

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: coleramos425 <colramos@amd.com>
2024-09-27 16:16:21 -05:00
xuchen-amd 94bfc825e9 Add the ability to determine GPU model from Chip ID (#423)
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add support for MI300X_A1

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove MI308X identification using num CUs, and format Python using black.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add Read the Docs

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add sphinx requirement

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove gpu_model identification using gpu_arch

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Fix Python formatting using black.

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>

[ROCm/rocprofiler-compute commit: c9773c157e]
2024-09-27 16:16:21 -05:00
xuchen-amd c9773c157e Add the ability to determine GPU model from Chip ID (#423)
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add support for MI300X_A1

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove MI308X identification using num CUs, and format Python using black.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add Read the Docs

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add sphinx requirement

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove gpu_model identification using gpu_arch

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Fix Python formatting using black.

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
2024-09-27 16:16:21 -05:00
Daniel Su 73adb18439 External CI: enable CI triggers (#426)
Signed-off-by: Daniel Su <danielsu@amd.com>

[ROCm/rocprofiler-compute commit: 99680a7833]
2024-09-27 16:16:21 -05:00