Commit Graph

64521 Commits

Author SHA1 Message Date
Hila, Nino 38d48c9a7d Add palamida.yml (#215) 2025-04-23 13:15:09 -07:00
Tony Gutierrez f2c482d923 rocr: Add large_bar_enabled var to the GPU agent
Adds a bool to the GPU agent and a public member method to
check if the GPU supports large BAR. This is needed so we can
check if large BAR is supported when a user tries to allocate
an AQL queue in device memory on a given GPU agent.

Also adds an exception to the AQL queue if device-side AQL queues
are requested and the GPU owner of the AQL doesn't support large
BAR. Otherwise, ROCr will currently allow device-side queues
that can cause faults when the user tries to touch their ring
buffers and the user will not know why the faults are occuring.

This relies on the fact that the KFD does not exposed any links
from the CPU to the GPU if large BAR is not enabled (though
links from the GPU to the CPU may still be exposed by the KFD).
2025-04-23 15:53:29 -04:00
Tony Gutierrez ce61e3301b rocr: Add large_bar_enabled var to the GPU agent
Adds a bool to the GPU agent and a public member method to
check if the GPU supports large BAR. This is needed so we can
check if large BAR is supported when a user tries to allocate
an AQL queue in device memory on a given GPU agent.

Also adds an exception to the AQL queue if device-side AQL queues
are requested and the GPU owner of the AQL doesn't support large
BAR. Otherwise, ROCr will currently allow device-side queues
that can cause faults when the user tries to touch their ring
buffers and the user will not know why the faults are occuring.

This relies on the fact that the KFD does not exposed any links
from the CPU to the GPU if large BAR is not enabled (though
links from the GPU to the CPU may still be exposed by the KFD).


[ROCm/ROCR-Runtime commit: f2c482d923]
2025-04-23 15:53:29 -04:00
Tony Gutierrez 6e3c375bf1 rocr: Flags to alloc queue buf/struct in dev mem
This builds on a prior change that allowed for allocating
a user-mode queue's packet buffer in device memory to also
allocate the queue struct in device memory. This provides
additional latency benefits particularly for cases where
dispatches are performed from the GPU itself. Flags are
added to support the various use cases.
2025-04-23 15:53:29 -04:00
Tony Gutierrez 6f37386eb2 rocr: Flags to alloc queue buf/struct in dev mem
This builds on a prior change that allowed for allocating
a user-mode queue's packet buffer in device memory to also
allocate the queue struct in device memory. This provides
additional latency benefits particularly for cases where
dispatches are performed from the GPU itself. Flags are
added to support the various use cases.


[ROCm/ROCR-Runtime commit: 6e3c375bf1]
2025-04-23 15:53:29 -04:00
Tony Gutierrez 11d1d2cd25 rocr: Remove empty shared.cpp 2025-04-23 15:53:29 -04:00
Tony Gutierrez 18404ba8a8 rocr: Remove empty shared.cpp
[ROCm/ROCR-Runtime commit: 11d1d2cd25]
2025-04-23 15:53:29 -04:00
Tony Gutierrez adbc0495e2 rocr/libhsakmt: Add coarse-grain allocator to GPU 2025-04-23 15:53:29 -04:00
Tony Gutierrez 3ebcf3020f rocr/libhsakmt: Add coarse-grain allocator to GPU
[ROCm/ROCR-Runtime commit: adbc0495e2]
2025-04-23 15:53:29 -04:00
Sang, Tao 60110b6c01 SWDEV-518831 - fix streams' sync issue in mthreads (#123)
* SWDEV-518831 - fix streams' sync issue in mthreads

1. Fix sync issue of null stream and non-null streams in
multithreads.
2. Remove assert(GetSubmissionBatch() == nullptr) as it
is invalid in multithreads.
3. Update getActiveQueues() to deal with the state of 
being terminated.

[ROCm/clr commit: 27aad09bd4]
2025-04-23 15:08:07 -04:00
Sang, Tao 27aad09bd4 SWDEV-518831 - fix streams' sync issue in mthreads (#123)
* SWDEV-518831 - fix streams' sync issue in mthreads

1. Fix sync issue of null stream and non-null streams in
multithreads.
2. Remove assert(GetSubmissionBatch() == nullptr) as it
is invalid in multithreads.
3. Update getActiveQueues() to deal with the state of 
being terminated.
2025-04-23 15:08:07 -04:00
Sang, Tao 45b75013ec SWDEV-516050 - Fix monitor hang in OCL (#75)
Fix monitor hang in cts integer_ops.
Improve notify().
Won't affect notifyAll() and Hip in direct
dispatch mode.

Change-Id: I95a458358e1cab9c76aefde117db09cdbd1fd3af

[ROCm/clr commit: 78f92901d8]
2025-04-23 14:34:53 -04:00
Sang, Tao 78f92901d8 SWDEV-516050 - Fix monitor hang in OCL (#75)
Fix monitor hang in cts integer_ops.
Improve notify().
Won't affect notifyAll() and Hip in direct
dispatch mode.

Change-Id: I95a458358e1cab9c76aefde117db09cdbd1fd3af
2025-04-23 14:34:53 -04:00
Sang, Tao 17369ea4e3 SWDEV-507388 - Check image support. (#6)
Change-Id: Ieda106374eb066cd22ddd1194a9f9b1352c26d16

[ROCm/hip-tests commit: 7bc6eda321]
2025-04-23 21:20:13 +05:30
Sang, Tao 7bc6eda321 SWDEV-507388 - Check image support. (#6)
Change-Id: Ieda106374eb066cd22ddd1194a9f9b1352c26d16
2025-04-23 21:20:13 +05:30
Xie, Jiabao(Jimbo) c7737558a4 SWDEV-441487 - add gfx1150/1 support to amd-staging clr (#182)
Co-authored-by: Jimbo Xie <jiabaxie@amd.com>

[ROCm/clr commit: 9a8c9e70b2]
2025-04-23 20:43:03 +05:30
Xie, Jiabao(Jimbo) 9a8c9e70b2 SWDEV-441487 - add gfx1150/1 support to amd-staging clr (#182)
Co-authored-by: Jimbo Xie <jiabaxie@amd.com>
2025-04-23 20:43:03 +05:30
Hila, Nino df7597851a Add palamida.yml (#11)
[ROCm/rocminfo commit: 61eb6895dc]
2025-04-22 15:55:03 -07:00
Hila, Nino 61eb6895dc Add palamida.yml (#11) 2025-04-22 15:55:03 -07:00
Choudhary, Rahul 8e495d03ba Create palamida.yml to enable Palamida scan (#8)
[ROCm/rocm-core commit: baedf5d388]
2025-04-22 15:49:32 -07:00
Choudhary, Rahul baedf5d388 Create palamida.yml to enable Palamida scan (#8) 2025-04-22 15:49:32 -07:00
Choudhary, Rahul 6dd08920ff Add palamida.yml (#47)
[ROCm/rocm_smi_lib commit: 2b8e118028]
2025-04-22 15:45:26 -07:00
Choudhary, Rahul 2b8e118028 Add palamida.yml (#47) 2025-04-22 15:45:26 -07:00
Choudhary, Rahul 05b8837d4e Create palamida.yml to enable Palamida scan
[ROCm/rocm-core commit: e3cf8dc4a3]
2025-04-22 15:44:14 -07:00
Choudhary, Rahul e3cf8dc4a3 Create palamida.yml to enable Palamida scan 2025-04-22 15:44:14 -07:00
xuchen-amd 703dc4d6ad process hip trace output. (#654)
Signed-off-by: xuchen-amd <xuchen@amd.com>

[ROCm/rocprofiler-compute commit: ee73c2a119]
2025-04-22 18:31:47 -04:00
xuchen-amd ee73c2a119 process hip trace output. (#654)
Signed-off-by: xuchen-amd <xuchen@amd.com>
2025-04-22 18:31:47 -04:00
xuchen-amd 39c53aadda Patch in new rocprofv3 metrics. (#679)
[ROCm/rocprofiler-compute commit: f145f89e30]
2025-04-22 18:30:26 -04:00
xuchen-amd f145f89e30 Patch in new rocprofv3 metrics. (#679) 2025-04-22 18:30:26 -04:00
Poag, Charis 25e0678501 [SWDEV-528097] Unique ID fix for missing ID in KGD -> use KFD's (#44)
Changes:
 - Unique Id tries reading from KGD
   -> falls back to use KFD if not found

Change-Id: I8fb8f38df5db7413805f4a20621ad12ed3fc89a3
Signed-off-by: Charis Poag <Charis.Poag@amd.com>

[ROCm/rocm_smi_lib commit: 4276207ff8]
2025-04-22 16:37:23 -05:00
Poag, Charis 4276207ff8 [SWDEV-528097] Unique ID fix for missing ID in KGD -> use KFD's (#44)
Changes:
 - Unique Id tries reading from KGD
   -> falls back to use KFD if not found

Change-Id: I8fb8f38df5db7413805f4a20621ad12ed3fc89a3
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2025-04-22 16:37:23 -05:00
Saleel Kudchadker 57c0c643ce rocr: return preferred SDMA engine mask
- Add a new AMD extension API to return preferred SDMA engine mask.
This can use used in conjunction with copy_on_engine API to get
optimal bandwidth.
2025-04-22 13:28:38 -07:00
Saleel Kudchadker 945d6da90b rocr: return preferred SDMA engine mask
- Add a new AMD extension API to return preferred SDMA engine mask.
This can use used in conjunction with copy_on_engine API to get
optimal bandwidth.


[ROCm/ROCR-Runtime commit: 57c0c643ce]
2025-04-22 13:28:38 -07:00
cfallows-amd 187aa63259 Update runner distro in Formatting workflow (#678)
Update formatting workflow to use 22.04. 20.04 deprecated last week.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 346c7e452a]
2025-04-22 16:14:15 -04:00
cfallows-amd 346c7e452a Update runner distro in Formatting workflow (#678)
Update formatting workflow to use 22.04. 20.04 deprecated last week.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-04-22 16:14:15 -04:00
Trowbridge, Ian 3b63300a67 Video file location change for rocDecode (#353)
* Video file location change for rocDecode

* Formatting

* Changed rocJPEG images directory not found to a warning as well

* Minor name update

* Fix rocJPEG disable variable

[ROCm/rocprofiler-sdk commit: c4716afd1c]
2025-04-22 14:09:01 -05:00
Trowbridge, Ian c4716afd1c Video file location change for rocDecode (#353)
* Video file location change for rocDecode

* Formatting

* Changed rocJPEG images directory not found to a warning as well

* Minor name update

* Fix rocJPEG disable variable
2025-04-22 14:09:01 -05:00
GunaShekar, Ajay 34d3f7022b SWDEV-523281 - CHANGELOG.md and negative test return values : hipLaunchKernelEx, hipLaunchKernelExC, hipDrvLaunchKernelEx (#155)
[ROCm/clr commit: 64d6f5714a]
2025-04-22 21:47:37 +05:30
GunaShekar, Ajay 64d6f5714a SWDEV-523281 - CHANGELOG.md and negative test return values : hipLaunchKernelEx, hipLaunchKernelExC, hipDrvLaunchKernelEx (#155) 2025-04-22 21:47:37 +05:30
Hila, Nino 6a1c7d8e43 Add palamida.yml 2025-04-22 11:06:25 -05:00
Hila, Nino 8095ce6cee Add palamida.yml
[ROCm/rdc commit: 6a1c7d8e43]
2025-04-22 11:06:25 -05:00
Hila, Nino 4f0e809bf9 Add palamida.yml
[ROCm/rocm_smi_lib commit: 461e5dbc11]
2025-04-22 12:01:04 -04:00
Hila, Nino 461e5dbc11 Add palamida.yml 2025-04-22 12:01:04 -04:00
Hila, Nino a080571adc Add palamida.yml
[ROCm/rocm-core commit: 7de7ec43bb]
2025-04-22 12:00:55 -04:00
Hila, Nino 7de7ec43bb Add palamida.yml 2025-04-22 12:00:55 -04:00
Andryeyev, German f8344154a0 SWDEV-497841 - Enable memory manager by default (#149)
[ROCm/clr commit: a5c860f3b0]
2025-04-22 21:20:37 +05:30
Andryeyev, German a5c860f3b0 SWDEV-497841 - Enable memory manager by default (#149) 2025-04-22 21:20:37 +05:30
Andryeyev, German 0569c7713c SWDEV-523300 - Add the new option to build HIP (#179)
Add the new cmake option AMD_COMPUTE_WIN  to build HIP on Windows
from the public github. AMD_COMPUTE_WIN should point to a special
repo with the PAL static libs

[ROCm/clr commit: a3effa16f1]
2025-04-22 21:05:04 +05:30
Andryeyev, German a3effa16f1 SWDEV-523300 - Add the new option to build HIP (#179)
Add the new cmake option AMD_COMPUTE_WIN  to build HIP on Windows
from the public github. AMD_COMPUTE_WIN should point to a special
repo with the PAL static libs
2025-04-22 21:05:04 +05:30
Bhardwaj, Gopesh 93abda4cfd Copilot suggestions (#360)
* Copilot suggestions

* Fixing perfetto links

* correcting default value of agent-index

[ROCm/rocprofiler-sdk commit: 1f1c192a5e]
2025-04-22 20:52:37 +05:30