İşleme Grafiği

1034 İşleme

Yazar SHA1 Mesaj Tarih
Sam Wu c95cfc9bd8 Update documentation requirements (#540)
[ROCm/rocprofiler-compute commit: f58070aff1]
2025-01-24 16:34:03 -07:00
cfallows-amd a64129b34f Add ubuntu 24.04 detection for roofline bin loading. (#541)
Also updated docker script for dev usage.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 7602341b70]
2025-01-23 19:53:50 -05:00
ywang103-amd 8079e2e10b enable rocprofv3 for all old soc architectures (#539)
* enable rocprofv3 for all old soc archetectures

* remove gfx906 from rocprofv3

[ROCm/rocprofiler-compute commit: 713570908a]
2025-01-23 15:37:00 -05:00
Cole Ramos c5c44a9cba Yearly license update (#538)
* Add license template designation

Signed-off-by: coleramos425 <colramos@amd.com>

* Update license year on *.py

Signed-off-by: coleramos425 <colramos@amd.com>

* Update license year on *.sh

Signed-off-by: coleramos425 <colramos@amd.com>

* Update license year on misc files

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 34760ff814]
2025-01-23 13:09:32 -06:00
Peter Park 4b097e6832 Specify path to sphinx configuration in .readthedocs.yaml (#536)
[ROCm/rocprofiler-compute commit: 5063e14309]
2025-01-22 15:22:26 -05:00
Peter Park 737feed972 update LICENSE year to 2025 (#530)
[ROCm/rocprofiler-compute commit: bb388b03f1]
2025-01-22 07:03:28 -08:00
dependabot[bot] b0eac39957 Bump rocm-docs-core from 1.12.0 to 1.13.0 in /docs/sphinx (#526)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.12.0...v1.13.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: c99d4525ef]
2025-01-22 07:03:19 -08:00
ywang103-amd 15744be6fc made change on the logic to add roofline file to expected csv list to fix crash on mi100 (#528)
[ROCm/rocprofiler-compute commit: 0dfb87f25f]
2025-01-22 07:03:13 -08:00
vedithal-amd 25888acd3c Quick fix for mpi_support (#527)
[ROCm/rocprofiler-compute commit: c5fec31535]
2025-01-22 07:03:07 -08:00
vedithal-amd 69283cb155 Docker environment for testing (#515)
* Add instructions on how to use Docker for manual and automatic testing

[ROCm/rocprofiler-compute commit: 5e90797b24]
2025-01-22 07:02:59 -08:00
Cole Ramos 5a7cb724ce Sync staging with mainline (#524)
* External CI: rename pipeline to rocprofiler-compute (#463)

Signed-off-by: Daniel Su <danielsu@amd.com>

* Update webui branding (#459)

* Update name and icon for browser tab to rocprofiler-compute.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Update name and icon for browser tab to rocprofiler-compute.

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Update branding in documentation (#442)

* find/replace Omniperf to ROCm Compute Profiler

Signed-off-by: Peter Park <peter.park@amd.com>

* update name in Sphinx conf

Signed-off-by: Peter Park <peter.park@amd.com>

* mv what-is-omniperf.rst -> what-is-rocprof-compute.rst

Signed-off-by: Peter Park <peter.park@amd.com>

* update Tutorials section

Signed-off-by: Peter Park <peter.park@amd.com>

* add Omniperf as keyword to Conceptual section for internal search

Signed-off-by: Peter Park <peter.park@amd.com>

* update Reference section

Signed-off-by: Peter Park <peter.park@amd.com>

* black fmt conf.py

Signed-off-by: Peter Park <peter.park@amd.com>

* update profile mode and basic usage subsections

Signed-off-by: Peter Park <peter.park@amd.com>

* update how to use analyze mode subsection

Signed-off-by: Peter Park <peter.park@amd.com>

* update install section

Signed-off-by: Peter Park <peter.park@amd.com>

* fix sphinx warnings

Signed-off-by: Peter Park <peter.park@amd.com>

* fix cmd line examples in profile/mode.rst

Signed-off-by: Peter Park <peter.park@amd.com>

* update install decision tree image

Signed-off-by: Peter Park <peter.park@amd.com>

* fix TOC and index

Signed-off-by: Peter Park <peter.park@amd.com>

fix weird wording

* fix cli text: deriving rocprofiler-compute metrics...

Signed-off-by: Peter Park <peter.park@amd.com>

* update standalone-gui.rst

Signed-off-by: Peter Park <peter.park@amd.com>

* restore removed doc updates from #428

Signed-off-by: Peter Park <peter.park@amd.com>

* update ref to Omniperf in index.rst

Signed-off-by: Peter Park <peter.park@amd.com>

* fix grafana connection name to match image

Signed-off-by: Peter Park <peter.park@amd.com>

* update cmds in tutorials

Signed-off-by: Peter Park <peter.park@amd.com>

---------

Signed-off-by: Peter Park <peter.park@amd.com>

* MI300 roofline enablement in rocprofiler-compute (#470)

* MI300 roofline enablement in rocprofiler-compute

requirements.txt
- running some modules complained about numpy version too new, adding extra requirement that numpy be 1.x
pmc_roof_perf.txt
- adding TCC_BUBBLE_sum counter to profile
soc_gfx940.py
soc_gfx941.py
soc_gfx942.py
- remove console logs reading that roofline is temporarily disabled, uncommenting blocks that check for roofline csv and run roofline post-processing
roofline_calc.py
- add mi300 to supported soc
- add new calculation for hbm_data for MI300 using tcc_bubble_sum, checks if counter > 0 to use
- add to a few comments
roofline-ubuntu-20_04-mi300-rocm6
- binary for the ubuntu systems to enable mi300 roofline calculations from rocm-amdgpu-bench

Note- other distros will get roofline bins to enable mi300, but need to be further tested before putting into branch.

Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>

* Reformatting roofline_calc.py

Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>

---------

Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>

* Update Python format checker (#471)

* Add pre commit hook for Python formatting

Signed-off-by: coleramos425 <colramos@amd.com>

* Update formatting workflow to run on latest Python and add isort formatter

Signed-off-by: coleramos425 <colramos@amd.com>

* Fix caught yaml formatting issues

* Update pyproject file

* Add pre-commit hook instruction to CONTRIBUTING guide

* Remove target-version from black pyproject.toml

* Fixed formatting errors found with black and isort

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Run hook: Whitespaces, fix end of file spaces

---------

Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* Bump cryptography from 43.0.0 to 43.0.1 in /docs/sphinx (#473)

Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.0 to 43.0.1.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pyca/cryptography/compare/43.0.0...43.0.1)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix file permission on MI300 roofline binary (#477)

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Removing numpy requirements of <2 (#478)

Checks are failing if version too high and no need for lower version

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Fix crash when loading web UI roofline for gfx942 (#479)

* Fix crash when loading web UI roofline for gfx942

* Fix formatting

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Make same changs for gfx940, gfx942.

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Fix formatting in soc_gfx940 and soc_gfx941.

Signed-off-by: benrichard-amd <ben.richard@amd.com>

---------

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Rebranding name change patch (#469)

* Patch in missed name change for rebranding.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Patch in missed name change for rebranding.

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Move dependabot.yml to .github/ and bump rocm-docs-core (#481)

* Move dependabot.yml to .github/

* Bump rocm-docs-core to 1.8.5

* Bump rocm-docs-core to 1.9.0

* Fix packaging for upgrading (#486)

Specify that "rocprofiler-compute" replaces / obsoletes the "omniperf" package.

* Renamed extension path from omniperf to rocprofiler_compute (#487)

Signed-off-by: Tim Gu <Tim.Gu@amd.com>

* MI300 rhel and sles roofline binaries (#480)

* Roofline bins for MI300 on rhel and sles distributions
Built from rocm-amdgpu-bench, tested on respective distro systems with MI300 hardware.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Minor modifications removing hardcoded variables in roofline files.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Modify test_profile_general.py ctest to include MI300 enablement (#498)

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* part 1 to support rocprofv3 (#492)

* rocprofv3 support initial commit

-Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity
is exceeded and the output CSV file format is different from v1/v2.

* Add rocprofv3 detection so v2 can still be used

It's hacky but it'll do for now.

* Add code path to convert rocprofv3 JSON output into CSV

* Grab correct value for Queue ID

* Use _sum suffix to sum TCC counters

Previously we were specifying each channel for TCC counters. rocprofv3 does
not support specifing each TCC channel, and instead will auto sum given
the TCC counter name. The counter name with the _sum suffix is also
supported and is also supported in v1 and v2. So we will use the TCC
counter name with the _sum suffix.

* Fix incorrect counter outputs when using rocprofv3

In the JSON output some counters appear multime times and must be
summed to get the correct value. These summed values match the
rocprofv3 output in CSV mode and also match the rocprofv2
output.

* Remove duplicate Correlation_ID and Wave_Size in output

* Handle json output that does not contain any dispatches

Omniperf was assuming each JSON output from rocprofv3 would always contain
dispatches. This is not the case. For example, in a multi-process
workload where one of the processes does not dispatch any kernels. A JSON
file will still be output for this process but it will not contain any dispatches.

* Code cleanup

* Update search path for rocprofv3 results

Rocprofv3 was updated to include the hostname in the path where
it outputs results.

* Handle accumulate counters

In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte
counters. v3 does not have this. So we need to define our own counters
in counter_defs.yaml. For this we use the counter name + _ACCUM, for
example SQ_INSTR_LEVEL_SMEM_ACCUM.

To use rocprofv3 you will need to update counter_defs.yaml to include
these new counter definitions.

* Use correct GPU ID

When converting JSON -> CSV we were assigning node_id to GPU_ID. Since
the JSON contains non-GPU devices, the node_id for GPUs might not
start at 0 as expected.

This commit maps the agent ID to the appropriate GPU ID.

* Parse scratch memory per work item from JSON

* Support rocprofv3 CSV parsing

JSON decoding is very slow for large files. Include support for parsing
rocprofv3 CSV output and make that the default.

CSV/JSON can be toggled via the ROCPROF_OUTPUT_FORMAT environment
variable e.g. ROCPROF_OUTPUT_FORMAT=csv or ROCPROF_OUTPUT_FORMAT=json

* black format after merge

* format isort

* change return of rocprof_cmd to try to resolve test's error

* hack to pick last part of rocminfo's name

* debug log of hacks

* Modify test_profile_general.py ctest to include MI300 enablement. Currently failing because of explicitly excluded roofline files for the soc and autofailed asserts for roof-only tests- originally in place because roofline was not enabled on mi300 yet.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* black and isort formated

* corrected line of copyright

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Co-authored-by: benrichard-amd <ben.richard@amd.com>
Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>
Co-authored-by: Carrie Fallows <Carrie.Fallows@amd.com>

* fix for crash of timestamp of part 1 for rocprofv3 (#499)

* fix the error caused by ignoring the lack of counter csv file from rocprofv3 for timestamp

* isort and black formated

* quick fix for gfx906 roofline (#505)

* Multi node support (#503)

* [CTest] Pipeline failures for MI300 (#483)

* Propagate new chip_id logic to testing workflow

Signed-off-by: coleramos425 <colramos@amd.com>

* Add a debug line to tests

Signed-off-by: coleramos425 <colramos@amd.com>

* Trying to set rocprofv2 generally in CTest module

Signed-off-by: coleramos425 <colramos@amd.com>

* Remove temp debugging lines from CI

Signed-off-by: coleramos425 <colramos@amd.com>

* Add roofline entry for MI300 expected files in CI tests

Signed-off-by: coleramos425 <colramos@amd.com>

* Make num_devices modifier global in scope

Signed-off-by: coleramos425 <colramos@amd.com>

* Change kernel name in PyTest to confirm rocprofv2 bug

Related to https://ontrack-internal.amd.com/browse/SWDEV-503453

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: coleramos425 <colramos@amd.com>

* Spatial-multiplexing: part 1 profiling stage (#465)

* rocprofv3 support initial commit

-Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity
is exceeded and the output CSV file format is different from v1/v2.

* Add rocprofv3 detection so v2 can still be used

It's hacky but it'll do for now.

* Add code path to convert rocprofv3 JSON output into CSV

* Grab correct value for Queue ID

* Use _sum suffix to sum TCC counters

Previously we were specifying each channel for TCC counters. rocprofv3 does
not support specifing each TCC channel, and instead will auto sum given
the TCC counter name. The counter name with the _sum suffix is also
supported and is also supported in v1 and v2. So we will use the TCC
counter name with the _sum suffix.

* Fix incorrect counter outputs when using rocprofv3

In the JSON output some counters appear multime times and must be
summed to get the correct value. These summed values match the
rocprofv3 output in CSV mode and also match the rocprofv2
output.

* Remove duplicate Correlation_ID and Wave_Size in output

* Handle json output that does not contain any dispatches

Omniperf was assuming each JSON output from rocprofv3 would always contain
dispatches. This is not the case. For example, in a multi-process
workload where one of the processes does not dispatch any kernels. A JSON
file will still be output for this process but it will not contain any dispatches.

* Code cleanup

* Update search path for rocprofv3 results

Rocprofv3 was updated to include the hostname in the path where
it outputs results.

* Handle accumulate counters

In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte
counters. v3 does not have this. So we need to define our own counters
in counter_defs.yaml. For this we use the counter name + _ACCUM, for
example SQ_INSTR_LEVEL_SMEM_ACCUM.

To use rocprofv3 you will need to update counter_defs.yaml to include
these new counter definitions.

* debug code

* add logic code for multiplexing

* minor fix

* more fixes

* rocprofv3 support initial commit

-Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity
is exceeded and the output CSV file format is different from v1/v2.

* Add rocprofv3 detection so v2 can still be used

It's hacky but it'll do for now.

* Add code path to convert rocprofv3 JSON output into CSV

* Grab correct value for Queue ID

* Use _sum suffix to sum TCC counters

Previously we were specifying each channel for TCC counters. rocprofv3 does
not support specifing each TCC channel, and instead will auto sum given
the TCC counter name. The counter name with the _sum suffix is also
supported and is also supported in v1 and v2. So we will use the TCC
counter name with the _sum suffix.

* Fix incorrect counter outputs when using rocprofv3

In the JSON output some counters appear multime times and must be
summed to get the correct value. These summed values match the
rocprofv3 output in CSV mode and also match the rocprofv2
output.

* Remove duplicate Correlation_ID and Wave_Size in output

* Handle json output that does not contain any dispatches

Omniperf was assuming each JSON output from rocprofv3 would always contain
dispatches. This is not the case. For example, in a multi-process
workload where one of the processes does not dispatch any kernels. A JSON
file will still be output for this process but it will not contain any dispatches.

* Code cleanup

* Update search path for rocprofv3 results

Rocprofv3 was updated to include the hostname in the path where
it outputs results.

* Handle accumulate counters

In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte
counters. v3 does not have this. So we need to define our own counters
in counter_defs.yaml. For this we use the counter name + _ACCUM, for
example SQ_INSTR_LEVEL_SMEM_ACCUM.

To use rocprofv3 you will need to update counter_defs.yaml to include
these new counter definitions.

* count accu files as well

* Use correct GPU ID

When converting JSON -> CSV we were assigning node_id to GPU_ID. Since
the JSON contains non-GPU devices, the node_id for GPUs might not
start at 0 as expected.

This commit maps the agent ID to the appropriate GPU ID.

* fix error with csv file parse from json and merge during post-processing

* implemented parsing of csv files from v3 output for optimization

* Parse scratch memory per work item from JSON

* Support rocprofv3 CSV parsing

JSON decoding is very slow for large files. Include support for parsing
rocprofv3 CSV output and make that the default.

CSV/JSON can be toggled via the ROCPROF_OUTPUT_FORMAT environment
variable e.g. ROCPROF_OUTPUT_FORMAT=csv or ROCPROF_OUTPUT_FORMAT=json

* black format after merge

* format isort

* change return of rocprof_cmd to try to resolve test's error

* hack to pick last part of rocminfo's name

* debug log of hacks

* Modify test_profile_general.py ctest to include MI300 enablement. Currently failing because of explicitly excluded roofline files for the soc and autofailed asserts for roof-only tests- originally in place because roofline was not enabled on mi300 yet.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* black and isort formated

* formated by isort and black

* change default rocprof's output to csv

* repaired crash caused by missing csv counter file when running for timestamp

* change name to spatial-multiplexing from multiplexing

* make necessary modification for review

* set the value of spatial_multiplexing in argument defautly to None

* repair the part that blocks regular pmc files' generation

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Co-authored-by: benrichard-amd <ben.richard@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>
Co-authored-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Simple fix for gpu model value. (#508)

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add FP64 to plot adhering to pdf name (#507)

* Replacing FP32-only plot with an FP32&FP64 combo plot. Results will likely be negligible but the plot name indicates both should be graphed.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Remove duplicate AI plot to clean up fp32 fp64 graph

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Add gpu series for roofline (#510)

* Add gpu_series for roofline.

* Use gpu_series in path names for roofline.

* Fix  TCC on MI200 when introduce rocprofv3 (#509)

* quick fix for v2

* one more fix

* revert a bit

---------

Co-authored-by: ywang103-amd <ywang103@amd.com>

* Bump rocm-docs-core from 1.9.0 to 1.12.0 in /docs/sphinx (#511)

Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.9.0 to 1.12.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.9.0...v1.12.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update sample roofline plot img (#516)

* Modify path to use gpu_model instead of gpu_series to match other workload directory path creation/search points. Affects manual testing, does not seem to affect ctests. (#513)

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Improve formatting when displaying rocprof command. (#476)

* Improve formatting when displaying rocprof command.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Fix python formatting.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Strip unwanted characters (rocprofv1 specific) from rocprof commands.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Strip unwanted characters (rocprofv1 specific) from rocprof commands.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Save the unmodified arguments for rocprof for debug message display.

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>

* quick fix for mpi_support (#518)

* Pass accumulate counters to rocprofv3 using -E option (#522)

rocprofv3 has a new -E option where extra counters can be passed (see accum_counters.yaml) instead
of defining them in counter_defs.yaml.

* Unify all file handling with pathlib (#512)

* Replace occurences of os.path functions with equivalent functions from
  pathlib library

* Remove unwanted imports of os.path and os

* Add coding guidelines for using pathlib instead of os.path

* Auto sync staging and mainline on a weekly cadence (#517)

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: Daniel Su <danielsu@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: Peter Park <peter.park@amd.com>
Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com>
Signed-off-by: Tim Gu <Tim.Gu@amd.com>
Co-authored-by: Daniel Su <danielsu@amd.com>
Co-authored-by: xuchen-amd <xuchen@amd.com>
Co-authored-by: Peter Park <peter.park@amd.com>
Co-authored-by: cfallows-amd <Carrie.Fallows@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Richard <143630488+benrichard-amd@users.noreply.github.com>
Co-authored-by: Tim Gu <Tim.Gu@amd.com>
Co-authored-by: ywang103-amd <ywang103@amd.com>
Co-authored-by: benrichard-amd <ben.richard@amd.com>
Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>
Co-authored-by: Fei Zheng <44449748+feizheng10@users.noreply.github.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Co-authored-by: vedithal-amd <Vignesh.Edithal@amd.com>

[ROCm/rocprofiler-compute commit: 272e5b6e32]
2025-01-02 15:29:47 -06:00
David Galiffi 38da6b266a Merge branch 'amd-staging' into dgaliffi/sync-main-with-stg
Signed-off-by: David Galiffi <David.Galiffi@amd.com>


[ROCm/rocprofiler-compute commit: f0ccace29b]
2024-11-05 11:21:47 -05:00
Fei Zheng 03ffa7a756 Merge pull request #460 from feizheng10/doc_warp_efficency
Fix PoP of VALU Active Threads with wave_size

[ROCm/rocprofiler-compute commit: b4f9b38e99]
2024-11-05 09:00:59 -07:00
Peter Park 5a30a05800 Fix changelog heading
Signed-off-by: Peter Park <peter.park@amd.com>


[ROCm/rocprofiler-compute commit: 6a381d8966]
2024-11-05 09:07:57 -05:00
fei.zheng f1c9c686ff fix PoP of VALU Active Threads with wave_size
Signed-off-by: fei.zheng <fei.zheng@amd.com>


[ROCm/rocprofiler-compute commit: 1b37572b4a]
2024-11-04 14:31:52 -07:00
David Galiffi 4e78cf9b8c Install LICENCE to ${CMAKE_INSTALL_DOCDIR} (#458)
* Install LICENSE to ${CMAKE_INSTALL_DOCDIR}
* Update tarball.yml to test for LICENSE file after the install

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: 50755de867]
2024-11-01 17:51:00 -04:00
David Galiffi e43db734fa Update VERSION to 3.0.0 (#457)
* Update VERSION  and README to 3.0.0
* Update version mismatch of profiling data to a warning.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: 152eff0df1]
2024-11-01 15:26:34 -04:00
Cole Ramos 14d90939da Give executable permission to rocprof-compute (#456)
Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 8a88e8bd90]
2024-11-01 14:16:49 -04:00
xuchen-amd 825440e7ba Rename Omniperf to ROCm Compute Profiler (#428)
- Update filenames.
- Update executable to `rocprof-compute` 
- Update update package to `rocprofiler-compute`
- Update name in application output and logs
- Update name in README files
- Update testing and workflows

---------

Signed-off-by: Xuan Chen <xuchen@amd.com>

[ROCm/rocprofiler-compute commit: 31b4de1a38]
2024-11-01 12:20:21 -04:00
Ben Richard b0c7f78ca6 Add broken mclk workaround for all arch (#453)
* Check for missing mclk, use hard-coded values if needed

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Fix typo

Signed-off-by: benrichard-amd <ben.richard@amd.com>

---------

Signed-off-by: benrichard-amd <ben.richard@amd.com>

[ROCm/rocprofiler-compute commit: 2de2faf944]
2024-10-25 17:13:10 -05:00
zichguan-amd 3328cf8d6c Enable baseline comparison between workloads from the same path (#447)
* Enable baseline comparison between workloads from the same path

Signed-off-by: zichguan-amd <zichuan.guan@amd.com>

* Formatting

Signed-off-by: zichguan-amd <zichuan.guan@amd.com>

* Change test to verify baseline works with same path

Signed-off-by: zichguan-amd <zichuan.guan@amd.com>

* Add three-way comparison test case

Signed-off-by: zichguan-amd <zichuan.guan@amd.com>

---------

Signed-off-by: zichguan-amd <zichuan.guan@amd.com>

[ROCm/rocprofiler-compute commit: 13a06f5131]
2024-10-24 12:00:36 -05:00
Ossian O'Reilly e188429f06 Change argparser help from '--list-kernels' (deprecated) to '--list-stats'. (#449)
Signed-off-by: OReilly, Ossian <ooreilly@amd.com>

[ROCm/rocprofiler-compute commit: 5f3c0f0429]
2024-10-21 11:10:12 -05:00
Ben Richard 6b0195f83e Use MI300 chip_id instead of model to detect XCD count (#448)
In a previous change we started using "MI300" for gpu_model instead of the full
"MI300X_A0" or "MI300X_A1", etc.

The XCD detection code was using gpu_model and expecting the full name, causing
the XCD count = 1. Passing chip_id fixes the issue.

Signed-off-by: benrichard-amd <ben.richard@amd.com>

[ROCm/rocprofiler-compute commit: a236fe0412]
2024-10-16 15:41:11 -04:00
coleramos425 38df31b863 Update CODEOWNERS for product team
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: e633d17372]
2024-10-11 20:25:43 +00:00
vstempen a83747166a Documented Docker container OpenSSL abilities being affected by Host network proxy services (#440)
* Documented Docker container OpenSSL abilities being affected by host
network proxy services, causing network certificates verification
problem during Docker container build stage of Grafana server setup.

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>

* Update docs/install/grafana-setup.rst

Co-authored-by: Peter Park <peter.park@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>

---------

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>
Co-authored-by: Peter Park <peter.park@amd.com>

[ROCm/rocprofiler-compute commit: ba94cb8370]
2024-10-07 15:53:48 -04:00
Ben Richard 4da8b0dc46 Skip output lines that have UTF8 decoding error (#441)
* Avoid crash if non-UTF8 character is encountered in output

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Ignore lines with non-UTF-8 characters. Do not print error.

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Remove trailing whitespace

Signed-off-by: benrichard-amd <ben.richard@amd.com>

---------

Signed-off-by: benrichard-amd <ben.richard@amd.com>

[ROCm/rocprofiler-compute commit: fb210abcd0]
2024-10-03 11:27:55 -04:00
Cole Ramos 83de3f34ae Add smart name and notes to triggered releases (#438)
Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: c8a1add54b]
2024-10-01 14:59:38 -05:00
coleramos425 b7d4dd023d Update issue template
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: faaf5bdcfe]
2024-09-30 16:45:42 +00:00
coleramos425 0c079e3068 Remove unrelease prefix from CHANGELOG
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: e497928dee]
2024-09-27 16:16:21 -05:00
cfallows-amd bd8e22adc4 Update VERSION, CHANGELOG, and README citation for next release (#433)
Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>

[ROCm/rocprofiler-compute commit: cf1b699ba7]
2024-09-27 16:16:21 -05:00
Cole Ramos 29d8243d04 Tarball on rocm tags and MAINTAINERS guide (#402)
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure

Signed-off-by: coleramos425 <colramos@amd.com>

* Apply linting feedback

Signed-off-by: coleramos425 <colramos@amd.com>

* Update links in MAINTAINERS for new branches

Signed-off-by: coleramos425 <colramos@amd.com>

* Update MAINTAINERS.md for changelog formatting

Signed-off-by: coleramos425 <colramos@amd.com>

* Update Omniperf ver checker to allow tags with rocm- prefix

Signed-off-by: coleramos425 <colramos@amd.com>

* Add step to packaging workflow to upload release tarball to release

Signed-off-by: coleramos425 <colramos@amd.com>

* Synax change for release name in packaging action

Signed-off-by: coleramos425 <colramos@amd.com>

* Update MAINTAINERS for instuctions on ROCm releases

Signed-off-by: coleramos425 <colramos@amd.com>

* Update softprops pluvin to v2 and remove release name

Removing the release name enables us to modify an existing release with the matching tag

Signed-off-by: coleramos425 <colramos@amd.com>

* Remove draft option on softprops plugin

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: d2e806d1aa]
2024-09-27 16:16:21 -05:00
xuchen-amd 94bfc825e9 Add the ability to determine GPU model from Chip ID (#423)
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add support for MI300X_A1

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove MI308X identification using num CUs, and format Python using black.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add Read the Docs

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add sphinx requirement

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove gpu_model identification using gpu_arch

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Fix Python formatting using black.

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>

[ROCm/rocprofiler-compute commit: c9773c157e]
2024-09-27 16:16:21 -05:00
Daniel Su 73adb18439 External CI: enable CI triggers (#426)
Signed-off-by: Daniel Su <danielsu@amd.com>

[ROCm/rocprofiler-compute commit: 99680a7833]
2024-09-27 16:16:21 -05:00
Peter Park c6696066d6 update package manager install docs to include omniperf in PATH (#420)
Signed-off-by: Peter Jun Park <peter.park@amd.com>

[ROCm/rocprofiler-compute commit: 812a7b7d08]
2024-09-27 16:16:21 -05:00
coleramos425 033cfd8598 Fix typo and CHANGELOG modification
After meeting with the DevOps team, I've added the Unreleased keyword to new CHANGELOG section per their request

Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 369b93bf46]
2024-09-27 16:16:21 -05:00
coleramos425 c078f99740 Rollback Grafana version in Docker container to enable deprecated Angular plugin (#416)
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 66e0418d42]
2024-09-27 16:16:21 -05:00
Cole Ramos 869d1b2ffe Add omniperf suffix to MOD_INSTALL_PATH in docs (#414)
If we don't add the suffix omniperf to the install path then the subsequent instruction of module load omniperf will not work

Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 5bc6b50b0b]
2024-09-27 16:16:21 -05:00
Peter Jun Park 07e048a829 mv changes to changelog.md
Signed-off-by: Peter Jun Park <peter.park@amd.com>


[ROCm/rocprofiler-compute commit: 90d0b82657]
2024-09-27 16:16:21 -05:00
David Galiffi 6c32a8cead Run Workflows on Release Branches (#409)
Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: 369b2063d8]
2024-09-27 16:16:21 -05:00
David Galiffi 95de535c98 Update dependabot.yml target-branch
Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: 3a4da11ff1]
2024-09-27 16:16:21 -05:00
David Galiffi 3aa88c09e5 Remove dev and main branch from workflows. (#404)
* Remove `dev` and `main` branch from workflows.

Update links in documentation.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* `amd-staging` -> `amd-mainline` in docs

Signed-off-by: Peter Jun Park <peter.park@amd.com>

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: Peter Jun Park <peter.park@amd.com>
Co-authored-by: Peter Jun Park <peter.park@amd.com>

[ROCm/rocprofiler-compute commit: 7c7705d2ba]
2024-09-27 16:16:21 -05:00
David Galiffi 3715320b89 Check Python version on application launch (#393)
* Check that the minimum required Python (3.8) version is used.

Prints a descriptive error message, rather than a cryptic import
failure, if minimum Python version is not met.

Internal ticket SWDEV-477233.


* Disable the RPM mangling of shebangs.

The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`.
With this set, omniperf is always using the platform installed version
of python, which is python 3.6 on RHEL 8. Using virtual environments,
like conda, did not work.

* Fix pylint issues

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: cfeea83785]
2024-09-27 16:16:21 -05:00
coleramos425 967dc81a87 Remove unrelease prefix from CHANGELOG
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 5d7af74f85]
2024-09-27 21:15:15 +00:00
cfallows-amd 72877f5544 Update VERSION, CHANGELOG, and README citation for next release (#433)
Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>

[ROCm/rocprofiler-compute commit: ba4429d745]
2024-09-27 16:10:31 -05:00
Cole Ramos ae0ad6560b Tarball on rocm tags and MAINTAINERS guide (#402)
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure

Signed-off-by: coleramos425 <colramos@amd.com>

* Apply linting feedback

Signed-off-by: coleramos425 <colramos@amd.com>

* Update links in MAINTAINERS for new branches

Signed-off-by: coleramos425 <colramos@amd.com>

* Update MAINTAINERS.md for changelog formatting

Signed-off-by: coleramos425 <colramos@amd.com>

* Update Omniperf ver checker to allow tags with rocm- prefix

Signed-off-by: coleramos425 <colramos@amd.com>

* Add step to packaging workflow to upload release tarball to release

Signed-off-by: coleramos425 <colramos@amd.com>

* Synax change for release name in packaging action

Signed-off-by: coleramos425 <colramos@amd.com>

* Update MAINTAINERS for instuctions on ROCm releases

Signed-off-by: coleramos425 <colramos@amd.com>

* Update softprops pluvin to v2 and remove release name

Removing the release name enables us to modify an existing release with the matching tag

Signed-off-by: coleramos425 <colramos@amd.com>

* Remove draft option on softprops plugin

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 0d15023f69]
2024-09-25 17:21:40 +00:00
xuchen-amd 19e9154d10 Add the ability to determine GPU model from Chip ID (#423)
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add support for MI300X_A1

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove MI308X identification using num CUs, and format Python using black.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add Read the Docs

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add sphinx requirement

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove gpu_model identification using gpu_arch

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Fix Python formatting using black.

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>

[ROCm/rocprofiler-compute commit: c48e6e31cf]
2024-09-25 17:21:40 +00:00
Daniel Su 92d8dddb60 External CI: enable CI triggers (#426)
Signed-off-by: Daniel Su <danielsu@amd.com>

[ROCm/rocprofiler-compute commit: 7ff385a105]
2024-09-25 17:21:40 +00:00
Peter Park 86b6c772ee update package manager install docs to include omniperf in PATH (#420)
Signed-off-by: Peter Jun Park <peter.park@amd.com>

[ROCm/rocprofiler-compute commit: ecd69d109b]
2024-09-25 17:21:40 +00:00
coleramos425 d99f2c7626 Fix typo and CHANGELOG modification
After meeting with the DevOps team, I've added the Unreleased keyword to new CHANGELOG section per their request

Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: bc4d386683]
2024-09-25 17:21:40 +00:00
coleramos425 a9935ea9a5 Rollback Grafana version in Docker container to enable deprecated Angular plugin (#416)
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 2aee85cb06]
2024-09-25 17:21:40 +00:00