Commit Graph

1058 Commits

Author SHA1 Message Date
Maneesh Gupta cdb7f8f354 hipMemcpyAsync returns success when trying to copy 0 bytes
Change-Id: I4c0ee7ccc7563e2df657b50356cdd7fec9a1ef15


[ROCm/clr commit: 445de66560]
2018-04-09 12:39:44 +05:30
Laurent Morichetti f22fbe4271 Add support for clang offload bundles and <<<>>> kernel launch.
[ROCm/clr commit: 323caee8d2]
2018-04-04 13:32:33 -07:00
Maneesh Gupta 66006b0ac7 Merge pull request #367 from gargrahul/fix_tex_drv_offset
Fix offset issue in texture driver APIs 

[ROCm/clr commit: c50f3caf5e]
2018-03-16 07:43:48 +05:30
Maneesh Gupta 46ddefedee Apply .clangformat to all repo source files
Change-Id: I7e79c6058f0303f9a98911e3b7dd2e8596079344


[ROCm/clr commit: 9e47fccc89]
2018-03-12 11:29:03 +05:30
Rahul Garg 83fac92815 Set offset value to 0
[ROCm/clr commit: c3d786d810]
2018-03-11 00:12:22 +05:30
Maneesh Gupta ecbb701440 Merge pull request #363 from gargrahul/surface_object_api
Added surface object support

[ROCm/clr commit: eee7fa6072]
2018-03-09 11:50:30 +05:30
Rahul Garg 685260a08a Added hip_surface header file
[ROCm/clr commit: 7c50ae3b04]
2018-03-01 12:22:56 +05:30
Rahul Garg 7272f1608c Added surface object support
[ROCm/clr commit: 92283d24d0]
2018-02-26 11:59:03 +05:30
Alex Voicu c4d704b2ad Change directory name to match HIP lowercase style.
[ROCm/clr commit: 696f0595a3]
2018-02-22 13:15:10 +00:00
Alex Voicu 4e8e090839 Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_purge_genco
[ROCm/clr commit: 1563d53c92]
2018-02-22 12:08:52 +00:00
Siu Chi Chan 9fddf100b7 make HIP to load the GPU objects and to setup the function symbol map on startup
[ROCm/clr commit: 0ca9591e55]
2018-02-18 14:26:44 -05:00
Alex Voicu eab8624938 Re-sync with upstream.
[ROCm/clr commit: a704bd8b44]
2018-02-12 20:20:24 +00:00
Maneesh Gupta 2dc84aeaf9 Merge pull request #321 from gargrahul/hipMemcpyArray_Functions
Added support for hipMemcpy Array functions-

[ROCm/clr commit: 647d1ba310]
2018-02-12 10:36:38 +05:30
Maneesh Gupta c6562bc2d2 Merge pull request #350 from gargrahul/fix_module_host_global_symbol
Fixed host allocated globals address lookup for host usage

[ROCm/clr commit: 7cd7a10e33]
2018-02-12 10:13:49 +05:30
Rahul Garg f15543d5cf Fixed host allocated globals address lookup for host usage
Fixed texture driver APIs failure


[ROCm/clr commit: b8c23f979b]
2018-01-30 18:06:31 +05:30
Alex Voicu 870aed0e50 Merge branch 'feature_purge_genco' of https://github.com/AlexVlx/HIP into feature_purge_genco
[ROCm/clr commit: 55dcd1a04a]
2018-01-17 14:07:48 +00:00
Alex Voicu 392dd28899 Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_purge_genco
[ROCm/clr commit: 09c704a2d0]
2018-01-17 14:02:19 +00:00
Rahul Garg ec4cc27986 Added support for -
- hipMemcpyFromArray
- hipMemcpyAtoH
- hipMemcpyHtoA


[ROCm/clr commit: ca5bcb5af4]
2018-01-16 11:44:19 +05:30
Rahul Garg 1ee7e7c2f9 Fixed build error
[ROCm/clr commit: d1dcc5025d]
2017-12-28 16:15:45 +05:30
Maneesh Gupta 290b5f1738 Implement hipStreamAddCallback
Change-Id: Ib851e4d86ba9c8406ca37b88162ea483ccbc9d36


[ROCm/clr commit: cd9ba0d1e1]
2017-12-19 16:06:14 +05:30
Maneesh Gupta cdd2f1a318 Merge pull request #282 from gargrahul/texture_driver_3d_support
Added support for 3D texture driver apis

[ROCm/clr commit: c124899669]
2017-12-18 15:39:26 +05:30
Alex Voicu 998b5dc3fa Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_purge_genco
[ROCm/clr commit: 4d0d4dc701]
2017-12-14 13:50:49 +00:00
Maneesh Gupta b75f3d6449 [cmake] Added target static_check for static code analysis
- Added static code analysis using cppcheck
- Fixed couple of warnings reported by cppcheck

Change-Id: Ie3b9b06e95ada322e7dc2ce3d6b91831e870198d


[ROCm/clr commit: 379cbfedcf]
2017-12-14 12:16:44 +05:30
Maneesh Gupta f6ac3f8337 Merge pull request #285 from aaronenyeshi/fix-ilogb-unreachable
Fix ilogb/ilogbf functions to return int

[ROCm/clr commit: c4192eec7d]
2017-12-12 10:47:33 +05:30
Alex Voicu aa48cc7b55 This introduces LipoProteinLipase (lpl), a simple tool for creating fat binaries. It represents a direct replacement of the creaky hccgenco.sh script, which had various issues. The format it uses is that of a code object bundle, generated by the Clang Offload Bundler. The output is always suffixed with the ".adipose" extension. It is shared with HCC. The hipcc script and associated tests are modified to use lpl. Help can be obtained by invoking lpl --help. A more computer-sciency / corporate friendly name is likely to be beneficial, which is a reason for choosing easily searchable/replaceable names such as lpl or adipose.
[ROCm/clr commit: 4e0739c68a]
2017-12-08 04:22:57 +00:00
Aaron En Ye Shi 880cd966de Fix ilogb/ilogbf functions to return int
This patch will fix hipDoublePrecisionMathDevice test on ThinLTO, which uncovered that hip math_function's ilogb/ilogbf should return type int instead of double. This will match rocdl.


[ROCm/clr commit: b439b45641]
2017-12-05 23:14:10 +00:00
Rahul Garg 467b908368 Added support for
- 3D texture driver APIs
- hipMalloc3D
- hipMemcpy3D for destination other than array


[ROCm/clr commit: 105df94cd0]
2017-12-05 14:11:13 +05:30
Alex Voicu 8294d086a8 Re-sync with upstream.
[ROCm/clr commit: 76614f15af]
2017-12-03 23:14:58 +00:00
Alex Voicu 37e40fcd40 This is primarily intended as an additional cleanup of the module functionality, in the aftermath of adopting module based dispatch. The main effort was associated with refactoring the questionable ihipModuleGetSymbol. It was quaintly written and misleading, in that it had little to do with getting symbols, and was exactly retrieving a kernel object. Error handling is modified so as to reduce branching depth. Functions which serve as interfaces to the HSA RT are moved in a separate helper header. Code object readers are properly deleted. Some leftover dead functionality pertaining to associating namespace scope variables with their allocated memory is removed. Executable loading is changed to use a string which holds the ELF image of the code object being loaded, thus avoiding some corner cases where using a istream would fail.
[ROCm/clr commit: e186bd9533]
2017-12-03 23:09:06 +00:00
Ben Sander 5b5bbd0b99 Merge pull request #271 from bensander/cppcheck
Cppcheck

[ROCm/clr commit: 6e2e029b39]
2017-12-02 08:36:17 -06:00
Alex Voicu 1ba0d0ca14 Remove stray leftover comment.
[ROCm/clr commit: 954b7dadf7]
2017-12-02 00:03:10 +00:00
Alex Voicu 6bdde982ff Replace archaic use of homebrew functionality with calls to the HC maths library. This fixes a hang observed when building hipTestDeviceDouble.
[ROCm/clr commit: b8c80bd0b2]
2017-12-02 00:01:47 +00:00
Ben Sander cabf4d817c Fix some cppcheck style issues.
[ROCm/clr commit: 5933ca7300]
2017-12-01 20:45:34 +00:00
Ben Sander b1aee08dc1 Fix warning from default cppchek.
[ROCm/clr commit: 743c54a012]
2017-12-01 20:45:33 +00:00
Alex Voicu 76336d46b4 Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter.
[ROCm/clr commit: 33bb425013]
2017-11-30 03:29:04 +00:00
Alex Voicu a27fa25d76 Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
This reverts commit 1cd6416


[ROCm/clr commit: 4966518846]
2017-11-29 21:49:10 +00:00
Alex Voicu a1d5f0ab0c Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
This reverts commit d2fd1f5


[ROCm/clr commit: 2557000b56]
2017-11-29 21:36:29 +00:00
Alex Voicu 4d18ad9ebe Fix compiler version check.
[ROCm/clr commit: 93e595c267]
2017-11-29 03:05:53 +00:00
Alex Voicu 0636d6a976 Add missing file.
[ROCm/clr commit: e305d3fc94]
2017-11-29 02:16:44 +00:00
Alex Voicu 6b21218303 Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component.
[ROCm/clr commit: 37c1811b2a]
2017-11-29 01:37:52 +00:00
Alex Voicu cdac21c81a Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
[ROCm/clr commit: c6ab6f292b]
2017-11-29 00:17:44 +00:00
Alex Voicu e85f49a57e Remove leftover agent allocated globals.
[ROCm/clr commit: 45a9f4f7b1]
2017-11-28 19:56:04 +00:00
Alex Voicu abf92dd6e7 Change memset kernel to use memcpy instead of placement new. Simplify indexers.
[ROCm/clr commit: d5c8de3f41]
2017-11-28 19:45:47 +00:00
Alex Voicu 914acbe88f Re-sync with upstream and re-factor platform global management for texture references.
[ROCm/clr commit: 6a0efb7ed2]
2017-11-28 19:15:29 +00:00
Alex Voicu 579a3187da Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
# Conflicts:
#	src/hip_module.cpp


[ROCm/clr commit: d37a5a6008]
2017-11-28 17:29:11 +00:00
Maneesh Gupta 621cc5e5ca Fix float2int rounding functions
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468


[ROCm/clr commit: cc418da654]
2017-11-28 17:23:43 +00:00
Alex Voicu a59daf78d6 This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands.
[ROCm/clr commit: bb35299560]
2017-11-28 17:23:06 +00:00
Alex Voicu 0de6e0be2b This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution.
[ROCm/clr commit: 4b7cb0624e]
2017-11-28 17:23:06 +00:00
Ben Sander 0de96b6e3e Merge pull request #256 from gargrahul/texture_driver_api_support
Texture driver APIs support

[ROCm/clr commit: e93a24bdbe]
2017-11-27 13:52:39 -06:00
Maneesh Gupta 05963822e7 Fix float2int rounding functions
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468


[ROCm/clr commit: 822743845c]
2017-11-23 09:57:24 +05:30