Commit Graph

6382 Commits

Author SHA1 Message Date
Christophe Paquot cd447a5aaa SWDEV-322620 - Virtual Memory Management APIs
Adding skeletons.
Implemented:
- hipMemGetAllocationGranularity with basic granularity
- hipMemGetAllocationPropertiesFromHandle
- hipMemCreate

Change-Id: I4bd2c75fae45d6a057efcad19d1d3c9715e9ae67
2022-04-08 11:38:51 -04:00
Jaydeep Patel ff78c439ef SWDEV-330661 - devicePointer null checking.
Change-Id: I3366031954330143109d0a79e86fd0e0ec996f01
2022-04-08 00:08:37 -04:00
Satyanvesh Dittakavi c0ada4320b SWDEV-326796 - Fix hipMemset crash when the size passed is more than allocated
Change-Id: If3b15da0960f3af347fca62beedd8003cb958c2e
2022-04-07 08:49:54 -04:00
Saleel Kudchadker b1436f6451 SWDEV-331152 - Add back HIP_HOST_COHERENT support
Change-Id: I1971df55913498df801ad319a20b95380a2c136f
2022-04-06 12:26:01 -04:00
Satyanvesh Dittakavi 0af8904b87 SWDEV-326793 - hipStreamGetFlags should query the flags for null stream
Change-Id: I1d1b833704c135b5a0c695b244380ac6c5b8438e
2022-04-06 04:09:17 -04:00
pghafari 798a304dbd SWDEV-316292 - adding Graph checks
hipGraphExecMemcpyNodeSetParamsFromSymbol negative test cases

Change-Id: I7b6c496a8bca831dc90d1d427273a2a4fea96587
2022-04-05 13:26:46 -04:00
Ajay 18c4458e8c SWDEV-303760 - Windows: to use the HIP found using find_package(hip)
Change-Id: I8dcc0adae5decc17aff45850681c3502c9e19fae
2022-04-05 12:01:51 -04:00
Payam 8618b1cd07 SWDEV-316819 - graph check ChildGraphNodeGetGraph
Change-Id: Id3a4fb64e6fb5ce37e97f1f3518e09c8bd9a2d0c
2022-04-05 01:24:36 -04:00
Rakesh Roy 5f0f7ffe92 SWDEV-326789 - Mark texture reference APIs as deprecated
Change-Id: I7a39cc1f036cd185ac3aab6c5f44730f16225f69
2022-04-05 00:04:34 -04:00
Julia Jiang 7b4b76b465 SWDEV-329687 - update install.md
Change-Id: Ib39df1cd462aa1644c4e0cc2ab0a3c780700056b
2022-04-03 13:03:02 -04:00
German Andryeyev fb835c6f3e SWDEV-328670 - Pass the size of allocation
The actual size of allocation can be different from the original
request due to alignments. Pass the size of the original request
for validation during the arena object look-up

Change-Id: I30000046b1ec56abe743e43113046144fd3edbc6
2022-04-01 11:18:55 -04:00
Ajay b5d9d61f5d SWDEV-320512 - hipcc.bin installation should be moved out of packaging
Change-Id: I8e37b47f43a7c6579b68a7dd1db1a3d05976fa9d
2022-03-31 17:52:39 -04:00
German Andryeyev 539d264eb0 SWDEV-311271 - Initial mempool implementation
HIP_MEM_POOL_SUPPORT controls memory pool support in runtime.
Currently it's disabled by default. The initial change doesn't
include: IPC, MGPU, virtual memory alloc, suballoc, defragmentation,
internal dependencies.

Change-Id: Ibed8528ebec698b045ebb247e49c0ecd6e587ed7
2022-03-31 09:21:37 -04:00
Ranjith Ramakrishnan 1a4fd9b7ea SWDEV-329277 - Soft link for hipInfo
Tensor flow build console shows "hip/lib/.hipInfo: No such file or directory"
Fixed by adding soft link for .hipInfo and this will maintain backward compatibility for file reorganization

Change-Id: I91c17115b56bbcabeb86cbcd12d3fb9aaa8f847e
2022-03-29 16:01:46 -07:00
Satyanvesh Dittakavi ed4014e519 SWDEV-329082 - Return right error code for hipHostUnregister
hipErrorHostMemoryNotRegistered should be returned when an
unregistered pointer is passed to hipHostUnregister

Change-Id: Ie76086b602bde2cd7a7a2b049cd03d29454ff306
2022-03-28 07:24:25 -04:00
Sarbojit Sarkar 80e1e2e6db SWDEV-325708 - Query for FineGrained support
Change-Id: I3a8d2bca50d0874c0ff60efa457006876b1fe963
2022-03-28 07:17:55 -04:00
Rakesh Roy 1e77357c7f SWDEV-326789 - Add Missing HIP API Functions For Nvidia Platform
Change-Id: I828028c5d893ca1487f33017a6902c3b7f786762
2022-03-25 01:34:57 -04:00
Saleel Kudchadker 73ff72bca9 SWDEV-301667 - Query event time directly
Change-Id: I566bfa95b8b6fa2bd4771e0c20224a4e74d5abb8
2022-03-25 01:08:07 -04:00
Ashutosh Mishra 106399f0fd SWDEV-329093 - correcting RPATH for lamdhip64.so
Change-Id: Ifd0fca732e8030edd6dc74d22b32bb75514c9258
2022-03-23 22:15:57 -04:00
Payam Ghafari d888c0a9bf Revert "SWDEV-316819 - adding graph checks"
This reverts commit 5dd91d698b.

Reason for revert: Catch2 test fails

Change-Id: If0ea0eab16b50f27c9acbc471530266917773ff1
2022-03-23 15:23:00 -04:00
Ajay ed487980cd SWDEV-315567 - hipGraphNodeTypeEventRecord node type get/set fixes
Change-Id: I76e866990a153fb254e1187e7fabcc1f93806469
2022-03-23 14:05:31 -04:00
Ranjith Ramakrishnan ef32ae6ada File Reorganization: Strip destination name hip from cmake and cpack install prefix path
Flat folder structure requires hip to be installed in /opt/rocm and this need a change in build script
This patch is a workaround, till build scripts changes for flat folder structure are merged and will be removed once build script changes are merged to amd-master

Change-Id: Ib6f51b9d4e89afcc954a5d96595ce471cf7bd67a
2022-03-23 12:47:56 -04:00
Sourabh Betigeri f73ff54fda SWDEV-316991 - Returns hipErrorInvalidValue when a wrong node type is passed to hipGraphExecEventWaitNodeSetEvent and hipGraphExecEventRecordNodeSetEvent APIs
Change-Id: Ic80b0b2b154e017b41af617f5049e037a1b66183
2022-03-22 18:09:10 -04:00
Ajay 8c103bb898 SWDEV-314982 - hipStreamGetCaptureInfo seq ID ptr check
Change-Id: I84a84121d2064182f0daea22578f0fa5f94f850c
2022-03-22 12:07:05 -04:00
Christophe Paquot 2ef41ff5be SWDEV-323899 - More capping of caps
Change-Id: If8ba22d01326b85455eaaee55e1e2a4b9832ebb2
2022-03-22 11:02:49 -04:00
sdashmiz ae506b40c0 SWDEV-303187: find the device pointer is for
- the pointer attribute is fetched for might not be the current device

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ibcea92b52da31adba5f62baae25b55671704c005
2022-03-22 10:55:28 -04:00
sdashmiz 610aa33a8b SWDEV-328556: check for wait event node type
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I4b70cb576df1ab31503d9089591026bebe4df16a
2022-03-22 10:54:55 -04:00
Payam 6a48e430d0 SWDEV-315033,SWDEV-315028 - adding null checks for graph
Change-Id: I9cbea5ea9ff59d7960ae11dfd73d5a744981495f
2022-03-22 02:08:49 -04:00
Satyanvesh Dittakavi 4a90c3ccaf SWDEV-327967 - Fix Segmentation fault in hipFree
Queue creation and release fails during hipFree causing seg fault
if the null queue was not created until then and there is no
device memory left.

Change-Id: I118b86b58e777dac5415bc9ba0c4e23c986efa7d
2022-03-22 00:34:40 -04:00
Sourabh Betigeri 02838eb236 SWDEV-320640 - Fix to return the right error code when the stream is not in capture mode
Change-Id: Id2f296e0cbf5f90a8163441f4c69c72615dd90a0
2022-03-21 19:38:00 -04:00
Ajay aacfc3ed7d SWDEV-327945 - hipGraphInstantiateWithFlags accept 0,1 as valid flag values
Change-Id: I3100a3464d1a47fca5f9da80f42e7dd2035865ad
2022-03-21 16:42:21 -04:00
Sourabh Betigeri 8adb379b1d SWDEV-316226 - Fix to return 'numDependencies' as an independent optional argument in StreamGetCaptureInfo_v2()
Change-Id: I19552c4e62401f324ba876d0aa36472ebaa37aa0
2022-03-18 15:44:43 -05:00
Ranjith Ramakrishnan 4bcccb60c9 SWDEV-291455 - File reorganization with backward compatibility
HIP installed in /opt/rocm
Wrapper header file in /opt/rocm/hip/include
Soft link for cmake and library files in /opt/rocm/hip

Depends-On: I30adccf7e6241dae12270156602d4b033ea99d93
Change-Id: If70b61020fa3ee85bf49171c842837da05191a48
2022-03-18 13:52:29 -04:00
Sourabh Betigeri c47a55f371 SWDEV-328295 - Returns a vector of graphNodes with reference to retain scope
Change-Id: Ib51c9bdbcb5e5cea76f111cb54bde724053073ff
2022-03-18 12:28:57 -04:00
Satyanvesh Dittakavi de069729a5 SWDEV-318123 - Address hipGraphHostNodeSetParams negative scenarios
Change-Id: I4884a364b40e93c779ca84f34eee4688f3583aab
2022-03-18 12:08:28 -04:00
Sarbojit Sarkar 33687d8cab SWDEV-327455 - Fix for event node crash
Change-Id: I4418800f04450f1bd23cef4e7812631727458a3b
2022-03-18 06:22:38 -04:00
Satyanvesh Dittakavi 796b8c2b62 SWDEV-326800 - hipStreamWaitEvent shouldnt accept flags other than 0
Change-Id: Ic9e2e8e7ac5d34d4286356534810c8e7aa0ee5ad
2022-03-18 03:34:53 -04:00
sdashmiz 8e81b8495c SWDEV-315402: Null param check for pGraphNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I4cd3a539cff1a01b4786d4edbc4201cd68346e0e
2022-03-17 22:17:27 -04:00
Ajay 782c411d1a SWDEV-313350 - hipStreamDestroy to remove the stream added to capturing list
Change-Id: I0979766da7f1cf6082835d46701009902f55139e
2022-03-17 17:22:51 +00:00
Ajay 8fad1177e3 SWDEV-315756 - hipGraphAddMemcpyNodeFromSymbol issues
Change-Id: Ibf9504454830b63caf6048aa53d726116da6d713
2022-03-17 12:10:31 -04:00
Shadi Dashmiz f8f8b0fd95 Revert "SWDEV-315402: Null param check for pGraphNode"
This reverts commit e383c5fca0.

Reason for revert: want to add one more check

Change-Id: I02b621d0c98b9000f75ea214cf5b4967cfaee95d
2022-03-17 10:04:43 -04:00
Christophe Paquot 375b8e5e8c SWDEV-323899 - Cap deviceProps.maxTexture1DLinear to INT32_MAX
Change-Id: Iacfd4f44e5169994ff11b6303be63a15d5935955
2022-03-16 16:54:27 -04:00
Satyanvesh Dittakavi a554d03b9a SWDEV-324016 - Refactor hipDrvPointerGetAttributes
Addresses the negative scenarios and assigns default NULL values to
the queried attributes when the pointer encountered is not valid.
This is to match the corresponding API's behavior in CUDA.

Change-Id: I4ce400b02416d455ec9649f731af2e327dccfe71
2022-03-16 05:30:28 -04:00
Satyanvesh Dittakavi 2fd90ec7a4 SWDEV-317716 - Add hipDeviceGetUuid API
Change-Id: I320c7bc11ddd7617e0246f6faf19135ad7363e73
2022-03-16 00:23:44 -04:00
Payam 4117655e91 SWDEV-317494 - Graph - allowing empty params
hipHostNodeParams should work without any parameters for the userData

Change-Id: Iee32c3ba87000e29ed037ee507f7da9ea54988a3
2022-03-15 14:45:46 -04:00
sdashmiz 2ae3b6d13f SWDEV-315736: event_out param correct nullptr check
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id164bc47c928e9c4541b29a0c9128e41e313ed22
2022-03-15 11:05:59 -04:00
Christophe Paquot 925c742d42 SWDEV-323472 - Fix hipThreadExchangeStreamCaptureMode
Matching CUDA's described behavior: Threads have their own mode.

Change-Id: I3ea15826305a607bff73eb317c4ef62728ed5dc8
2022-03-15 10:53:02 -04:00
Satyanvesh Dittakavi 3cc0a3fcaf SWDEV-321656 - Address incorrect warp size with hiprtc
Change-Id: I97051d4e2cf27cb073c39663c62e43d5c19b1a12
2022-03-15 06:52:21 -04:00
Payam 5dd91d698b SWDEV-316819 - adding graph checks
hipGraphChildGraphNodeGetGraph - Scenario 3: Pass Parent node instead of the child node

Change-Id: Ia55921bca1e2745c9c97f2b7eb36244ffb719eb4
2022-03-14 22:43:58 -04:00
sdashmiz e383c5fca0 SWDEV-315402: Null param check for pGraphNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie1082bb5e5ebdbcc6d38bb1349cb879c2e85a453
2022-03-14 13:36:56 -04:00