SWDEV-198863 - Options for hip-clang-vdi path to provide the chicken bits, or functional equivalents to HCC_DB (phase 2)
Enable the log functions for release build.
Tests:
1. Linux HIP ROCM platform. VEGA10. Driver is release build.
1.1 export LOG_LEVEL=3
./hipModule
There are many logs.
1.2 export GPU_LOG_MASK=0
./hipModule
There is no log
2. Windows HIP PAL platform. VEGA10, Driver is release or fastdbg build.
2.1 set LOG_LEVEL=3
run test hipPrintfKernel
There are many logs
2.2 set GPU_LOG_MASK=0
run test hipPrintfKernel
There is no log
3. http://ocltc.amd.com:8111/viewModification.html?modId=128481&personal=true&tab=vcsModificationBuilds
ReviewBoard: http://ocltc.amd.com/reviews/r/18240/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/debug.hpp#11 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#324 edit
SWDEV-2 - Change OpenCL version number from 3031 to 3032.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2779 edit
SWDEV-198863 - Options for hip-clang-vdi path to provide the chicken bits, or functional equivalents to HCC_DB (phase 1)
1. The log macros is turned off for release build. So log functions has zero impact to release build.
2. The log macros have level, mask, condition control. So we can have more control to avoid log flooding.
I also adjusted some existing log to use new log functions.
1. To excercise and test the new log functions.
2. To improve performance slightly.
3. The change is mainly for HIP-ROCM, we can move more in next phases for PAL or ORCA.
4. I make these log feature unavailable for release build. We can revert to old log functions for release build in a case by case method.
Tests:
1. http://ocltc.amd.com:8111/viewModification.html?modId=128289&personal=true&tab=vcsModificationBuildshttp://ocltc.amd.com:8111/viewModification.html?modId=128358&personal=true&tab=vcsModificationBuilds
2. release build, run hip program, there is no log
3. fastdebug build, run hip program,
export LOG_LEVEL=3
export GPU_LOG_MASK=4294967295
There was a lot of logs.
4. fastdebug build, run hip program,
export LOG_LEVEL=2
export GPU_LOG_MASK=4294967295
There was no logs.
5. fastdebug build, run hip program,
export LOG_LEVEL=3
export GPU_LOG_MASK=4294967294
There was much less logs.
6. fastdebug build, run hip program,
export LOG_LEVEL=3
export GPU_LOG_MASK=47102
There was even much less logs. The logs was expected according to the mask.
7. Tested step 2 to 6 similarily in Windows and Linux
ReviewBoard: http://ocltc.amd.com/reviews/r/18215
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#46 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#82 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hiprtc_internal.hpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/comgrctx.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#68 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#137 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#91 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#100 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/runtime.cpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/debug.hpp#10 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#323 edit
SWDEV-2 - Change OpenCL version number from 3030 to 3031.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2778 edit
SWDEV-2 - Change OpenCL version number from 3029 to 3030.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2777 edit
SWDEV-2 - Change OpenCL version number from 3028 to 3029.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2776 edit
SWDEV-2 - Change OpenCL version number from 3027 to 3028.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2775 edit
SWDEV-2 - Change OpenCL version number from 3026 to 3027.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2774 edit
SWDEV-2 - Change OpenCL version number from 3025 to 3026.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2773 edit
SWDEV-2 - Change OpenCL version number from 3024 to 3025.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2772 edit
SWDEV-2 - Change OpenCL version number from 3023 to 3024.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2771 edit
SWDEV-2 - Change OpenCL version number from 3022 to 3023.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2770 edit
SWDEV-2 - Change OpenCL version number from 3021 to 3022.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2769 edit
SWDEV-2 - Change OpenCL version number from 3020 to 3021.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2768 edit
SWDEV-2 - Change OpenCL version number from 3019 to 3020.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2767 edit
SWDEV-2 - Change OpenCL version number from 3018 to 3019.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2766 edit
SWDEV-2 - Change OpenCL version number from 3017 to 3018.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2765 edit
SWDEV-2 - Change OpenCL version number from 3016 to 3017.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2764 edit
SWDEV-198862 - Options for hip-clang-vdi path to provide the chicken bits, or functional equivalents to HCC_OPT_FLUSH
Add HCC_OPT_FLUSH flag to use fence scope agent when possible for HIP VDI. The flag is defaulted to turn on, similiar to HIP HCC.
Add AMD_OCL_OPT_FLUSH to use fence scope agent when possible for OpenCL. This was tested in Windows and PAL. Default is off.
This flag can be used for future OpenCL test.
Tests:
1. http://ocltc.amd.com:8111/viewModification.html?modId=127189&personal=true&tab=vcsModificationBuilds
The teamcity test includes HIP - VDI - Rocm tests.
2. VEGA10 , Windows, HIP, 110 hiptests PASS.
3. VEGA10 , Linux AMDGPU PRO, HIP - PAL, 110 hiptests PASS.
Newer:
http://ocltc.amd.com:8111/viewModification.html?modId=127193&personal=true&tab=vcsModificationBuilds
Reviewboard: http://ocltc.amd.com/reviews/r/18092/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#247 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#342 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#89 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.hpp#29 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#321 edit
SWDEV-2 - Change OpenCL version number from 3015 to 3016.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2763 edit
SWDEV-2 - Change OpenCL version number from 3014 to 3015.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2762 edit
SWDEV-2 - Change OpenCL version number from 3013 to 3014.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2761 edit
SWDEV-189650 - [HIP-CLANG][HIP/VDI/PAL] Hangs on test hip_threadfence_system
1. In HIP + VDI + ROCm, allow SVM atomic in VEGA10 and later ASIC. GFX8 (Tonga) was enabled before.
2. In HIP + VDI + PAL Linux driver, allow SVM atomic in VEGA10 and later ASIC.
Tests:
1. In HIP + VDI + ROCm, hip_threadfence_system test passed.
2. In HIP + VDI + PAL + Linux , hip_threadfence_system test passed.
3. OpenCL + PAL, clinfo and ocltest runtime test pass.
4. OpenCL + ROCM, clinfo and ocltest runtime test pass.
5. Windows 10, VEGA 10, clinfo and and ocltest runtime test pass. hip_threadfence_system test passed by skipping the test.
Teamcity presubmission test:
http://ocltc.amd.com:8111/viewModification.html?modId=127083&personal=true&tab=vcsModificationBuildshttp://ocltc.amd.com:8111/viewModification.html?modId=127076&personal=true&tab=vcsModificationBuilds
ReviewBoard: http://ocltc.amd.com/reviews/r/18077/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#73 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#171 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#80 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.hpp#31 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#134 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#44 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#320 edit
SWDEV-2 - Change OpenCL version number from 3012 to 3013.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2760 edit
SWDEV-2 - Change OpenCL version number from 3011 to 3012.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2759 edit
SWDEV-2 - Change OpenCL version number from 3010 to 3011.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2758 edit
SWDEV-2 - Change OpenCL version number from 3009 to 3010.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2757 edit
SWDEV-2 - Change OpenCL version number from 3008 to 3009.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2756 edit
SWDEV-192384 - [HIP CQE][HIPonPAL][19.40] hipBindTexRef1DFetch, hipTextureRef2D are failed on all ASICs for both Win/Lnx
The runtime cannot trivially determine all the resources that will be used by a kernel, thus it can fail to make all of them resident.
1. Add new runtime flag PAL_ALWAYS_RESIDENT. Enabling this setting will cause resources to become resident at allocation time.
2. Set the default value of the above flag to true for HIP and false for OCL.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/18054/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#79 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.hpp#30 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#100 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.hpp#27 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#153 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#319 edit
SWDEV-2 - Change OpenCL version number from 3007 to 3008.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2755 edit
SWDEV-2 - Change OpenCL version number from 3006 to 3007.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2754 edit
SWDEV-2 - Change OpenCL version number from 3005 to 3006.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2753 edit
SWDEV-2 - Change OpenCL version number from 3004 to 3005.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2752 edit
SWDEV-2 - Change OpenCL version number from 3003 to 3004.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2751 edit
SWDEV-2 - Change OpenCL version number from 3002 to 3003.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2750 edit
SWDEV-2 - Change OpenCL version number from 3001 to 3002.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2749 edit
SWDEV-2 - Change OpenCL version number from 3000 to 3001.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2748 edit
SWDEV-2 - Change OpenCL version number from 2999 to 3000.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2747 edit
SWDEV-2 - Change OpenCL version number from 2998 to 2999.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2746 edit
SWDEV-2 - Change OpenCL version number from 2997 to 2998.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2745 edit
SWDEV-2 - Change OpenCL version number from 2996 to 2997.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2744 edit
SWDEV-2 - Change OpenCL version number from 2995 to 2996.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2743 edit
SWDEV-2 - Change OpenCL version number from 2994 to 2995.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2742 edit
SWDEV-2 - Change OpenCL version number from 2993 to 2994.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2741 edit
SWDEV-2 - Change OpenCL version number from 2992 to 2993.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2740 edit
SWDEV-2 - Change OpenCL version number from 2991 to 2992.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2739 edit
SWDEV-2 - Change OpenCL version number from 2990 to 2991.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2738 edit
SWDEV-2 - Change OpenCL version number from 2989 to 2990.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2737 edit
foreman