Commit Graph

13496 Commits

Author SHA1 Message Date
Benjamin Welton e21609c80e Code migration and include fixes (#830)
* Migrating code/reformatting

* Remove unnecessary includes
---------

Co-authored-by: Benjamin Welton <ben@amd.com>
2024-04-29 15:48:50 -07:00
David Galiffi ee3139de7e Update CMakeLists
- Add CPACK_RPM_PACKAGE_RELEASE_DIST to set RPM distro.
- Indent packaging logs for easier reading.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>


[ROCm/rocprofiler-compute commit: 450370a767]
2024-04-29 14:58:52 -05:00
David Galiffi 450370a767 Update CMakeLists
- Add CPACK_RPM_PACKAGE_RELEASE_DIST to set RPM distro.
- Indent packaging logs for easier reading.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-04-29 14:58:52 -05:00
David Galiffi e75e632f3d Update project packaging
Signed-off-by: David Galiffi <David.Galiffi@amd.com>


[ROCm/rocprofiler-compute commit: 539ec0c65e]
2024-04-29 14:58:42 -05:00
David Galiffi 539ec0c65e Update project packaging
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-04-29 14:58:42 -05:00
Giovanni LB 3ae1b6af74 SWDEV-452226: Changing ATT dispatch IDs to match previous kernel-trace change
Change-Id: Ifd00160f2e8705e9ef11d41d284f6625b70de389
2024-04-29 11:56:32 -04:00
Giovanni LB c0cb1373a4 SWDEV-452226: Changing ATT dispatch IDs to match previous kernel-trace change
Change-Id: Ifd00160f2e8705e9ef11d41d284f6625b70de389


[ROCm/rocprofiler commit: 3ae1b6af74]
2024-04-29 11:56:32 -04:00
David Yat Sin 57b93e02a4 Use pthread_attr_setaffinity_np when available
If pthread_attr_setaffinity_np function exists use it instead of
pthread_setaffinity_np as pthread_setaffinity_np seems to fail to set
the affinity settings on some systems.

Change-Id: Icd8b17039699ac10d9cd5c4dbb6ac44630673949
2024-04-29 15:02:54 +00:00
David Yat Sin b6829f7a72 Bump HSA_AMD_INTERFACE_VERSION_MINOR
Bumping HSA_AMD_INTERFACE_VERSION_MINOR version to 5 to account for
previously added GPU agent query: HSA_AMD_AGENT_INFO_MEMORY_PROPERTIES

Change-Id: Ic8cfdcfb7bad6f3d1e0b3d68f505a62074fc26b9
2024-04-29 12:55:18 +00:00
coleramos425 3ac6cd4b53 Fix outstanding roofline test that was missed in previous commit
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 3f150409f1]
2024-04-26 10:53:57 -05:00
coleramos425 3f150409f1 Fix outstanding roofline test that was missed in previous commit
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-26 10:53:57 -05:00
Kent Russell 5e1f24f305 .github: Add CODEOWNERS file
Change-Id: Ia763b91177f1ae09d16e5968bed17b0dba62cbe5
Signed-off-by: Kent Russell <kent.russell@amd.com>
2024-04-26 09:21:39 -04:00
Jonathan R. Madsen f167317524 Public C++ header files and samples updates (#819)
* Public C++ header files (source/include/rocprofiler-sdk/cxx)

* Update samples/api_buffered_tracing

- scratch memory and page migration
- README

* Update samples/api_buffered_tracing

- page migration component in sample

* Update tests/page-migration/validate.py

- fix checks for page migration operation names

* Update tests/page-migration/validate.py

- fix get_allocated_pages

* Update scratch memory and page migration validations

* Fix include/rocprofiler-sdk/cxx installation

* Rework include/rocprofiler-sdk/cxx

- Improve name_info to support const char*, string_view, string

* Update samples/api_{buffered,callback}_tracing

* External correlation ID request sample

- includes correlation ID retirement demo

* Update samples/api_buffered_tracing/README.md

* Update lib/rocprofiler-sdk/hsa/queue.cpp

- generate correlation ID for kernel launch if one doesn't exist

* Remove priority check from tool libraries (samples/tests)

- if(priority > 0) return nullptr check in rocprofiler_configure has proliferated beyond its intended use

* Apply suggestions from code review

[ROCm/rocprofiler-sdk commit: de13d2ac5d]
2024-04-25 20:09:11 -05:00
Jonathan R. Madsen de13d2ac5d Public C++ header files and samples updates (#819)
* Public C++ header files (source/include/rocprofiler-sdk/cxx)

* Update samples/api_buffered_tracing

- scratch memory and page migration
- README

* Update samples/api_buffered_tracing

- page migration component in sample

* Update tests/page-migration/validate.py

- fix checks for page migration operation names

* Update tests/page-migration/validate.py

- fix get_allocated_pages

* Update scratch memory and page migration validations

* Fix include/rocprofiler-sdk/cxx installation

* Rework include/rocprofiler-sdk/cxx

- Improve name_info to support const char*, string_view, string

* Update samples/api_{buffered,callback}_tracing

* External correlation ID request sample

- includes correlation ID retirement demo

* Update samples/api_buffered_tracing/README.md

* Update lib/rocprofiler-sdk/hsa/queue.cpp

- generate correlation ID for kernel launch if one doesn't exist

* Remove priority check from tool libraries (samples/tests)

- if(priority > 0) return nullptr check in rocprofiler_configure has proliferated beyond its intended use

* Apply suggestions from code review
2024-04-25 20:09:11 -05:00
Jonathan R. Madsen ec3d720303 Fix CPACK_RPM_PACKAGE_LICENSE (#63)
- move install command for license to rocprofiler_register_config_install.cmake
- CPACK_RPM_PACKAGE_LICENSE should be set to license type (i.e. "MIT"), not the path to the license file

[ROCm/rocprofiler-register commit: 11a4668306]
2024-04-25 16:04:09 -05:00
Jonathan R. Madsen 11a4668306 Fix CPACK_RPM_PACKAGE_LICENSE (#63)
- move install command for license to rocprofiler_register_config_install.cmake
- CPACK_RPM_PACKAGE_LICENSE should be set to license type (i.e. "MIT"), not the path to the license file
2024-04-25 16:04:09 -05:00
raramakr e4b6a828e4 SWDEV-448381 - CPACK dependency list should be comma separated (#61)
* SWDEV-448381 - CPACK dependency list should be comma separated

* Remove redundant code and update the dependency list in first place

* Update cmake/rocprofiler_register_config_packaging.cmake

---------

Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>

[ROCm/rocprofiler-register commit: dd231244ee]
2024-04-25 15:55:14 -05:00
raramakr dd231244ee SWDEV-448381 - CPACK dependency list should be comma separated (#61)
* SWDEV-448381 - CPACK dependency list should be comma separated

* Remove redundant code and update the dependency list in first place

* Update cmake/rocprofiler_register_config_packaging.cmake

---------

Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
2024-04-25 15:55:14 -05:00
Ammar ELWazir 9681d0d8de SWDEV-458196: Fixing PID and TID
Perfetto added more restrictions on the types, so "1" is different from 1 alone, which wasn't the case before. Thats why we are seeing this issue recently

Change-Id: I69835c8f61bb9168fdfcdcd0821c1ba35d0369fe
2024-04-25 15:18:48 -05:00
Ammar ELWazir 1541f36388 SWDEV-458196: Fixing PID and TID
Perfetto added more restrictions on the types, so "1" is different from 1 alone, which wasn't the case before. Thats why we are seeing this issue recently

Change-Id: I69835c8f61bb9168fdfcdcd0821c1ba35d0369fe


[ROCm/rocprofiler commit: 9681d0d8de]
2024-04-25 15:18:48 -05:00
Jonathan R. Madsen 9b747eb63c Correct timestamp skew adjustments for kernel and async copy tracing (#827)
[ROCm/rocprofiler-sdk commit: e2bce49655]
2024-04-25 14:36:11 -05:00
Jonathan R. Madsen e2bce49655 Correct timestamp skew adjustments for kernel and async copy tracing (#827) 2024-04-25 14:36:11 -05:00
Vladimir Indic d0016ef728 Restructure code object source code (#826)
* public codeobj info

* Restructure code object source code file layout

* Update get_unloaded_code_objects + add iterate_loaded_code_objects

* Remove get_unloaded_code_objects from visible internal API

- iterate_loaded_code_objects + functor which filters on the hsa_executable_t effectively reproduces this behavior

* Whitespace removal

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 733aa8e438]
2024-04-25 14:03:04 -05:00
Vladimir Indic 733aa8e438 Restructure code object source code (#826)
* public codeobj info

* Restructure code object source code file layout

* Update get_unloaded_code_objects + add iterate_loaded_code_objects

* Remove get_unloaded_code_objects from visible internal API

- iterate_loaded_code_objects + functor which filters on the hsa_executable_t effectively reproduces this behavior

* Whitespace removal

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2024-04-25 14:03:04 -05:00
coleramos425 9a0d5f0663 Replace deprecated roofline warning with logging helper function
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 7d34e80567]
2024-04-25 18:43:20 +00:00
coleramos425 7d34e80567 Replace deprecated roofline warning with logging helper function
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-25 18:43:20 +00:00
Joseph Macaranas ac3d2ca8c5 Add support for external CI builds using Azure Pipelines (#62)
* Add support for external CI builds using Azure Pipelines

* Change token name to match IT-created token

[ROCm/rocprofiler-register commit: 2b777139d3]
2024-04-25 13:41:30 -05:00
Joseph Macaranas 2b777139d3 Add support for external CI builds using Azure Pipelines (#62)
* Add support for external CI builds using Azure Pipelines

* Change token name to match IT-created token
2024-04-25 13:41:30 -05:00
coleramos425 efcf9001d7 Add TCC_TOO_MANY_EA_WRREQS_STALL to gfx940 input configs (#349)
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 0fc620ce79]
2024-04-25 18:22:00 +00:00
coleramos425 0fc620ce79 Add TCC_TOO_MANY_EA_WRREQS_STALL to gfx940 input configs (#349)
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-25 18:22:00 +00:00
coleramos425 3237f685e6 Update names of roofline csv expectation in testing
Co-authored-by: Jose Santos <josantos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 46aa20e014]
2024-04-25 18:10:21 +00:00
coleramos425 46aa20e014 Update names of roofline csv expectation in testing
Co-authored-by: Jose Santos <josantos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-25 18:10:21 +00:00
amd-jmacaran 587e4287f4 Change token name to match IT-created token
Change-Id: Ic9189c012024c59cf5bad9daf25f6c2575a100fd
2024-04-25 12:23:28 -04:00
amd-jmacaran 75803689d1 Change token name to match IT-created token
Change-Id: Ie08eb15af669d4247c611c122ca0a77eb365f6dd
2024-04-25 03:57:02 -04:00
Galantsev, Dmitrii cb87eeeae7 Update kBlockNameMap
Change-Id: I096f40f2b953fad7081d4b9bc05c0291c0f8058d
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-04-24 23:50:55 -05:00
Galantsev, Dmitrii 0c8827c4b7 CMAKE - Use ADDRESS_SANITIZER env var
Change-Id: I4727120de2f9d7bded8c24033c252ede718831fc
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-04-24 23:04:25 -05:00
David Yat Sin 3d999a1adf Perform HDP flush for SDMA copies gfx10/gfx11
Perform HDP flush on gfx10/gfx11 PCIe devices.

Exclude gfx101x devices

Change-Id: Ief76c34634b09b0a7942cb71519d4082ca8b4fad
2024-04-24 18:07:34 -04:00
David Galiffi e9df02bb5b Add ".venv" to gitignore file
Signed-off-by: David Galiffi <David.Galiffi@amd.com>


[ROCm/rocprofiler-compute commit: c24baf3610]
2024-04-24 17:02:52 -05:00
David Galiffi c24baf3610 Add ".venv" to gitignore file
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-04-24 17:02:52 -05:00
Jonathan R. Madsen abe00ad1d0 Update CMake config install location + env setup files (#821)
- install cmake config files to CMAKE_INSTALL_LIBDIR instead of CMAKE_INSTALL_DATAROOTDIR per ROCm standards
- Provide setup-env.sh and modulefiles for rocprofiler-sdk and rocprofiler-sdk-roctx

[ROCm/rocprofiler-sdk commit: 67dbe3f47f]
2024-04-24 14:43:47 -05:00
Jonathan R. Madsen 67dbe3f47f Update CMake config install location + env setup files (#821)
- install cmake config files to CMAKE_INSTALL_LIBDIR instead of CMAKE_INSTALL_DATAROOTDIR per ROCm standards
- Provide setup-env.sh and modulefiles for rocprofiler-sdk and rocprofiler-sdk-roctx
2024-04-24 14:43:47 -05:00
amd-jmacaran 9a91005354 Add support for external CI builds using Azure Pipelines
Change-Id: I7658fbc8c52bef551dae8c13413825507a0d8c0a
2024-04-24 15:25:10 -04:00
Jonathan R. Madsen 3b6249bdac Rework counter collection sample app (#822)
* Sync more often in counter collection samples

* Update samples/counter_collection/main.cpp

- support command line arguments
  - number of iterations
  - iterations per sync
  - number of devices to use

[ROCm/rocprofiler-sdk commit: 8c985543d9]
2024-04-24 14:00:59 -05:00
Jonathan R. Madsen 8c985543d9 Rework counter collection sample app (#822)
* Sync more often in counter collection samples

* Update samples/counter_collection/main.cpp

- support command line arguments
  - number of iterations
  - iterations per sync
  - number of devices to use
2024-04-24 14:00:59 -05:00
David Yat Sin 9af225e1b1 Add support for contiguous memory allocations
Support contiguous physical memory allocation flag. Allocations with
this flag will have contiguous physical memory. This is dependent on KFD
support for this flag and the AllocateKfdMemory(..) function call will
fail when it is not supported.

Change-Id: I6c51c8b061f7b026fdcc2aa2c37c74ecc13d95b6
2024-04-24 14:02:07 -04:00
David Yat Sin e539c8dce2 Remove assert for physical vs virtual memory size
On systems with more than 1 TB of memory per NUMA region, this triggers
unnecessary errors.

Change-Id: I1bc7f209b9c1739b516c9f6b0acf434488ac7b8d
2024-04-24 08:43:23 -04:00
Jonathan R. Madsen 312461ebe5 Fix LICENSE install location + CPACK_RPM_PACKAGE_LICENSE (#820)
- LICENSE needs to be installed in share/doc/rocprofiler-sdk not share/doc/rocprofiler
- CPACK_RPM_PACKAGE_LICENSE should be set to license type not the license location

[ROCm/rocprofiler-sdk commit: 5d365bb8b8]
2024-04-24 01:19:32 -05:00
Jonathan R. Madsen 5d365bb8b8 Fix LICENSE install location + CPACK_RPM_PACKAGE_LICENSE (#820)
- LICENSE needs to be installed in share/doc/rocprofiler-sdk not share/doc/rocprofiler
- CPACK_RPM_PACKAGE_LICENSE should be set to license type not the license location
2024-04-24 01:19:32 -05:00
amd-jmacaran 8a893ea0b8 Add support for external CI builds using Azure Pipelines
Change-Id: I8f4de331f00317a959b86f7e5b7a1025ba03564b
2024-04-23 21:10:49 -04:00
Ammar ELWazir e165856721 Update rocprofiler_config_packaging.cmake (#817)
[ROCm/rocprofiler-sdk commit: 777add01d1]
2024-04-23 18:43:41 -05:00